AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2025-01-06 02:40:07 +00:00
Code Issues Projects Releases Wiki Activity

dialog: Avoid possible use-after-free

Browse Source 
When the dialogue's titlebar was replaced, we were still trying to
update the label we constructed but that was now destroyed.

https://bugzilla.gnome.org/show_bug.cgi?id=726492
This commit is contained in:
Bastien Nocera 2014-03-17 09:27:36 +01:00
parent 5b4a942260
commit 20c764fc5e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk/gtkdialog.c
View File

@ -304,7 +304,7 @@ apply_use_header_bar (GtkDialog *dialog)
label = gtk_label_new ("");
gtk_style_context_add_class (gtk_widget_get_style_context (label), "title");
gtk_box_set_center_widget (GTK_BOX (box), label);
g_signal_connect (dialog, "notify::title", G_CALLBACK (update_title), label);
g_signal_connect_object (dialog, "notify::title", G_CALLBACK (update_title), label, 0);
}
gtk_window_set_titlebar (GTK_WINDOW (dialog), box);