AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-11-17 06:10:15 +00:00
Code Issues Projects Releases Wiki Activity

GtkPlacesSidebar: Remove to FIXMEs

Browse Source 
It doesn't hurt to just add the ref here, as the FIXME suggests.
This commit is contained in:
Matthias Clasen 2014-01-27 21:47:14 -05:00
parent 4872ee75e6
commit 2783395eae
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gtk/gtkplacessidebar.c
View File

@ -2859,7 +2859,7 @@ drive_poll_for_media_cb (GObject *source_object,
g_error_free (error); g_error_free (error);
} }
/* FIXME: drive_stop_cb() gets a reffed sidebar, and unrefs it. Do we need to do the same here? */ g_object_unref (sidebar);
} }
static void static void
@ -2878,7 +2878,7 @@ rescan_shortcut_cb (GtkMenuItem *item,
if (drive != NULL) if (drive != NULL)
{ {
g_drive_poll_for_media (drive, NULL, drive_poll_for_media_cb, sidebar); g_drive_poll_for_media (drive, NULL, drive_poll_for_media_cb, g_object_ref (sidebar));
g_object_unref (drive); g_object_unref (drive);
} }
} }
@ -2909,7 +2909,7 @@ drive_start_cb (GObject *source_object,
g_error_free (error); g_error_free (error);
} }
/* FIXME: drive_stop_cb() gets a reffed sidebar, and unrefs it. Do we need to do the same here? */ g_object_unref (sidebar);
} }
static void static void
@ -2932,7 +2932,7 @@ start_shortcut_cb (GtkMenuItem *item,
mount_op = gtk_mount_operation_new (GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (sidebar)))); mount_op = gtk_mount_operation_new (GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (sidebar))));
g_drive_start (drive, G_DRIVE_START_NONE, mount_op, NULL, drive_start_cb, sidebar); g_drive_start (drive, G_DRIVE_START_NONE, mount_op, NULL, drive_start_cb, g_object_ref (sidebar));
g_object_unref (mount_op); g_object_unref (mount_op);
g_object_unref (drive); g_object_unref (drive);