AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-26 21:51:08 +00:00
Code Issues Projects Releases Wiki Activity

Merge branch 'mcatanzaro/company-unparent-warning' into 'master'

Browse Source 
Add critical if widget has a parent during dispose

See merge request GNOME/gtk!3053
This commit is contained in:
Matthias Clasen 2021-01-07 18:37:28 +00:00
commit 2a79152762
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gtk/gtkwidget.c
View File

@ -7187,7 +7187,13 @@ gtk_widget_dispose (GObject *object)
gtk_list_list_model_clear (priv->controller_observer);
if (priv->parent)
gtk_widget_unparent (widget);
{
g_critical ("%s %p has a parent %s %p during dispose. Parents hold a reference, so this should not happen.\n"
"Did you call g_object_unref() instead of gtk_widget_unparent()?",
G_OBJECT_TYPE_NAME (widget), widget,
G_OBJECT_TYPE_NAME (priv->parent), priv->parent);
priv->parent = NULL;
}
while (priv->paintables)
gtk_widget_paintable_set_widget (priv->paintables->data, NULL);