From 2b66e18dab44e1f207c881078a3230569bd3b927 Mon Sep 17 00:00:00 2001 From: Michael Natterer Date: Tue, 26 Feb 2008 14:20:08 +0000 Subject: [PATCH] don't g_free() the members of info->tag_stack since they are a) gobjects 2008-02-26 Michael Natterer * gtk/gtktextbufferserialize.c (parse_info_free): don't g_free() the members of info->tag_stack since they are a) gobjects and b) not even owned by us, ugh... Fixes crash when deserializing fails. svn path=/trunk/; revision=19657 --- ChangeLog | 14 ++++++++++---- gtk/gtktextbufferserialize.c | 9 --------- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index f54748cc4f..a98c8f8e14 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2008-02-26 Michael Natterer + + * gtk/gtktextbufferserialize.c (parse_info_free): don't g_free() + the members of info->tag_stack since they are a) gobjects and b) + not even owned by us, ugh... Fixes crash when deserializing fails. + 2008-02-26 Sven Neumann * docs/tools/shooter.c (find_toplevel_window) @@ -45,10 +51,10 @@ 2008-02-22 Dominic Lachowicz - * gdk-pixbuf/queryloaders.c (loader_sanity_check): It's perfectly acceptable - for a module to only support the save_to_callback() method if it marks itself - as WRITABLE - + * gdk-pixbuf/queryloaders.c (loader_sanity_check): It's perfectly + acceptable for a module to only support the save_to_callback() + method if it marks itself as WRITABLE + 2008-02-16 Matthias Clasen * configure.in: Bump version diff --git a/gtk/gtktextbufferserialize.c b/gtk/gtktextbufferserialize.c index 217208c4b4..c36409b4fd 100644 --- a/gtk/gtktextbufferserialize.c +++ b/gtk/gtktextbufferserialize.c @@ -1625,17 +1625,8 @@ text_span_free (TextSpan *span) static void parse_info_free (ParseInfo *info) { - GSList *slist; GList *list; - slist = info->tag_stack; - while (slist) - { - g_free (slist->data); - - slist = slist->next; - } - g_slist_free (info->tag_stack); g_slist_free (info->states);