update docs, return current FALSE if x is smaller than the current visible

Thu Jan 24 23:03:24 2002  Kristian Rietveld  <kris@gtk.org>

        * gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
        return current FALSE if x is smaller than the current visible area,
        not than the requested area, don't correct y coordinate,
        TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
This commit is contained in:
Kristian Rietveld 2002-01-24 22:07:35 +00:00 committed by Kristian Rietveld
parent b0f37124de
commit 2ccd6fd5d7
8 changed files with 60 additions and 10 deletions

View File

@ -1,3 +1,10 @@
Thu Jan 24 23:03:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
return current FALSE if x is smaller than the current visible area,
not than the requested area, don't correct y coordinate,
TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com> Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c * gtk/gtktreeview.c

View File

@ -1,3 +1,10 @@
Thu Jan 24 23:03:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
return current FALSE if x is smaller than the current visible area,
not than the requested area, don't correct y coordinate,
TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com> Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c * gtk/gtktreeview.c

View File

@ -1,3 +1,10 @@
Thu Jan 24 23:03:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
return current FALSE if x is smaller than the current visible area,
not than the requested area, don't correct y coordinate,
TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com> Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c * gtk/gtktreeview.c

View File

@ -1,3 +1,10 @@
Thu Jan 24 23:03:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
return current FALSE if x is smaller than the current visible area,
not than the requested area, don't correct y coordinate,
TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com> Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c * gtk/gtktreeview.c

View File

@ -1,3 +1,10 @@
Thu Jan 24 23:03:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
return current FALSE if x is smaller than the current visible area,
not than the requested area, don't correct y coordinate,
TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com> Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c * gtk/gtktreeview.c

View File

@ -1,3 +1,10 @@
Thu Jan 24 23:03:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
return current FALSE if x is smaller than the current visible area,
not than the requested area, don't correct y coordinate,
TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com> Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c * gtk/gtktreeview.c

View File

@ -1,3 +1,10 @@
Thu Jan 24 23:03:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_path_at_pos): update docs,
return current FALSE if x is smaller than the current visible area,
not than the requested area, don't correct y coordinate,
TREE_WINDOW_Y_TO_RBTREE_Y will do that. Fixes #67477.
Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com> Thu Jan 24 15:41:08 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreeview.c * gtk/gtktreeview.c

View File

@ -8355,14 +8355,15 @@ gtk_tree_view_get_bin_window (GtkTreeView *tree_view)
* @cell_y: A pointer where the Y coordinate relative to the cell can be placed, or %NULL * @cell_y: A pointer where the Y coordinate relative to the cell can be placed, or %NULL
* *
* Finds the path at the point (@x, @y), relative to widget coordinates. That * Finds the path at the point (@x, @y), relative to widget coordinates. That
* is, @x and @y are relative to an events coordinates. It is primarily for * is, @x and @y are relative to an events coordinates. @x and @y must come
* things like popup menus. If @path is non-%NULL, then it will be filled with * from an event on the @tree_view only where event->window ==
* the #GtkTreePath at that point. This path should be freed with * gtk_tree_view_get_bin (). It is primarily for things like popup menus.
* gtk_tree_path_free(). If @column is non-%NULL, then it will be filled with * If @path is non-%NULL, then it will be filled with the #GtkTreePath at that
* the column at that point. @cell_x and @cell_y return the coordinates relative * point. This path should be freed with gtk_tree_path_free(). If @column
* to the cell background (i.e. the @background_area passed to * is non-%NULL, then it will be filled with the column at that point.
* gtk_cell_renderer_render()). This function is only meaningful if @tree_view * @cell_x and @cell_y return the coordinates relative to the cell background
* is realized. * (i.e. the @background_area passed to gtk_cell_renderer_render()). This
* function is only meaningful if @tree_view is realized.
* *
* Return value: %TRUE if a row exists at that coordinate. * Return value: %TRUE if a row exists at that coordinate.
**/ **/
@ -8390,7 +8391,7 @@ gtk_tree_view_get_path_at_pos (GtkTreeView *tree_view,
if (tree_view->priv->tree == NULL) if (tree_view->priv->tree == NULL)
return FALSE; return FALSE;
if (x > tree_view->priv->hadjustment->upper) if (x > tree_view->priv->hadjustment->page_size)
return FALSE; return FALSE;
if (x < 0 || y < 0) if (x < 0 || y < 0)
@ -8438,7 +8439,7 @@ gtk_tree_view_get_path_at_pos (GtkTreeView *tree_view,
} }
y_offset = _gtk_rbtree_find_offset (tree_view->priv->tree, y_offset = _gtk_rbtree_find_offset (tree_view->priv->tree,
TREE_WINDOW_Y_TO_RBTREE_Y (tree_view, y + tree_view->priv->vadjustment->value), TREE_WINDOW_Y_TO_RBTREE_Y (tree_view, y),
&tree, &node); &tree, &node);
if (tree == NULL) if (tree == NULL)