AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-27 06:00:22 +00:00
Code Issues Projects Releases Wiki Activity

Make menu activation work again

Browse Source 
After we stopped untranslatable delivering events, menus stopped
working 'the second time'. After some painful debugging, it appears
that this is caused by the menushell code deliberately grabbing
on the menubar *after* grabbing on the menu, causing events to
be deleivered to the wrong toplevel. This did not use to matter,
but now we drop these events.

Absent a more thorough rewrite of menus, just don't grab on
the menubar. This makes menu activation work again and does not
appear to have ill effects, on either Wayland or X.

Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1796
This commit is contained in:
Matthias Clasen 2019-04-06 00:20:21 +00:00
parent cb3d61bb0e
commit 2deb0e7e1d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk/gtkmenushell.c
View File

@ -708,7 +708,7 @@ multi_press_pressed (GtkGestureMultiPress *gesture,
gtk_widget_get_parent (menu_item) == GTK_WIDGET (menu_shell) &&
menu_item != priv->active_menu_item)
{
gtk_menu_shell_activate (menu_shell);
priv->active = TRUE;
if (GTK_MENU_SHELL_GET_CLASS (menu_shell)->submenu_placement == GTK_TOP_BOTTOM)
{