AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-11-17 23:10:22 +00:00
Code Issues Projects Releases Wiki Activity

GtkHeaderBar: Don't leak

Browse Source 
Should have a finalize function, if there's strings to free.
Also avoid some pointless extra ref on custom title widgets.
This commit is contained in:
Matthias Clasen 2013-03-19 20:35:28 -04:00
parent 2f9726b4a4
commit 3289b3efbf
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gtk/gtkheaderbar.c
View File

@ -682,12 +682,11 @@ gtk_header_bar_set_custom_title (GtkHeaderBar *bar,
priv->custom_title = NULL;
gtk_widget_unparent (custom);
g_object_unref (custom);
}
if (title_widget)
{
priv->custom_title = g_object_ref (title_widget);
priv->custom_title = title_widget;
gtk_widget_hide (priv->label);
@ -726,6 +725,16 @@ gtk_header_bar_get_custom_title (GtkHeaderBar *bar)
return bar->priv->custom_title;
}
static void
gtk_header_bar_finalize (GObject *object)
{
GtkHeaderBar *bar = GTK_HEADER_BAR (object);
g_free (bar->priv->title);
G_OBJECT_CLASS (gtk_header_bar_parent_class)->finalize (object);
}
static void
gtk_header_bar_get_property (GObject *object,
guint prop_id,
@ -1048,6 +1057,7 @@ gtk_header_bar_class_init (GtkHeaderBarClass *class)
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class);
GtkContainerClass *container_class = GTK_CONTAINER_CLASS (class);
object_class->finalize = gtk_header_bar_finalize;
object_class->get_property = gtk_header_bar_get_property;
object_class->set_property = gtk_header_bar_set_property;