AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-24 12:41:16 +00:00
Code Issues Projects Releases Wiki Activity

docs: Clarify the section on commit access

Browse Source 
The section is about rules for direct commit access to the upstream
repository, so let's be more clear about it.
This commit is contained in:
Emmanuele Bassi 2018-10-15 10:48:05 +01:00
parent 0397c8b628
commit 3f567781dd
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
CONTRIBUTING.md
View File

@ -210,7 +210,7 @@ Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1234
the commit message, e.g. `Bug: #1234`, and use the automatic issue the commit message, e.g. `Bug: #1234`, and use the automatic issue
closing syntax in the description of the merge request. closing syntax in the description of the merge request.
### Access to the GTK repository ### Commit access to the GTK repository
GTK is part of the GNOME infrastructure. At the current time, any GTK is part of the GNOME infrastructure. At the current time, any
person with write access to the GNOME repository can merge changes to person with write access to the GNOME repository can merge changes to
@ -238,10 +238,11 @@ people committing to GTK to follow a few rules:
0. Always write a meaningful commit message. Changes without a sufficient 0. Always write a meaningful commit message. Changes without a sufficient
commit message will be reverted. commit message will be reverted.
0. Never push to a public branch directly; you should always go through 0. Never push to the `master` branch, or any stable branches, directly; you
a merge request, to ensure that the code is tested on the CI infrastructure should always go through a merge request, to ensure that the code is
at the very least. A merge request is also the proper place to get a tested on the CI infrastructure at the very least. A merge request is
comprehensive code review from the core developers of GTK. also the proper place to get a comprehensive code review from the core
developers of GTK.
If you have been contributing to GTK for a while and you don't have commit If you have been contributing to GTK for a while and you don't have commit
access to the repository, you may ask to obtain it following the [GNOME account access to the repository, you may ask to obtain it following the [GNOME account