AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-28 14:31:10 +00:00
Code Issues Projects Releases Wiki Activity

gdk/wayland: freeze popups when hidden

Browse Source 
Previously, there was an issue with glitching after showing/hiding a
popover that was not also destroyed. This was due to the popover having
an update_freeze_count of zero after hiding the surface.

That resulted in it's toplevel continuously dropping frames such as during
high-frame-rate scrolling in textviews. This problem is much more visible
on high-frame-rate displays such as 120hz/144hz.

With this commit, we freeze the frame clock of the popup until it is
mapped again.
This commit is contained in:
Christian Hergert 2022-03-23 17:00:21 -07:00 committed by Ivan Molodetskikh
parent 26b250503d
commit 4bf07aeef9
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gdk/wayland/gdksurface-wayland.c
View File

@ -113,6 +113,7 @@ struct _GdkWaylandSurface
PopupState popup_state; PopupState popup_state;
unsigned int popup_thaw_upon_show : 1;
unsigned int initial_configure_received : 1; unsigned int initial_configure_received : 1;
unsigned int has_uncommitted_ack_configure : 1; unsigned int has_uncommitted_ack_configure : 1;
unsigned int mapped : 1; unsigned int mapped : 1;
@ -2984,6 +2985,9 @@ gdk_wayland_surface_hide_surface (GdkSurface *surface)
if (GDK_IS_POPUP (surface)) if (GDK_IS_POPUP (surface))
{ {
impl->popup_thaw_upon_show = TRUE;
gdk_surface_freeze_updates (surface);
switch (impl->popup_state) switch (impl->popup_state)
{ {
case POPUP_STATE_WAITING_FOR_REPOSITIONED: case POPUP_STATE_WAITING_FOR_REPOSITIONED:
@ -3223,6 +3227,12 @@ show_popup (GdkSurface *surface,
if (!impl->display_server.wl_surface) if (!impl->display_server.wl_surface)
gdk_wayland_surface_create_surface (surface); gdk_wayland_surface_create_surface (surface);
if (impl->popup_thaw_upon_show)
{
impl->popup_thaw_upon_show = FALSE;
gdk_surface_thaw_updates (surface);
}
gdk_wayland_surface_map_popup (surface, width, height, layout); gdk_wayland_surface_map_popup (surface, width, height, layout);
} }