Fix sensitivity of file operation buttons and buttons inside fileop

Fri Oct 25 14:51:34 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkfilesel.c: Fix sensitivity of file operation
        buttons and buttons inside fileop dialogs to update
        properly based on the contents of the entries.
        (#74267, based on part of a patch from Muktha
        Narayan)

        * gtk/gtkitemfactory.c (gtk_item_factory_create_item):
        Warn if loading <ImageItem> image fails.

        * tests/testgtk.c: Fix data for "apple" inline pixbuf
        to be valid.
This commit is contained in:
Owen Taylor 2002-10-25 19:59:41 +00:00 committed by Owen Taylor
parent 12f3fbc081
commit 547b0bd938
7 changed files with 80 additions and 37 deletions

View File

@ -1,10 +1,10 @@
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
* gtk/gtkitemfactory.c (gtk_item_factory_create_item):
Warn if loading <ImageItem> image fails.
@ -12,6 +12,12 @@ Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* tests/testgtk.c: Fix data for "apple" inline pixbuf
to be valid.
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
2002-10-25 Matthias Clasen <maclas@gmx.de>
* gdk/x11/gdkcursor-x11.c: Fix doc comment.

View File

@ -1,10 +1,10 @@
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
* gtk/gtkitemfactory.c (gtk_item_factory_create_item):
Warn if loading <ImageItem> image fails.
@ -12,6 +12,12 @@ Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* tests/testgtk.c: Fix data for "apple" inline pixbuf
to be valid.
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
2002-10-25 Matthias Clasen <maclas@gmx.de>
* gdk/x11/gdkcursor-x11.c: Fix doc comment.

View File

@ -1,10 +1,10 @@
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
* gtk/gtkitemfactory.c (gtk_item_factory_create_item):
Warn if loading <ImageItem> image fails.
@ -12,6 +12,12 @@ Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* tests/testgtk.c: Fix data for "apple" inline pixbuf
to be valid.
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
2002-10-25 Matthias Clasen <maclas@gmx.de>
* gdk/x11/gdkcursor-x11.c: Fix doc comment.

View File

@ -1,10 +1,10 @@
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
* gtk/gtkitemfactory.c (gtk_item_factory_create_item):
Warn if loading <ImageItem> image fails.
@ -12,6 +12,12 @@ Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* tests/testgtk.c: Fix data for "apple" inline pixbuf
to be valid.
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
2002-10-25 Matthias Clasen <maclas@gmx.de>
* gdk/x11/gdkcursor-x11.c: Fix doc comment.

View File

@ -1,10 +1,10 @@
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
* gtk/gtkitemfactory.c (gtk_item_factory_create_item):
Warn if loading <ImageItem> image fails.
@ -12,6 +12,12 @@ Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* tests/testgtk.c: Fix data for "apple" inline pixbuf
to be valid.
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
2002-10-25 Matthias Clasen <maclas@gmx.de>
* gdk/x11/gdkcursor-x11.c: Fix doc comment.

View File

@ -1,10 +1,10 @@
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
* gtk/gtkitemfactory.c (gtk_item_factory_create_item):
Warn if loading <ImageItem> image fails.
@ -12,6 +12,12 @@ Fri Oct 25 10:50:37 2002 Owen Taylor <otaylor@redhat.com>
* tests/testgtk.c: Fix data for "apple" inline pixbuf
to be valid.
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
2002-10-25 Matthias Clasen <maclas@gmx.de>
* gdk/x11/gdkcursor-x11.c: Fix doc comment.

View File

@ -1076,15 +1076,22 @@ gtk_item_factory_create_item (GtkItemFactory *ifactory,
gtk_check_menu_item_set_show_toggle (GTK_CHECK_MENU_ITEM (widget), TRUE);
if (type_id == quark_type_image_item)
{
GError *error = NULL;
GdkPixbuf *pixbuf = NULL;
image = NULL;
pixbuf = gdk_pixbuf_new_from_inline (-1,
entry->extra_data,
FALSE,
NULL);
&error);
if (pixbuf)
image = gtk_image_new_from_pixbuf (pixbuf);
else
{
g_warning ("Error loading menu image: %s", error->message);
g_error_free (error);
}
if (image)
{
gtk_image_menu_item_set_image (GTK_IMAGE_MENU_ITEM (widget), image);