From 5c071cb02eedc18dae13ce8cb548efdcef0c541b Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Wed, 7 Aug 2024 18:07:35 +0200 Subject: [PATCH] dmabuf: Fix a check We were comparing with destination stride, not with source stride, and in rare cases when those were different, this would trigger aborts in the testsuite. --- gdk/gdkdmabuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdk/gdkdmabuf.c b/gdk/gdkdmabuf.c index 748d0aa5d3..a054bfaf7d 100644 --- a/gdk/gdkdmabuf.c +++ b/gdk/gdkdmabuf.c @@ -71,7 +71,7 @@ download_memcpy (guchar *dst_data, bpp = gdk_memory_format_bytes_per_pixel (dst_format); src_stride = dmabuf->planes[0].stride; src_data = src_datas[0] + dmabuf->planes[0].offset; - g_return_if_fail (sizes[0] >= dmabuf->planes[0].offset + gdk_memory_format_min_buffer_size (dst_format, dst_stride, width, height)); + g_return_if_fail (sizes[0] >= dmabuf->planes[0].offset + gdk_memory_format_min_buffer_size (dst_format, src_stride, width, height)); if (dst_stride == src_stride) memcpy (dst_data, src_data, (height - 1) * dst_stride + width * bpp);