AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-11-08 17:50:10 +00:00
Code Issues Projects Releases Wiki Activity

cups printbackend: Plug memory leaks

Browse Source 
This loop has many early exits, and all of them
need to free this info object that gets allocated
at the beginning.
This commit is contained in:
Matthias Clasen 2022-08-12 18:44:25 -04:00
parent 586826d34c
commit 62192cba6e
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
modules/printbackends/gtkprintbackendcups.c
View File

@ -3726,7 +3726,10 @@ cups_request_printer_list_cb (GtkPrintBackendCups *cups_backend,
attr = ippNextAttribute (response);
if (attr == NULL)
break;
{
printer_setup_info_free (info);
break;
}
while (attr != NULL && ippGetGroupTag (attr) == IPP_TAG_PRINTER)
{
@ -3737,6 +3740,7 @@ cups_request_printer_list_cb (GtkPrintBackendCups *cups_backend,
if (info->printer_name == NULL ||
(info->printer_uri == NULL && info->member_uris == NULL))
{
printer_setup_info_free (info);
if (attr == NULL)
break;
else
@ -3747,7 +3751,10 @@ cups_request_printer_list_cb (GtkPrintBackendCups *cups_backend,
iter = g_list_find_custom (GTK_PRINT_BACKEND_CUPS (backend)->temporary_queues_removed,
info->printer_name, (GCompareFunc) g_strcmp0);
if (iter != NULL)
continue;
{
printer_setup_info_free (info);
continue;
}
if (info->got_printer_type)
{