AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2025-01-13 14:00:09 +00:00
Code Issues Projects Releases Wiki Activity

boxlayout: Don't always reserve height for baseline alignment

Browse Source 
Otherwise an horizontal box may have a larger minumum height than
any of its children even though non of them is baseline-aligned.

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/5863
This commit is contained in:
António Fernandes 2023-06-02 20:18:56 +01:00
parent c8c895d160
commit 6b59c138b2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gtk/gtkboxlayout.c
View File

@ -323,6 +323,7 @@ gtk_box_layout_compute_opposite_size (GtkBoxLayout *self,
int largest_min_above = -1, largest_min_below = -1; int largest_min_above = -1, largest_min_below = -1;
int largest_nat_above = -1, largest_nat_below = -1; int largest_nat_above = -1, largest_nat_below = -1;
gboolean have_baseline = FALSE; gboolean have_baseline = FALSE;
gboolean align_baseline = FALSE;
for (child = gtk_widget_get_first_child (widget); for (child = gtk_widget_get_first_child (widget);
child != NULL; child != NULL;
@ -350,6 +351,10 @@ gtk_box_layout_compute_opposite_size (GtkBoxLayout *self,
if (child_min_baseline > -1) if (child_min_baseline > -1)
{ {
have_baseline = TRUE; have_baseline = TRUE;
if (gtk_widget_get_valign (child) == GTK_ALIGN_BASELINE_FILL ||
gtk_widget_get_valign (child) == GTK_ALIGN_BASELINE_CENTER)
align_baseline = TRUE;
largest_min_above = MAX (largest_min_above, child_min_baseline); largest_min_above = MAX (largest_min_above, child_min_baseline);
largest_min_below = MAX (largest_min_below, child_min - child_min_baseline); largest_min_below = MAX (largest_min_below, child_min - child_min_baseline);
largest_nat_above = MAX (largest_nat_above, child_nat_baseline); largest_nat_above = MAX (largest_nat_above, child_nat_baseline);
@ -358,7 +363,7 @@ gtk_box_layout_compute_opposite_size (GtkBoxLayout *self,
} }
} }
if (self->orientation == GTK_ORIENTATION_HORIZONTAL) if (self->orientation == GTK_ORIENTATION_HORIZONTAL && align_baseline)
{ {
largest_min = MAX (largest_min, largest_min_above + largest_min_below); largest_min = MAX (largest_min, largest_min_above + largest_min_below);
largest_nat = MAX (largest_nat, largest_nat_above + largest_nat_below); largest_nat = MAX (largest_nat, largest_nat_above + largest_nat_below);