AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-09-19 21:40:22 +00:00
Code Issues Projects Releases Wiki Activity

gsk: texture-scale nodes with non-integer bounds aren't opaque

Browse Source 
Due to the way the intermediate offscreen gets drawn, we might end up
with seams at the edges.

And I don't think it's worth spending more time on than saying "not
opaque".

Fixes the compare-render testsuite

New testcase included.
This commit is contained in:
Benjamin Otte 2024-07-08 12:51:47 +02:00
parent 4cdf7aa65a
commit 6d564075f3
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gsk/gskrendernodeimpl.c
View File

@ -2117,7 +2117,9 @@ gsk_texture_scale_node_new (GdkTexture *texture,
self = gsk_render_node_alloc (GSK_TEXTURE_SCALE_NODE);
node = (GskRenderNode *) self;
node->offscreen_for_opacity = FALSE;
node->fully_opaque = gdk_memory_format_alpha (gdk_texture_get_format (texture)) == GDK_MEMORY_ALPHA_OPAQUE;
node->fully_opaque = gdk_memory_format_alpha (gdk_texture_get_format (texture)) == GDK_MEMORY_ALPHA_OPAQUE &&
bounds->size.width == floor (bounds->size.width) &&
bounds->size.height == floor (bounds->size.height);
self->texture = g_object_ref (texture);
gsk_rect_init_from_rect (&node->bounds, bounds);

7
testsuite/gsk/opaque/texture-scale-noninteger.node Normal file
View File

@ -0,0 +1,7 @@
texture-scale {
bounds: 3 0 1.5 1;
}
texture-scale {
bounds: 0 3 1 1.5;
}