AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2025-01-16 15:14:17 +00:00
Code Issues Projects Releases Wiki Activity

notebook: Use gdk_drag_begin

Browse Source 
Use gdk_drag_begin for one-off drags.
This commit is contained in:
Matthias Clasen 2020-01-06 18:06:25 -05:00
parent f459164f8a
commit 8c3736709e
1 changed files with 37 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

95
gtk/gtknotebook.c
View File

@ -54,6 +54,7 @@
#include "gtkdragsource.h" #include "gtkdragsource.h"
#include "gtkwidgetpaintable.h" #include "gtkwidgetpaintable.h"
#include "gtkselectionprivate.h" #include "gtkselectionprivate.h"
#include "gtknative.h"
#include "a11y/gtknotebookaccessible.h" #include "a11y/gtknotebookaccessible.h"
@ -696,15 +697,9 @@ static gboolean gtk_notebook_focus (GtkWidget *widget,
GtkDirectionType direction); GtkDirectionType direction);
/*** Drag and drop Methods ***/ /*** Drag and drop Methods ***/
static void gtk_notebook_drag_begin (GtkDragSource *source, static void gtk_notebook_dnd_finished_cb (GdkDrag *drag,
GdkDrag *drag,
GtkWidget *widget); GtkWidget *widget);
static void gtk_notebook_drag_end (GtkDragSource *source, static void gtk_notebook_drag_cancel_cb (GdkDrag *drag,
GdkDrag *drag,
gboolean delete_data,
GtkWidget *widget);
static gboolean gtk_notebook_drag_failed (GtkDragSource *source,
GdkDrag *drag,
GdkDragCancelReason reason, GdkDragCancelReason reason,
GtkWidget *widget); GtkWidget *widget);
static gboolean gtk_notebook_drag_motion (GtkDropTarget *dest, static gboolean gtk_notebook_drag_motion (GtkDropTarget *dest,
@ -2872,25 +2867,41 @@ gtk_notebook_motion (GtkEventController *controller,
if (page->detachable && if (page->detachable &&
check_threshold (notebook, priv->mouse_x, priv->mouse_y)) check_threshold (notebook, priv->mouse_x, priv->mouse_y))
{ {
GdkSurface *surface;
GdkDevice *device;
GdkContentProvider *content; GdkContentProvider *content;
GtkDragSource *source; GdkDrag *drag;
GdkPaintable *paintable;
priv->detached_tab = priv->cur_page; priv->detached_tab = priv->cur_page;
source = gtk_drag_source_new (); surface = gtk_native_get_surface (gtk_widget_get_native (GTK_WIDGET (notebook)));
content = gdk_content_provider_new_with_formats (priv->source_targets, gtk_notebook_drag_data_get, widget); device = gtk_get_current_event_device ();
gtk_drag_source_set_content (source, content);
content = gdk_content_provider_new_with_formats (priv->source_targets,
gtk_notebook_drag_data_get,
widget);
drag = gdk_drag_begin (surface, device, content, GDK_ACTION_MOVE, priv->drag_begin_x, priv->drag_begin_y);
g_object_unref (content); g_object_unref (content);
gtk_drag_source_set_actions (source, GDK_ACTION_MOVE);
g_signal_connect (source, "drag-begin", G_CALLBACK (gtk_notebook_drag_begin), notebook); g_signal_connect (drag, "dnd-finished", G_CALLBACK (gtk_notebook_dnd_finished_cb), notebook);
g_signal_connect (source, "drag-end", G_CALLBACK (gtk_notebook_drag_end), notebook); g_signal_connect (drag, "cancel", G_CALLBACK (gtk_notebook_drag_cancel_cb), notebook);
g_signal_connect (source, "drag-failed", G_CALLBACK (gtk_notebook_drag_failed), notebook);
paintable = gtk_widget_paintable_new (priv->detached_tab->tab_widget);
gtk_drag_icon_set_from_paintable (drag, paintable, -2, -2);
g_object_unref (paintable);
if (priv->dnd_timer)
{
g_source_remove (priv->dnd_timer);
priv->dnd_timer = 0;
}
priv->operation = DRAG_OPERATION_DETACH;
tab_drag_end (notebook, priv->cur_page);
g_object_unref (drag);
gtk_drag_source_drag_begin (source, widget,
gtk_get_current_event_device (),
priv->drag_begin_x, priv->drag_begin_y);
g_object_unref (source);
return; return;
} }
@ -3092,35 +3103,8 @@ update_arrow_nodes (GtkNotebook *notebook)
} }
static void static void
gtk_notebook_drag_begin (GtkDragSource *source, gtk_notebook_dnd_finished_cb (GdkDrag *drag,
GdkDrag *drag, GtkWidget *widget)
GtkWidget *widget)
{
GtkNotebook *notebook = GTK_NOTEBOOK (widget);
GtkNotebookPrivate *priv = notebook->priv;
GdkPaintable *paintable;
if (priv->dnd_timer)
{
g_source_remove (priv->dnd_timer);
priv->dnd_timer = 0;
}
g_assert (priv->cur_page != NULL);
priv->operation = DRAG_OPERATION_DETACH;
tab_drag_end (notebook, priv->cur_page);
paintable = gtk_widget_paintable_new (priv->detached_tab->tab_widget);
gtk_drag_source_set_icon (source, paintable, -2, -2);
g_object_unref (paintable);
}
static void
gtk_notebook_drag_end (GtkDragSource *source,
GdkDrag *drag,
gboolean delete_data,
GtkWidget *widget)
{ {
GtkNotebook *notebook = GTK_NOTEBOOK (widget); GtkNotebook *notebook = GTK_NOTEBOOK (widget);
GtkNotebookPrivate *priv = notebook->priv; GtkNotebookPrivate *priv = notebook->priv;
@ -3154,11 +3138,10 @@ gtk_notebook_create_window (GtkNotebook *notebook,
return NULL; return NULL;
} }
static gboolean static void
gtk_notebook_drag_failed (GtkDragSource *source, gtk_notebook_drag_cancel_cb (GdkDrag *drag,
GdkDrag *drag, GdkDragCancelReason reason,
GdkDragCancelReason reason, GtkWidget *widget)
GtkWidget *widget)
{ {
GtkNotebook *notebook = GTK_NOTEBOOK (widget); GtkNotebook *notebook = GTK_NOTEBOOK (widget);
GtkNotebookPrivate *priv = notebook->priv; GtkNotebookPrivate *priv = notebook->priv;
@ -3174,11 +3157,7 @@ gtk_notebook_drag_failed (GtkDragSource *source,
if (dest_notebook) if (dest_notebook)
do_detach_tab (notebook, dest_notebook, priv->detached_tab->child); do_detach_tab (notebook, dest_notebook, priv->detached_tab->child);
return TRUE;
} }
return FALSE;
} }
static gboolean static gboolean