106574 - Inconsistent increment behavior for gtkspinbutton

* gtk/gtkspinbutton.c (gtk_spin_button_real_value_change):
        Commit the entry text before doing an increment. Patch by
        Björn Lindqvist.


svn path=/trunk/; revision=20196
This commit is contained in:
Matthias Clasen 2008-05-27 22:50:49 +00:00
parent 4b1bba8af1
commit 8d5e58b632
2 changed files with 17 additions and 1 deletions

View File

@ -1,3 +1,11 @@
2008-05-27 Matthias Clasen <mclasen@redhat.com>
106574 - Inconsistent increment behavior for gtkspinbutton
* gtk/gtkspinbutton.c (gtk_spin_button_real_value_change):
Commit the entry text before doing an increment. Patch by
Björn Lindqvist.
2008-05-27 Federico Mena Quintero <federico@novell.com>
http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow

View File

@ -1266,7 +1266,15 @@ static void
gtk_spin_button_real_change_value (GtkSpinButton *spin,
GtkScrollType scroll)
{
gdouble old_value = spin->adjustment->value;
gdouble old_value;
/* When the key binding is activated, there may be an outstanding
* value, so we first have to commit what is currently written in
* the spin buttons text entry. See #106574
*/
gtk_spin_button_update (spin);
old_value = spin->adjustment->value;
/* We don't test whether the entry is editable, since
* this key binding conceptually corresponds to changing