From 90be2baf8bd593991550ba46b45871039d53df46 Mon Sep 17 00:00:00 2001 From: Emmanuele Bassi Date: Tue, 26 Sep 2023 14:40:37 +0100 Subject: [PATCH] broadway: Plug another leak When getting a colorized texture we're downloading the texture as a Cairo surface, and then feeding it to another texture, but we never drop the reference of the new surface. --- gsk/broadway/gskbroadwayrenderer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gsk/broadway/gskbroadwayrenderer.c b/gsk/broadway/gskbroadwayrenderer.c index c52c2d5e4e..1343525a92 100644 --- a/gsk/broadway/gskbroadwayrenderer.c +++ b/gsk/broadway/gskbroadwayrenderer.c @@ -453,7 +453,7 @@ get_colorized_texture (GdkTexture *texture, const graphene_matrix_t *color_matrix, const graphene_vec4_t *color_offset) { - cairo_surface_t *surface = gdk_texture_download_surface (texture); + cairo_surface_t *surface; cairo_surface_t *image_surface; graphene_vec4_t pixel; guint32* pixel_data; @@ -475,6 +475,7 @@ get_colorized_texture (GdkTexture *texture, return g_object_ref (colorized->texture); } + surface = gdk_texture_download_surface (texture); image_surface = cairo_surface_map_to_image (surface, NULL); data = cairo_image_surface_get_data (image_surface); width = cairo_image_surface_get_width (image_surface); @@ -536,6 +537,8 @@ get_colorized_texture (GdkTexture *texture, colorized_list, (GDestroyNotify)colorized_texture_free_list); } + cairo_surface_destroy (surface); + return colorized_texture; }