AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-27 06:00:22 +00:00
Code Issues Projects Releases Wiki Activity

texthandle: Correct placement of handles

Browse Source 
Text handles had the same problem as popovers.
They were interpreting their pointing-to rectangle
relative to the widgets bounds, when it is meant
to be relative to the widgtets allocation.

While we touch this code, rewrite it to use
gtk_widget_compute_point.
This commit is contained in:
Matthias Clasen 2023-03-24 14:49:18 -04:00
parent fb3fe7a353
commit 9db08c7a86
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gtk/gtktexthandle.c
View File

@ -131,15 +131,26 @@ gtk_text_handle_present_surface (GtkTextHandle *handle)
GdkRectangle rect;
GtkRequisition req;
GtkWidget *parent;
GtkNative *native;
graphene_point_t point = GRAPHENE_POINT_INIT (handle->pointing_to.x, handle->pointing_to.y);
graphene_point_t transformed;
double nx, ny;
gtk_widget_get_preferred_size (widget, NULL, &req);
gtk_text_handle_get_padding (handle, &handle->border);
parent = gtk_widget_get_parent (widget);
gtk_widget_get_surface_allocation (parent, &rect);
rect.x += handle->pointing_to.x;
rect.y += handle->pointing_to.y + handle->pointing_to.height - handle->border.top;
native = gtk_widget_get_native (parent);
gtk_native_get_surface_transform (native, &nx, &ny);
if (!gtk_widget_compute_point (parent, GTK_WIDGET (native),
&point, &transformed))
transformed = point;
rect.x = (int)(transformed.x + nx);
rect.y = (int)(transformed.y + ny) + handle->pointing_to.height - handle->border.top;
rect.width = req.width - handle->border.left - handle->border.right;
rect.height = 1;