From 9e11bb33356d627a1ef723d77a981144520e52cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=A0=D1=83=D1=81=D0=BB=D0=B0=D0=BD=20=D0=98=D0=B6=D0=B1?= =?UTF-8?q?=D1=83=D0=BB=D0=B0=D1=82=D0=BE=D0=B2?= Date: Thu, 24 Jul 2014 13:41:51 +0000 Subject: [PATCH] Remove gdk_win32_input_shape_combine_region() This function currently calls gdk_win32_window_shape_combine_region(), which is wrong, because it leads to SetWindowRgn() being called with non-NULL region, which makes W32 disable theming (particularly - decoration theming), which makes decorations revert back to old GDI-drawn Windows 2000 variant, which looks out of place and interacts *badly* with alpha channel (because GDI). https://bugzilla.gnome.org/show_bug.cgi?id=733671 --- gdk/win32/gdkwindow-win32.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdk/win32/gdkwindow-win32.c b/gdk/win32/gdkwindow-win32.c index 9b02791b49..0088206ed8 100644 --- a/gdk/win32/gdkwindow-win32.c +++ b/gdk/win32/gdkwindow-win32.c @@ -3227,10 +3227,10 @@ gdk_win32_input_shape_combine_region (GdkWindow *window, gint offset_x, gint offset_y) { - if (GDK_WINDOW_DESTROYED (window)) - return; - /* CHECK: are these really supposed to be the same? */ - gdk_win32_window_shape_combine_region (window, shape_region, offset_x, offset_y); + /* Input shapes are not supported: input shape is always the same as + * the window shape; pixels with alpha == 0 are usually not clickable, + * clickability can be overriden by handling WM_NCHITTEST. + */ } gboolean