From a78643bd6fdb91f8ad9f1aacf0b2ebb557dc39bf Mon Sep 17 00:00:00 2001 From: Michael Hutchinson Date: Tue, 2 Jul 2013 19:04:36 -0400 Subject: [PATCH] Bug 705181: Fix annoying beeping introduced by Mac IME NSTextInputClient should not chain unhandled commands to super (cherry picked from commit 91bcca6f395ba6d5aa5a688d6d629633bbea539f) --- gdk/quartz/GdkQuartzView.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdk/quartz/GdkQuartzView.c b/gdk/quartz/GdkQuartzView.c index 0254ee319e..6bc3afeea1 100644 --- a/gdk/quartz/GdkQuartzView.c +++ b/gdk/quartz/GdkQuartzView.c @@ -172,7 +172,11 @@ -(void)doCommandBySelector: (SEL)aSelector { GDK_NOTE (EVENTS, g_print ("doCommandBySelector\n")); - [super doCommandBySelector: aSelector]; + /* Do nothing. Although we are required to implement this method for + * NSTextInputClient, we do not handle Cocoa command IDs, and the + * Apple docs explicitly say not to forward unhandled commands up + * the NSReponder chain, which calls NSBeep(). + */ } -(void)insertText: (id)aString replacementRange: (NSRange)replacementRange