AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-09-20 05:50:11 +00:00
Code Issues Projects Releases Wiki Activity

a11y: Only allow get_name/description when realized

Browse Source 
These functions rely on self->accessible_role
being set, and that is only the case for realized
contexts.

In practice, this is not a problem. Contexts are
realized before ATs can get their names or descriptions,
and the inspector realizes contexts too, nowadays.

The only place where this caused a hickup is the
testsuite.
This commit is contained in:
Matthias Clasen 2023-06-19 11:47:59 -04:00
parent 7df9cc1b47
commit a791f235e6
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk/gtkatcontext.c
View File

@ -1229,6 +1229,8 @@ gtk_at_context_get_text_accumulate (GtkATContext *self,
{
GtkAccessibleValue *value = NULL;
g_warn_if_fail (self->realized);
/* Step 2.A */
if (!is_ref)
{
@ -1377,6 +1379,8 @@ gtk_at_context_get_text (GtkATContext *self,
{
GtkATContext *parent = NULL;
g_warn_if_fail (self->realized);
/* Step 1 */
if (gtk_accessible_role_get_naming (self->accessible_role) == GTK_ACCESSIBLE_NAME_PROHIBITED)
return g_strdup ("");