From a9b698b265f4b0c909b1baabc6b2c8bcec719a46 Mon Sep 17 00:00:00 2001 From: Carlos Soriano Date: Thu, 11 Jun 2015 18:55:24 +0200 Subject: [PATCH] gtkplacesidebar: remove obsolete drop state We didn't use those for some time now. --- gtk/gtkplacessidebar.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c index 568d72d9ee..a518d09363 100644 --- a/gtk/gtkplacessidebar.c +++ b/gtk/gtkplacessidebar.c @@ -106,22 +106,14 @@ #define TIMEOUT_EXPAND 500 /* These are used when a destination-side DND operation is taking place. - * Normally, when a file is being hovered directly over a bookmark, - * we’ll be in DROP_STATE_NORMAL. - * - * But when a file is being hovered between bookmarks, this means the user - * may want to create a new bookmark for that file between those bookmarks. - * In that case, the drop state will be *not* DROP_STATE_NORMAL. - * - * When the drop state is FADING_OUT, it means that the user is hovering - * directly over an existing bookmark and an immediate drop will cause the - * file being dragged to be dropped on the bookmark, instead of causing - * a new bookmark to be created. + * Normally, when a common drag action is taking place, the state will be + * DROP_STATE_NEW_BOOKMARK_ARMED, however, if the client of GtkPlacesSidebar + * wants to show hints about the valid targets, we sill set it as + * DROP_STATE_NEW_BOOKMARK_ARMED_PERMANENT, so the sidebar will show drop hints + * until the client says otherwise */ typedef enum { DROP_STATE_NORMAL, - DROP_STATE_NEW_BOOKMARK_FADING_IN, - DROP_STATE_NEW_BOOKMARK_FADING_OUT, DROP_STATE_NEW_BOOKMARK_ARMED, DROP_STATE_NEW_BOOKMARK_ARMED_PERMANENT, } DropState;