Simplify, make more efficient and fix memory leak when turning quark into

Tue Dec  4 12:16:31 2001  Owen Taylor  <otaylor@redhat.com>
	* gtk/gtksettings.c (gtk_settings_set_property_value):
	Simplify, make more efficient and fix memory leak
	when turning quark into a string. (#66103, HideToshi
	Tajima)
This commit is contained in:
Owen Taylor 2001-12-04 17:20:41 +00:00 committed by Owen Taylor
parent feca5a64e2
commit b36b22988c
8 changed files with 44 additions and 12 deletions

View File

@ -1,4 +1,9 @@
Tue Dec 4 12:06:13 2001 Owen Taylor <otaylor@redhat.com>
Tue Dec 4 12:16:31 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtksettings.c (gtk_settings_set_property_value):
Simplify, make more efficient and fix memory leak
when turning quark into a string. (#66103, HideToshi
Tajima)
* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
init() and unref priv->tooltips in destroy rather

View File

@ -1,4 +1,9 @@
Tue Dec 4 12:06:13 2001 Owen Taylor <otaylor@redhat.com>
Tue Dec 4 12:16:31 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtksettings.c (gtk_settings_set_property_value):
Simplify, make more efficient and fix memory leak
when turning quark into a string. (#66103, HideToshi
Tajima)
* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
init() and unref priv->tooltips in destroy rather

View File

@ -1,4 +1,9 @@
Tue Dec 4 12:06:13 2001 Owen Taylor <otaylor@redhat.com>
Tue Dec 4 12:16:31 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtksettings.c (gtk_settings_set_property_value):
Simplify, make more efficient and fix memory leak
when turning quark into a string. (#66103, HideToshi
Tajima)
* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
init() and unref priv->tooltips in destroy rather

View File

@ -1,4 +1,9 @@
Tue Dec 4 12:06:13 2001 Owen Taylor <otaylor@redhat.com>
Tue Dec 4 12:16:31 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtksettings.c (gtk_settings_set_property_value):
Simplify, make more efficient and fix memory leak
when turning quark into a string. (#66103, HideToshi
Tajima)
* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
init() and unref priv->tooltips in destroy rather

View File

@ -1,4 +1,9 @@
Tue Dec 4 12:06:13 2001 Owen Taylor <otaylor@redhat.com>
Tue Dec 4 12:16:31 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtksettings.c (gtk_settings_set_property_value):
Simplify, make more efficient and fix memory leak
when turning quark into a string. (#66103, HideToshi
Tajima)
* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
init() and unref priv->tooltips in destroy rather

View File

@ -1,4 +1,9 @@
Tue Dec 4 12:06:13 2001 Owen Taylor <otaylor@redhat.com>
Tue Dec 4 12:16:31 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtksettings.c (gtk_settings_set_property_value):
Simplify, make more efficient and fix memory leak
when turning quark into a string. (#66103, HideToshi
Tajima)
* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
init() and unref priv->tooltips in destroy rather

View File

@ -1,4 +1,9 @@
Tue Dec 4 12:06:13 2001 Owen Taylor <otaylor@redhat.com>
Tue Dec 4 12:16:31 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtksettings.c (gtk_settings_set_property_value):
Simplify, make more efficient and fix memory leak
when turning quark into a string. (#66103, HideToshi
Tajima)
* gtk/gtkcolorsel.c: Ref and sink priv->tooltips in
init() and unref priv->tooltips in destroy rather

View File

@ -583,11 +583,8 @@ gtk_settings_set_property_value (GtkSettings *settings,
name = g_strdup (prop_name);
g_strcanon (name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "-", '-');
name_quark = g_quark_try_string (name);
if (name_quark)
g_free (name);
else
name_quark = g_quark_from_string (name);
name_quark = g_quark_from_string (name);
g_free (name);
qvalue = g_datalist_id_get_data (&settings->queued_settings, name_quark);
if (!qvalue)