From bbd8b9a51c3c581e914d907679dab8194fdb35bc Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 22 Mar 2006 21:11:40 +0000 Subject: [PATCH] Emit the ::page-removed signal after removing the page. (#335238, 2006-03-22 Matthias Clasen * gtk/gtknotebook.c (gtk_notebook_remove): Emit the ::page-removed signal after removing the page. (#335238, Christian Persch) --- ChangeLog | 5 +++++ ChangeLog.pre-2-10 | 5 +++++ gtk/gtknotebook.c | 12 ++++++++---- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 506a691387..730d65cd31 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-03-22 Matthias Clasen + + * gtk/gtknotebook.c (gtk_notebook_remove): Emit the ::page-removed + signal after removing the page. (#335238, Christian Persch) + 2006-03-22 Carlos Garnacho * gtk/gtkexpander.c: Make it to expand when hovering during DnD diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 506a691387..730d65cd31 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,8 @@ +2006-03-22 Matthias Clasen + + * gtk/gtknotebook.c (gtk_notebook_remove): Emit the ::page-removed + signal after removing the page. (#335238, Christian Persch) + 2006-03-22 Carlos Garnacho * gtk/gtkexpander.c: Make it to expand when hovering during DnD diff --git a/gtk/gtknotebook.c b/gtk/gtknotebook.c index b0017891f1..cdbc2843ca 100644 --- a/gtk/gtknotebook.c +++ b/gtk/gtknotebook.c @@ -855,7 +855,7 @@ gtk_notebook_class_init (GtkNotebookClass *class) * @page_num: the @child page number * * the ::page-removed signal is emitted in the notebook - * right before a page is removed from the notebook. + * right after a page is removed from the notebook. * * Since: 2.10 **/ @@ -869,7 +869,7 @@ gtk_notebook_class_init (GtkNotebookClass *class) GTK_TYPE_WIDGET, G_TYPE_UINT); /** - * GtkNotebook::page-attached: + * GtkNotebook::page-added: * @notebook: the #GtkNotebook * @child: the child #GtkWidget affected * @page_num: the new page number for @child @@ -3299,13 +3299,17 @@ gtk_notebook_remove (GtkContainer *container, children = children->next; } + g_object_ref (widget); + + gtk_notebook_real_remove (notebook, children); + g_signal_emit (notebook, notebook_signals[PAGE_REMOVED], 0, widget, page_num); - - gtk_notebook_real_remove (notebook, children); + + g_object_unref (widget); } static gboolean