AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-30 15:31:34 +00:00
Code Issues Projects Releases Wiki Activity

widget: Change callback scope

Browse Source 
Look who changed his mind since commit 8e2ffb3b46 :-)

The "call" scope means that the callback is only used during the
function call itself (here: gtk_widget_class_install_action()).

That's clearly wrong here, as the callback is invoked every time
the action is activated.

Arguably the "notified" scope is a better match here, where the
lack of a GDestroyNotify parameter suggests that the callback may
be used forever (which is the case here).

Related: #3498
This commit is contained in:
Florian Müllner 2021-07-28 21:48:01 +02:00
parent 527b2c5ab1
commit bc386c9a60
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk/gtkwidget.c
View File

@ -12465,7 +12465,7 @@ gtk_widget_class_add_action (GtkWidgetClass *widget_class,
* @widget_class: a `GtkWidgetClass`
* @action_name: a prefixed action name, such as "clipboard.paste"
* @parameter_type: (nullable): the parameter type
* @activate: (scope call): callback to use when the action is activated
* @activate: (scope notified): callback to use when the action is activated
*
* This should be called at class initialization time to specify
* actions to be added for all instances of this class.