AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-11-18 09:00:34 +00:00
Code Issues Projects Releases Wiki Activity

stylecontext: Simplify code

Browse Source 
Compute the differences only once and not in both if branches.
This commit is contained in:
Benjamin Otte 2014-12-16 06:40:10 +01:00
parent 7493e814a9
commit c0af2d6fa6
1 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
gtk/gtkstylecontext.c
View File

@ -2832,16 +2832,6 @@ _gtk_style_context_validate (GtkStyleContext *context,
style_info_set_values (info, values);
_gtk_style_context_update_animating (context);
if (current)
{
changes = gtk_css_style_get_difference (values, current);
}
else
{
changes = _gtk_bitmask_new ();
changes = _gtk_bitmask_invert_range (changes, 0, _gtk_css_style_property_get_n_properties ());
}
g_object_unref (values);
}
else
@ -2856,21 +2846,17 @@ _gtk_style_context_validate (GtkStyleContext *context,
else
update_properties (context, current, info->decl, changes);
}
_gtk_bitmask_free (changes);
if (change & GTK_CSS_CHANGE_ANIMATE &&
gtk_style_context_is_animating (context))
{
GtkCssStyle *new_values;
GtkBitmask *animation_changes;
new_values = gtk_css_animated_style_new_advance (GTK_CSS_ANIMATED_STYLE (info->values), timestamp);
animation_changes = gtk_css_style_get_difference (new_values, info->values);
style_info_set_values (info, new_values);
g_object_unref (new_values);
changes = _gtk_bitmask_union (changes, animation_changes);
_gtk_bitmask_free (animation_changes);
if (!GTK_IS_CSS_ANIMATED_STYLE (info->values) ||
gtk_css_animated_style_is_static (GTK_CSS_ANIMATED_STYLE (info->values)))
_gtk_style_context_update_animating (context);
@ -2878,7 +2864,15 @@ _gtk_style_context_validate (GtkStyleContext *context,
}
if (current)
g_object_unref (current);
{
changes = gtk_css_style_get_difference (info->values, current);
g_object_unref (current);
}
else
{
changes = _gtk_bitmask_new ();
changes = _gtk_bitmask_invert_range (changes, 0, _gtk_css_style_property_get_n_properties ());
}
if (!_gtk_bitmask_is_empty (changes))
gtk_style_context_do_invalidate (context, changes);