AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-11-10 19:00:08 +00:00
Code Issues Projects Releases Wiki Activity

notebook: Fix up ref counting

Browse Source 
We need to keep a ref to the page objects.
This commit is contained in:
Matthias Clasen 2019-02-20 23:02:39 -05:00
parent f11d0118a3
commit c1ad7217b5
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gtk/gtknotebook.c
View File

@ -4216,7 +4216,7 @@ gtk_notebook_insert_notebook_page (GtkNotebook *notebook,
if ((position < 0) || (position > nchildren))
position = nchildren;
priv->children = g_list_insert (priv->children, page, position);
priv->children = g_list_insert (priv->children, g_object_ref (page), position);
if (position < nchildren)
sibling = GTK_NOTEBOOK_PAGE_FROM_LIST (g_list_nth (priv->children, position))->tab_widget;
@ -4305,6 +4305,7 @@ gtk_notebook_real_insert_page (GtkNotebook *notebook,
gint position)
{
GtkNotebookPage *page;
int ret;
page = g_object_new (GTK_TYPE_NOTEBOOK_PAGE,
"child", child,
@ -4312,7 +4313,11 @@ gtk_notebook_real_insert_page (GtkNotebook *notebook,
"menu", menu_label,
NULL);
return gtk_notebook_insert_notebook_page (notebook, page, position);
ret = gtk_notebook_insert_notebook_page (notebook, page, position);
g_object_unref (page);
return ret;
}
static gboolean