From c3d3e2d47b772b96848628bb68b0d4e7e9fd3fad Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sat, 27 May 2023 17:26:39 -0400 Subject: [PATCH] sortlistmodel: Fix handling of section sort keys When the section sorter changes, we need to update the keys, otherwise the sorter will continue to report the old sections. This code is currently a bit suboptimal, since the creation of sort keys and section sort keys are muddled together. Fixes: #5854 --- gtk/gtksortlistmodel.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gtk/gtksortlistmodel.c b/gtk/gtksortlistmodel.c index 50add242f0..becfec012e 100644 --- a/gtk/gtksortlistmodel.c +++ b/gtk/gtksortlistmodel.c @@ -912,6 +912,12 @@ gtk_sort_list_model_sorter_changed_cb (GtkSorter *sorter, } } + if (self->section_sorter) + { + gtk_sort_keys_unref (self->section_sort_keys); + self->section_sort_keys = gtk_sorter_get_keys (self->section_sorter); + } + if (gtk_sort_list_model_start_sorting (self, NULL)) pos = n_items = 0; else