diff --git a/ChangeLog b/ChangeLog index 5e95706af8..84845db98d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2008-08-19 Björn Lindqvist + + Bug 548354 – Remove repeated code in gtk_cell_view_size_allocate + + * gtk/gtkcellview.c (gtk_cell_view_size_allocate): Remove some + code duplication, no need for separate loops for GTK_PACK_START + and GTK_PACK_END. + 2008-08-19 Johan Dahlin * gtk/gtk-builder-convert (GtkBuilderConverter._parse): diff --git a/gtk/gtkcellview.c b/gtk/gtkcellview.c index 08cd400a95..144feba00b 100644 --- a/gtk/gtkcellview.c +++ b/gtk/gtkcellview.c @@ -381,32 +381,15 @@ gtk_cell_view_size_allocate (GtkWidget *widget, else if (extra_space > 0 && expand_cell_count > 0) extra_space /= expand_cell_count; - /* iterate list for PACK_START cells */ for (i = cellview->priv->cell_list; i; i = i->next) { GtkCellViewCellInfo *info = (GtkCellViewCellInfo *)i->data; - if (info->pack == GTK_PACK_END) - continue; - if (!info->cell->visible) continue; - info->real_width = info->requested_width + (info->expand?extra_space:0); - } - - /* iterate list for PACK_END cells */ - for (i = cellview->priv->cell_list; i; i = i->next) - { - GtkCellViewCellInfo *info = (GtkCellViewCellInfo *)i->data; - - if (info->pack == GTK_PACK_START) - continue; - - if (!info->cell->visible) - continue; - - info->real_width = info->requested_width + (info->expand?extra_space:0); + info->real_width = info->requested_width + + (info->expand ? extra_space : 0); } }