Bug 399314 – Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach

2007-01-22  Chris Wilson <chris@chris-wilson.co.uk>

	Bug 399314 – Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach

	* gtk/gtkstyle.h:
		Cause gcc to issue a warning if the style returned from
		gtk_style_attach is not used. Failure to update
		widget->style causes some very difficult to identify bugs,
		eg Bug 353498 – crash in Terminal: changing icon theme.


svn path=/trunk/; revision=17199
This commit is contained in:
Chris Wilson 2007-01-22 15:19:53 +00:00 committed by Chris Wilson
parent a236fb7a26
commit c41296336a
2 changed files with 11 additions and 1 deletions

View File

@ -1,3 +1,13 @@
2007-01-22 Chris Wilson <chris@chris-wilson.co.uk>
Bug 399314 Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach
* gtk/gtkstyle.h:
Cause gcc to issue a warning if the style returned from
gtk_style_attach is not used. Failure to update
widget->style causes some very difficult to reproduce bugs,
eg Bug 353498 crash in Terminal: changing icon theme.
2007-01-19 Michael Emmel <mike.emmel@gmail.com>
* gdk/directfb/gdkevents-directfb.c: added fixes for window

View File

@ -427,7 +427,7 @@ GType gtk_style_get_type (void) G_GNUC_CONST;
GtkStyle* gtk_style_new (void);
GtkStyle* gtk_style_copy (GtkStyle *style);
GtkStyle* gtk_style_attach (GtkStyle *style,
GdkWindow *window);
GdkWindow *window) G_GNUC_WARN_UNUSED_RESULT;
void gtk_style_detach (GtkStyle *style);
#ifndef GTK_DISABLE_DEPRECATED