bnc355225 - File chooser crash in Tab completion

2008-06-03  Federico Mena Quintero  <federico@novell.com>

	* gtk/gtkfilechooserentry.c (install_completion_feedback_timer):
	If the user presses Tab while the completion feedback window is
	active, then we'll assert.  Remove the assertion and just re-set
	the timer.  Fixes https://bugzilla.novell.com/show_bug.cgi?id=355225

Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20305
This commit is contained in:
Federico Mena Quintero 2008-06-03 18:08:48 +00:00 committed by Federico Mena Quintero
parent 8ade45013c
commit cf62c83b0e
2 changed files with 9 additions and 1 deletions

View File

@ -1,3 +1,10 @@
2008-06-03 Federico Mena Quintero <federico@novell.com>
* gtk/gtkfilechooserentry.c (install_completion_feedback_timer):
If the user presses Tab while the completion feedback window is
active, then we'll assert. Remove the assertion and just re-set
the timer. Fixes https://bugzilla.novell.com/show_bug.cgi?id=355225
2008-06-03 Colin Walters <walters@redhat.com>
Bug 535303 add _get_implementation to GtkStatusIcon

View File

@ -939,7 +939,8 @@ completion_feedback_timeout_cb (gpointer data)
static void
install_completion_feedback_timer (GtkFileChooserEntry *chooser_entry)
{
g_assert (chooser_entry->completion_feedback_timeout_id == 0);
if (chooser_entry->completion_feedback_timeout_id != 0)
g_source_remove (chooser_entry->completion_feedback_timeout_id);
chooser_entry->completion_feedback_timeout_id = gdk_threads_add_timeout (COMPLETION_FEEDBACK_TIMEOUT_MS,
completion_feedback_timeout_cb,