AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-27 14:10:30 +00:00
Code Issues Projects Releases Wiki Activity

slicelistmodel: Fix two wrong computations

Browse Source 
Both of those are thinkos during math.
Found by Mohammed Sadiq.

Testcases triggering both have been added.
This commit is contained in:
Benjamin Otte 2020-02-14 03:13:49 +01:00
parent 97ec29d3f5
commit d303b5b0eb
2 changed files with 42 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk/gtkslicelistmodel.c
View File

@ -133,7 +133,7 @@ gtk_slice_list_model_items_changed_cb (GListModel *model,
if (position < self->offset)
{
guint skip = MIN (removed, added);
skip = MIN (skip, position - self->offset);
skip = MIN (skip, self->offset - position);
position += skip;
removed -= skip;
@ -149,7 +149,7 @@ gtk_slice_list_model_items_changed_cb (GListModel *model,
g_assert (position >= self->offset);
position -= self->offset;
changed = MIN (changed, self->size) - position;
changed = MIN (changed, self->size - position);
g_list_model_items_changed (G_LIST_MODEL (self), position, changed, changed);
}

40
testsuite/gtk/slicelistmodel.c
View File

@ -322,6 +322,44 @@ test_changes (void)
g_object_unref (slice);
}
static void
test_bug_added_equals_removed (void)
{
GtkSliceListModel *slice;
GListStore *store;
store = new_store (1, 10, 1);
slice = new_model (store, 0, 10);
assert_model (slice, "1 2 3 4 5 6 7 8 9 10");
assert_changes (slice, "");
splice (store, 9, 1, (guint[]) { 11 }, 1);
assert_model (slice, "1 2 3 4 5 6 7 8 9 11");
assert_changes (slice, "9-1+1");
g_object_unref (store);
g_object_unref (slice);
}
static void
test_bug_skip_amount (void)
{
GtkSliceListModel *slice;
GListStore *store;
store = new_store (1, 5, 1);
slice = new_model (store, 2, 2);
assert_model (slice, "3 4");
assert_changes (slice, "");
splice (store, 0, 5, (guint[]) { 11, 12, 13, 14, 15 }, 5);
assert_model (slice, "13 14");
assert_changes (slice, "0-2+2");
g_object_unref (store);
g_object_unref (slice);
}
int
main (int argc, char *argv[])
{
@ -338,6 +376,8 @@ main (int argc, char *argv[])
#if GLIB_CHECK_VERSION (2, 58, 0) /* g_list_store_splice() is broken before 2.58 */
g_test_add_func ("/slicelistmodel/changes", test_changes);
#endif
g_test_add_func ("/slicelistmodel/bug/added_equals_removed", test_bug_added_equals_removed);
g_test_add_func ("/slicelistmodel/bug/skip_amount", test_bug_skip_amount);
return g_test_run ();
}