AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-09-22 14:54:09 +00:00
Code Issues Projects Releases Wiki Activity

menu: Simplify function

Browse Source 
No need to do complicated math when we can just look at the allocation.
This commit is contained in:
Benjamin Otte 2019-04-25 01:27:58 +02:00 committed by Matthias Clasen
parent e702a33432
commit d971c4e69d
1 changed files with 11 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
gtk/gtkmenu.c
View File

@ -3521,30 +3521,19 @@ compute_child_offset (GtkMenu *menu,
gint *height)
{
GtkMenuPrivate *priv = menu->priv;
gint item_top_attach;
gint child_offset = 0;
gint i;
GtkAllocation allocation;
get_effective_child_attach (menu_item, &item_top_attach);
gtk_widget_get_allocation (menu_item, &allocation);
if (allocation.width > 0)
{
if (offset)
*offset = allocation.y + priv->scroll_offset;
if (height)
*height = allocation.height;
return TRUE;
}
/* there is a possibility that we get called before _size_request,
* so check the height table for safety.
*/
if (!priv->heights || priv->heights_length < gtk_menu_get_n_rows (menu))
return FALSE;
/* when we have a row with only invisible children, its height will
* be zero, so there's no need to check WIDGET_VISIBLE here
*/
for (i = 0; i < item_top_attach; i++)
child_offset += priv->heights[i];
if (offset)
*offset = child_offset;
if (height)
*height = priv->heights[item_top_attach];
return TRUE;
return FALSE;
}
static void