From da8994f941460206106255112ebe7dcd36b83065 Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Wed, 22 Aug 2018 19:48:20 +0200 Subject: [PATCH] Don't deprecate gtk_widget_show_all() After discussions on IRC, the conclusion was reached that deprecations only make sense if an action can be taken to not use the deprecated code that makes the code more current and simplifies a later port to a newer GTK version. In this particular case, the suitable action would be adding gtk_widget_show() calls whenever a widget is created, so that a call to show_all() is not necessary. However, in GTK4 these calls would not be necessary and end up just bloating the codebase unnecessarily. So it was decided the better solution would be to not deprecate the API and instead leave this work to be done during potential GTK4 ports of applications. This reverts commit 4d71d2303dafe1c02eb79040e32fe2172d1f295f. Fixes !1282 --- gtk/gtkwidget.c | 2 +- gtk/gtkwidget.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c index 56d47c96cd..ca0281cdd9 100644 --- a/gtk/gtkwidget.c +++ b/gtk/gtkwidget.c @@ -1260,7 +1260,7 @@ G_GNUC_END_IGNORE_DEPRECATIONS P_("No show all"), P_("Whether gtk_widget_show_all() should not affect this widget"), FALSE, - GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY|G_PARAM_DEPRECATED); + GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY); /** * GtkWidget:has-tooltip: diff --git a/gtk/gtkwidget.h b/gtk/gtkwidget.h index bc1575039b..04fd4ab414 100644 --- a/gtk/gtkwidget.h +++ b/gtk/gtkwidget.h @@ -628,12 +628,12 @@ GDK_AVAILABLE_IN_ALL void gtk_widget_hide (GtkWidget *widget); GDK_AVAILABLE_IN_ALL void gtk_widget_show_now (GtkWidget *widget); -GDK_DEPRECATED_IN_3_24 +GDK_AVAILABLE_IN_ALL void gtk_widget_show_all (GtkWidget *widget); -GDK_DEPRECATED_IN_3_24 +GDK_AVAILABLE_IN_ALL void gtk_widget_set_no_show_all (GtkWidget *widget, gboolean no_show_all); -GDK_DEPRECATED_IN_3_24 +GDK_AVAILABLE_IN_ALL gboolean gtk_widget_get_no_show_all (GtkWidget *widget); GDK_AVAILABLE_IN_ALL void gtk_widget_map (GtkWidget *widget);