AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-26 05:31:07 +00:00
Code Issues Projects Releases Wiki Activity

Use and print note for key only if there are credentials

Browse Source 
Otherwise key might be printed uninitialized.
This commit is contained in:
Christian Dywan 2010-10-08 16:01:07 +02:00
parent 3267cd08e9
commit e9a7a2104b
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/printbackends/cups/gtkprintbackendcups.c
View File

@ -707,7 +707,6 @@ gtk_print_backend_cups_set_password (GtkPrintBackend *backend,
GtkPrintBackendCups *cups_backend = GTK_PRINT_BACKEND_CUPS (backend); GtkPrintBackendCups *cups_backend = GTK_PRINT_BACKEND_CUPS (backend);
GList *l; GList *l;
char dispatch_hostname[HTTP_MAX_URI]; char dispatch_hostname[HTTP_MAX_URI];
gchar *key;
gchar *username = NULL; gchar *username = NULL;
gchar *hostname = NULL; gchar *hostname = NULL;
gchar *password = NULL; gchar *password = NULL;
@ -729,15 +728,15 @@ gtk_print_backend_cups_set_password (GtkPrintBackend *backend,
if (hostname != NULL && username != NULL && password != NULL) if (hostname != NULL && username != NULL && password != NULL)
{ {
key = g_strconcat (username, "@", hostname, NULL); gchar *key = g_strconcat (username, "@", hostname, NULL);
g_hash_table_insert (cups_backend->auth, key, g_strdup (password)); g_hash_table_insert (cups_backend->auth, key, g_strdup (password));
GTK_NOTE (PRINTING,
g_print ("CUPS backend: storing password for %s\n", key));
} }
g_free (cups_backend->username); g_free (cups_backend->username);
cups_backend->username = g_strdup (username); cups_backend->username = g_strdup (username);
GTK_NOTE (PRINTING,
g_print ("CUPS backend: storing password for %s\n", key));
for (l = cups_backend->requests; l; l = l->next) for (l = cups_backend->requests; l; l = l->next)
{ {