AuroraMiddleware/gtk
1
0
Fork 1
mirror of https://gitlab.gnome.org/GNOME/gtk.git synced 2024-12-26 21:51:08 +00:00
Code Issues Projects Releases Wiki Activity

cssshadowvalue: Handle error condition propertly

Browse Source 
We were parsing off the end of our array before noticing
that we've gone too far. gcc 11 warns about this.
This commit is contained in:
Matthias Clasen 2021-03-17 07:49:06 -04:00
parent ee837dfc12
commit ea185cbdda
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gtk/gtkcssshadowvalue.c
View File

@ -494,14 +494,14 @@ gtk_css_shadow_value_parse (GtkCssParser *parser,
return gtk_css_shadow_value_new_none ();
do {
if (n_shadows == MAX_SHADOWS)
{
gtk_css_parser_error_syntax (parser, "Not more than %d shadows supported", MAX_SHADOWS);
goto fail;
}
if (gtk_css_shadow_value_parse_one (parser, box_shadow_mode, &shadows[n_shadows]))
n_shadows++;
if (n_shadows > MAX_SHADOWS)
{
gtk_css_parser_error_syntax (parser, "Not more than 64 shadows supported");
goto fail;
}
} while (gtk_css_parser_try_token (parser, GTK_CSS_TOKEN_COMMA));
return gtk_css_shadow_value_new (shadows, n_shadows, FALSE);