Commit Graph

10794 Commits

Author SHA1 Message Date
Richard Hult
e7d1152a8e Implement those, fixes loading python bindings.
2008-08-07  Richard Hult  <richard@imendio.com>

	* gdk/quartz/gdkscreen-quartz.c: (gdk_screen_get_monitor_plug_name)
	(gdk_screen_get_monitor_height_mm, gdk_screen_get_monitor_width_mm):
	Implement those, fixes loading python bindings.

svn path=/trunk/; revision=21029
2008-08-07 08:14:12 +00:00
Emmanuele Bassi
66459b2502 Bug 545031 – list of recently used files is created world-readable
2008-08-07  Emmanuele Bassi  <ebassi@gnome.org>

	Bug 545031 – list of recently used files is created world-readable

	* gtk/gtkrecentmanager.c:
	(gtk_recent_manager_real_changed): Set the recently-used.xbel
	file to 0600. (Guido Berhoerster)

svn path=/trunk/; revision=21028
2008-08-07 00:54:01 +00:00
Michael Natterer
8fda215cc0 remove return value, this function returns void.
2008-08-06  Michael Natterer  <mitch@imendio.com>

	* modules/printbackends/cups/gtkcupsutils.c
	(gtk_cups_connection_test_free): remove return value, this
	function returns void.


svn path=/trunk/; revision=21022
2008-08-06 11:59:35 +00:00
Michael Natterer
3d75f27801 gtk/gtkcombobox.c gtk/gtkiconview.c gtk/gtkrange.c gtk/gtkscrolledwindow.c
2008-08-06  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcombobox.c
	* gtk/gtkiconview.c
	* gtk/gtkrange.c
	* gtk/gtkscrolledwindow.c
	* gtk/gtktreeview.c: remove CLAMPing from values passed to
	gtk_adjustment_set_value() since it does it right now.


svn path=/trunk/; revision=21021
2008-08-06 11:32:33 +00:00
Matthias Clasen
8fd301d7a4 Bump version
svn path=/trunk/; revision=21017
2008-08-05 18:27:06 +00:00
Matthias Clasen
c246a4e7b0 2.13.6
svn path=/trunk/; revision=21015
2008-08-05 18:20:35 +00:00
Michael Natterer
da61c61c4b bail out early if priv->button is NULL to avoid zillions of warnings when
2008-08-05  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcombobox.c (gtk_combo_box_update_sensitivity): bail out
	early if priv->button is NULL to avoid zillions of warnings when
	destroying combo boxes that were working fine before the
	button sensitivity patch.


svn path=/trunk/; revision=21014
2008-08-05 15:44:04 +00:00
Michael Natterer
f2527e8d07 Bug 544858 – Seal GtkAdjustment
2008-08-05  Michael Natterer  <mitch@imendio.com>

	Bug 544858 – Seal GtkAdjustment

	* gtk/gtk.symbols
	* gtk/gtkadjustment.[ch] (struct GtkAdjustment): seal all struct
	members.

	Add accessors for all properties and additionally a new function
	gtk_adjustment_configure() which sets all properties at
	once. Patch by Christian Dywan and myself.


svn path=/trunk/; revision=21013
2008-08-05 14:46:26 +00:00
Michael Natterer
0affd82480 clamp the value to [lower...upper-page_size] instead of only
2008-08-05  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkadjustment.c (gtk_adjustment_set_value): clamp the value
	to [lower...upper-page_size] instead of only [lower...upper].

	* README: add note about this change.

	While this fix is correct and should have been there forever, it
	has the potential to break some corner cases, however these cases
	would set page_size to a value != 0 which suggests they want it
	honored.


svn path=/trunk/; revision=21012
2008-08-05 14:25:29 +00:00
Michael Natterer
b1ad452d25 don't use the deprecated gtk_box_pack_start_defaults().
2008-08-05  Michael Natterer  <mitch@imendio.com>

	* tests/testiconview.c: don't use the deprecated
	gtk_box_pack_start_defaults().


svn path=/trunk/; revision=21010
2008-08-05 12:30:15 +00:00
Matthias Clasen
c455b5eac1 Add some missing braces
svn path=/trunk/; revision=21005
2008-08-05 00:21:49 +00:00
Tor Lillqvist
36a571570d Trivialities.
svn path=/trunk/; revision=21004
2008-08-05 00:17:42 +00:00
Tor Lillqvist
5b97a90502 Cast pointer to gintptr instead of gulong to avoid warning on Win64.
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/gtktext.c: Cast pointer to gintptr instead of gulong to
	avoid warning on Win64.


svn path=/trunk/; revision=21003
2008-08-04 23:55:40 +00:00
Tor Lillqvist
ffeb954aff Cast tile, stipple and clip_mask pointers to gintptr when calculating
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkgc.c: Cast tile, stipple and clip_mask pointers to
	gintptr when calculating hash, so we get all of the pointer bits
	on Win64 where long is 32 bits.


svn path=/trunk/; revision=21002
2008-08-04 23:51:16 +00:00
Tor Lillqvist
9be8382038 Don't need to declare IPrintDialogCallback with mingw64 either. It seems
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkprintoperation-win32.c: Don't need to declare
	IPrintDialogCallback with mingw64 either. It seems to come with
	newer versions of the headers.


svn path=/trunk/; revision=21001
2008-08-04 23:49:15 +00:00
Tor Lillqvist
a1e3946f58 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gtk/gtksocket-win32.c: Don't cast HWND to guint, pass it as such
	as the GdkNativeWindow parameter to
	gtk_window_remove_embedded_xid(). Debugging printout format fixes.

	* gtk/gtkwin32embed.h
	* gtk/gtkwin32embed.c: Change the types of wparam and lparam
	parameters to actually be WPARAM and LPARAM.

	* gtk/gtkplug-win32.c: Adapt accordingly.


svn path=/trunk/; revision=21000
2008-08-04 23:44:59 +00:00
Matthias Clasen
7d85757776 Bug 382291 – Automatically dim the combobox when the model is empty
2008-08-04  Matthias Clasen  <mclasen@redhat.com>

        Bug 382291 – Automatically dim the combobox when the model is empty

        * gtk/gtk.symbols:
        * gtkcombobox.[hc]: Add a GtkComboBox::button-sensitivity
        property with getter and setter to control the sensitity of
        empty combo boxes. Patch by Carlos Garnacho, Sven Herzberg,
        Christian Dywan and others.

        * README.in: Add a note about automatic combobox sensitivity.


svn path=/trunk/; revision=20997
2008-08-04 23:40:36 +00:00
Tor Lillqvist
b97d6816c8 Enclose ?: expression with parens so cast covers all of it.
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gtk/updateiconcache.c (write_bucket): Enclose ?: expression
	with parens so cast covers all of it.


svn path=/trunk/; revision=20996
2008-08-04 23:38:06 +00:00
Matthias Clasen
785b5f1b3f Improve a string
svn path=/trunk/; revision=20995
2008-08-04 23:36:17 +00:00
Tor Lillqvist
d6ab77ea70 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/win32/gdkcursor-win32.c
	* gdk/win32/xcursors.h: Change some gchar* to guchar* and vice
	versa to avoid gcc 4.4 signedness warnings.

	* gdk/win32/gdkevents-win32.c: Add some guchar and char pointer
	casts to get rid of gcc 4.4 signedness warnings. Print GdkAtom
	values in debugging output using the %p format.
	
	* gdk/win32/gdkkeys-win32.c
	* gdk/win32/gdkfont-win32.c
	* gdk/win32/gdkmain-win32.c: Add some casts to avoid gcc warnings.
 
	* gdk/win32/gdkwindow-win32.c: Use SetWindowLongPtr() instead of
	SetWindowLong().

	* gdk/win32/gdkwin32id.c (gdk_handle_hash): Use all 64 bits of a
	HANDLE on Win64.


svn path=/trunk/; revision=20994
2008-08-04 23:21:36 +00:00
Tor Lillqvist
a860ec7d7b Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/win32/gdkproperty-win32.c
	* gdk/win32/gdkselection-win32.c: Add some guchar and char pointer
	casts to get rid of gcc 4.4 warnings. Print GdkAtom values in
	debugging output using the %p format.


svn path=/trunk/; revision=20993
2008-08-04 23:01:32 +00:00
Tor Lillqvist
eff4be5c8d Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gtk/gtkwindow.h
	* gtk/gtkwindow.c: Change the type of the xid parameter of the
	internal gtk_window_remove_embedded_xid() and
	gtk_window_add_embedded_xid() functions from guint to
	GdkNativeWindow.

	* gtk/gtkwindow.c (send_client_message_to_embedded_windows):
	Instead of GPOINTER_TO_UINT(), just cast the gpointer to
	GdkNativeWindow. GPOINTER_TO_UINT() drops the upper 32 bits on
	Win64.


svn path=/trunk/; revision=20992
2008-08-04 22:57:36 +00:00
Tor Lillqvist
f4d9ce22f4 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/gdkselection.h
	* gdk/gdkselection.c
	* gdk/win32/gdkselection-win32.c
	* gdk/x11/gdkselection-x11.c: Change type of the requestor
	window id parameter of gdk_selection_send_notify_for_display()
	and gdk_selection_send_notify() from guint32 to
	GdkNativeWindow.

	* gdk/win32/gdkselection-win32.c: Add some guchar and char pointer
	casts to get rid of gcc 4.4 warnings. Print GdkAtom values in
	debugging output using the %p format.


svn path=/trunk/; revision=20991
2008-08-04 22:43:57 +00:00
Matthias Clasen
7919814bf6 Fix make check
svn path=/trunk/; revision=20990
2008-08-04 22:38:56 +00:00
Tor Lillqvist
62b41df929 Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-05  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* gdk/gdkdnd.h
	* gdk/gdkdnd.c
	* gdk/win32/gdkdnd-win32.c
	* gdk/x11/gdkdnd-x11.c: Change return value and type of window id
	from guint32 to GdkNativeWindow for
	gdk_drag_get_protocol_for_display() and
	gdk_drag_get_protocol(). This is not an API break on existing
	platforms, as GdkNativeWindow has been guint32 for them
	already.


svn path=/trunk/; revision=20989
2008-08-04 22:36:53 +00:00
Tor Lillqvist
ad2ea92f75 Cast pointers to guintptr, not unsigned long, before doing bit tests on
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* gdk/gdkrgb.c: Cast pointers to guintptr, not unsigned long,
	before doing bit tests on them.


svn path=/trunk/; revision=20987
2008-08-04 22:26:26 +00:00
Tor Lillqvist
6a5f3cc9d9 Define GDK_NATIVE_WINDOW_POINTER on 32-bit Windows, too. It just makes
2008-08-05  Tor Lillqvist  <tml@novell.com>

	* configure.in: Define GDK_NATIVE_WINDOW_POINTER on 32-bit
	Windows, too. It just makes more sense, as a HWND *is* a kind of
	pointer.

	* gdk/gdkconfig.h.win32: Ditto here.


svn path=/trunk/; revision=20986
2008-08-04 22:20:53 +00:00
Björn Lindqvist
67a8a3a265 Bug 534979 – GtkImageMenuItem is a bin but has two children.
2008-08-04  Björn Lindqvist  <bjourne@gmail.com>

	Bug 534979 – GtkImageMenuItem is a bin but has two children.

	* gtk/gtkimagemenuitem.c (gtk_image_menu_item_forall): Do not
	include the image widget when iterating over non-internal
	children. Patch by rainwoodman.

svn path=/trunk/; revision=20985
2008-08-04 21:37:02 +00:00
Matthias Clasen
361a787cfd Updates
svn path=/trunk/; revision=20984
2008-08-04 18:41:28 +00:00
Matthias Clasen
f9504c1402 Bump glib dependency
svn path=/trunk/; revision=20983
2008-08-04 18:24:14 +00:00
Michael Natterer
0ac989bdcc gtk/gtkclist.c gtk/gtkctree.c gtk/gtkpixmap.c get rid of using deprecated
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.c
	* gtk/gtkctree.c
	* gtk/gtkpixmap.c
	* gtk/gtkpreview.c: get rid of using deprecated GDK APIs.

	* gtk/gtktext.c: ditto, apart from the text cruft APIs.


svn path=/trunk/; revision=20982
2008-08-04 17:59:43 +00:00
Michael Natterer
7261e61f29 call gdk_rgb_set_verbose(TRUE) if "gdkrgb" is in the debug flags.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gdk/gdk.c (gdk_parse_args): call gdk_rgb_set_verbose(TRUE) if
	"gdkrgb" is in the debug flags.

	* gdk/gdkrgb.c (gdk_rgb_init): remove setting the verbose flag
	here, this function is deprecated and the debug flag didn't work
	when using GDK properly.


svn path=/trunk/; revision=20981
2008-08-04 17:17:46 +00:00
Matthias Clasen
25536fafd0 Update to handle GEmblem`
svn path=/trunk/; revision=20980
2008-08-04 16:36:28 +00:00
Michael Natterer
45ac6c4fc1 undeprecate (apart from still using GtkOptionMenu).
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* tests/prop-editor.c: undeprecate (apart from still using
	GtkOptionMenu).


svn path=/trunk/; revision=20979
2008-08-04 16:33:28 +00:00
Michael Natterer
a3a5bc340d gtk/gtkseparatortoolitem.c remove pointless #undef GTK_DISABLE_DEPRECATED.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkseparatortoolitem.c
	* tests/testactions.c: remove pointless #undef GTK_DISABLE_DEPRECATED.

	* gtk/gtkcalendar.c (calendar_set_display_option): use
	gtk_calendar_set_display_options() instead of the deprecated
	gtk_calendar_display_options().


svn path=/trunk/; revision=20977
2008-08-04 16:12:23 +00:00
Carlos Garnacho
65a53ff251 Fix "/* within comment" warning.
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkfilechooserbutton.c: Fix "/* within comment" warning.

svn path=/trunk/; revision=20975
2008-08-04 15:17:27 +00:00
Carlos Garnacho
e9be9eb190 Set drag window background to be the GtkNotebook background color. This is
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtknotebook.c (gtk_notebook_expose): Set drag window background
        to be the GtkNotebook background color. This is a workaround to
        prevent black pixels in rounded tabs when reordering. Improves
        #368234.

svn path=/trunk/; revision=20973
2008-08-04 14:46:22 +00:00
Carlos Garnacho
7e439efc92 Deprecate gtk_file_chooser_*_new_with_backend(), since GIO is already used
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtk.symbols:
        * gtk/gtkfilechooserbutton.[ch]:
        * gtk/gtkfilechooserdefault.[ch]:
        * gtk/gtkfilechooserdialog.[ch]:
        * gtk/gtkfilechooserwidget.[ch]: Deprecate
        gtk_file_chooser_*_new_with_backend(), since GIO is already used
        directly. Fixes #545976.

svn path=/trunk/; revision=20972
2008-08-04 14:43:53 +00:00
Carlos Garnacho
02c65db5c0 Make GFile-oriented API public. Fixes #545978.
2008-08-04  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtk.symbols:
        * gtk/gtkfilechooser.[ch]: Make GFile-oriented API public. Fixes
        #545978.
        * gtk/gtkfilechooserbutton.c:
        * gtk/gtkfilechooserdefault.c:
        * gtk/gtkfilechooserutils.c: Update to use public GFile API.

svn path=/trunk/; revision=20971
2008-08-04 14:43:05 +00:00
Michael Natterer
aa435e024a build with GTK_DISABLE_DEPRECATED again.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/Makefile.am: build with GTK_DISABLE_DEPRECATED again.

	Fix pltcheck.sh by restricting the visibility of deprecated
	symbols to the places where they are actually used:

	* gtk/gtkclist.c
	* gtk/gtkctree.c
	* gtk/gtklistitem.c
	* gtk/gtklist.c
	* gtk/gtkprogressbar.c
	* gtk/gtkpixmap.c
	* gtk/gtkprogress.c: #undef GTK_DISABLE_DEPRECATED and #define
	__GTK_FOO_C__ on top instead of before including gtkaliasdef.c.

	* gtk/gtkclist.h
	* gtk/gtkctree.h
	* gtk/gtklistitem.h
	* gtk/gtklist.h
	* gtk/gtkpixmap.h
	* gtk/gtkprogress.h: make the headers visible if the respective
	__GTK_FOO_C__ are defined.


svn path=/trunk/; revision=20970
2008-08-04 14:38:35 +00:00
Michael Natterer
dbd5b75e5e gtk/gtkclist.c gtk/gtklist.c gtk/gtkoldeditable.c gtk/gtkpixmap.c
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.c
	* gtk/gtklist.c
	* gtk/gtkoldeditable.c
	* gtk/gtkpixmap.c
	* gtk/gtktipsquery.c
	* gtk/gtktree.c
	* gtk/gtktreeitem.c: avoid using deprecated GtkWidget API.


svn path=/trunk/; revision=20969
2008-08-04 14:23:55 +00:00
Michael Natterer
906db67f37 gtk/gtkclist.[ch] gtk/gtkctree.[ch] gtk/gtkitemfactory.[ch]
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.[ch]
	* gtk/gtkctree.[ch]
	* gtk/gtkitemfactory.[ch]
	* gtk/gtkobject.[ch]
	* gtk/gtksignal.[ch]: s/GtkDestroyNotify/GDestroyNotify/g


svn path=/trunk/; revision=20967
2008-08-04 14:13:56 +00:00
Sven Neumann
cd8bca1c64 update the link color when the "visited" state is changed.
2008-08-04  Sven Neumann  <sven@gimp.org>

	* gtk/gtklinkbutton.c (gtk_link_button_set_uri): update the link
	color when the "visited" state is changed.


svn path=/trunk/; revision=20966
2008-08-04 14:13:12 +00:00
Michael Natterer
d132b616e2 move the code of the deprecated gtk_window_set_policy() to a new private
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkwindow.c: move the code of the deprecated
	gtk_window_set_policy() to a new private function
	gtk_window_set_policy_internal() and call it from
	gtk_window_set_policy().

	(gtk_window_set_resizable): use the new internal function in order
	to avoid our own deprecated public API.


svn path=/trunk/; revision=20965
2008-08-04 13:52:56 +00:00
Michael Natterer
888c3a72b5 move the code of the deprecated gtk_binding_entry_clear() to a new private
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbindings.c: move the code of the deprecated
	gtk_binding_entry_clear() to a new private function
	gtk_binding_entry_clear_internal() and call it from
	gtk_binding_entry_clear().

	(_gtk_binding_entry_add_signall)
	(gtk_binding_parse_bind): use the new internal function in order
	to avoid our own deprecated public API.


svn path=/trunk/; revision=20963
2008-08-04 11:08:33 +00:00
Michael Natterer
5a3691352d avoid our own deprecated public API and use
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfontsel.c (gtk_font_selection_dialog_get_font):
	avoid our own deprecated public API and use
	gtk_font_selection_get_font_internal() instead of
	gtk_font_selection_get_font().

	(gtk_font_selection_get_font)
	(gtk_font_selection_dialog_get_font): Add missing
	"Deprecated: 2.0" to the api doc comments.


svn path=/trunk/; revision=20962
2008-08-04 10:33:02 +00:00
Michael Natterer
154f0f56de add the generated PNGs to CLEANFILES.
2008-08-04  Michael Natterer  <mitch@imendio.com>

	* gdk/tests/Makefile.am: add the generated PNGs to CLEANFILES.


svn path=/trunk/; revision=20961
2008-08-04 10:20:16 +00:00
Tor Lillqvist
1934bff891 Small improvement.
svn path=/trunk/; revision=20960
2008-08-04 09:05:51 +00:00
Tor Lillqvist
71d9f3d45b Set LIB_EXE_MACHINE_FLAG to either X86 or X64 on Windows. AC_SUBST it.
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* configure.in: Set LIB_EXE_MACHINE_FLAG to either X86 or X64 on
	Windows. AC_SUBST it.

	* gdk/Makefile.am
	* gtk/Makefile.am: Pass appropriate -machine flag to lib.exe.


svn path=/trunk/; revision=20957
2008-08-03 23:47:10 +00:00
Tor Lillqvist
963ee0de5e Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
2008-08-04  Tor Lillqvist  <tml@novell.com>

	Bug 544684 - Win64 issue, window handles are assumed to be 32-bit

	* configure.in: On Win64, define GDK_NATIVE_WINDOW_POINTER.

	* gdk/gdkconfig.h.win32: Ditto here.


svn path=/trunk/; revision=20956
2008-08-03 23:36:17 +00:00
Tor Lillqvist
6ecaa61a1c Fix typo in Win32 and Quartz code:
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkstatusicon.c: Fix typo in Win32 and Quartz code:
	s/gtk_icon_icon_info_load_icon/gtk_icon_info_load_icon/ .


svn path=/trunk/; revision=20955
2008-08-03 23:16:31 +00:00
Tor Lillqvist
72f0a30431 Don't bother with the test "if gio can sniff png" if $gio_can_sniff has
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* configure.in: Don't bother with the test "if gio can sniff png"
	if $gio_can_sniff has been already set. Preset it to "no" for
	Win32. This helps cross-compilation from 32-bit Windows to
	64-bit. No idea how this should be handled for cross-compilation
	in general.


svn path=/trunk/; revision=20954
2008-08-03 23:09:28 +00:00
Tor Lillqvist
34159c417b Don't bother looking up EnumDisplayMonitors and GetMonitorInfoA
2008-08-04  Tor Lillqvist  <tml@novell.com>

	* gdk/win32/gdkdisplay-win32.c: Don't bother looking up
	EnumDisplayMonitors and GetMonitorInfoA dynamically, they are
	present in NT-based Windows since Windows 2000.
	(enum_monitor): For some reason the MONITORINFOEX struct in
	mingw-win64 is different than the proper one as in MSDN and 32-bit
	mingw, so just copy the proper definition here.


svn path=/trunk/; revision=20953
2008-08-03 23:05:37 +00:00
Björn Lindqvist
8303b4437e Bug 540379 – gtk_tree_view_enable_model_drag_dest and
2008-08-03  Björn Lindqvist  <bjourne@gmail.com>

	Bug 540379 – gtk_tree_view_enable_model_drag_dest and
	gtk_tree_view_enable_model_drag_source unsets reorderable property

	* gtk/gtktreeview.c: Improve docstrings regarding reorderable
	property.

svn path=/trunk/; revision=20952
2008-08-03 19:38:21 +00:00
Matthias Clasen
a8700de468 Support GEmblemedIcon
svn path=/trunk/; revision=20951
2008-08-03 19:28:05 +00:00
Matthias Clasen
ca66090cd5 Add translator comment
svn path=/trunk/; revision=20950
2008-08-03 19:25:00 +00:00
Tor Lillqvist
4998d8c469 Bug 538686 - gtkprintoperation-win32.c: devmode_from_settings
2008-08-02  Tor Lillqvist  <tml@novell.com>

	Bug 538686 - gtkprintoperation-win32.c: devmode_from_settings

	* gtk/gtkprintoperation-win32.c (devmode_from_settings): Plug
	potential leak. Thanks to Morten Welinder.


svn path=/trunk/; revision=20944
2008-08-02 11:29:31 +00:00
Tor Lillqvist
c364ffa340 gtk/gtkprint-win32.c gtk/gtkprint-win32.h Cosmetic fixups after patch
2008-08-02  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkprint-win32.c
	* gtk/gtkprint-win32.h
	* gtk/gtkprintoperation-win32.c: Cosmetic fixups after patch
	below.


svn path=/trunk/; revision=20943
2008-08-02 09:31:01 +00:00
Tor Lillqvist
8ce17cf990 Bug 339699 - implement gtk_print_operation_set_show_dialog for Windows
2008-08-02  Tor Lillqvist  <tml@novell.com>

	Bug 339699 - implement gtk_print_operation_set_show_dialog for
	Windows
	
	* gtk/gtkprint-win32.c
	* gtk/gtkprint-win32.h
	* gtk/gtkprintoperation-win32.c: Patch by ecyrbe@gmail.com.


svn path=/trunk/; revision=20942
2008-08-02 09:27:47 +00:00
Matthias Clasen
d2fc1c7ee0 Add GIcon support to GtkStatusIcon
svn path=/trunk/; revision=20940
2008-08-02 05:07:02 +00:00
Matthias Clasen
5b980c221a Bug 429427 – Add "arrow-spacing" style property to GtkRange
2008-08-02  Matthias Clasen  <mclasen@redhat.com>

        Bug 429427 – Add "arrow-spacing" style property to GtkRange

        * gtk/gtkrange.c: Add an arrow-spacing style property.
        Patch by Carlos Garnacho and Christian Dywan


svn path=/trunk/; revision=20939
2008-08-02 04:52:54 +00:00
Matthias Clasen
7d88f59fad Bug 429411 – add style properties to set minimum progressbar
2008-08-02  Matthias Clasen  <mclasen@redhat.com>

        Bug 429411 – add style properties to set minimum progressbar
        width/height

        * gtk/gtkprogressbar.c: Add style properties for minimum size.
        Patch by Carlos Garnacho and Christian Dywan


svn path=/trunk/; revision=20938
2008-08-02 04:48:47 +00:00
Matthias Clasen
4080d5c3af log entry
svn path=/trunk/; revision=20937
2008-08-02 04:46:13 +00:00
Matthias Clasen
ef8144bd71 Add an example to the docs
svn path=/trunk/; revision=20935
2008-08-02 04:42:36 +00:00
Matthias Clasen
0b66b244a4 Bug 539733 – No way to control treeview separator height
svn path=/trunk/; revision=20932
2008-08-02 04:32:12 +00:00
Matthias Clasen
5478721aba Bug 65818 – rename gtk_window_set_default() and add getter for it
svn path=/trunk/; revision=20931
2008-08-02 04:29:47 +00:00
Matthias Clasen
c5121d272b Use po/LINGUAS
svn path=/trunk/; revision=20930
2008-08-02 04:23:13 +00:00
Matthias Clasen
ed383758c6 Improve docs
svn path=/trunk/; revision=20929
2008-08-02 04:12:55 +00:00
Claudio Saavedra
6a6e72dea2 Bug 545931 – small documentation typos
2008-08-01  Claudio Saavedra  <csaavedra@igalia.com>

	Bug 545931 – small documentation typos

	* gtk/gtkcomboboxentry.c: Fix some typos in the documentation.


svn path=/trunk/; revision=20927
2008-08-02 01:25:20 +00:00
Hans Breuer
491999783b build gdkwindowimpl
2008-08-01  Hans Breuer  <hans@breuer.org>

	* gdk/makefile.msc : build gdkwindowimpl

	* gtk/gtkwidget.c : fix c99ism - declaration needs to be at the
	start of a block

	* tests/makefile.msc : update


svn path=/trunk/; revision=20926
2008-08-01 14:43:22 +00:00
Cody Russell
4e3c97b3f2 Bug 56070 – Can't click button after setting it sensitive.
2008-07-31  Cody Russell  <bratsche@gnome.org>

        Bug 56070 – Can't click button after setting it sensitive.

        * gtk/gtkwidget.[ch] 
        * gtk/gtkwindow.c
        * gtk/gtkmain.c
        * gtk/gtkbutton.c
        * gtk/gtkprivate.h
        * gdk/gdkevents.h: Synthesize crossing events events where necessary.

        * gtk/tests/crossingevents.c: Add unit tests for crossing events.

        Big thanks to Ed Catmur, Matthias Clasen, and everyone else who
        has worked on and helped out with this.


svn path=/trunk/; revision=20924
2008-08-01 03:30:50 +00:00
Matthias Clasen
e9d978dff9 Bug 424207 – printing hangs on unreachable cups server
svn path=/trunk/; revision=20923
2008-07-31 23:56:17 +00:00
Matthias Clasen
c04c884f35 Use a second-granularity timer.
svn path=/trunk/; revision=20922
2008-07-31 22:27:02 +00:00
Matthias Clasen
29fc592dad Use g_timeout_add_seconds
svn path=/trunk/; revision=20921
2008-07-31 22:19:07 +00:00
Matthias Clasen
75651f652e Add gdk_threads_add_timeout_seconds{_full}
svn path=/trunk/; revision=20919
2008-07-31 22:11:44 +00:00
Tor Lillqvist
29b6e6587a Fix problems in handling custom paper sizes. The DEVMODE::dmPaperWidth and
2008-07-30  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkprintoperation-win32.c: Fix problems in handling custom
	paper sizes. The DEVMODE::dmPaperWidth and dmPaperLength are in
	tenths of a millimeter, and the RECT passed to CreateEnhMetaFile()
	is in hundredths of a millimeter. Patch by Sven Neumann.


svn path=/trunk/; revision=20916
2008-07-30 09:52:42 +00:00
Matthias Clasen
43d0b7792a Small doc improvement
svn path=/trunk/; revision=20912
2008-07-28 23:29:38 +00:00
Matthias Clasen
34dc548878 Support rendering GEmblemedIcon
svn path=/trunk/; revision=20910
2008-07-28 16:15:14 +00:00
Sven Herzberg
0db654a743 Bug 544863 – gtkquartz.h not included in released 2.13.5 package
2008-07-27  Sven Herzberg  <sven@imendio.com>

	Bug 544863 – gtkquartz.h not included in released 2.13.5 package

	* gtk/Makefile.am: explicitly include the moved header in EXTRA_DIST


svn path=/trunk/; revision=20908
2008-07-26 23:58:34 +00:00
Murray Cumming
72bf940716 Documented the activate and popup-menu signals as being for use by
2008-07-25  Murray Cumming  <murrayc@murrayc.com>

* gtk/gtkstatusicon.c (gtk_status_icon_class_init):
Documented the activate and popup-menu signals as being for use 
by applications and language bindings, though they are G_SIGNAL_ACTION, 
as stated in bug #361561.

svn path=/trunk/; revision=20905
2008-07-25 15:42:41 +00:00
Sebastien Bacher
862fde72de don't try free gettext() values,
fix a printing dialog crasher (bug 544390)

svn path=/trunk/; revision=20904
2008-07-24 12:56:59 +00:00
Cody Russell
c8061385a9 Bug 544510 – SetTimer callback signatures has the wrong type
2008-07-24  Cody Russell  <bratsche@gnome.org>

        Bug 544510 – SetTimer callback signatures has the wrong type

        * gdk/win32/gdkevents-win32.c: Fix modal_timer_proc() and
        sync_timer_proc() to use UINT_PTR for the 'id' parameter
        instead of 'id'.  Patch by Richard Hult.


svn path=/trunk/; revision=20903
2008-07-24 12:55:53 +00:00
Matthias Clasen
7e39f9285a Add translator hints
svn path=/trunk/; revision=20902
2008-07-24 04:02:37 +00:00
Matthias Clasen
4c7d351053 Bug 544265 – GDK assumes XFIXES extension
2008-07-23  Matthias Clasen  <mclasen@redhat.com>

        Bug 544265 – GDK assumes XFIXES extension

        * gdk/x11/gdkcursor-x11.c (_gdk_x11_cursor_update_theme):
        Only call XFixes functions if the server has the extension.
        Reported by Ian Turner.

svn path=/trunk/; revision=20901
2008-07-24 03:38:08 +00:00
Tor Lillqvist
cd15d3e109 Clarification.
svn path=/trunk/; revision=20898
2008-07-23 09:09:34 +00:00
Matthias Clasen
830a9d2710 More correct content type handling
svn path=/trunk/; revision=20897
2008-07-23 04:20:15 +00:00
Sven Herzberg
7551360c1e Fix svn:ignore and the include condition
2008-07-22  Sven Herzberg  <sven@imendio.com>

	Fix svn:ignore and the include condition

	* gdk/tests/check-gdk-cairo.c: ifndef => ifdef


svn path=/trunk/; revision=20896
2008-07-22 21:21:53 +00:00
Tor Lillqvist
c9d31fc022 Workaround for what apparently is a bug in MSYS: returning -1 from main()
2008-07-22  Tor Lillqvist  <tml@novell.com>

	* configure.in: Workaround for what apparently is a bug in MSYS:
	returning -1 from main() is misinterpreted as exit status 0, so
	make sure we return 0 or 1.


svn path=/trunk/; revision=20895
2008-07-22 20:14:01 +00:00
Sven Herzberg
ef3e772fbb Add a test for my fixes from July 20th.
2008-07-22  Sven Herzberg  <sven@imendio.com>

	Add a test for my fixes from July 20th.

	* configure.in: create gdk/tests/Makefile
	* gdk/Makefile.am: include the tests subfolder
	* gdk/tests/Makefile.am: create and run my test
	* gdk/tests/check-gdk-cairo.c (test), (main): the test that I wrote
	(passes at least for x11 and quartz backends)


svn path=/trunk/; revision=20894
2008-07-22 18:50:54 +00:00
Frederic Crozat
db7915ec51 Don't use RandR 1.2 if driver is detected as randr12_compat (ie X driver
2008-07-22  Frederic Crozat  <fcrozat@mandriva.com>

        * gdk/x11/gdkscreen-x11.c: Don't use RandR 1.2
        if driver is detected as randr12_compat (ie X driver
        is not RandR 1.2 compliant). Fixes multihead with
        such drivers. Bug #543317.


svn path=/trunk/; revision=20893
2008-07-22 17:41:39 +00:00
Matthias Clasen
ea0399b234 Default to linking against Xinerama again, so that we can fallback to
* configure.in: Default to linking against Xinerama again,
        so that we can fallback to Xinerama when broken X drivers
        make Xrandr useless. Sigh.

svn path=/trunk/; revision=20891
2008-07-22 15:07:14 +00:00
Matthias Clasen
b8ee465c3b Bump version
svn path=/trunk/; revision=20890
2008-07-22 00:44:04 +00:00
Matthias Clasen
c3e0a4ea74 2.13.5
svn path=/trunk/; revision=20888
2008-07-22 00:39:10 +00:00
Matthias Clasen
94ba6bba06 Doc fixes
svn path=/trunk/; revision=20887
2008-07-21 23:23:41 +00:00
Michael Natterer
8a1bdcbe4a use gtk_box_pack_start() instead of the deprecated
2008-07-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbox.c (gtk_box_add): use gtk_box_pack_start() instead of
	the deprecated gtk_box_pack_start_defaults().

	* gtk/gtkbindings.c (gtk_binding_entry_add_signal)
	(gtk_binding_parse_signal): use _gtk_binding_entry_add_signall()
	instead of the deprecated gtk_binding_entry_add_signall().


svn path=/trunk/; revision=20885
2008-07-21 14:35:51 +00:00
Emmanuele Bassi
1db0192042 Use GSlice to allocate the application data for recently used resources;
2008-07-21  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c:
	(recent_app_info_new), (recent_app_info_free): Use GSlice to
	allocate the application data for recently used resources;
	do not call time() to initialize the timestamp, as it will
	be overwritten anyway later. (#535223, Michael Meeks)

svn path=/trunk/; revision=20884
2008-07-21 13:37:15 +00:00
Kristian Rietveld
fd4a8411f0 Bug 543989 - Crash in gtk_tree_view_size_allocate_columns
2008-07-21  Kristian Rietveld  <kris@gtk.org>

	Bug 543989 - Crash in gtk_tree_view_size_allocate_columns

	* gtk/gtktreeview.c (gtk_tree_view_size_allocate_columns): check
	for width_changed != NULL.  (Patch by Josselin Mouette).


svn path=/trunk/; revision=20883
2008-07-21 13:32:05 +00:00
Michael Natterer
b8a2347c45 Bug 442042 – GtkScaleButton is too limited
2008-07-21  Michael Natterer  <mitch@imendio.com>

	Bug 442042 – GtkScaleButton is too limited

	* tests/testvolumebutton.c: forgot to commit code that tests
	toggling the button's orientation. Also fixes the file's coding
	style.


svn path=/trunk/; revision=20882
2008-07-21 12:58:36 +00:00
Cody Russell
c8fef535b2 Bug 153567 – Repaint glitches in widgets
2008-07-21  Cody Russell  <bratsche@gnome.org>

        Bug 153567 – Repaint glitches in widgets

        * gdk/win32/gdkevents-win32.c: Set a sync timer when
        we receive WM_SYNCPAINT, and RedrawWindow() once
        the timer expires.


svn path=/trunk/; revision=20881
2008-07-21 12:46:41 +00:00
Michael Natterer
b06c30bb51 use the simpler g_signal_override_class_handler() instead of
2008-07-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktoolbar.c (gtk_toolbar_class_init): use the simpler
	g_signal_override_class_handler() instead of
	g_signal_override_class_closure().

	* gtk/gtktextview.c (gtk_text_view_class_init): ditto.

	(gtk_text_view_compat_move_focus): chain up using
	g_signal_chain_from_overridden_handler() instead of the generic
	g_signal_chain_from_overridden() which needs manual fiddling with
	millions of GValues.


svn path=/trunk/; revision=20880
2008-07-21 12:27:30 +00:00
Michael Natterer
affea672d2 remove redundant include.
2008-07-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkuimanager.c: remove redundant include.


svn path=/trunk/; revision=20878
2008-07-21 12:23:22 +00:00
Michael Natterer
7f00695920 remove _gtk_binding_signal_new().
2008-07-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbindings.[ch]: remove _gtk_binding_signal_new().

	* gtk/gtkfilechooserdefault.c
	* gtk/gtkmenu.c
	* gtk/gtkmenushell.c
	* gtk/gtkscalebutton.c
	* gtk/gtktextview.c
	* gtk/gtktoolbar.c
	* gtk/gtkwidget.c: use g_signal_new_class_handler() instead. Add
	some missing I_() to the signal names.


svn path=/trunk/; revision=20874
2008-07-21 09:48:20 +00:00
Michael Natterer
c6bb5b4882 remove g_return_if_fail() from private functions and virtual function
2008-07-21  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkspinbutton.c: remove g_return_if_fail() from private
	functions and virtual function implementations. Some minor
	cleanups.


svn path=/trunk/; revision=20873
2008-07-21 09:41:28 +00:00
Andre Klapper
4346194869 Bug 543915 - translation issues
2008-07-20  Andre Klapper  <a9016009@gmx.de>

	Bug 543915 - translation issues

	* modules/printbackends/cups/gtkprintbackendcups.c:
	Add translator comments for several strings.


svn path=/trunk/; revision=20872
2008-07-20 22:03:32 +00:00
Sven Herzberg
bd86f2e8fb reviewed by: Richard Hult
2008-07-20  Sven Herzberg  <sven@imendio.com>

	reviewed by: Richard Hult

	Fixes #543868: GdkPixmap is upside down on quartz

	* gdk/quartz/gdkdrawable-quartz.c (gdk_quartz_draw_drawable): flip the
	coordinate space from GTK+ orientation to CoreGraphics orientation
	before calling CoreGraphics code
	* gdk/quartz/gdkgc-quartz.c (gdk_quartz_draw_tiled_pattern): drop the
	coordinate space flipping (we always get it right, now)
	* gdk/quartz/gdkpixmap-quartz.c
	(gdk_pixmap_impl_quartz_get_context): flip the coordinate space when
	creating the CGContextRef


svn path=/trunk/; revision=20870
2008-07-20 19:22:37 +00:00
Sven Herzberg
61ca4f71a0 reviewed by: Richard Hult
2008-07-20  Sven Herzberg  <sven@imendio.com>

	reviewed by: Richard Hult

	Extracted the CGContextRef creation into a virtual function of
	GdkDrawableImplQuartz; implement get_context() for GdkPixmap and
	GdkWindow

	* gdk/quartz/gdkdrawable-quartz.c
	(gdk_quartz_drawable_get_context): dropped the different
	implementations; forward to the virtual function now
	* gdk/quartz/gdkdrawable-quartz.h: added the virtual function
	* gdk/quartz/gdkpixmap-quartz.c
	(gdk_pixmap_impl_quartz_get_context),
	(gdk_pixmap_impl_quartz_class_init): implemented get_context()
	* gdk/quartz/gdkwindow-quartz.c
	(gdk_window_impl_quartz_get_context),
	(gdk_window_impl_quartz_class_init): implemented get_context()


svn path=/trunk/; revision=20869
2008-07-20 16:14:35 +00:00
Matthias Clasen
ab128c454e Updates
svn path=/trunk/; revision=20866
2008-07-19 22:57:02 +00:00
Federico Mena Quintero
5bd03f2b44 Remove the old icon cache if regenerating it would cause it to be empty
Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20865
2008-07-18 19:28:13 +00:00
Matthias Clasen
46047f173e Fix a crash
svn path=/trunk/; revision=20864
2008-07-18 19:07:39 +00:00
Matthias Clasen
71e134617c Avoid a crash
svn path=/trunk/; revision=20863
2008-07-18 19:03:54 +00:00
Federico Mena Quintero
0278fdcbc2 Don't do funny casts to avoid compiler warnings
2008-07-18  Federico Mena Quintero  <federico@novell.com>

	* demos/gtk-demo/changedisplay.c (find_toplevel_at_pointer): Don't
	do funny casts to avoid compiler warnings.

	* demos/gtk-demo/textview.c (easter_egg_callback): Likewise.

	* gtk/gtkmain.c (rewrite_event_for_grabs, gtk_get_event_widget): Likewise.

	* gtk/gtkmodules.c (load_module): Likewise.

	* gtk/gtkselection.c (gtk_selection_convert): Likewise.

	* gtk/gtktipsquery.c (gtk_tips_query_event): Likewise.

	* gtk/queryimmodules.c (query_module): Likewise.

	* tests/testgtk.c (create_gridded_geometry, create_key_lookup)
	(find_widget_at_pointer): Likewise.

Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20862
2008-07-18 18:27:30 +00:00
Matthias Clasen
cf68d46c64 Add a forgotten hunk
svn path=/trunk/; revision=20861
2008-07-18 15:51:06 +00:00
Sven Herzberg
938bebdd88 Make aliasfilecheck.sh pass for the quartz backend, too.
2008-07-18  Sven Herzberg  <sven@imendio.com>

	Make aliasfilecheck.sh pass for the quartz backend, too.

	* gtk/Makefile.am: don't include gtkquartz.h in the list of c files


svn path=/trunk/; revision=20860
2008-07-18 15:49:14 +00:00
Runa Bhattacharjee
6023e1b7fc Added Entry for addition of Pashto (ps) to ALL_LINGUAS in configure.in
svn path=/trunk/; revision=20854
2008-07-17 05:56:22 +00:00
Paolo Borelli
6ee8be8899 Bug 447998 - GtkBuilder does not support building parts of the xml tree
2008-07-15  Paolo Borelli  <pborelli@katamail.com>

	Bug 447998 - GtkBuilder does not support building parts of the xml tree

	* gtk/gtkbuilder.c:
	* gtk/gtkbuilder.h:
	* gtk/gtkbuilderprivate.h:
	* gtk/gtkbuilderparser.c:
	* gtk/gtk.symbols:
	Add two new functions that allow cherry picking and construct
	objects from a ui description file or string.

	* gtk/tests/builder.c: tests for the above.


svn path=/trunk/; revision=20845
2008-07-16 15:36:53 +00:00
Paolo Borelli
3e5cda3d3c fix up broken test (cellview has no "clicked" signal) case and plug a
2008-07-15  Paolo Borelli  <pborelli@katamail.com>

	* gtk/tests/builder.c: fix up broken test (cellview has no "clicked"
	signal) case and plug a couple of leaks.


svn path=/trunk/; revision=20844
2008-07-16 14:13:29 +00:00
Matthias Clasen
f815c34a2b Don't free a GFile. Reported by Sebastien Bacher
* gtk/gtkfilesystem.c (_gtk_file_system_set_bookmark_label): Don't
        free a GFile. Reported by Sebastien Bacher



svn path=/trunk/; revision=20843
2008-07-16 13:51:56 +00:00
Matthias Clasen
4946240780 Bug 339591 – Detect list of availible cover pages
Patch by Marek Kasik:
        * modules/printbackends/cups/gtkprintbackendcups.c: Get the list of
        available cover pages and the default front and back cover pages
        from the cups server.


svn path=/trunk/; revision=20839
2008-07-15 17:45:18 +00:00
Matthias Clasen
1eb96eadfc Bug 384940 – handle rejecting jobs and authentication meaningfully
Patch by Marek Kasik, icons by Mike Langlie:
        * gtk/gtk.symbols:
        * gtk/gtkprintbackend.h:
        * gtk/gtkprinter.[hc]: Add new paused and accepting-jobs properties
        and getters/setters.

        * gtk/gtkstock.h:
        * gtk/gtkiconfactory.c:
        * gtk/Makefile.am:
        * gtk/stock-icons/{16,24}/gtk-print-paused.{png,svg}: New icon.

        * modules/printbackends/cups/gtkprintbackendcups.c:
        * gtk/gtkprintunixdialog.c: Handle paused and job-rejecting
        printers.


svn path=/trunk/; revision=20838
2008-07-15 17:34:34 +00:00
Matthias Clasen
1ea43444be test content sniffing capability of gio
svn path=/trunk/; revision=20837
2008-07-15 16:33:24 +00:00
Xavier Claessens
2452be453b Bug 542523 - GtkTextTag should handle setting properties to NULL
2008-07-15  Xavier Claessens  <xclaesse@gmail.com>

	Bug 542523 - GtkTextTag should handle setting properties to NULL

	* gtk/gtktexttag.c (gtk_text_tag_set_property): Unset the color when
	setting it to NULL instead of displaying a warning.


svn path=/trunk/; revision=20836
2008-07-15 15:23:43 +00:00
Matthias Clasen
ba3b08bc7b Fix a problem with context menu sensitivity
svn path=/trunk/; revision=20834
2008-07-15 05:57:39 +00:00
Matthias Clasen
b0ac0f978e Unset the image when the label is set to "(None)". Reported by Neil
* gtk/gtkfilechooserbutton.c (update_label_and_image): Unset
        the image when the label is set to "(None)". Reported by
        Neil Roberts


svn path=/trunk/; revision=20833
2008-07-15 05:29:41 +00:00
Matthias Clasen
bae6c5576f Add an "Unselect all" button
svn path=/trunk/; revision=20832
2008-07-15 05:19:23 +00:00
Matthias Clasen
69dcbadd00 Plug a small memory leak
svn path=/trunk/; revision=20831
2008-07-15 05:00:42 +00:00
Matthias Clasen
8af098a54d Trivial doc fix
svn path=/trunk/; revision=20829
2008-07-15 03:00:04 +00:00
Matthias Clasen
855b3c228e Add -ljpeg when checking for jasper. Reported by Mike Calmus
* configure.in: Add -ljpeg when checking for jasper.
        Reported by Mike Calmus


svn path=/trunk/; revision=20827
2008-07-15 02:05:30 +00:00
Matthias Clasen
ba01e0fec1 Add some missing stock icons
svn path=/trunk/; revision=20826
2008-07-14 22:37:42 +00:00
Kristian Rietveld
2cc1247433 Fix #316087.
2008-07-11  Kristian Rietveld  <kris@gtk.org>

	Bug 316087 - Resizing columns is chaotic

	* gtk/gtktreeprivate.h: add new member fields.

	* gtk/gtktreeview.c (gtk_tree_view_init), (validate_row): set post
	validation flag,
	(gtk_tree_view_size_allocate_columns): rework the size allocation
	mechanism to only recalculate the expand values if the width of the
	widget, content or the column configuration has changed,
	(gtk_tree_view_size_allocate): move call to size_allocate_columns()
	to before the adjustment updates so the proper width is used after
	we updated it,
	(gtk_tree_view_button_press), (gtk_tree_view_motion_resize_column):
	use the column width minus the expand value for the resized width,
	(gtk_tree_view_move_column_after): update call to
	gtk_tree_view_size_allocate_columns().

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_set_expand): set use
	resized width to FALSE.

	* tests/Makefile.am:
	* tests/testtreecolumnsizing.c: new interactive test program
	for testing column resizing with different column configurations.


svn path=/trunk/; revision=20818
2008-07-11 14:17:49 +00:00
Simos Xenitellis
1d510a9e84 Fixed typo in comment (the name of Markus Kuhn)
svn path=/trunk/; revision=20817
2008-07-10 23:20:30 +00:00
Simos Xenitellis
6b1d3af387 Bug 334418 – Support easy input of ellipsis
svn path=/trunk/; revision=20816
2008-07-10 23:15:00 +00:00
Murray Cumming
9c16d619b9 tooltip-text and tooltip-markup properties: Interpret an empty string as a
2008-07-03  Murray Cumming  <murrayc@murrayc.com>

* gtk/gtkwidget.c (gtk_widget_set_property):  tooltip-text and 
tooltip-markup properties: Interpret an empty string as a NULL 
string because an empty tooltip is silly. This will help 
language bindings that do not bother to have the two types of 
empty/null strings.
Bug #541399.

svn path=/trunk/; revision=20814
2008-07-10 17:46:25 +00:00
Matthias Clasen
418a348bef fix a segfault in the a11y code
svn path=/trunk/; revision=20813
2008-07-10 16:37:53 +00:00
Christian Neumair
2271df7c8d Skip update of accelerator child node if it has no associated action.
2008-07-08  Christian Neumair  <cneumair@gnome.org>

	* gtk/gtkuimanager.c (update_node):
	Skip update of accelerator child node if it has no associated action.
	Fixes #541950.

svn path=/trunk/; revision=20811
2008-07-07 23:17:40 +00:00
Cody Russell
6301e71979 Bug 541964 – [Win32] Setting modal hint to current value might confuse
2008-07-07  Cody Russell  <bratsche@gnome.org>

        Bug 541964 – [Win32] Setting modal hint to current value might confuse the stack

        * gdk/win32/gdkwindow-win32.c: Check if	the value is the same as the
        existing modal hint value before setting it.


svn path=/trunk/; revision=20809
2008-07-07 22:26:35 +00:00
Cody Russell
54bd8a3b2d Bug 540994 – [Win32] Some windows don't appear at the top when created
2008-07-07  Cody Russell  <bratsche@gnome.org>

        Bug 540994 – [Win32] Some windows don't appear at the top when created

        * gdk/win32/gdkwindow-win32.c: Raise the window when setting it modal.

        I actually already committed this one by accident, probably when I committed
        #541305, but just wanted to document it here in the ChangeLog.


svn path=/trunk/; revision=20808
2008-07-07 22:18:15 +00:00
Johan Dahlin
4773df1215 Add a test case for 528845.
2008-07-07  Johan Dahlin  <johan@gnome.org>

        * gtk/tests/builder.c (test_cell_view):
        Add a test case for 528845.


svn path=/trunk/; revision=20806
2008-07-07 12:01:58 +00:00
Tor Lillqvist
d698b1f6fd Need to initialise private->impl here, too.
2008-07-07  Tor Lillqvist  <tml@novell.com>

	* gdk/win32/gdkwindow-win32.c
	(gdk_window_foreign_new_for_display): Need to initialise
	private->impl here, too.


svn path=/trunk/; revision=20805
2008-07-07 09:28:40 +00:00
Michael Natterer
a51c43f5c6 include the two needed headers instead of <gtk/gtk.h>.
2008-07-07  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilesystem.c: include the two needed headers instead of
	<gtk/gtk.h>.


svn path=/trunk/; revision=20804
2008-07-07 09:05:02 +00:00
Matthias Clasen
99836c6528 Don't blindly chain up in the buildable implementation. Reported by Kevin
* gtk/gtkcellview.c: Don't blindly chain up in the buildable
        implementation.  Reported by Kevin Ryde.



svn path=/trunk/; revision=20802
2008-07-07 02:45:51 +00:00
Matthias Clasen
e326046d5a Add a note that cairo contexts cannot be cached for handling expose
* gdk/gdkcairo.c (gdk_cairo_create): Add a note that cairo
        contexts cannot be cached for handling expose events.
        Proposed by Behdad Esfahbod.


svn path=/trunk/; revision=20800
2008-07-07 00:28:37 +00:00
Matthias Clasen
cad36b3c42 Doc improvement
svn path=/trunk/; revision=20799
2008-07-07 00:08:00 +00:00
Matthias Clasen
7f12a27249 Clarify the docs. Pointed out by Wolfgang Oertl
* gtk/gtkwidget.c (gtk_widget_get_composite_name): Clarify the
        docs. Pointed out by Wolfgang Oertl



svn path=/trunk/; revision=20798
2008-07-06 23:58:37 +00:00
Matthias Clasen
0eb6848908 Add docs
svn path=/trunk/; revision=20796
2008-07-06 23:43:15 +00:00
Matthias Clasen
0950b2aa73 Fix broken links
svn path=/trunk/; revision=20794
2008-07-06 23:32:10 +00:00
Christian Dywan
bb396a07b2 Remove erroneously added g_return_if_fail (bug #541811).
2008-07-07  Christian Dywan  <christian@imendio.com>

	* gtk/gtkcontainer.c (gtk_container_add_with_properties): Remove
	erroneously added g_return_if_fail (bug #541811).

svn path=/trunk/; revision=20792
2008-07-06 22:24:24 +00:00
Matthias Clasen
75c668dbf2 Fix up highlighting
svn path=/trunk/; revision=20791
2008-07-06 07:24:02 +00:00
Matthias Clasen
a2802754f1 Bug 327582 – Incomplete docs for GtkSettings::gtk-icon-sizes
2008-07-06  Matthias Clasen  <mclasen@redhat.com>

        Bug 327582 – Incomplete docs for GtkSettings::gtk-icon-sizes

        * gtk/gtksettings.c: Improve the documentation of the
        gtk-icon-sizes setting. Proposed by Tommi Komulainen.



svn path=/trunk/; revision=20790
2008-07-06 06:28:47 +00:00
Matthias Clasen
e36dd2f4e3 Bug 539248 – gtk_calender_query_tooltip calls ->detail_func with invalid
2008-07-06  Matthias Clasen  <mclasen@redhat.com>

        Bug 539248 – gtk_calender_query_tooltip calls ->detail_func with
        invalid dates

        * gtk/gtkcalendar.c (gtk_calendar_query_tooltip):
        Check that the cursor is over a valid date before retrieving
        its details.  Patch by Chris Wilson


svn path=/trunk/; revision=20789
2008-07-06 06:08:48 +00:00
Matthias Clasen
486d65659f Bug 493008 – gdk_screen_get_window_stack is not 64-bit-compatible
2008-07-06  Matthias Clasen  <mclasen@redhat.com>

        Bug 493008 – gdk_screen_get_window_stack is not 64-bit-compatible

        * gdk/x11/gdkscreen-x11.c (gdk_screen_get_window_stack): Fix
        64-bit brokenness. Reported by Christian Hammond.


svn path=/trunk/; revision=20788
2008-07-06 06:05:02 +00:00
Matthias Clasen
128585147f Bug 541645 – gtkfilechooserdefault segfaults when bookmark does not
2008-07-06  Matthias Clasen  <mclasen@redhat.com>

        Bug 541645 – gtkfilechooserdefault segfaults when bookmark does not
        contain ://

        * gtk/gtkfilechooserdefault.c (_gtk_file_chooser_label_for_file):
        Be more robust. Reported by  Jelte van der Hoek


svn path=/trunk/; revision=20787
2008-07-06 05:34:03 +00:00
Matthias Clasen
36f5e8d776 Deprecate gtk_box_pack_{start,end}_defaults
svn path=/trunk/; revision=20786
2008-07-06 04:46:36 +00:00
Matthias Clasen
1fbe931f0c 2.13.5
svn path=/trunk/; revision=20785
2008-07-05 20:34:08 +00:00
Matthias Clasen
40a31e283c 2.13.4
svn path=/trunk/; revision=20783
2008-07-05 20:30:16 +00:00
Michael Natterer
777066b3c7 move gtk_draw_insertion_cursor() out of the deprecated section because it
2008-07-05  Michael Natterer  <mitch@imendio.com>

	* gtk/gtk.symbols: move gtk_draw_insertion_cursor() out of the
	deprecated section because it isn't deprecated.


svn path=/trunk/; revision=20780
2008-07-05 16:36:59 +00:00
Michael Natterer
c09eb4fdcb remove #if HAVE_CONFIG_H and clean up other include weirdness in this
2008-07-05  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkprogressbar.c: remove #if HAVE_CONFIG_H and clean up
	other include weirdness in this file.


svn path=/trunk/; revision=20779
2008-07-05 16:03:49 +00:00
Matthias Clasen
3a054c925e Updates
svn path=/trunk/; revision=20773
2008-07-05 04:51:16 +00:00
Matthias Clasen
908aba628a Doc updates
svn path=/trunk/; revision=20772
2008-07-04 22:03:37 +00:00
Matthias Clasen
faef4e8ce2 Small doc fixes
svn path=/trunk/; revision=20771
2008-07-04 21:55:21 +00:00
Matthias Clasen
a1b44ad8cf Some GDK doc additions
svn path=/trunk/; revision=20770
2008-07-04 21:52:54 +00:00
Matthias Clasen
c6e63c6d49 More property deborkage
svn path=/trunk/; revision=20769
2008-07-04 21:20:25 +00:00
Matthias Clasen
7f874a4d19 Fix the getter for text-length
svn path=/trunk/; revision=20768
2008-07-04 21:04:10 +00:00
Matthias Clasen
a46f8f3726 Fix default value
svn path=/trunk/; revision=20767
2008-07-04 20:46:45 +00:00
Matthias Clasen
81376a6e58 Debork
svn path=/trunk/; revision=20765
2008-07-04 20:01:50 +00:00
Michael Natterer
e90941635f Forgot gtktipsquery.c
svn path=/trunk/; revision=20764
2008-07-04 19:23:47 +00:00
Michael Natterer
05a6983f62 Fix make check:
2008-07-04  Michael Natterer  <mitch@imendio.com>

	Fix make check:

	* gtk/Makefile.am: remove GTK_DISABLE_DEPRECATED from INCLUDES
	again :-(

	* gtk/gtkclist.c
	* gtk/gtkcombo.c
	* gtk/gtkctree.c
	* gtk/gtklist.c
	* gtk/gtklistitem.c
	* gtk/gtknotebook.c
	* gtk/gtkobject.c
	* gtk/gtkoldeditable.c
	* gtk/gtkpixmap.c
	* gtk/gtktext.c
	* gtk/gtktree.c
	* gtk/gtktreeitem.c: don't #define it again before including
	gtkalias.h after it has been #undef'ed before.


svn path=/trunk/; revision=20763
2008-07-04 18:38:36 +00:00
Michael Natterer
a63ba82b64 set need_im_reset to FALSE instead of 0.
2008-07-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkentry.c (_gtk_entry_reset_im_context): set need_im_reset
	to FALSE instead of 0.


svn path=/trunk/; revision=20762
2008-07-04 16:41:13 +00:00
Michael Natterer
da4da16baf Allocate with GSlice:
2008-07-04  Michael Natterer  <mitch@imendio.com>

	Allocate with GSlice:

	* gtk/gtkassistant.c: GtkAssistantPage
	* gtk/gtkcellview.c: GtkCellViewCellInfo
	* gtk/gtkentry.c: GtkEntryPasswordHint, PopupInfo
	* gtk/gtkfilefilter.c: FilterRule
	* gtk/gtknotebook.c: GtkNotebookPage


svn path=/trunk/; revision=20761
2008-07-04 14:27:40 +00:00
Michael Natterer
d905a906a4 allocate ComboCellInfo with GSlice.
2008-07-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcombobox.c: allocate ComboCellInfo with GSlice.


svn path=/trunk/; revision=20760
2008-07-04 10:52:52 +00:00
Michael Natterer
d934deaaf3 change "error_dialog" variable to GtkWidget fo fix two warnings.
2008-07-04  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkprintoperation.c (print_pages): change "error_dialog"
	variable to GtkWidget fo fix two warnings.


svn path=/trunk/; revision=20759
2008-07-04 10:46:19 +00:00
Michael Natterer
89da90a6cd Bug 539944 – Add GtkScaleButton API so struct fields can be marked as
2008-07-04  Michael Natterer  <mitch@imendio.com>

	Bug 539944 – Add GtkScaleButton API so struct fields can be marked
	as private

	* gtk/gtk.symbols
	* gtk/gtkscalebutton.[ch]: add gtk_scale_button_get_plus_button()
	and _get_minus_button(). Patch by Christian Dywan.


svn path=/trunk/; revision=20757
2008-07-04 09:02:20 +00:00
Matthias Clasen
4f56813d00 Fix make check
svn path=/trunk/; revision=20756
2008-07-04 05:05:45 +00:00
Matthias Clasen
d423a9224a Fix make check
svn path=/trunk/; revision=20755
2008-07-04 04:02:35 +00:00
Matthias Clasen
65f9d54685 Fall back to the default positioning when the menuitem is not realized.
* gtk/gtkmenuitem.c: Fall back to the default positioning when
        the menuitem is not realized. Patch by Björn Lindqvist.



svn path=/trunk/; revision=20754
2008-07-03 23:33:08 +00:00
Matthias Clasen
8f6aa13b05 Fix a memory leak. Patch by Christian Persch.
* gtk/gtkfilesystem.c (get_volumes_list): Fix a memory leak.
        Patch by Christian Persch.


svn path=/trunk/; revision=20752
2008-07-03 22:46:00 +00:00
Matthias Clasen
2f1ef69fb7 Don't select the first row if the folder is empty. Patch by Olle
* gtk/gtkfilechooserdefault.c (browse_files_select_first_row): Don't
        select the first row if the folder is empty.
        Patch by Olle Bergkvist.


svn path=/trunk/; revision=20751
2008-07-03 22:40:33 +00:00
Tor Lillqvist
688cc55cdd Bug 540861 - invalid UTF-8 in input device name
2008-07-04  Tor Lillqvist  <tml@novell.com>

	Bug 540861 - invalid UTF-8 in input device name

	* gdk/win32/gdkinput-win32.c: Fetch the device and cursor names in
	Unicode, and convert to UTF-8 for the GdkDevice's name field.


svn path=/trunk/; revision=20750
2008-07-03 22:11:38 +00:00
Matthias Clasen
7d9cf87a04 Set properties in the order in which they are specified in the xml file.
* gtk/gtkbuilderparser.c (parse_custom): Set properties in the order
        in which they are specified in the xml file.


svn path=/trunk/; revision=20749
2008-07-03 18:09:04 +00:00
Matthias Clasen
efd2dbf026 Add gtk_scale_button_get_popup
svn path=/trunk/; revision=20748
2008-07-03 18:03:13 +00:00
Matthias Clasen
5d0421f6c3 One more
svn path=/trunk/; revision=20747
2008-07-03 17:37:07 +00:00
Matthias Clasen
c20433d644 Use monospace as font name, not mono. Patch by Yevgen Muntyan.
* demos/gtk-demo/printing.c: Use monospace as font name,
        not mono. Patch by Yevgen Muntyan.


svn path=/trunk/; revision=20746
2008-07-03 17:35:50 +00:00
Matthias Clasen
075d84b88a No more mushroom
svn path=/trunk/; revision=20745
2008-07-03 17:29:39 +00:00
Michael Natterer
528f7b7336 remove "_from_bindings" suffix from the names of binding signal
2008-07-03  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkscalebutton.c: remove "_from_bindings" suffix from the
	names of binding signal implementations.


svn path=/trunk/; revision=20744
2008-07-03 13:13:23 +00:00
Li Yuan
6f2850bd2d Bug #536430. Add libgailutil.la into gail-uninstalled.pc.in.
2008-07-03  Li Yuan  <li.yuan@sun.com>

        * gail-uninstalled.pc.in:
        Bug #536430. Add libgailutil.la into gail-uninstalled.pc.in.

svn path=/trunk/; revision=20742
2008-07-03 08:48:24 +00:00
Cody Russell
7a500d97b2 Bug 540529 – Remove all GIMP references
2008-07-03  Cody Russell  <bratsche@gnome.org>

        Bug 540529 – Remove all GIMP references

        * gtk+-2.0.pc.in:
        * gdk-2.0.pc.in:
        * gtk+-unix-print-2.0.pc.in:
        * gtk+-2.0-uninstalled.pc.in:
        * gdk-2.0-uninstalled.pc.in: Changed GIMP Toolkit to say
        GTK+ Graphical UI Library in the pkg-config files.


svn path=/trunk/; revision=20739
2008-07-03 05:47:22 +00:00
Matthias Clasen
d2343ff20b Fix attribution
svn path=/trunk/; revision=20738
2008-07-03 04:45:50 +00:00
Cody Russell
e7b024c6b7 Bug 541305 – [Win32] Scrolling was broken after GdkWindow refactoring
2008-07-02  Cody Russell  <bratsche@gnome.org>

        Bug 541305 – [Win32] Scrolling was broken after GdkWindow refactoring

        * gdk/win32/gdkwindow-win32.c:	Reverted	some logic so that scrolling
	works again.

        * gdk/win32/gdkgeometry-win32.c: Removed some more unnecessary	checks.
        * gdk/win32/gdkkeys-win32.c: Removed unused variable to fix compile-time
        warnings.


svn path=/trunk/; revision=20737
2008-07-02 20:22:30 +00:00
Cody Russell
2bb97a7a90 Bug 541249 – [Win32] Fix some internal static methods
2008-07-02  Cody Russell  <bratsche@gnome.org>

        Bug 541249 – [Win32] Fix some internal static methods

        * gdk/gdkwindow-win32.c: Make the interface implementation methods
        static.


svn path=/trunk/; revision=20734
2008-07-02 13:58:28 +00:00
Michael Natterer
a82c180023 Bug 537591 – Don't hardcode minimum width of menuitems
2008-07-02  Michael Natterer  <mitch@imendio.com>

	Bug 537591 – Don't hardcode minimum width of menuitems

	* gtk/gtkmenuitem.c: applied patch from Christian Dywan which
	introduces a "width-chars" style property which replaces the
	hardcoded minimum width of menuitems with submenu. Patch
	extracted from Maemo-GTK+.


svn path=/trunk/; revision=20733
2008-07-02 12:05:42 +00:00
Michael Natterer
1b291602bd remove some of the million includes.
2008-07-02  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilechooserdefault.c: remove some of the million includes.


svn path=/trunk/; revision=20732
2008-07-02 10:14:45 +00:00
Kristian Rietveld
74984a5c24 Since s/2.16/2.14/ for the new gicon property.
2008-07-02  Kristian Rietveld  <kris@imendio.com>

	* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_class_init):
	Since s/2.16/2.14/ for the new gicon property.


svn path=/trunk/; revision=20731
2008-07-02 09:34:24 +00:00
Kristian Rietveld
4cceb2f1dc Bug 455268 - Add gtk-enable-tooltips GtkSetting
2008-07-02  Kristian Rietveld  <kris@imendio.com>

	Bug 455268 - Add gtk-enable-tooltips GtkSetting

	* gtk/gtk.symbols:
	* gtk/gtktoolbar.[ch] (gtk_toolbar_[gs]et_tooltips): deprecated.

	* gtk/gtksettings.c: introduce gtk-enable-tooltips XSetting.

	* gtk/gtktooltip.c (_gtk_tooltip_handle_event): take the newly
	introduced XSetting into account.

	* demos/gtk-demo/appwindow.c: don't use the now deprecated
	gtk_toolbar_set_tooltips().


svn path=/trunk/; revision=20730
2008-07-02 09:32:14 +00:00
Cody Russell
e625b41a1d Bug 541162 – [Win32] Update for the new GdkWindowImpl stuff
2008-07-02  Cody Russell  <bratsche@gnome.org>

        Bug 541162 – [Win32] Update for the new GdkWindowImpl stuff

        * gdk/win32/gdkprivate-win32.h:
        * gdk/win32/gdkgeometry-win32.c:
        * gdk/win32/gdkevents-win32.c:
        * gdk/win32/gdkwindow-win32.c: Update Win32 backend according to
        the newly refactored GdkWindow code.


svn path=/trunk/; revision=20729
2008-07-02 06:06:29 +00:00
Cody Russell
0d0f9a7fc1 Bug 539164 – Windows' System Menu blocks main loop
2008-07-01  Cody Russell  <bratsche@gnome.org>

        Bug 539164 – Windows' System Menu blocks main loop

        * gdk/win32/gdkevents-win32.c:	Use a modal timer proc in between
	receiving WM_ENTERMENULOOP and	WM_EXITMENULOOP	and pump	the
	GLib mainloop from there.


svn path=/trunk/; revision=20726
2008-07-01 23:13:26 +00:00
Cody Russell
688470400b Remove old ChangeLog entry
svn path=/trunk/; revision=20725
2008-07-01 23:04:35 +00:00
Richard Hult
119f3cf183 Some aftermath from the window impl cleanups:
2008-07-01  Richard Hult  <richard@imendio.com>

	Some aftermath from the window impl cleanups:

	* gdk/quartz/gdkwindow-quartz.c:
	(gdk_window_merge_child_input_shapes): Rename and export again.
	(gdk_window_quartz_get_offsets): Make static.

svn path=/trunk/; revision=20723
2008-07-01 18:27:43 +00:00
Michael Natterer
6281cec0ab forgot to commit the header, fixed now.
2008-07-01  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkscalebutton.h: forgot to commit the header, fixed now.


svn path=/trunk/; revision=20719
2008-07-01 07:45:40 +00:00
Matthias Clasen
44e2afaadb Add event sound settings. Patch by Lennart Pöttering.
* gdk/x11/gdksettings.c:
        * gtk/gtksettings.c: Add event sound settings.
        Patch by Lennart Pöttering.


svn path=/trunk/; revision=20717
2008-07-01 06:22:04 +00:00
Matthias Clasen
a7abdcf8fc Handle failure to create temp file by returning NULL.
* gtk/gtkprintoperation-unix.c
        (_gtk_print_operation_platform_backend_create_preview_surface):
        Handle failure to create temp file by returning NULL.

        * gtk/gtkprintoperation.c (gtk_print_operation_preview_handler):
        Return FALSE if surface creation fails.

        (print_pages): If the preiew signal is not handled, show an
        error dialog.


svn path=/trunk/; revision=20715
2008-07-01 05:38:49 +00:00
Michael Natterer
cbd06646dd Bug 442042 – GtkScaleButton is too limited
2008-07-01  Michael Natterer  <mitch@imendio.com>

	Bug 442042 – GtkScaleButton is too limited

	* gtk/gtkscalebutton.[ch]: turn "orientation" into a normal
	property that can be changed at any time after widget
	creation. Add public API for it.

	* gtk/gtk.symbols: add gtk_scale_button_get/set_orientation.


svn path=/trunk/; revision=20710
2008-06-30 23:41:10 +00:00
Cody Russell
fce9c8b7d4 Practically everything changed.
2008-06-30  Cody Russell  <bratsche@gnome.org>

        * Practically everything changed.

        Change	all references	of GIMP	Toolkit	(and variations	of it)
        to GTK+	Toolkit, showing no mercy at all to our	beloved
	ancestry. (#540529)


svn path=/trunk/; revision=20709
2008-06-30 23:01:56 +00:00
Michael Natterer
971023d922 Some unrelated cleanups found while reviewing the offscreen window patch:
2008-06-30  Michael Natterer  <mitch@imendio.com>

	Some unrelated cleanups found while reviewing
	the offscreen window patch:

	* gdk/gdkwindow.c: add missing Since: 2.14 to the redirection
	functions, fix some function header indentation, update
	documentation of redirect_to_drawable().

	* gdk/x11/gdkwindow-x11.c
	* gdk/x11/gdkpixmap-x11.c: fix function header
	formatting/indentation.

	* gtk/gtkwidget.c: use I_() on "damage_event".


svn path=/trunk/; revision=20708
2008-06-30 12:15:29 +00:00
Michael Natterer
2e3c1149ae remove duplicate declaration of _gdk_window_new().
2008-06-30  Michael Natterer  <mitch@imendio.com>

	* gdk/gdkinternals.h: remove duplicate declaration of
	_gdk_window_new().


svn path=/trunk/; revision=20707
2008-06-30 11:04:42 +00:00
Michael Natterer
b4201d4de9 reorder source lists alphabetically.
2008-06-30  Michael Natterer  <mitch@imendio.com>

	* gdk/Makefile.am: reorder source lists alphabetically.


svn path=/trunk/; revision=20706
2008-06-30 10:44:47 +00:00
Matthias Clasen
ab019f3ade Avoid unnecessary redraws when resizing. Patch by Owen Taylor
* gtk/gtkwindow.c: Avoid unnecessary redraws when resizing.
        Patch by Owen Taylor


svn path=/trunk/; revision=20705
2008-06-30 05:17:02 +00:00
Behdad Esfahbod
e670565932 Bug 530255 – GtkAboutDialog cuts off comments label Followup patch from
2008-06-29  Behdad Esfahbod  <behdad@gnome.org>

        Bug 530255 – GtkAboutDialog cuts off comments label
        Followup patch from  Jan Arne Petersen

        * gtk/gtklabel.c (gtk_label_get_layout_offsets): Ensure layout.


svn path=/trunk/; revision=20703
2008-06-29 17:17:09 +00:00
Michael Natterer
5390e1e24c properly indent the newly added GtkSelectionData accessors. Some newlines
2008-06-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkselection.h: properly indent the newly added
	GtkSelectionData accessors. Some newlines can't hurt either.


svn path=/trunk/; revision=20702
2008-06-28 17:02:20 +00:00
Mikael Hallendal
ff7f25c9af Removed accidental empty row in gtk_box_pack.
2008-06-27  Mikael Hallendal  <micke@imendio.com>

	* gtk/gtkbox.c (gtk_box_pack): Removed accidental empty row.

svn path=/trunk/; revision=20701
2008-06-28 16:21:28 +00:00
Mikael Hallendal
257ca7ef7d Factor out gtk_box_pack from gtk_box_pack_start and gtk_box_pack_end to reduce code duplication.
2008-06-27  Mikael Hallendal  <micke@imendio.com>

        * gtk/gtkbox.c (gtk_box_pack, gtk_box_pack_start, gtk_box_pack_end):
        Factored out gtk_box_pack from gtk_box_pack_start and use it from both
        pack_start and pack_end in order to reduce the code duplication.

svn path=/trunk/; revision=20700
2008-06-28 16:16:26 +00:00
Michael Natterer
b8cee08351 Bug 442042 – GtkScaleButton is too limited
2008-06-27  Michael Natterer  <mitch@imendio.com>

	Bug 442042 – GtkScaleButton is too limited

	* gtk/gtkscalebutton.c (gtk_scale_button_init): set the name
	"gtk-scalebutton-popup-window" on the popup window so it is
	properly themeable.


svn path=/trunk/; revision=20698
2008-06-27 20:13:25 +00:00
Kristian Rietveld
cf3542155f adapt to use GdkWindowImpl interface.
2008-06-27  Kristian Rietveld  <kris@imendio.com>

	* gdk/quartz/gdkgeometry-quartz.c:
	* gdk/quartz/gdkwindow-quartz.c:
	* gdk/quartz/gdkprivate-quartz.h: adapt to use GdkWindowImpl
	interface.


svn path=/trunk/; revision=20697
2008-06-27 17:06:06 +00:00
Carlos Garnacho
b3bb8c47b5 Fix two potential critical warnings. Bug #539470.
2008-06-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkrecentmanager.c (get_icon_for_mime_type): Fix two potential
        critical warnings. Bug #539470.

svn path=/trunk/; revision=20696
2008-06-27 15:33:42 +00:00
Emmanuele Bassi
e27632cd6d Abstract some GdkWindow API into an interface that the backends must
2008-06-27  Emmanuele Bassi  <ebassi@gnome.org>

	Abstract some GdkWindow API into an interface that the backends
	must implement. (based on a patch by Alex Larsson)

	* gdk/Makefile.am: Add gdkwindowimpl.[ch]

	* gdk/gdk.symbols: Move symbols around.

	* gdk/gdkinternals.h:
	* gdk/gdkwindowimpl.[ch]: Move some of the GdkWindow API we require
	from the backends to a GInterface that the backends should implement
	instead.

	* gdk/gdkwindow.c: Provide some of the GdkWindow public API as a
	wrapper call around the GdkWindowImpl interface vtable.

	* gdk/x11/gdkevents-x11.c:
	* gdk/x11/gdkgeometry-x11.c:
	* gdk/x11/gdkprivate-x11.h:
	* gdk/x11/gdkwindow-x11.c:
	* gdk/x11/gdkwindow-x11.h: Update the X11 backend to implement
	the GdkWindowImpl interface.

svn path=/trunk/; revision=20695
2008-06-27 14:27:44 +00:00
Martyn James Russell
cf1df130dc Fixed the FAQ location in the warning produced here.
* gtk/gtkcontainer.c: (gtk_container_add): Fixed the FAQ location
	in the warning produced here.

svn path=/trunk/; revision=20693
2008-06-27 11:51:40 +00:00
Michael Natterer
53d96e46f4 Bug 442042 – GtkScaleButton is too limited
2008-06-27  Michael Natterer  <mitch@imendio.com>

	Bug 442042 – GtkScaleButton is too limited

	* gtk/gtkscalebutton.c: add "orientation" property. Make sure the
	stuff that is part of the public API continues to be created in
	init() to stay compatible. Move creating of the popup scale to
	constructor(). Add an internal HScale class. Changed popup
	positioning for horizontal scales accordingly.


svn path=/trunk/; revision=20692
2008-06-27 09:33:32 +00:00
Michael Natterer
d79185cf1f gtk/gtkscalebutton.c remove redundant init() and class_init() prototypes,
2008-06-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkscalebutton.c
	* gtk/gtkvolumebutton.c: remove redundant init() and class_init()
	prototypes, remove redundant includes, remove a little trailing
	whitespace.


svn path=/trunk/; revision=20691
2008-06-26 17:14:27 +00:00
Richard Hult
2f29e8d9f5 Patch from Christian Dywan to clean up selection data setting.
2008-06-26  Richard Hult  <richard@imendio.com>

	* gtk/gtkclipboard-quartz.c: (gtk_clipboard_wait_for_contents):
	* gtk/gtkquartz.c:
	(_gtk_quartz_get_selection_data_from_pasteboard),
	(_gtk_quartz_set_selection_data_for_pasteboard): Patch from
	Christian Dywan to clean up selection data setting.

svn path=/trunk/; revision=20690
2008-06-26 13:01:40 +00:00
Richard Hult
2e6f82b987 Don't use deprecated function gtk_widget_ref, replace with g_object_ref.
2008-06-26  Richard Hult  <richard@imendio.com>

	* gtk/gtkdnd-quartz.c (gtk_drag_begin_internal): Don't use
	deprecated function gtk_widget_ref, replace with g_object_ref.

svn path=/trunk/; revision=20689
2008-06-26 12:44:10 +00:00
Michael Natterer
1a6b0cb1ca #include "config.h"
2008-06-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilesystem.c: #include "config.h"


svn path=/trunk/; revision=20688
2008-06-26 10:19:23 +00:00
Carlos Garnacho
1732652e71 current_folder can be NULL here, do not try to reference it (Bug #540235)
2008-06-26  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkfilechooserdefault.c
        (gtk_file_chooser_default_get_current_folder): current_folder can be
        NULL here, do not try to reference it (Bug #540235)
        (gtk_file_chooser_default_get_files): Deal better with
        gtk_file_chooser_default_get_current_folder() being able to return
        NULL.

svn path=/trunk/; revision=20687
2008-06-26 09:41:13 +00:00
Michael Natterer
260e94547f allocate the GtkTextUtilCallbackInfo structs with GSlice.
2008-06-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextutil.c (_gtk_text_util_append_special_char_menuitems):
	allocate the GtkTextUtilCallbackInfo structs with GSlice.


svn path=/trunk/; revision=20686
2008-06-26 09:06:48 +00:00
Michael Natterer
3d322ce16a there is no reason to include <gtk/gtktypebuiltins.h> in the middle of the
2008-06-25  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: there is no reason to include
	<gtk/gtktypebuiltins.h> in the middle of the file, move it to top,
	replacing the <glib-object.h> include. Also move the remaining few
	non-deprecated things to the top and move some deprecated things
	around to clean up the mess with too many deprecated sections even
	more.


svn path=/trunk/; revision=20685
2008-06-25 09:32:38 +00:00
Michael Natterer
0c1f022ba7 deprecate gtk_type_init() unconditionally (also for GTK_COMPILATION). Move
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktypeutils.h: deprecate gtk_type_init() unconditionally
	(also for GTK_COMPILATION). Move some deprecated typedefs around
	to reduce the mess with zillions of deprecated sections.

	* gtk/gtkmain.c (do_post_parse_initialization): replace the call
	to gtk_type_init() by g_type_init() and gtk_object_get_type() even
	though the latter is probably completely pointless.


svn path=/trunk/; revision=20684
2008-06-24 19:11:30 +00:00
Johan Dahlin
c472d99c0b Revert GtkScaleButton accesses for plus/minus buttons, as per #539944
svn path=/trunk/; revision=20682
2008-06-24 13:41:13 +00:00
Michael Natterer
24c0eb5d39 also revert change in how the dialog's vbox was added (bug #539732).
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkdialog.c (gtk_dialog_init): also revert change in how
	the dialog's vbox was added (bug #539732).


svn path=/trunk/; revision=20681
2008-06-24 10:49:12 +00:00
Carlos Garnacho
60e1b3ea89 Remove container implementation, which isn't thought for handling
2008-06-24  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkdialog.[ch]: Remove container implementation, which isn't
        thought for handling non-direct children. Fixes #539732.
        (gtk_dialog_pack_start) (gtk_dialog_pack_end): Removed as well, it
        doesn't provide enough control to API users (removing, reordering...),
        this is better handled through:
        (gtk_dialog_get_content_area): New function which just returns
        dialog->vbox.
        * gtk/gtk.symbols: Modify accordingly.
        * docs/reference/gtk/tmpl/gtkdialog.sgml: Update docs to recommend
        using gtk_dialog_get_[action|content]_area() instead of accessing
        dialog struct members directly.

svn path=/trunk/; revision=20680
2008-06-24 10:22:40 +00:00
Michael Natterer
a13f698b3a gtk/gtkassistant.h gtk/gtkcellrenderer.h gtk/gtkfilechooserentry.h
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkassistant.h
	* gtk/gtkcellrenderer.h
	* gtk/gtkfilechooserentry.h
	* gtk/gtkprivate.h
	* gtk/gtktooltip.h
	* gtk/gtktreeview.h
	* gtk/gtkwindow.h: no need to include gtkwidget.h or gtkobject.h
	if there is any other widget included, they all have to include
	their respective parent classes (the is-a relation works for
	includes too).


svn path=/trunk/; revision=20679
2008-06-24 10:16:01 +00:00
Michael Natterer
7146dd12e5 remove includes from this internal header.
2008-06-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextutil.h: remove includes from this internal header.

	* gtk/gtktextutil.c: include gtktextbuffer.h before gtktextutil.h.


svn path=/trunk/; revision=20678
2008-06-24 09:55:08 +00:00
Michael Natterer
257cfa289b formatting.
2008-06-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkinvisible.h: formatting.


svn path=/trunk/; revision=20676
2008-06-23 14:28:13 +00:00
Michael Natterer
77e99003a8 gtk/gtkaction.h gtk/gtkbuildable.h gtk/gtkbuilderprivate.h
2008-06-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkaction.h
	* gtk/gtkbuildable.h
	* gtk/gtkbuilderprivate.h
	* gtk/gtkcelllayout.h
	* gtk/gtkentrycompletion.h
	* gtk/gtkfilechoosersettings.h
	* gtk/gtkfilesystem.h
	* gtk/gtkfilesystemmodel.h
	* gtk/gtkicontheme.h
	* gtk/gtklinkbutton.h
	* gtk/gtkpagesetup.h
	* gtk/gtkpapersize.h
	* gtk/gtkprintcontext.h
	* gtk/gtkprintoperation.h
	* gtk/gtkprintoperationpreview.h
	* gtk/gtkprintsettings.h
	* gtk/gtkrecentchooserprivate.h
	* gtk/gtkrecentmanager.h
	* gtk/gtksearchengine.h
	* gtk/gtktexttag.h
	* gtk/gtktreeselection.h
	* gtk/gtktreeviewcolumn.h
	* gtk/gtkuimanager.h: remove redundant inclusion of <glib.h> and
	<glib-object.h>. There is no point in relying on them being pulled
	in by other headers in some places and placing them explicitly in
	other places, so choose the "as little includes as possible"
	approach and get rid of them.


svn path=/trunk/; revision=20675
2008-06-23 14:07:19 +00:00
Kristian Rietveld
ed7d0ed47e do not hard code the prefix of the enum, use @ENUMPREFIX@ instead (you
2008-06-23  Kristian Rietveld  <kris@imendio.com>

	* gdk/gdkenumtypes.h.template:
	* gdk-pixbuf/gdk-pixbuf-enum-types.h.template:
	* gtk/gtktypebuiltins.h.template:
	* perf/typebuiltins.h.template: do not hard code the prefix of the
	enum, use @ENUMPREFIX@ instead (you need an up to date glib for this).


svn path=/trunk/; revision=20674
2008-06-23 12:09:15 +00:00
Michael Natterer
7dfaf81ee2 gtk/gtkmountoperation.h gtk/gtktestutils.h remove as many includes as
2008-06-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmountoperation.h
	* gtk/gtktestutils.h
	* gtk/gtkshow.[ch]: remove as many includes as possible from these
	new files. They can't be included individually, so nothing can break.


svn path=/trunk/; revision=20673
2008-06-23 10:47:22 +00:00
Michael Natterer
91f84cd1d8 use g_param_spec_flags(), not enum() when registering the "modifier-mask"
2008-06-22  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkaccelgroup.c: use g_param_spec_flags(), not enum() when
	registering the "modifier-mask" property.


svn path=/trunk/; revision=20670
2008-06-22 16:42:22 +00:00
Johan Dahlin
d97cdbdf53 Include "config.h" instead of <config.h> Command used: find -name
2008-06-21  Johan Dahlin  <jdahlin@async.com.br>

    * *.[ch]: Include "config.h" instead of <config.h>
    Command used:
    find -name \*.[ch]|xargs perl -p -i -e 's/^#include <config.h>/#include "config.h"/g'
    Rubberstamped by Mitch and Tim


svn path=/trunk/; revision=20669
2008-06-22 14:28:52 +00:00
Carlos Garnacho
56bbbbf553 Bug 539466 – GtkMenuShell API/ABI break in trunk.
2008-06-21  Carlos Garnacho  <carlos@imendio.com>

        Bug 539466 – GtkMenuShell API/ABI break in trunk.

        * gtk/gtkmenushell.h: Fix API/ABI break, two guint fields had
        different name and packing width.

svn path=/trunk/; revision=20666
2008-06-21 14:56:07 +00:00
Johan Dahlin
a1362779ee Cast to guint8* to avoid a compiler warning.
2008-06-21  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkiconcachevalidator.c (check_pixel_data): Cast to guint8* to avoid
    a compiler warning.


svn path=/trunk/; revision=20665
2008-06-21 13:09:57 +00:00
Johan Dahlin
33d64796d0 Document a style property
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbutton.c: Document a style property


svn path=/trunk/; revision=20664
2008-06-21 12:34:12 +00:00
Michael Natterer
aefbaedc61 remove redundant include, fix indentation, replace header by a GDK
2008-06-21  Michael Natterer  <mitch@imendio.com>

	* gdk/gdkapplaunchcontext.h: remove redundant include, fix
	indentation, replace header by a GDK copyright header (don't say
	"The Gnome Library"), remove trailing whitespace.


svn path=/trunk/; revision=20663
2008-06-21 10:44:26 +00:00
Hans Breuer
d3ce448c20 fix 'function' : incompatible types - from 'struct _cairo *' to 'struct
2008-06-21  Hans Breuer  <hans@breuer.org>

	* gtk/gtkprintoperation-win32.c(1713) : fix 'function' : incompatible 
	types - from 'struct _cairo *' to 'struct _cairo_surface *' by
	passing the surface to cairo_surface_show_page(), not the context
	* gtk/gtkprintoperation-win32.c(866) : get rid of warning C4018: 
	'<' : signed/unsigned mismatch by using guint for the loop

	* gtk/gtkmenu.c(gtk_menu_get_property) : property 'menu::active' is 
	an uint, gtk_menu_get_active() returns the widget pointer. Convert
	the latter to the former by calculating the index in menu::children
	Also fix some occurences of g_return_if_fail() where 
	g_return_val_if_fail() was meant


svn path=/trunk/; revision=20662
2008-06-21 09:49:00 +00:00
Björn Lindqvist
743eebc1a5 Bug 539363 – Segfault when creating GtkPlugs
2008-06-21  Björn Lindqvist  <bjourne@gmail.com>

	Bug 539363 – Segfault when creating GtkPlugs

	* gtk/gtkplug.c (gtk_plug_class_init): Spaces not allowed in
	property names. "socket window" => "socket-window"

svn path=/trunk/; revision=20661
2008-06-21 01:03:25 +00:00
Jody Goldberg
87caf0d3ae Fix life cycle to avoid crash. [#536966]
2008-06-20  Jody Goldberg <jody@gnome.org>

	* gtk/gtkprintoperation-win32.c (gtk_print_run_page_setup_dialog) : 
	  Fix life cycle to avoid crash. [#536966]

svn path=/trunk/; revision=20660
2008-06-21 00:53:17 +00:00
Hans Breuer
8e2ef4982b must return a value of the appropriate type with g_return_val_if_fail
2008-06-20  Hans Breuer  <hans@breuer.org>

	* gtk/gtkmenuitem.c gtk/gtkmessagedialog.c gtk/gtkplug.c : must return
	a value of the appropriate type with g_return_val_if_fail
	
	* gdk/gdkconfig.h.win32 : add the GSEAL definition here as well

	* gtk/gtkfilesystem.c : don't add the "File System" on win32

	* tests/makefile.msc : remove broken autotestfile(system|chooser) 
	from build


svn path=/trunk/; revision=20657
2008-06-20 20:39:22 +00:00
Johan Dahlin
2e75eb1330 Document and use - instead of _ in signal names.
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkeditable.c: Document and use - instead of _ in signal names.


svn path=/trunk/; revision=20656
2008-06-20 20:11:46 +00:00
Johan Dahlin
ef5e0e9601 Fix up deprecated markup syntax. Add version numbers and a message on the
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkbutton.c:
    * gtk/gtkcolorsel.c:
    * gtk/gtkentry.c:
    * gtk/gtkitemfactory.c:
    * gtk/gtknotebook.c:
    Fix up deprecated markup syntax. Add version numbers and
    a message on the remaning ones.


svn path=/trunk/; revision=20655
2008-06-20 19:42:53 +00:00
Mikael Hallendal
df11b00dae Replaced use of gtk_signal_connect with the g_signal_connect equivalents.
2008-06-20  Mikael Hallendal  <micke@imendio.com>

	* tests/testthreads.c: Use g_signal_connect instead of
	gtk_signal_connect.

	* demos/testgtk/main.c: switched to use GSignal instead of GtkSignal.
	While the code is not built, people may still look at it.

svn path=/trunk/; revision=20654
2008-06-20 19:26:50 +00:00
Kjartan Maraas
0eba9bf8fe reviewed by: <Carlos Garnacho <garnacho@gnome.org>
2008-06-20  Kjartan Maraas  <kmaraas@gnome.org>

	reviewed by: <Carlos Garnacho <garnacho@gnome.org>

	* gtk/gtkbuilder.h:
	* gtk/gtkliststore.h:
	* gtk/gtkobject.h:
	* gtk/gtktextchild.h:
	* gtk/gtktreemodelfilter.h:
	* gtk/gtktreemodelsort.h:
	* gtk/gtktreestore.h:
	#include <gdkconfig.h> not <gdk/gdkconfig.h>

svn path=/trunk/; revision=20653
2008-06-20 18:52:52 +00:00
Martyn James Russell
c8322b8c0e Fix warnings from calling g_object_notify() on a GtkAccelGroup without
* gtk/gtkaccelgroup.c: Fix warnings from calling
	g_object_notify() on a GtkAccelGroup without casting to a
	GObject.

svn path=/trunk/; revision=20652
2008-06-20 15:10:00 +00:00
Johan Dahlin
755a662ff2 Modernize and order things as most other objects. Defines at the top,
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtkcolorsel.c: Modernize and order things as most
    other objects. Defines at the top, class init before init
    before gobject methods before object method before widget
    methods. No changes to the logic done.


svn path=/trunk/; revision=20651
2008-06-20 15:01:31 +00:00
Martyn James Russell
7e374415b6 Don't call g_object_notify() with properties that don't exist. Also, make
* gtk/gtkaccelgroup.c: Don't call g_object_notify() with
	properties that don't exist. Also, make sure we notify for
	the "is-locked" property.

svn path=/trunk/; revision=20650
2008-06-20 14:45:54 +00:00
Johan Dahlin
90bc8940c8 Remove left-over unused property enum.
2008-06-20  Johan Dahlin  <jdahlin@async.com.br>

    * gtk/gtklayout.c (enum): Remove left-over unused property enum.


svn path=/trunk/; revision=20649
2008-06-20 14:34:50 +00:00