2008-09-04 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.c (gtk_widget_get_draw_rectangle): when extending
the draw rectangle by the "draw-border" style property, subtract
"left" from "x" and "top" from "y", not the other way around.
svn path=/trunk/; revision=21285
2008-09-03 Matthias Clasen <mclasen@redhat.com>
Bug 550528 - IconView DND interface does not work if only used as
source
* gtk/gtkiconview.c: Make source-only DND work.
Found by Alex Simon
svn path=/trunk/; revision=21270
2008-09-03 Michael Natterer <mitch@imendio.com>
* gtk/gtkarrow.c: expose-event returns gboolean not gint,
reindented static prototypes and did some minor cleanups.
svn path=/trunk/; revision=21265
2008-09-02 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.c (gtk_widget_get_allocation): removed this
function because there is massive disagreement about how to
implement it. Needs some general discussion in the next
development cycle about how our C api should evolve.
* gtk/gtk.symbols: changed accordingly.
svn path=/trunk/; revision=21259
2008-09-01 Wouter Bolsterlee <wbolster@svn.gnome.org>
* gtk/gtkselection.c:
Update documentation for gtk_selection_data_get_data to
match the changes introduced in -r21232 (the length
parameter was removed).
svn path=/trunk/; revision=21256
2008-08-29 Björn Lindqvist <bjourne@gmail.com>
Bug 437791 – Animation is played at the wrong speed
* gdk-pixbuf/io-gif.c (gif_get_lzw): Better 100 ms timeout for
broken GIFs with 0 frame timeout.
svn path=/trunk/; revision=21242
2008-08-29 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.h: move the gtk_widget_get_parent() and
gtk_widget_get_parent_window() prototypes together with their
respective setters.
* gtk/gtkwidget.c: move gtk_widget_get_parent_window() together
with its setter.
svn path=/trunk/; revision=21240
2008-08-29 Michael Natterer <mitch@imendio.com>
* configure.in: remove -DPANGO_DISABLE_SINGLE_INCLUDES from
CPPFLAGS, I committed that accidentially.
svn path=/trunk/; revision=21237
2008-08-29 Matthias Clasen <mclasen@redhat.com>
Bug 549262 – GtkScrolledWindow should not accept focus unless
GTK_CAN_FOCUS is set
* gtk/gtkscrolledwindow.c (gtk_scrolled_window_focus): only grab the
focus, if GTK_WIDGET_CAN_FOCUS() returns TRUE. Patch by Sven
Herzberg
svn path=/trunk/; revision=21233
2008-08-28 Christian Dywan <christian@imendio.com>
Bug 549734 – gtk_selection_data_get_data prototype is wrong
* gtk/gtkselection.[ch] (gtk_selection_data_get_data): make the
'length' argument of gtk_selection_data_get_data a 'gint', that's
what it should be.
svn path=/trunk/; revision=21229
2008-08-27 Cody Russell <bratsche@gnome.org>
* gdk/win32/gdkevents-win32.c:
* gdk/win32/gdkwindow-win32.c (show_window_recurse): Check if
the window's state has GDK_WINDOW_STATE_MAXIMIZED set before
calling ShowWindow (), and show using SW_SHOWMAXIMIZED or
SW_RESTORE accordingly. This fixes an issue where maximized
windows that are iconified do not restore back to maximized
when you click the taskbar. (#528975)
svn path=/trunk/; revision=21218
2008-08-26 Matthias Clasen <mclasen@redhat.com>
Bug 549354 – Crash trying to open a file on a remote folder
* gtk/gtkfilechooserdefault.c (error_message_with_parent): Handle
the fact that parent may be NULL without crashing.
svn path=/trunk/; revision=21206
* gtk/gtksettings.c: When reconstructing the color hash, try
harder to avoid unnecessary notification, since this can lead
to infinite reloading of rc files in some situations.
svn path=/trunk/; revision=21182
2008-08-21 Cody Russell <bratsche@gnome.org>
* gdk/win32/gdkevents-win32.c (doesnt_want_key): Remove the checks
to see if the window is modally blocked. This doesn't get us anything,
and it confuses the search window in GtkTreeView (and potentially other
utility windows in other apps). (#520165)
svn path=/trunk/; revision=21180
2008-08-21 Marek Kasik <mkasik@redhat.com>
Bug 545875 – evo crashed when trying to print pages 6-7 of a 1 page
email
* gtk/gtkprintoperation.c: Clamp page ranges to correct ranges
svn path=/trunk/; revision=21177
+
+ * gdk/x11/gdkscreen-x11.c (_gdk_x11_screen_size_changed): Emit the
+ monitors changed signal when the screen size changes.
+
svn path=/trunk/; revision=21172
2008-08-05 Milan Crha <mcrha@redhat.com>
* gtk/gtknotebook.c: (gtk_notebook_do_arrow): Allow changing page with
arrows even on non-focusable notebook. (#528091)
svn path=/trunk/; revision=21170
2008-08-19 Björn Lindqvist <bjourne@gmail.com>
Bug 548354 – Remove repeated code in gtk_cell_view_size_allocate
* gtk/gtkcellview.c (gtk_cell_view_size_allocate): Remove some
code duplication, no need for separate loops for GTK_PACK_START
and GTK_PACK_END.
svn path=/trunk/; revision=21158
2008-08-19 Johan Dahlin <johan@gnome.org>
* gtk/gtk-builder-convert (GtkBuilderConverter._parse):
Remove the requres-version tag as well
svn path=/trunk/; revision=21157
* gtk/gtkcalendar.c (gtk_calendar_class_init()): Limit the "year"
property to G_MAXINT >> 9, instead of G_MAXINT >> 8: year_to_days()
multiplies the year property with 365 and returns the result as
glong. Therefore ceil(log(365, 2)) = 9 bits must be available,
not just 8 bits.
svn path=/trunk/; revision=21150
2008-08-18 Björn Lindqvist <bjourne@gmail.com>
Bug 541315 – Segfault when selecting a GtkMenuItem with submenu
and no parent
* gtk/gtkmenuitem.c (gtk_menu_item_real_popup_submenu): Ensure
that the menu item has a parent before popping it up.
svn path=/trunk/; revision=21149
2008-08-15 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkdrawable-quartz.c (gdk_quartz_draw_drawable): Some
aftermath of the fix of bug #543868. Clip and flip to the source,
not the destination. Don't save/restore the gstate, it's already
done when getting/releasing the context.
svn path=/trunk/; revision=21136
2008-08-15 Sven Herzberg <sven@imendio.com>
Use the g_test_*() API for this test
reviewed by: Richard Hult
* gdk/tests/check-gdk-cairo.c: use the g_test_*() API to permit adding
new tests
svn path=/trunk/; revision=21133
2008-08-15 Sven Herzberg <sven@imendio.com>
Prepare for using the g_test_*() API
reviewed by: Richard Hult
* gdk/tests/check-gdk-cairo.c: use assertions instead of returning an
error code
svn path=/trunk/; revision=21132
2008-08-13 Michael Natterer <mitch@imendio.com>
* gtk/gtkstock.c (gtk_stock_lookup): cast the return value of
g_dgettext() to fix warning about discarded qualifier.
svn path=/trunk/; revision=21106
2008-08-12 Paolo Borelli <pborelli@katamail.com>
* gtk/gtkclipboard.c (gtk_clipboard_store):
use canonical signal name.
svn path=/trunk/; revision=21104
2008-08-12 Paolo Borelli <pborelli@katamail.com>
Bug 526234 - make shift+ctrl+del delete till the end of line
* gtk/gtktextview.c: add shift+ctrl+del and shift+ctrl+backspace
keyboard shortcuts to delete to the end/start of the current line.
svn path=/trunk/; revision=21103
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/gtklinkbutton.c (set_link_color): bail out if there is no
label to set the color on.
(gtk_link_button_add): call set_link_color() so the label gets
the right color no matter how the link button is created.
svn path=/trunk/; revision=21100
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/gtkassistant.c: remove unused variable and fix formatting of
some function headers.
svn path=/trunk/; revision=21099
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/gtkstatusicon.c (gtk_status_icon_get_gicon): use
g_return_val_if_fail() now that the function has a return value.
svn path=/trunk/; revision=21095
2008-08-12 Sven Neumann <sven@gimp.org>
* gtk/gtknotebook.c
* gtk/gtkradiotoolbutton.c: property nick and blurb should be
marked with P_(), not _().
svn path=/trunk/; revision=21091
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/*.c: consistently chain up using
GTK_FOO_CLASS(parent_class)->bar(instance) instead of
(*GTK_FOO_CLASS(parent_class))->bar(instance).
svn path=/trunk/; revision=21085
2008-08-11 Michael Natterer <mitch@imendio.com>
Bug 546754 – 2.13.6 update create rendering issue in the evolution
composer
* gtk/gtkadjustment.c: instead of CLAMP(), use
value = MIN (value, upper - page_size);
value = MAX (value, lower);
so we don't end up below lower if upper - page_size is smaller
than lower.
svn path=/trunk/; revision=21080
2008-08-11 Michael Natterer <mitch@imendio.com>
Bug 547270 – Make GtkHSV public
* gtk/Makefile.am
* gtk/gtk.h: install gtkhsv.h as public header (its symbols were
always public anyway).
* gtk/gtkhsv.h: add single-include guards, add class struct padding,
seal the instance member, cleanup.
* gtk/gtkhsv.c: center the widget in its allocation,
add "Since: 2.14", cleanup.
svn path=/trunk/; revision=21078
2008-08-11 Michael Natterer <mitch@imendio.com>
* demos/gtk-demo/textscroll.c (create_text_view): don't use the
deprecated gtk_box_pack_start_defaults().
svn path=/trunk/; revision=21062
2008-08-09 Sven Herzberg <sven@imendio.com>
Bug 544863 – gtkquartz.h not included in released 2.13.5 package
* gtk/Makefile.am: always add gtkquartz.h to EXTRA_DIST
svn path=/trunk/; revision=21052
2008-08-08 Cody Russell <bratsche@gnome.org>
* gtk/gtkmenushell.c
* gtk/gtkmenu.c: In enter/leave notify events, check that the crossing
mode is not GTK_GRAB, GTK_UNGRAB, or STATE_CHANGED. Fixes regressions
in menus caused by bug #56070.
svn path=/trunk/; revision=21049
2008-08-09 Sven Herzberg <sven@imendio.com>
Get the gdk+cairo test to pass distcheck, too
* gdk/tests/Makefile.am: set GDK_PIXBUF_MODULE_FILE so the test can
pick up the one created at build time
* gdk/tests/check-gdk-cairo.c (main): delete the output files after a
successful test run
svn path=/trunk/; revision=21048
2008-08-07 16:19:16 Tim Janik <timj@imendio.com>
* gdk/gdkrgb.c (gdk_rgb_select_conv): use g_error() instead of a
combination of g_warning+exit to avoid misleading the user.
svn path=/trunk/; revision=21037
2008-08-07 Michael Natterer <mitch@imendio.com>
Bug 546756 – gnome-panel crashed with SIGSEGV in
g_type_check_instance_cast()
* gtk/gtkimagemenuitem.c: add GtkObject::destroy() implementation
and remove the image now that it's an internal child and isn't
destroyed by gtk_container_destroy() any longer. Thanks to tml for
helping bisecting this down.
svn path=/trunk/; revision=21034
2008-08-07 Sven Neumann <sven@gimp.org>
Bug 546771 - Add writable property "visited" to GtkLinkButton
* gtk/gtk.symbols
* gtk/gtklinkbutton.[ch]: expose the 'visited' state as a
read-write property with getters and setters. Also move the nick
and blurb of the "uri" property to the proper translation
domain.
svn path=/trunk/; revision=21032
2008-08-07 Michael Natterer <mitch@imendio.com>
* gtk/gtkicontheme.c (apply_emblems): move variables to local
scopes, fix indentation and silence bogus warning about using
uninitialized variables.
svn path=/trunk/; revision=21031
2008-08-07 Emmanuele Bassi <ebassi@gnome.org>
Bug 545031 – list of recently used files is created world-readable
* gtk/gtkrecentmanager.c:
(gtk_recent_manager_real_changed): Set the recently-used.xbel
file to 0600. (Guido Berhoerster)
svn path=/trunk/; revision=21028
2008-08-06 Michael Natterer <mitch@imendio.com>
* gtk/gtkcombobox.c
* gtk/gtkiconview.c
* gtk/gtkrange.c
* gtk/gtkscrolledwindow.c
* gtk/gtktreeview.c: remove CLAMPing from values passed to
gtk_adjustment_set_value() since it does it right now.
svn path=/trunk/; revision=21021
2008-08-05 Michael Natterer <mitch@imendio.com>
* gtk/gtkcombobox.c (gtk_combo_box_update_sensitivity): bail out
early if priv->button is NULL to avoid zillions of warnings when
destroying combo boxes that were working fine before the
button sensitivity patch.
svn path=/trunk/; revision=21014
2008-08-05 Michael Natterer <mitch@imendio.com>
Bug 544858 – Seal GtkAdjustment
* gtk/gtk.symbols
* gtk/gtkadjustment.[ch] (struct GtkAdjustment): seal all struct
members.
Add accessors for all properties and additionally a new function
gtk_adjustment_configure() which sets all properties at
once. Patch by Christian Dywan and myself.
svn path=/trunk/; revision=21013
2008-08-05 Michael Natterer <mitch@imendio.com>
* gtk/gtkadjustment.c (gtk_adjustment_set_value): clamp the value
to [lower...upper-page_size] instead of only [lower...upper].
* README: add note about this change.
While this fix is correct and should have been there forever, it
has the potential to break some corner cases, however these cases
would set page_size to a value != 0 which suggests they want it
honored.
svn path=/trunk/; revision=21012
2008-08-05 Michael Natterer <mitch@imendio.com>
* tests/testiconview.c: don't use the deprecated
gtk_box_pack_start_defaults().
svn path=/trunk/; revision=21010
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/gtktext.c: Cast pointer to gintptr instead of gulong to
avoid warning on Win64.
svn path=/trunk/; revision=21003
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/gtkgc.c: Cast tile, stipple and clip_mask pointers to
gintptr when calculating hash, so we get all of the pointer bits
on Win64 where long is 32 bits.
svn path=/trunk/; revision=21002
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/gtkprintoperation-win32.c: Don't need to declare
IPrintDialogCallback with mingw64 either. It seems to come with
newer versions of the headers.
svn path=/trunk/; revision=21001
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gtk/gtksocket-win32.c: Don't cast HWND to guint, pass it as such
as the GdkNativeWindow parameter to
gtk_window_remove_embedded_xid(). Debugging printout format fixes.
* gtk/gtkwin32embed.h
* gtk/gtkwin32embed.c: Change the types of wparam and lparam
parameters to actually be WPARAM and LPARAM.
* gtk/gtkplug-win32.c: Adapt accordingly.
svn path=/trunk/; revision=21000
2008-08-04 Matthias Clasen <mclasen@redhat.com>
Bug 382291 – Automatically dim the combobox when the model is empty
* gtk/gtk.symbols:
* gtkcombobox.[hc]: Add a GtkComboBox::button-sensitivity
property with getter and setter to control the sensitity of
empty combo boxes. Patch by Carlos Garnacho, Sven Herzberg,
Christian Dywan and others.
* README.in: Add a note about automatic combobox sensitivity.
svn path=/trunk/; revision=20997
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/updateiconcache.c (write_bucket): Enclose ?: expression
with parens so cast covers all of it.
svn path=/trunk/; revision=20996
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gdk/win32/gdkcursor-win32.c
* gdk/win32/xcursors.h: Change some gchar* to guchar* and vice
versa to avoid gcc 4.4 signedness warnings.
* gdk/win32/gdkevents-win32.c: Add some guchar and char pointer
casts to get rid of gcc 4.4 signedness warnings. Print GdkAtom
values in debugging output using the %p format.
* gdk/win32/gdkkeys-win32.c
* gdk/win32/gdkfont-win32.c
* gdk/win32/gdkmain-win32.c: Add some casts to avoid gcc warnings.
* gdk/win32/gdkwindow-win32.c: Use SetWindowLongPtr() instead of
SetWindowLong().
* gdk/win32/gdkwin32id.c (gdk_handle_hash): Use all 64 bits of a
HANDLE on Win64.
svn path=/trunk/; revision=20994
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gdk/win32/gdkproperty-win32.c
* gdk/win32/gdkselection-win32.c: Add some guchar and char pointer
casts to get rid of gcc 4.4 warnings. Print GdkAtom values in
debugging output using the %p format.
svn path=/trunk/; revision=20993
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gtk/gtkwindow.h
* gtk/gtkwindow.c: Change the type of the xid parameter of the
internal gtk_window_remove_embedded_xid() and
gtk_window_add_embedded_xid() functions from guint to
GdkNativeWindow.
* gtk/gtkwindow.c (send_client_message_to_embedded_windows):
Instead of GPOINTER_TO_UINT(), just cast the gpointer to
GdkNativeWindow. GPOINTER_TO_UINT() drops the upper 32 bits on
Win64.
svn path=/trunk/; revision=20992
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gdk/gdkselection.h
* gdk/gdkselection.c
* gdk/win32/gdkselection-win32.c
* gdk/x11/gdkselection-x11.c: Change type of the requestor
window id parameter of gdk_selection_send_notify_for_display()
and gdk_selection_send_notify() from guint32 to
GdkNativeWindow.
* gdk/win32/gdkselection-win32.c: Add some guchar and char pointer
casts to get rid of gcc 4.4 warnings. Print GdkAtom values in
debugging output using the %p format.
svn path=/trunk/; revision=20991
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gdk/gdkdnd.h
* gdk/gdkdnd.c
* gdk/win32/gdkdnd-win32.c
* gdk/x11/gdkdnd-x11.c: Change return value and type of window id
from guint32 to GdkNativeWindow for
gdk_drag_get_protocol_for_display() and
gdk_drag_get_protocol(). This is not an API break on existing
platforms, as GdkNativeWindow has been guint32 for them
already.
svn path=/trunk/; revision=20989
2008-08-05 Tor Lillqvist <tml@novell.com>
* gdk/gdkrgb.c: Cast pointers to guintptr, not unsigned long,
before doing bit tests on them.
svn path=/trunk/; revision=20987