Commit Graph

10797 Commits

Author SHA1 Message Date
Richard Hult
b29d3d4082 Bug 554141 – uninitialized data use/free in gtkclipboard-quartz.c
2008-09-29  Richard Hult  <richard@imendio.com>

	Bug 554141 – uninitialized data use/free in gtkclipboard-quartz.c

	* gtk/gtkclipboard-quartz.c: (gtk_clipboard_wait_for_contents):
	Patch from Jon A. Cruz to initialize the allocated selection data.

svn path=/trunk/; revision=21540
2008-09-29 10:41:07 +00:00
Matthias Clasen
3f8d98b94d Bug 339367 – Incorrect spotlocation
2008-09-27  Matthias Clasen  <mclasen@redhat.com>

        Bug 339367 – Incorrect spotlocation

        * modules/input/gtkimcontextxim.c: Correct the spot location
        for on-the-spot style.

svn path=/trunk/; revision=21537
2008-09-28 03:21:15 +00:00
Denis Washington
f3b6806eda only draw keyboard focus when keyboard navigation is used, like
2008-09-27  Denis Washington  <denisw@svn.gnome.org>

	* gtk/gtkiconview.c: only draw keyboard focus when keyboard navigation
	is used, like GtkTreeView. (Bug #553575)

svn path=/trunk/; revision=21534
2008-09-27 12:53:05 +00:00
Matthias Clasen
783c7932f3 Bug 552959 – GtkTrayIcon: _NET_SYSTEM_TRAY_VISUAL and real
transparency

        * gtk/gtktrayicon-x11.c: Add support for the _BET_SYSTEM_TRAY_VISUAL
        property described in
        http://lists.freedesktop.org/archives/xdg/2008-September/009919.html
        If _NET_SYSTEM_TRAY_VISUAL is a visual with an alpha channel, the
        parent-relative-background hack is skipped and we draw with a real
        transparent background.

        * gtk/gtkrc.c: Remove the default GtkTrayIcon style, since the
        parent-relative background is now set when realizing the tray
        icon.

        Patch by Owen Taylor


svn path=/trunk/; revision=21531
2008-09-27 04:27:53 +00:00
Matthias Clasen
1a962664ee Bug 552956 – Should check composite extension version
2008-09-26  Matthias Clasen  <mclasen@redhat.com>

        Bug 552956 – Should check composite extension version

        * gdk/x11/gdkdisplay-x11.c: Check that the version of the
        composite extension is at least 0.4.
        Patch by Owen Taylor


svn path=/trunk/; revision=21530
2008-09-27 03:43:50 +00:00
Matthias Clasen
abe8d89fd9 Bug 553803 – eventually call XCloseDevice on XOpenDevice results
* gdk/x11/gdkinput.c: Add a finalize function for device objects,
        and call XCloseDevice there.

        * gdk/x11/gdkinput-x11.c:
        * gdk/x11/gdkdisplay-x11.c: Move freeing of device objects to
        the finalize function.
        Patch by Caolan McNamara


svn path=/trunk/; revision=21529
2008-09-27 00:47:45 +00:00
Matthias Clasen
474033176e Forgotten log entry
svn path=/trunk/; revision=21527
2008-09-27 00:20:42 +00:00
Matthias Clasen
9b320a62f1 Bug 553578 - tabs are not drawn correctly
2008-09-26  Matthias Clasen  <mclasen@redhat.com>

        Bug 553578 - tabs are not drawn correctly

        * gtk/gtknotebook.c: Track the visibility state of notebook tabs
        between allocations so that we know to redraw the tab labels if
        tabs are hidden and shown without changing position.
        Reported by Marek Kašík, patch by Owen Taylor.


svn path=/trunk/; revision=21525
2008-09-26 23:58:12 +00:00
Matthias Clasen
bc48caa272 Bug 553133 – GtkFileChooser won't ask to mount a volume
2008-09-26  Matthias Clasen  <mclasen@redhat.com>

        Bug 553133 – GtkFileChooser won't ask to mount a volume

        * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Use
        a GtkMountOperation when mounting, so that we get a password
        dialog when required.

svn path=/trunk/; revision=21523
2008-09-26 19:25:35 +00:00
Cody Russell
7e8ebe06f7 Bug 553917 – Typo in gdkwindow-win32.c
2008-09-26  Cody Russell  <bratsche@gnome.org>

        Bug 553917 – Typo in gdkwindow-win32.c

        * gdk/win32/gdkwindow-win32.c: Fixed a typo in 
        update_system_menu().  Changed GDK_DECOR_ALL to GDK_FUNC_ALL.

        Reported by Richard Hult


svn path=/trunk/; revision=21522
2008-09-26 16:47:58 +00:00
Marek Kasik
f96d7b972b Bug 553241 – double freed pointer in lpr_write cause firefox3 crash
2008-09-25  Marek Kasik  <mkasik@redhat.com>

	Bug 553241 – double freed pointer in lpr_write cause firefox3 crash

	* modules/printbackends/lpr/gtkprintbackendlpr.c:
	The redundant freeing of memory was removed.

	Patch by Chris Wang

svn path=/trunk/; revision=21516
2008-09-25 11:46:35 +00:00
Michael Natterer
23bcd6df88 don't unref the file system backend, the newly added
2008-09-25  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
	don't unref the file system backend, the newly added
	unset_file_system_backend() already does this (bug #553135).


svn path=/trunk/; revision=21514
2008-09-25 11:22:34 +00:00
Michael Natterer
eed535d6b2 events return gboolean not gint, reindented static prototypes.
2008-09-24  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkeventbox.c: events return gboolean not gint, reindented
	static prototypes.


svn path=/trunk/; revision=21513
2008-09-24 10:35:53 +00:00
Johan Dahlin
5fcfc7a368 Bug 553385 – gtk-builder-convert creates untranslated combobox models
2008-09-24  Johan Dahlin  <johan@gnome.org>

    Bug 553385 – gtk-builder-convert creates untranslated combobox models

    * gtk/gtk-builder-convert: Set the translatable property on
    col tags for converted combos.


svn path=/trunk/; revision=21512
2008-09-24 09:59:05 +00:00
Tor Lillqvist
57473511e5 Include all of share/man, lib/pkgconfig, share/aclocal and share/gtk-doc
2008-09-24  Tor Lillqvist  <tml@novell.com>

	* gtk-zip.sh.in: Include all of share/man, lib/pkgconfig,
	share/aclocal and share/gtk-doc instead of trying to list
	individual files or subdirectories. We had missed gail.pc, for
	instance.


svn path=/trunk/; revision=21511
2008-09-24 09:22:58 +00:00
Christian Dywan
9da63118e1 Bug 538782 – Make GtkMenu's arrow size themable
* gtk/gtkmenu.c (gtk_menu_class_init), (gtk_menu_paint):
Implement "arrow-scaling" style property in GtkMenu.

svn path=/trunk/; revision=21509
2008-09-24 08:56:10 +00:00
Christian Dywan
3a872a3c42 Bug 408244 – add GtkDialog::content-area-spacing
* gtk/gtkbox.c (gtk_box_init), (gtk_box_set_spacing),
(_gtk_box_set_spacing_set), (_gtk_box_get_spacing_set):
* gtk/gtkbox.h:
* gtk/gtkdialog.c (gtk_dialog_class_init), (update_spacings):
Implement "content-area-spacing" style property in GtkDialog
and internal helper _gtk_box_get_spacing_set in GtkBox.
Patch by Tim Janik, Sven Herzberg and myself.

svn path=/trunk/; revision=21508
2008-09-24 08:41:46 +00:00
Christian Dywan
0c5bfe5f2b Bug 541391 – Unfocussable Treeview swallows focus
* gtk/gtktreeview.c (grab_focus_and_unset_draw_keyfocus),
(gtk_tree_view_focus): Honor GTK_WIDGET_CAN_FOCUS properly

svn path=/trunk/; revision=21507
2008-09-24 08:19:51 +00:00
Denis Washington
bbc726431d draw focus as a rectangle around the complete item, not just the text.
2008-09-24  Denis Washington  <denisw@svn.gnome.org>

	* gtk/gtkiconview.c: draw focus as a rectangle around the
	complete item, not just the text. (Bug #38254)

svn path=/trunk/; revision=21506
2008-09-24 08:04:15 +00:00
Michael Natterer
781850fc64 gtk/gtkobject.c s/GtkType/GType/ and
2008-09-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkobject.c
	* gtk/gtksignal.[ch]: s/GtkType/GType/ and
	s/GtkSignalMarshaller/GSignalCMarshaller/.


svn path=/trunk/; revision=21498
2008-09-23 18:24:33 +00:00
Michael Natterer
014acf7565 remove unused variable and fix indentation.
2008-09-23  Michael Natterer  <mitch@imendio.com>

	* gdk/x11/gdkevents-x11.c (gdk_event_translate): remove unused
	variable and fix indentation.


svn path=/trunk/; revision=21496
2008-09-23 10:46:46 +00:00
Michael Natterer
4cdb97778a gtk/gtkclist.h gtk/gtkctree.h gtk/gtklist.h gtk/gtklistitem.h
2008-09-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.h
	* gtk/gtkctree.h
	* gtk/gtklist.h
	* gtk/gtklistitem.h
	* gtk/gtkobject.h
	* gtk/gtkoldeditable.h
	* gtk/gtkpixmap.h
	* gtk/gtkpreview.h
	* gtk/gtktext.h
	* gtk/gtktipsquery.h
	* gtk/gtktree.h
	* gtk/gtktreeitem.h: get rid of GtkType and GTK_CHECK_FOO() also
	in all deprecated headers.


svn path=/trunk/; revision=21495
2008-09-23 10:28:23 +00:00
Matthias Clasen
235480bd9c Bug 553135 – eog crash: assertion failed. Gtk error:
2008-09-22  Matthias Clasen  <mclasen@redhat.com>

        Bug 553135 – eog crash: assertion failed. Gtk error:
        shortcuts_remove_rows: code should not be reached

        * gtk/gtkfilechooserdefault.c: Disconnect from GtkFileSystem
        signals when we are destroyed, in order to avoid nasty surprises.
        Patch by Claudio Saavedra


svn path=/trunk/; revision=21492
2008-09-22 18:32:31 +00:00
Emmanuele Bassi
e27c3c1939 Bug 552789 – Show size column in the search and recently used files
2008-09-22  Emmanuele Bassi  <ebassi@linux.intel.com>

	Bug 552789 – Show size column in the search and recently used
	files modes

	* gtk/gtkfilechooserdefault.c: Display the file size column
	when in OPERATION_MODE_SEARCH. This removes a stat() call
	and simplifies the code a little bit by changing the query
	for file informations for each search engine hit.

svn path=/trunk/; revision=21491
2008-09-22 14:25:45 +00:00
Michael Natterer
1dc24ea3a5 gtk/gtksignal.[ch] gtk/gtkclist.c gtk/gtklist.c gtk/gtkmain.c
2008-09-22  Michael Natterer  <mitch@imendio.com>

	* gtk/gtksignal.[ch]
	* gtk/gtkclist.c
	* gtk/gtklist.c
	* gtk/gtkmain.c
	* gtk/gtktext.c
	* gtk/gtktreeitem.c: use G_CALLBACK and GCallback instead of
	GTK_SIGNAL_FUNC and GtkSignalFunc also in deprecated code.


svn path=/trunk/; revision=21488
2008-09-22 10:35:44 +00:00
Frederic Crozat
d89074b428 use the correct gi18n header. Fixes bug #553000.
2008-09-22  Frederic Crozat  <fcrozat@mandriva.com>

        * gtk/gtkfilesystem.c: use the correct gi18n header.
        Fixes bug #553000.


svn path=/trunk/; revision=21486
2008-09-22 08:55:58 +00:00
Michael Natterer
3215e56501 add "Deprecated: 2.4" to all the deprecated append(), prepend() and
2008-09-22  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktoolbar.[ch]: add "Deprecated: 2.4" to all the deprecated
	append(), prepend() and insert() functions and recommend to use
	gtk_toolbar_insert() instead. Use GCallback instead of
	GtkSignalFunc even in deprecated API.


svn path=/trunk/; revision=21485
2008-09-22 08:35:21 +00:00
Matthias Clasen
50d7cf9db4 Don't leak a GFile
svn path=/trunk/; revision=21468
2008-09-21 05:21:00 +00:00
Michael Natterer
58be13491e Fix ChangeLog to fit in 80 columns.
svn path=/trunk/; revision=21463
2008-09-20 10:30:40 +00:00
Owen Taylor
b48fc37a2c Small cleanups to debug messages for GtkPlug/GtkSocket
2008-09-19  Owen Taylor  <otaylor@redhat.com>

        Small cleanups to debug messages for GtkPlug/GtkSocket

        * gtk/gtksocket-x11.c: Fix debug message to say "Socket" not "Plug"
        * gtk/gtkplug-x11.c: Remove excess newlines from the ends of debug messages.

svn path=/trunk/; revision=21458
2008-09-19 22:52:33 +00:00
Carlos Garnacho
ee06ce951b Bug 83935 – GtkEntry's default invisible char should be U+25CF
2008-09-19  Carlos Garnacho  <carlos@imendio.com>

        Bug 83935 – GtkEntry's default invisible char should be U+25CF

        * gtk/gtkentry.c (find_invisible_char) (gtk_entry_init): Find a
        more suitable invisible char than '*' based on the used font.
        (gtk_entry_class_init) (gtk_entry_set_property)
        (gtk_entry_get_property): Add a "invisible-char-set" property.
        (gtk_entry_unset_invisible_char): New function, needed now that the
        default invisible char isn't fixed.
        * gtk/gtkentry.h:
        * gtk/gtk.symbols:
        * docs/reference/gtk/gtk-sections.txt: Add the new function.

svn path=/trunk/; revision=21446
2008-09-19 13:45:07 +00:00
Christian Persch
34b3bb8c5f Bug 552837 – mem leak in gtkimmulticontext
* gtk/gtkimmulticontext.c: (gtk_im_multicontext_get_slave): Plug mem
 	leak.

svn path=/trunk/; revision=21445
2008-09-19 12:28:30 +00:00
Emmanuele Bassi
d5a173b4ed Save the size column visibility state with the rest of the FileChooser
2008-09-18  Emmanuele Bassi  <ebassi@linux.intel.com>

	* gtk/gtkfilechooserdefault.c (settings_save): Save the size column
	visibility state with the rest of the FileChooser settings.

svn path=/trunk/; revision=21437
2008-09-18 22:00:53 +00:00
Emmanuele Bassi
555ef89dc3 Bug 325095 – show a 'size' column
2008-09-18  Emmanuele Bassi  <ebassi@linux.intel.com>

	Bug 325095 – show a 'size' column

	* gtk/gtkfilechooserdefault.c:
	* gtk/gtkfilechooserprivate.h: Add a context menu item controlling
	the visibility of the file size column. This works only for the
	browse mode, and the column is not visible by default.

	* gtk/gtkfilechoosersettings.[ch]: Add a ShowSizeColumn key to the
	settings file.

svn path=/trunk/; revision=21431
2008-09-18 15:29:33 +00:00
Dominic Lachowicz
8bfc826f27 Revert most of previous patch, as it didn't work as expected; Some work
2008-09-18  Dominic Lachowicz  <domlachowicz@gmail.com>

        * modules/engines/ms-windows/*: Revert most of previous patch, as it didn't work as expected;
        Some work toward #531086 - the new GtkTooltip widget doesn't theme properly on win32. Now, at least
        the background color seems okay
w

svn path=/trunk/; revision=21430
2008-09-18 15:28:19 +00:00
Dominic Lachowicz
9194e5ac44 MS Windows style should use pango_win32_font_description_from_logfont;
2008-09-18  Dominic Lachowicz  <domlachowicz@gmail.com>

        * modules/engins/ms-windows/*: MS Windows style should use pango_win32_font_description_from_logfont;
        Allows us to rip out a lot of potentially buggy code, and also get the font specification from the
        XP theme (#434987)


svn path=/trunk/; revision=21429
2008-09-18 15:02:53 +00:00
Matthias Clasen
9b428cd6f7 updated version number to 2.15.0 for development.
2008-09-18  Matthias Clasen  <mclasen@redhat.com>

        * configure.in: updated version number to 2.15.0 for development.

        * ChangeLog.pre-2-14: rotate ChangeLog

=== Branch for 2.14 ===


svn path=/trunk/; revision=21428
2008-09-18 14:55:35 +00:00
Matthias Clasen
a20075a75f Bump version
svn path=/trunk/; revision=21422
2008-09-18 04:32:47 +00:00
Matthias Clasen
3a6b0693b9 2.14.2
svn path=/trunk/; revision=21420
2008-09-18 04:30:42 +00:00
Matthias Clasen
e3a1d85d64 Updates
svn path=/trunk/; revision=21419
2008-09-18 02:52:51 +00:00
Matthias Clasen
8ec27f7760 Bug 346903 – gtk_enumerate_printers needs events to complete
2008-09-17  Matthias Clasen  <mclasen@redhat.com>

        Bug 346903 – gtk_enumerate_printers needs events to complete

        * gtk/gtkprintbackend.h:
        * gtk/gtkprintbackend.c: Add a GtkPrintBackend::status property.

        * modules/printbackends/cups/gtkcupsutils.h:
        * modules/printbackends/cups/gtkcupsutils.c: Turn the connection
        test into a tristate available/unavailable/in progress.

        * modules/printbackends/cups/gtkprintbackendcups.c: Use a single
        connection test instance for getting the default printer and for
        getting the printer list. Set the GtkPrintBackend::status property
        according to the result of the connection test. Use the printer-type
        attribute to find the default printer, if cups supports it.

        * gtk/gtkprinter.c: When enumerating printers, give up when
        the backend status is 'unavailable'.

        * gtk/gtkprintunixdialog.c (printer_status_cb): Select the printer
        when it is the default and nothing else has been selected yet.


svn path=/trunk/; revision=21417
2008-09-17 22:07:10 +00:00
Christian Persch
df619a1370 Bug 552668 – format not a string literal and no format arguments in
gtkimmodule

svn path=/trunk/; revision=21416
2008-09-17 19:56:19 +00:00
Christian Persch
7b533d0492 Bug 552667 – gtkimage containing gicon leaks memory
* gtk/gtkimage.c: (ensure_pixbuf_for_gicon): Fix critical warnings
	when looking up the icon fails. Plug a mem leak.

svn path=/trunk/; revision=21415
2008-09-17 18:09:13 +00:00
Matthias Clasen
1df29bcae8 Bug 329593 – Entering characters on a line very cpu intensive and
slow

        * gtk/gtknotebook.c (gtk_notebook_page_allocate): Return a boolean
        that indicates whether the tab allocation has changed.
        (gtk_notebook_pages_allocate): Only redraw the tabs if their
        allocation has changed.
        (gtk_notebook_calculate_tabs_allocations): Remove unused return value.
        Patch by Owen Taylor


svn path=/trunk/; revision=21414
2008-09-17 16:02:26 +00:00
Matthias Clasen
0f397dcccc Bug 408154 – [PATCH] Change GtkEntryCompletion max-items to style
2008-09-17  Matthias Clasen  <mclasen@redhat.com>

        Bug 408154 – [PATCH] Change GtkEntryCompletion max-items to style
        property

        * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
        Take actions into account when finding the available space for
        matches. Patch by Ross Burton


svn path=/trunk/; revision=21413
2008-09-17 15:22:52 +00:00
Matthias Clasen
5f9c268e56 Doc improvements
svn path=/trunk/; revision=21412
2008-09-17 15:13:15 +00:00
Matthias Clasen
c35ea43d67 Bug 552107 – Small libtool fixes
2008-09-17  Matthias Clasen  <mclasen@redhat.com>

        Bug 552107 – Small libtool fixes

        * configure.in: Regenerate libtool early, quote $deplibs_check_method.
        Patch by Patryk Zawadzki


svn path=/trunk/; revision=21411
2008-09-17 15:10:30 +00:00
Matthias Clasen
ed877089bd Bug 551722 – gtk_widget_set_scroll_adjustments() should check the signal
2008-09-17  Matthias Clasen  <mclasen@redhat.com>

        Bug 551722 – gtk_widget_set_scroll_adjustments() should check the
        signal signature

        * gtk/gtkwidget.c (gtk_widget_set_scroll_adjustments): Check the
        signature of the signal. Patch by Christian Persch


svn path=/trunk/; revision=21410
2008-09-17 15:07:32 +00:00
Michael Natterer
eca33d60be don't access widget->window if the widget is not realized.
2008-09-16  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkwidget.c (_gtk_widget_set,get_pointer_window): don't
	access widget->window if the widget is not realized.


svn path=/trunk/; revision=21403
2008-09-16 17:47:30 +00:00
Matthias Clasen
a6674b9ea8 Bug 551987 – GtkPaned redrawing problem
2008-09-16  Matthias Clasen  <mclasen@redhat.com>

        Bug 551987 – GtkPaned redrawing problem

        * gtk/gtkpaned.c: Remove excess invalidations. Patch by Owen Taylor



svn path=/trunk/; revision=21400
2008-09-16 04:54:13 +00:00