Commit Graph

10872 Commits

Author SHA1 Message Date
Matthias Clasen
cdef5cdc49 Bug 557524 – "va_end(args);" should be added into
2008-10-24  Matthias Clasen  <mclasen@redhat.com>

        Bug 557524 – "va_end(args);" should be added into
        gtk_text_buffer_insert_with_tags_by_name( )

        * gtk/gtktextbuffer.c (gtk_text_buffer_insert_with_tags_by_name):
        Don't forget to call va_end. Pointed out by Boram Park


svn path=/trunk/; revision=21706
2008-10-24 04:16:07 +00:00
Alexander Larsson
fb55cf75f0 Bug 528320 - Incorrect icons displayed for files with custom mimetype
2008-10-23  Alexander Larsson  <alexl@redhat.com>

	Bug 528320 - Incorrect icons displayed for files with custom mimetype icons
	
        * gtk/gtkfilesystem.c:
        (_gtk_file_info_render_icon):
	Fall back on default file icon if there was no icon or it
	was not found in the theme. This goes with the corresponding
	change in glib to not add the fallback icon, but is useful
	in other cases too.



svn path=/trunk/; revision=21702
2008-10-23 09:59:46 +00:00
Behdad Esfahbod
e108b3d2d9 Bug 555920 – gtkentry.c passes wrong enum to
2008-10-22  Behdad Esfahbod  <behdad@gnome.org>

        Bug 555920 – gtkentry.c passes wrong enum to
        pango_layout_set_alignment()

        * gtk/gtkentry.c (gtk_entry_create_layout): Don't set layout 
        adjustment.


svn path=/trunk/; revision=21700
2008-10-22 21:02:23 +00:00
Matthias Clasen
aadac20e90 Only emit size-changed if the screen size actually changed.
2008-10-22  Matthias Clasen  <mclasen@redhat.com>

        * gdk/x11/gdkscreen-x11.c: Only emit size-changed if the screen
        size actually changed.


svn path=/trunk/; revision=21698
2008-10-22 14:55:56 +00:00
Michael Natterer
6df89b0ad8 gdk/gdkdraw.c gdk/gdkimage.c gdk/gdkscreen.c replace assertions for obj !=
2008-10-21  Michael Natterer  <mitch@imendio.com>

	* gdk/gdkdraw.c
	* gdk/gdkimage.c
	* gdk/gdkscreen.c
	* gdk/gdkwindow.c: replace assertions for obj != NULL by
	GDK_IS_OBJ(), remove redundant != NULL checks when there is
	already a type check, add some g_return_if_fail() that were
	missing entirely, fix some broken indentation and spacing.


svn path=/trunk/; revision=21695
2008-10-21 21:42:39 +00:00
Tor Lillqvist
c103cbec8a Bug 557266 - Window Management Problem
2008-10-21  Tor Lillqvist  <tml@novell.com>

	Bug 557266 - Window Management Problem

	Also reported in mail to gtk-list, and of course it has been well
	known in general that window state management is messy and buggy
	in various ways in gdk/win32.

	* gdk/win32/gdkwindow-win32.c (show_window_internal): Correct
	handling of GDK_WINDOW_STATE_ABOVE windows. It doesn't work to set
	the WS_EX_TOPMOST extended style bit using SetWindowLong(). We
	must call SetWindowPos() on the window using HWND_TOPMOST
	instead. The description for WS_EX_TOPMOST in the documentation
	for CreateWindowEx() even implies that if you read it carefully.


svn path=/trunk/; revision=21694
2008-10-21 20:31:05 +00:00
Michael Natterer
def00e8821 reorder functions to be in standard order, add prototypes and namespace to
2008-10-21  Michael Natterer  <mitch@imendio.com>

	* gdk/gdkapplaunchcontext.c: reorder functions to be in standard
	order, add prototypes and namespace to static functions, add
	g_return_if_fail()s which were missing all over the place.


svn path=/trunk/; revision=21692
2008-10-21 20:20:50 +00:00
Christian Persch
4ba6262be9 Bug 557059 – crash when compositing emblems with icon
2008-10-20  Christian Persch  <chpe@gnome.org>

	Bug 557059 – crash when compositing emblems with icon

	* gtk/gtkicontheme.c: (apply_emblems): Copy the pixbuf before using it
	with gtk_pixbuf_composite, in case its pixdata is read-only (mmaped
	from icon cache or builtins).

svn path=/trunk/; revision=21690
2008-10-20 16:55:00 +00:00
Murray Cumming
093d425393 gtk_icon_view_set_tooltip_row(), gtk_icon_view_set_tooltip_item():
2008-10-20  Murray Cumming  <murrayc@murrayc.com>

* gtk/gtkiconview.c: gtk_icon_view_set_tooltip_row(), 
gtk_icon_view_set_tooltip_item():
* gtk/gtktreeview.c: gtk_icon_view_set_tooltip_row(), 
gtk_icon_view_set_tooltip_cell():
Documentation: Mention the simple set_tooltip_column() 
alternative.

svn path=/trunk/; revision=21689
2008-10-20 12:11:05 +00:00
Tor Lillqvist
a7dd74740a On WM_WINDOWPOSCHANGING, don't dereference windowpos in the debugging
2008-10-18  Tor Lillqvist  <tml@novell.com>

	* gdk/win32/gdkevents-win32.c (gdk_event_translate): On
	WM_WINDOWPOSCHANGING, don't dereference windowpos in the debugging
	output without setting it first.

2008-10-18  Tor Lillqvist  <tml@novell.com>

	Bug 556578 - GIMP windows stay on top of other windows

	* gdk/win32/gdkevents-win32.c (ensure_stacking_on_unminimize)
	(ensure_stacking_on_window_pos_changing)
	(ensure_stacking_on_activate_app): Ignore unmapped windows in the
	loops where we look for the lowest "transient-type" window.

	(gdk_event_translate): Don't call
	ensure_stacking_on_window_pos_changing() or
	ensure_stacking_on_activate_app() for unmapped windows.


svn path=/trunk/; revision=21676
2008-10-17 22:56:33 +00:00
Marek Kasik
17a64e8841 Bug 556527 - The current page property is not passed to GtkPrintUnixDialog
2008-10-16  Marek Kasik  <mkasik@redhat.com>

	Bug 556527 - The current page property is not passed to
	GtkPrintUnixDialog

	* gtk/gtkprintoperation-unix.c: pass current-page property
	to GtkPrintUnixDialog

svn path=/trunk/; revision=21660
2008-10-16 11:20:33 +00:00
Michael Natterer
51e3443d7d fix typo in the type name so the macro becomes usable.
2008-10-15  Michael Natterer  <mitch@imendio.com>

	* gdk/gdkapplaunchcontext.h (GDK_IS_APP_LAUNCH_CONTEXT): fix typo
	in the type name so the macro becomes usable.


svn path=/trunk/; revision=21658
2008-10-15 15:50:10 +00:00
Christian Dywan
ca872e8845 556150 – gtk 'object' property test fixing
* gtk/tests/object.c (list_ignore_properties):
Remove some recently fixed properties from the exception list

svn path=/trunk/; revision=21653
2008-10-14 13:23:44 +00:00
Matthias Clasen
2377e48038 Bug 555779 – GtkCellRendererPixbuf crashed on failed GIcon lookup
2008-10-13  Matthias Clasen  <mclasen@redhat.com>

        Bug 555779 – GtkCellRendererPixbuf crashed on failed GIcon lookup

        * gtk/gtkcellrendererpixbuf
        (gtk_cell_renderer_pixbuf_create_themed_pixbuf): Don't crash
        if a GIcon is not present in the current theme. Patch by
        Alex Larsson.


svn path=/trunk/; revision=21650
2008-10-14 03:47:18 +00:00
Matthias Clasen
784896ae1e Bug 552318 – menubar mnemonics consumed even when
2008-10-13  Matthias Clasen  <mclasen@redhat.com>

        Bug 552318 – menubar mnemonics consumed even when
        gtk-enable-mnemonics=false

        * gtk/gtkwindow.c (gtk_window_activate_key): Don't let mnemonic
        entries block accelerator activation when gtk-enable-mnemonics is
        FALSE. Problem reported by Andreas Moog.


svn path=/trunk/; revision=21648
2008-10-14 02:00:11 +00:00
Cody Russell
9e3de2fe7f Fix option parsing so that -a and --action work correctly.
2008-10-13  Cody Russell <cody@jhu.edu>

        * test/testfilechooser.c: Fix option parsing so that -a and
        --action work correctly.


svn path=/trunk/; revision=21645
2008-10-13 15:15:23 +00:00
Christian Persch
aadcba2dc5 Bug 555386 – format not a string literal and no format arguments
svn path=/trunk/; revision=21642
2008-10-13 12:54:45 +00:00
Christian Persch
e68135a992 Bug 555724 – gtkcellrendereraccel not initialised correctly
svn path=/trunk/; revision=21641
2008-10-13 12:54:39 +00:00
Simos Xenitellis
77a980ec79 Closed #555625 – Updated gtk_compose_seqs_compact table (gtkimcontextsimpleseqs.h)
svn path=/trunk/; revision=21634
2008-10-12 16:11:48 +00:00
Matthias Clasen
7f78ec24a8 Revert the GtkSettings::gtk-toolbar-icon-size part of the previous change,
2008-10-11  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtktoolbar.c: Revert the GtkSettings::gtk-toolbar-icon-size
        part of the previous change, since it doesn't work correctly without
        extra complication, and using custom icon sizes doesn't make too
        much sense in a desktop-wide setting.


svn path=/trunk/; revision=21633
2008-10-12 15:27:57 +00:00
Matthias Clasen
4dc4227c70 Bug 555186 – Setting gtk-toolbar-icon-size with custom icon_size
2008-10-11  Matthias Clasen  <mclasen@redhat.com>

        Bug 555186 – Setting gtk-toolbar-icon-size with custom icon_size

        * gtk/gtktoolbar.c: Turn GtkToolbar::icon-size and
        GtkSettings::gtk-toolbar-icon-size into int properties, to
        allow the use of app-registered icon sizes.


svn path=/trunk/; revision=21632
2008-10-12 03:17:16 +00:00
Christian Dywan
4630182ec4 Bug 555676 – gtk_widget_real_grab_focus assumes toplevel == window
* gtk/gtkwidget.c (gtk_widget_real_grab_focus):
Actually test for GTK_IS_WINDOW *and* GTK_WIDGET_TOPLEVEL

svn path=/trunk/; revision=21631
2008-10-11 03:37:47 +00:00
Behdad Esfahbod
c28bb76f4b Bug 551355 – [PATCH] Make glib build with libtool 2.2
2008-10-10  Behdad Esfahbod  <behdad@gnome.org>

        Bug 551355 – [PATCH] Make glib build with libtool 2.2

        * autogen.sh: Accept libtool 2.2.   We are moving towards having
        it working.


svn path=/trunk/; revision=21630
2008-10-11 00:05:31 +00:00
Richard Hult
4dbea21c81 Add empty stub to fix linking.
2008-10-10  Richard Hult  <richard@imendio.com>

	* gdk/quartz/gdkkeys-quartz.c: (gdk_keymap_get_caps_lock_state)
	Add empty stub to fix linking.

svn path=/trunk/; revision=21629
2008-10-10 13:38:05 +00:00
Simos Xenitellis
23caa73f9b Fixed Bug 555000, check_algorithmically() applies to deadkey keysyms only.
svn path=/trunk/; revision=21627
2008-10-10 08:29:12 +00:00
Simos Xenitellis
ab46558d12 Fixed Bug 555000, check_algorithmically() applies to deadkey keysyms only.
svn path=/trunk/; revision=21626
2008-10-10 08:28:12 +00:00
Simos Xenitellis
a3fe407624 Fixed Bug 555000, check_algorithmically() applies to deadkey keysyms only.
svn path=/trunk/; revision=21623
2008-10-10 08:21:54 +00:00
Christian Dywan
7bd7a266f2 Bug 555676 – gtk_widget_real_grab_focus assumes toplevel == window
* gtk/gtkwidget.c (gtk_widget_real_grab_focus):
Test for GTK_IS_WINDOW instead of GTK_WIDGET_TOPLEVEL

svn path=/trunk/; revision=21622
2008-10-09 17:27:59 +00:00
Christian Dywan
4bd29a4229 Bug 555573 – gtk_font_selection_set_font_name
shouldn't require a screen

* gtk/gtkfontsel.c (gtk_font_selection_set_font_name):
Don't warn if there is no screen, just return FALSE

svn path=/trunk/; revision=21621
2008-10-09 16:26:35 +00:00
Christian Dywan
ba5fbdb32b Bug 555523 – gtk_scale_button_set_adjustment should accept NULL
* gtk/gtkscalebutton.c (gtk_scale_button_set_adjustment):
Create a new adjustment if NULL is passed, like other widgets

svn path=/trunk/; revision=21620
2008-10-09 16:19:06 +00:00
Christian Dywan
78be7a0a34 Bug 555578 – GtkTable propertiy maxima are wrong
* gtk/gtktable.c (gtk_table_class_init), (gtk_table_resize):
Always use 65535 instead of G_MAXUINT since that is
the actually supported maximum number of columns and rows

svn path=/trunk/; revision=21619
2008-10-09 15:57:55 +00:00
Richard Hult
db0ad1ff52 Bug 550342 – Splash screens have a caption
2008-10-09  Richard Hult  <richard@imendio.com>

	Bug 550342 – Splash screens have a caption

	* gdk/quartz/gdkwindow-quartz.c: (_gdk_window_new),
	(gdk_window_set_decorations): Patch from Marianne Gagnon to make
	splash windows borderless.

svn path=/trunk/; revision=21617
2008-10-09 11:27:31 +00:00
Michael Natterer
1d82722199 Bug 516425 – Optionally display accelerators in popups
2008-10-09  Michael Natterer  <mitch@imendio.com>

	Bug 516425 – Optionally display accelerators in popups

	* gtk/gtkuimanager.h (enum GtkUIManagerItemType): add value
	GTK_UI_MANAGER_POPUP_WITH_ACCELS which works like _POPUP but
	shows the actions' accelerators.

	* gtk/gtkuimanager.c: honor the new enum value for programmatically
	created UIs, and support <popup accelerators="true"> in the XML
	for the same purpose.


svn path=/trunk/; revision=21615
2008-10-09 08:50:33 +00:00
Simos Xenitellis
d84a56d3a3 Fixed Bug 554192 – deadkey-only compose sequences now working
svn path=/trunk/; revision=21613
2008-10-08 23:04:54 +00:00
Christian Persch
941abf8780 Bug 554702 – gtkfilesystem leaks GError
Also fixes some "format not a string literal and no format arguments"
warnings.

svn path=/trunk/; revision=21611
2008-10-08 21:00:56 +00:00
Matthias Clasen
28e58945d7 Add bug ref
svn path=/trunk/; revision=21609
2008-10-08 15:32:48 +00:00
Matthias Clasen
67d94ca553 Don't forget to reset reload_state when current_folder is already correct.
2008-10-08  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserdefault.c (update_current_folder_get_info_cb):
        Don't forget to reset reload_state when current_folder is already
        correct. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=465992


svn path=/trunk/; revision=21608
2008-10-08 15:32:23 +00:00
Christian Dywan
5d8adc9406 Bug 555270 – Allow unsetting a MessageDialog's image
2008-10-08  Christian Dywan  <christian@imendio.com>

Bug 555270 – Allow unsetting a MessageDialog's image

* gtk/gtkmessagedialog.c (gtk_message_dialog_set_property),
Remove a superfluous cast to GtkWidget*
(gtk_message_dialog_set_image): Accept NULL for the image
and unset the image in that case.

svn path=/trunk/; revision=21607
2008-10-08 02:27:07 +00:00
Christian Dywan
eda544e8e6 Bug 436533 – Allow more space efficient scroll arrows placement
* gtk/gtkenums.h: Add GtkArrowPlacement
* gtk/gtkmenu.c (gtk_menu_class_init), (get_arrows_border),
(get_arrows_visible_area), (get_double_arrows),
(get_arrows_sensitive_area): Implement GtkMenu::arrow-placement
to allow scrolling arrows to be placed at the start, end or both
Patch by Tommi Komulainen and myself

svn path=/trunk/; revision=21606
2008-10-08 02:16:08 +00:00
Christian Dywan
61c3e66e2c Bug 555387 – Changing the sensitivity of a statusbar
mistakenly requires a display

* gtk/gtkstatusbar.c (set_grip_cursor): Only change the cursor
of the resize grip if there is a grip window.

svn path=/trunk/; revision=21605
2008-10-08 02:02:50 +00:00
Matthias Clasen
f72dd13a36 Avoid uninitialized memory warnings
svn path=/trunk/; revision=21603
2008-10-07 18:06:00 +00:00
11:03:30 Tim Janik
ddd556aff4 keep GtkBox as an abstract type and keep _gtk_box_new() as private
2008-10-07 11:03:30  Tim Janik  <timj@imendio.com>

        * gtk/gtkbox.h: keep GtkBox as an abstract type and keep _gtk_box_new()
        as private function until we settle on the exact semantics.
        renamed _gtk_box_set_old_defaults() as suggested by Mitch.


svn path=/trunk/; revision=21599
2008-10-07 09:07:27 +00:00
Michael Natterer
a23bb3bf88 reindent static prototypes.
2008-10-07  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbox.c: reindent static prototypes.


svn path=/trunk/; revision=21598
2008-10-07 07:50:04 +00:00
Michael Natterer
97a9867c9f Bug 553573 – Add orientation API to GtkBox
2008-10-07  Michael Natterer  <mitch@imendio.com>

	Bug 553573 – Add orientation API to GtkBox

	* gtk/gtkbox.[hh]: implement the GtkOrientable interface and
	swallow all code from GtkHBox and GtkVBox. Add gtk_box_new()
	which takes a GtkOrientation argument. Also move the newly
	added "spacing_set" boolean from struct GtkBox to the new
	private struct.

	* gtk/gtkhbox.[ch]
	* gtk/gtkvbox.[ch]: remove all code except the constructor and
	call gtk_orientable_set_orientation() in init().

	* gtk/gtk.symbols: add gtk_box_new().


svn path=/trunk/; revision=21596
2008-10-07 07:44:06 +00:00
Tor Lillqvist
8a227df95f Clarification.
svn path=/trunk/; revision=21595
2008-10-06 21:33:36 +00:00
Björn Lindqvist
36c545b0a1 Bug 539464 – gtk_cell_view_get_model is missing in GtkCellView
2008-10-06  Björn Lindqvist  <bjourne@gmail.com>

	Bug 539464 – gtk_cell_view_get_model is missing in GtkCellView

	* gtk/gtkcellview.c (gtk_cell_view_get_model): Add
	gtk_cell_view_get_model.

svn path=/trunk/; revision=21593
2008-10-06 21:15:45 +00:00
Matthias Clasen
29c097a5f7 Show the tooltip on the range entry itself, too.
2008-10-06  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintunixdialog.c (create_main_page): Show the tooltip
        on the range entry itself, too.


svn path=/trunk/; revision=21591
2008-10-06 18:26:27 +00:00
Tor Lillqvist
6ee15f8ed6 Slight editing of last entry.
svn path=/trunk/; revision=21589
2008-10-05 00:11:39 +00:00
Tor Lillqvist
55d7d50e13 Bug 132501 - Make utility window translate to tool window in win32
2008-10-04  Tor Lillqvist  <tml@novell.com>

	Bug 132501 - Make utility window translate to tool window in win32

	Implement the utility window type hint. Such windows are kept on
	top of other windows. Makes GIMP's toolbox and dock windows behave
	more like in GNOME under metacity. Apply the same logic also to
	windows marked with the dialog window type hint, and windows that
	are transient for some other window. I'll call such windows
	"transient-type" below.

	* gdk/win32/gdkevents-win32.c (doesnt_want_key): Drop unused
	variables.

	(ensure_stacking_on_unminimize)
	(ensure_stacking_on_window_pos_changing)
	(ensure_stacking_on_activate_app): New functions to implement the
	desired stacking order. Make sure that a window that is not
	transient-type stays below any transient-type windows of the
	application. When activating a non-transient-type window make sure
	it rises as high as possible.

	(gdk_event_translate): Call above functions on
	WM_WINDOWPOSCHANGING, WM_ACTIVATEAPP and on WM_SIZE when
	unminimizing. Improve debugging printout.

	* gdk/win32/gdkwindow-win32.c (get_effective_window_decorations):
	Handle utility windows like toolbar windows.

	(gdk_window_new_internal) (update_style_bits): Give utility
	windows the WS_EX_TOOLWINDOW extended style.

	(gdk_window_set_title): If debugging "misc" or "events", make the
	handle of top-level windows show up in their title bars. Very
	useful when looking at debugging output.

	(gdk_window_set_keep_above) (gdk_window_set_keep_below)
	(gdk_window_set_modal_hint) (gdk_window_set_skip_taskbar_hint)
	(gdk_window_set_skip_pager_hint): Add and improve debugging
	printout.

	(gdk_window_set_type_hint): Print hint symbolically in GDK_NOTE().

2008-10-04  Tor Lillqvist  <tml@novell.com>

	* gdk/win32/gdkmain-win32.c (_gdk_win32_window_exstyle_to_string)
	(_gdk_win32_window_pos_bits_to_string): New debugging printout
	functions. Decode the WS_EX_* and SWP_* bits.

	* gdk/win32/gdkprivate-win32.h: Declare them. Define
	GDK_DEBUG_MISC_OR_EVENTS for use in GDK_NOTE() to match either
	"misc" or "events".


svn path=/trunk/; revision=21587
2008-10-05 00:00:10 +00:00
Matthias Clasen
c135a80524 Add some debug output.
2008-10-03  Matthias Clasen <mclasen@redhat.com>

        * gtk/gtkmodules.c (_gtk_modules_settings_changed): Add some
        debug output.



svn path=/trunk/; revision=21583
2008-10-04 01:54:30 +00:00