Commit Graph

6997 Commits

Author SHA1 Message Date
Matthias Clasen
f2cb87d3a9 Implement a clientmessage based scheme for makeing sure that all GTK+
2005-08-22  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkwindow.c (gtk_window_client_event):
	* gtk/gtkicontheme.c (ensure_valid_themes)
	(_gtk_icon_theme_check_reload): Implement a clientmessage based
	scheme for makeing sure that all GTK+ applications notice if an
	icon theme has been updated. This should prevent multiple versions
	of an icon theme cache to be mapped in memory at the same time,
	which can cause excessive memory consumption.  (#313156, Chris
	Lahey)
2005-08-22 20:12:15 +00:00
Matthias Clasen
97ec1cdf4f Add a note regarding icon theme changes.
2005-08-22  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
	regarding icon theme changes.

	* gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
	pixbufs which are backed by the mmapped memory of an icon cache,
	increase the refcount of the icon cache, so that the memory is not
	munmapped away underneath the pixbuf upon icon theme changes.
	(#314170, Kjartan Maraas)
2005-08-22 16:38:46 +00:00
Matthias Clasen
e337f0cf19 Add GTK_DEP_LIBS, in order to link against Xext. (#314062)
2005-08-22  Matthias Clasen  <mclasen@redhat.com>

	* docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
	to link against Xext.  (#314062)
2005-08-22 14:44:39 +00:00
Matthias Clasen
8da86542c5 One more fix to prevent buffer overruns. (#314081, Hans Breuer)
2005-08-22  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
	overruns.  (#314081, Hans Breuer)
2005-08-22 14:14:45 +00:00
Matthias Clasen
b358753ae0 Clarify that the returned layout must not be modified.
2005-08-20  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
	returned layout must not be modified.
2005-08-21 01:57:01 +00:00
Jonathan Blandford
320c78ce86 clear scroll_to_path if the model changes.
Sat Aug 20 16:12:14 2005  Jonathan Blandford  <jrb@redhat.com>

        * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
        scroll_to_path if the model changes.

        * gtk/gtkiconview.c: (gtk_icon_view_destroy),
        (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
        (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
        we're realized, #312798
        (gtk_icon_view_set_model): clear scroll_to_path if the model
        changes.
2005-08-20 20:16:34 +00:00
Matthias Clasen
2e951f5763 Don't queue a draw if the layout has not changed. (#313991, Benjamin Berg)
2005-08-20  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkrange.c (gtk_range_adjustment_changed)
	(gtk_range_adjustment_value_changed):  Don't queue a draw
	if the layout has not changed.  (#313991, Benjamin Berg)
2005-08-20 05:55:25 +00:00
Matthias Clasen
4e5fe40c02 Remove duplicate lines. (#313344, Benoit Carpentier)
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeitem.c: Remove duplicate lines.  (#313344,
	Benoit Carpentier)
2005-08-19 19:23:32 +00:00
Matthias Clasen
3dffa71bea Fix a typo.
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* modules/engines/ms-windows/msw_style.c (setup_system_styles):
	Fix a typo.
2005-08-19 19:21:45 +00:00
Matthias Clasen
313b8ffabf Handle pixbuf being NULL without warnings. Also, don't leak pixbuf
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserbutton.c (change_icon_theme)
	(model_add_special, model_add_special, model_add_volumes):
	Handle pixbuf being NULL without warnings. Also, don't
	leak pixbuf references when the icon theme is changed.
2005-08-19 18:21:31 +00:00
Matthias Clasen
37ef7f0389 Don't access the user data on destroyed windows, since at best it can be a
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmain.c (gtk_get_event_widget): Don't access
	the user data on destroyed windows, since at best
	it can be a stale pointer.  (#313953, Robin Green)
2005-08-19 16:46:57 +00:00
Matthias Clasen
e20eb8b760 Avoid a buffer overrun. (#313900, Sebastien Bacher)
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
	(#313900, Sebastien Bacher)
2005-08-19 16:16:17 +00:00
Matthias Clasen
445b61e3e7 Return FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
	FALSE if the tree is empty.  (#313891, Guillaume Cottenceau)
2005-08-19 14:05:32 +00:00
Matthias Clasen
859126d546 Free data returned from XGetWindowProperty.
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
	(xdnd_read_actions, get_client_window_at_coords_recurse):
	Free data returned from XGetWindowProperty.

	* gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
	Free data returned from XGetWindowProperty.  (313867, Kjartan
	Maraas)

	* gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
	children in all cases.  (#313862, Kjartan Maraas)
2005-08-19 05:46:06 +00:00
Matthias Clasen
ba8fd4b9e2 Free children in all cases. (#313862, Kjartan Maraas)
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
	children in all cases.  (#313862, Kjartan Maraas)
2005-08-19 05:16:31 +00:00
Matthias Clasen
d1ab2bf3d5 Store GtkIconData structs in the per-directory hash, even if they come
2005-08-19  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
	in the per-directory hash, even if they come from the icon cache.
	We tried to avoid that before, but as a result leaked icon data
	structs.  (#313852, Kjartan Maraas)
2005-08-19 04:39:30 +00:00
Matthias Clasen
af7a0fa154 Disconnect signal handlers on destroy, not on finalize. (#313759, Brett
2005-08-18  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
	signal handlers on destroy, not on finalize.  (#313759, Brett Atoms)
2005-08-18 20:29:55 +00:00
Owen Taylor
70be25eea2 Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config files for x11/xext.
2005-08-15  Owen Taylor  <otaylor@redhat.com>

        * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
        files for x11/xext. (Jonas Bonn)
2005-08-15 21:26:19 +00:00
Tor Lillqvist
6591528e95 Put debugging printout inside GTK_NOTE.
2005-08-15  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
	inside GTK_NOTE.
2005-08-15 19:36:32 +00:00
Owen Taylor
013a0b0f11 Fix have_base_pc / have_base_x_pc typo.
2005-08-15  Owen Taylor  <otaylor@redhat.com>

        * configure.in: Fix have_base_pc / have_base_x_pc typo.

        * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
        (#313417, James Andrewartha)

        * configure.in: Add fontconfig to X_PACKAGES, since we use it for
        FcNameConstant(). (More of #313417)
2005-08-15 19:04:55 +00:00
Matthias Clasen
cbd1435c88 When using gtk_dialog_run() for modal dialogs, make sure to inherit the
2005-08-15  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
	modal dialogs, make sure to inherit the window group from
	the parent, since we don't inherit window groups across
	transient parents currently.  (#312918, Christian Persch)

	* gtk/gtkmessagedialog.c (gtk_message_dialog_new):
	* gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2005-08-15 18:17:01 +00:00
Matthias Clasen
6fbbdeefd3 Handle paths of depth 0 gracefully. (#312796, Jonathan Blandford)
2005-08-15  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkiconview.c (gtk_icon_view_select_path)
	(gtk_icon_view_scroll_to_path): Handle paths of depth 0
	gracefully.  (#312796, Jonathan Blandford)
2005-08-15 16:46:52 +00:00
Matthias Clasen
24a55633ce Add some more tests for menu placement.
2005-08-15  Matthias Clasen  <mclasen@redhat.com>

	* tests/testtoolbar.c: Add some more tests for menu placement.

	* gtk/gtkmenutoolbutton.c (menu_position_func):
	* gtk/gtktoolbar.c (menu_position_func): Improve positioning
	of toolbutton menus and of the overflow menu.  (#312937,
	#153870, Christian Persch, Paolo Borelli)
2005-08-15 16:36:31 +00:00
Tor Lillqvist
c92959a448 Use g_path_get_dirname() instead of the nonportable <libgen.h> and
2005-08-15  Tor Lillqvist  <tml@novell.com>

	* gtk/updateiconcache.c: Use g_path_get_dirname() instead of
	the nonportable <libgen.h> and dirname().
2005-08-15 14:53:00 +00:00
Matthias Clasen
4b5f259ba0 Use object data to mark widgets and groups as visited, so that we avoid
2005-08-15  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtksizegroup.c: Use object data to mark widgets and
	groups as visited, so that we avoid constant extra list
	traversals. Also allocate quarks in class_init.  (#311618,
	Michael Natterer)
2005-08-15 13:46:32 +00:00
Matthias Clasen
ce9570dd58 Correct the download location for the hicolor icon theme. (#313475, Olexiy
2005-08-15  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
	download location for the hicolor icon theme. (#313475, Olexiy
	Avramchenko)
2005-08-15 13:28:22 +00:00
Owen Taylor
42dc0241f3 Handle pixmap == NULL when checking for a colormap. (Allin Cottrell).
2005-08-15  Owen Taylor  <otaylor@redhat.com>

        * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
        * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
        * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
        Handle pixmap == NULL when checking for a colormap.
        (Allin Cottrell).
2005-08-15 12:35:04 +00:00
Matthias Clasen
329fc5da74 Store only one copy of the pixel data for symlinked icons. To achieve
2005-08-14  Matthias Clasen  <mclasen@redhat.com>

	* gtk/updateiconcache.c: Store only one copy of the pixel data
	for symlinked icons. To achieve this, maintain a hashtable
	mapping pathnames to pixel data, and share the pixel data for
	all symlinks resolving to the same pathname. When writing out
	the image data, write out the pixel data only the first time
	it is met, and store the offset pointing to the first copy
	for use in all later cases.
	This reduces the size of the Bluecurve icon cache from 40
	to 13MB. (#312972)
2005-08-15 03:52:34 +00:00
Matthias Clasen
8975d5800d Bump version 2005-08-13 19:43:56 +00:00
Matthias Clasen
64e268edf4 2.8.0 2005-08-13 19:34:27 +00:00
Matthias Clasen
d704f0320e Require cairo 0.9.2 2005-08-13 12:51:54 +00:00
Matthias Clasen
eb48fdc0b6 Remove a line without effect.
2005-08-12  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkcheckmenuitem.c (gtk_real_check_menu_item_draw_indicator):
	Remove a line without effect.
2005-08-12 22:53:03 +00:00
Matthias Clasen
1f61c61410 When changing the icon theme, defer the resetting of rc styles to an idle,
2005-08-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkicontheme.c: When changing the icon theme, defer
        the resetting of rc styles to an idle, so that it does
        not happen e.g during expose handling (which is problematic,
        since some widgets, like the toolbar, are changing the
        hierarchy in response to style changes).  (#300539, reported
        by many people, analyzed by Owen Taylor)
2005-08-12 18:39:17 +00:00
Owen Taylor
c24e5e2890 gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap)
2005-08-12  Owen Taylor  <otaylor@redhat.com>

        * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap)
        * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap)
        * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap): Warn if
        gdk_drawable_get_colormap (pixmap) is NULL and return.
2005-08-12 13:13:54 +00:00
Matthias Clasen
59121c52b3 Bump version 2.8.0 2005-08-12 12:58:17 +00:00
Matthias Clasen
2b40fb4fd9 Work around some problems with the gnome-vfs backends which could lead to
2005-08-11  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c: Work around some problems
	with the gnome-vfs backends which could lead to crashes
	in the bookmark handling.  (#310270, Diego Gonzalez, patch
	by Michael Meeks)
2005-08-12 03:03:44 +00:00
Kristian Rietveld
1f56c13d32 Fix for #312924, by John Finlay.
2005-08-11  Kristian Rietveld  <kris@gtk.org>

	Fix for #312924, by John Finlay.

	* gtk/gtkliststore.c (gtk_list_store_increment_stamp),
	(gtk_list_store_clear): increment stamp on store clearance.

	* gtk/gtktreestore.c (gtk_tree_store_increment_stamp),
	(gtk_tree_store_clear): ditto.
2005-08-11 18:07:47 +00:00
Kristian Rietveld
48729ed118 queue a draw for the entire widget if any column changes width. (Fixes
2005-08-11  Kristian Rietveld  <kris@gtk.org>

	* gtk/gtktreeview.c (gtk_tree_view_size_allocate_columns): queue
	a draw for the entire widget if any column changes width. (Fixes
	#311026, reported by Frederic Crozat).
2005-08-11 17:47:18 +00:00
J. Ali Harlow
4682009053 Revert to linking against pangowin32 under win32 platform (Owen Taylor).
2005-08-10  J. Ali Harlow  <ali@juiblex.co.uk>

        * configure.in: Revert to linking against pangowin32 under win32
	platform (Owen Taylor).
2005-08-10 13:22:33 +00:00
J. Ali Harlow
3502a2a259 Make the last change compile.
2005-08-10  J. Ali Harlow  <ali@juiblex.co.uk>

        * gdk/win32/gdkfont-win32.c (gdk_font_from_description_for_display): Make
	the last change compile.
2005-08-10 11:02:29 +00:00
Matthias Clasen
b7bd68546c Remove ambiguities pointed out by gcc.
2005-08-10  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted)
	(gtk_tree_model_filter_remove_node): Remove ambiguities pointed
	out by gcc.
2005-08-10 04:15:43 +00:00
James Henstridge
749227685f fix definition of GDK_DEP_CFLAGS so that it doesn't cause build failures
2005-08-10  James Henstridge  <james@jamesh.id.au>

	* configure.in: fix definition of GDK_DEP_CFLAGS so that it
	doesn't cause build failures if $X_PACKAGES is not empty.
2005-08-10 03:35:51 +00:00
Owen Taylor
b1df326ab3 Remove superfluous call to gdk_window_get_offsets (). (#313051, Bertram
2005-08-09  Owen Taylor  <otaylor@redhat.com>

        * gdk/gdkwindow.c (gdk_window_ref_cairo_surface): Remove superfluous
        call to gdk_window_get_offsets (). (#313051, Bertram Felgenhauer)
2005-08-10 02:40:10 +00:00
Owen Taylor
bfd04045e5 Strip out all Xft, FreeType, and pangoxft checking. Rewrite X checks to
2005-08-09  Owen Taylor  <otaylor@redhat.com>

        * configure.in: Strip out all Xft, FreeType, and pangoxft checking.
        Rewrite X checks to use pkg-config as much as possible.

        * gdk/win32/gdkfont-win32.c (gdk_font_from_description_for_display): Make
        this return Arial always to avoid using PangoWin32FontMap. (X11 backend
        has always been returned "fixed" for a long time)

        * gdk/linux-fb/gdkdrawable-fb2.c: Remove draw_glyphs() implementations,
        fall through to the default implementation in terms of Cairo.

        * gdk/linux-fb/gdkdrawable-fb2.c (gdk_fb_draw_text): Use gdk_draw_glyphs()
        on the wrapper rather than gdk_fb_draw_glyphs()
2005-08-10 02:31:51 +00:00
Mark McLoughlin
00cc060921 Fixes "notification area leaks space" (bug #312687)
2005-08-09  Mark McLoughlin  <mark@skynet.ie>

        Fixes "notification area leaks space" (bug #312687)

        * gtk/gtksocket-x11.c: (_gtk_socket_windowing_filter_func):
          gtk/gtkplug.c: (_gtk_plug_add_to_socket): don't pass a
        detail to g_signal_emit_by_name()
2005-08-09 16:30:09 +00:00
Matthias Clasen
df33513a90 Updates
2005-08-09  Matthias Clasen  <mclasen@redhat.com>

	* NEWS: Updates
2005-08-09 15:16:43 +00:00
Matthias Clasen
6f5687c1e3 Use g_quark_from_static_string here.
2005-08-09  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtksizegroup.c (get_size_groups, set_size_groups): Use
	g_quark_from_static_string here.
2005-08-09 04:49:36 +00:00
Christian Persch
fb382a2bd0 Deactivate the menu when the button becomes insensitive, and remove dead
2005-08-08  Christian Persch  <chpe@cvs.gnome.org>

	* gtk/gtkmenutoolbutton.c: (gtk_menu_tool_button_state_changed),
	(gtk_menu_tool_button_class_init), (popup_menu_under_arrow),
	(gtk_menu_tool_button_init):

	Deactivate the menu when the button becomes insensitive, and remove
	dead code. Fixes bug #312920.

2005-08-08  Matthias Clasen  <mclasen@redhat.com>
2005-08-08 18:34:43 +00:00
Matthias Clasen
4494bd6ff8 Fix the build 2005-08-08 18:28:50 +00:00
Christian Persch
1992b31396 Use ->priv instead of GTK_MENU_TOOL_BUTTON_GET_PRIVATE. Surviving part of
2005-08-08  Christian Persch  <chpe@cvs.gnome.org>

	* gtk/gtkmenutoolbutton.c:
	(gtk_menu_tool_button_construct_contents),
	(button_state_changed_cb), (menu_position_func),
	(arrow_button_toggled_cb):

	Use ->priv instead of GTK_MENU_TOOL_BUTTON_GET_PRIVATE.
	Surviving part of bug #310589.
2005-08-08 18:14:26 +00:00