mirror of
https://gitlab.gnome.org/GNOME/gtk.git
synced 2025-01-08 11:40:16 +00:00
9ca38c4647
According to the XEmbed specification, a window should be created "elsewhere" and then reparented into the target parent window. Instead, GTK+ creates the window directly in desired target parent window. This allows some races to occur. Another program that does not follow XEmbed is tabbed. XEmbed requires an _XEMBED_INFO property on the to-be-embedded window, but tabbed does not check for this property. Thus, as soon as GTK+ creates its window, tabbed starts managing this window and now GTK+ setting up the window races with tabbed starting to manage the window. If tabbed is fast enough to map the window, GTK+ never sees a MapNotify event, because it did not yet select StructureNotifyMask on its window. This results in a black window inside of tabbed. Note that this cannot really be fixed in tabbed, since XEmbed says that the _XEMBED_INFO property must be already present when the window appears. Thus, patching tabbed to wait for _XEMBED_INFO to appear is not something that the spec requires/allows. Instead, this commit changes GTK+ so that it directly sets the right event mask when the window is created. This means that there is no more race between tabbed mapping the window and GTK+ selecting StructureNotifyMask. Note that the proper fix would be to do as XEmbed requires: Create the window elsewhere and then reparent it into the target window. However, that would require a more invasive patch, so this commit only takes the "easy approach" of fixing this one race. Hopefully, all the other races that can occur during window setup are harmless, because the embedder/socket will hopefully watch for PropertyNotify events as needed. Fixes: https://gitlab.gnome.org/GNOME/gtk/issues/757 See-also: https://github.com/awesomeWM/awesome/issues/2385 Signed-off-by: Uli Schlachter <psychon@znc.in> |
||
|---|---|---|
| .. | ||
| gdkapplaunchcontext-x11.c | ||
| gdkasync.c | ||
| gdkasync.h | ||
| gdkcursor-x11.c | ||
| gdkdevice-core-x11.c | ||
| gdkdevice-xi2.c | ||
| gdkdevicemanager-core-x11.c | ||
| gdkdevicemanager-x11.c | ||
| gdkdevicemanager-xi2.c | ||
| gdkdevicemanagerprivate-core.h | ||
| gdkdisplay-x11.c | ||
| gdkdisplay-x11.h | ||
| gdkdisplaymanager-x11.c | ||
| gdkdnd-x11.c | ||
| gdkeventsource.c | ||
| gdkeventsource.h | ||
| gdkeventtranslator.c | ||
| gdkeventtranslator.h | ||
| gdkgeometry-x11.c | ||
| gdkglcontext-x11.c | ||
| gdkglcontext-x11.h | ||
| gdkkeys-x11.c | ||
| gdkmain-x11.c | ||
| gdkmonitor-x11.c | ||
| gdkmonitor-x11.h | ||
| gdkprivate-x11.h | ||
| gdkproperty-x11.c | ||
| gdkscreen-x11.c | ||
| gdkscreen-x11.h | ||
| gdkselection-x11.c | ||
| gdksettings.c | ||
| gdktestutils-x11.c | ||
| gdkvisual-x11.c | ||
| gdkwindow-x11.c | ||
| gdkwindow-x11.h | ||
| gdkx11applaunchcontext.h | ||
| gdkx11cursor.h | ||
| gdkx11device-core.h | ||
| gdkx11device-xi2.h | ||
| gdkx11device.h | ||
| gdkx11devicemanager-core.h | ||
| gdkx11devicemanager-xi2.h | ||
| gdkx11devicemanager-xi.h | ||
| gdkx11devicemanager.h | ||
| gdkx11display.h | ||
| gdkx11displaymanager.h | ||
| gdkx11dnd.h | ||
| gdkx11glcontext.h | ||
| gdkx11keys.h | ||
| gdkx11monitor.h | ||
| gdkx11property.h | ||
| gdkx11screen.h | ||
| gdkx11selection.h | ||
| gdkx11utils.h | ||
| gdkx11visual.h | ||
| gdkx11window.h | ||
| gdkx-autocleanups.h | ||
| gdkx.h | ||
| gdkxftdefaults.c | ||
| gdkxid.c | ||
| Makefile.am | ||
| MwmUtil.h | ||
| xsettings-client.c | ||
| xsettings-client.h | ||