mirror of
https://gitlab.gnome.org/GNOME/gtk.git
synced 2024-12-27 06:00:22 +00:00
1454ba15ba
Here's the shortest description of the bug I can come up with:
When computing values, we have 3 kinds of dependencies:
(1) other properties ("currentColor" or em values)
(2) inherited properties ("inherit")
(3) generic things from the theme (@keyframes or @define-color)
Previously, we passed the GtkStyleContext as an argument, because it
provided these 3 things using:
(1) _gtk_style_context_peek_property()
(2) _gtk_style_context_peek_property(gtk_style_context_get_parent())
(3) context->priv->cascade
However, this makes it impossible to lookup values other than the ones
accessible via _gtk_style_context_peek_property(). And this is exactly
what we are doing in gtk_style_context_update_cache(). So when the cache
updates encountered case (1), they were looking up the values from the
wrong style data.
So this large patch essentially does nothing but replace the
context argument in all compute functions with new arguments for the 3
cases above:
(1) values
(2) parent_values
(3) provider
We apparently have a lot of computing code.
137 lines
3.5 KiB
C
137 lines
3.5 KiB
C
/* GTK - The GIMP Toolkit
|
|
* Copyright (C) 2011 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include "gtkcsstypedvalueprivate.h"
|
|
|
|
#include "gtkcsscustompropertyprivate.h"
|
|
#include "gtkcssstylefuncsprivate.h"
|
|
|
|
struct _GtkCssValue {
|
|
GTK_CSS_VALUE_BASE
|
|
GValue value;
|
|
};
|
|
|
|
static void
|
|
gtk_css_value_typed_free (GtkCssValue *value)
|
|
{
|
|
g_value_unset (&value->value);
|
|
g_slice_free (GtkCssValue, value);
|
|
}
|
|
|
|
static GtkCssValue *
|
|
gtk_css_value_typed_compute (GtkCssValue *value,
|
|
guint property_id,
|
|
GtkStyleProviderPrivate *provider,
|
|
GtkCssComputedValues *values,
|
|
GtkCssComputedValues *parent_values,
|
|
GtkCssDependencies *dependencies)
|
|
{
|
|
GtkCssCustomProperty *custom = GTK_CSS_CUSTOM_PROPERTY (_gtk_css_style_property_lookup_by_id (property_id));
|
|
|
|
return _gtk_css_style_compute_value (provider, values, parent_values, custom->pspec->value_type, value, dependencies);
|
|
}
|
|
|
|
static gboolean
|
|
gtk_css_value_typed_equal (const GtkCssValue *value1,
|
|
const GtkCssValue *value2)
|
|
{
|
|
return FALSE;
|
|
}
|
|
|
|
static GtkCssValue *
|
|
gtk_css_value_typed_transition (GtkCssValue *start,
|
|
GtkCssValue *end,
|
|
guint property_id,
|
|
double progress)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
static void
|
|
gtk_css_value_typed_print (const GtkCssValue *value,
|
|
GString *string)
|
|
{
|
|
_gtk_css_style_print_value (&value->value, string);
|
|
}
|
|
|
|
static const GtkCssValueClass GTK_CSS_VALUE_TYPED = {
|
|
gtk_css_value_typed_free,
|
|
gtk_css_value_typed_compute,
|
|
gtk_css_value_typed_equal,
|
|
gtk_css_value_typed_transition,
|
|
gtk_css_value_typed_print
|
|
};
|
|
|
|
static GtkCssValue *
|
|
gtk_css_typed_value_new_for_type (GType type)
|
|
{
|
|
GtkCssValue *result;
|
|
|
|
result = _gtk_css_value_new (GtkCssValue, >K_CSS_VALUE_TYPED);
|
|
|
|
g_value_init (&result->value, type);
|
|
|
|
return result;
|
|
}
|
|
|
|
GtkCssValue *
|
|
_gtk_css_typed_value_new (const GValue *value)
|
|
{
|
|
GtkCssValue *result;
|
|
|
|
g_return_val_if_fail (G_IS_VALUE (value), NULL);
|
|
|
|
result = gtk_css_typed_value_new_for_type (G_VALUE_TYPE (value));
|
|
|
|
g_value_copy (value, &result->value);
|
|
|
|
return result;
|
|
}
|
|
|
|
GtkCssValue *
|
|
_gtk_css_typed_value_new_take (GValue *value)
|
|
{
|
|
GtkCssValue *result;
|
|
|
|
g_return_val_if_fail (G_IS_VALUE (value), NULL);
|
|
|
|
result = _gtk_css_typed_value_new (value);
|
|
g_value_unset (value);
|
|
|
|
return result;
|
|
}
|
|
|
|
gboolean
|
|
_gtk_is_css_typed_value_of_type (const GtkCssValue *value,
|
|
GType type)
|
|
{
|
|
if (value->class != >K_CSS_VALUE_TYPED)
|
|
return FALSE;
|
|
|
|
return G_VALUE_HOLDS (&value->value, type);
|
|
}
|
|
|
|
const GValue *
|
|
_gtk_css_typed_value_get (const GtkCssValue *value)
|
|
{
|
|
g_return_val_if_fail (value->class == >K_CSS_VALUE_TYPED, NULL);
|
|
|
|
return &value->value;
|
|
}
|