GTK is a multi-platform toolkit for creating graphical user interfaces.
Go to file
Daniel Boles dfa6591675 DropTarget: Fix critical if reject drop pre-enter
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/5922

The docs of `Gtk.DropTarget::accept` say this:
> If the decision whether the drop will be accepted or rejected depends
> on the data, [`::accept`] should return `TRUE`, [`:preload`] should be
> set and the value should be inspected via the `::notify:value` signal,
> calling `gtk_drop_target_reject()` if required.

But this pattern causes a CRITICAL, given these steps:
* Create a `DragSource` and `DropTarget`
* Keep the default `::accept` handler and set `:preload` to `TRUE`
* Connect to `notify::value` and therein call `DropTarget.reject()`
* CRITICAL at `DropTarget.enter()`→`Drop.get_actions()` on NULL instance

We should let the documented case work without a CRITICAL or worse, null
deref. And per @otte on the bug, we should bail earlier before `::enter`
& setting `GTK_STATE_FLAG_DROP_ACTIVE`; neither should occur if rejected

This fixes that, by checking after `start_drop()` when notifications are
thawed, whether any handler has `reject()`ed & set our `drop` to `NULL`.
2023-06-27 21:37:32 +01:00
.gitlab/issue_templates Update references to master in the repository 2021-11-29 17:37:49 -05:00
.gitlab-ci ci: Use the current build options for flatpaks 2023-06-20 20:49:29 -04:00
build-aux build: Rename another option 2023-05-09 21:41:27 -04:00
demos widget-factory: Set a11y labels on scale buttons 2023-06-25 22:28:23 -04:00
docs buildertool: Make render an alias for screenshot 2023-06-26 10:58:35 -04:00
examples Replace deprecated CSS loading API 2023-05-16 16:59:05 -04:00
gdk vulkan: Add a pipeline cache 2023-06-26 20:28:11 +02:00
gsk Merge branch 'fix-asan-ifunc' into 'main' 2023-06-27 19:55:28 +00:00
gtk DropTarget: Fix critical if reject drop pre-enter 2023-06-27 21:37:32 +01:00
modules Visual Studio: Remove workarounds for <= glib-2.74.x 2023-06-21 12:29:38 +08:00
po Update Brazilian Portuguese translation 2023-06-26 13:08:53 +00:00
subprojects glib.wrap: Use 2.76.0 2023-06-21 12:27:41 +08:00
tests testsections: A testbed for sections 2023-05-27 21:30:14 -04:00
testsuite Add another a11y test 2023-06-21 19:55:46 -04:00
tools gtk4-builder-tool: Fix naming 2023-06-27 07:09:04 -04:00
.clang-format clang-format: This did not work 2022-09-10 14:35:40 -04:00
.editorconfig Add editorconfig file 2021-10-28 18:17:02 +01:00
.gitignore .gitignore: Ignore .flatpak-builder directory 2023-05-15 13:08:56 -07:00
.gitlab-ci.yml ci: Collect artifacts from the asan build 2023-06-12 14:54:28 -04:00
AUTHORS AUTHORS: some updates 2020-09-12 11:52:14 -04:00
CONTRIBUTING.md CONTRIBUTING: Updates 2023-02-06 07:35:11 +01:00
COPYING
gtk.doap Update the gtk.doap file 2021-01-18 09:14:50 -05:00
gtk.supp Fix some typos in gtk.supp 2023-06-09 08:28:36 -04:00
lsan.supp asan: Ignore leaks from librsvg 2021-03-27 21:03:43 -04:00
make-pot Add new printf patterns to make-pot 2022-11-05 11:23:53 +01:00
make-release.sh make-release: Explicily enable introspection 2023-02-04 16:31:55 +01:00
meson_options.txt build: Rename another option 2023-05-09 21:41:27 -04:00
meson.build Visual Studio: Remove workarounds for <= glib-2.74.x 2023-06-21 12:29:38 +08:00
NEWS NEWS: updates 2023-06-20 20:49:29 -04:00
NEWS.pre-1.0
NEWS.pre-2.0
NEWS.pre-3.0
NEWS.pre-4.0 Split NEWS for pre-4.0 changes 2021-01-19 10:40:09 +01:00
README.md README: Updates 2023-04-28 17:31:12 -04:00

GTK — The GTK toolkit

Build status

General information

GTK is a multi-platform toolkit for creating graphical user interfaces. Offering a complete set of widgets, GTK is suitable for projects ranging from small one-off projects to complete application suites.

GTK is a free and open-source software project. The licensing terms for GTK, the GNU LGPL, allow it to be used by all developers, including those developing proprietary software, without any license fees or royalties.

GTK is hosted by the GNOME project (thanks!) and used by a wide variety of applications and projects.

The official download location

The official web site

The official developers blog

Discussion forum

Nightly documentation can be found at

Nightly flatpaks of our demos can be installed from the GNOME Nightly repository:

  • flatpak remote-add --if-not-exists gnome-nightly https://nightly.gnome.org/gnome-nightly.flatpakrepo
  • flatpak install gnome-nightly org.gtk.Demo4
  • flatpak install gnome-nightly org.gtk.WidgetFactory4
  • flatpak install gnome-nightly org.gtk.IconBrowser4

Building and installing

In order to build GTK you will need:

You will also need various dependencies, based on the platform you are building for:

If you are building the X11 backend, you will also need:

  • Xlib, and the following X extensions:
    • xrandr
    • xrender
    • xi
    • xext
    • xfixes
    • xcursor
    • xdamage
    • xcomposite

If you are building the Wayland backend, you will also need:

  • Wayland-client
  • Wayland-protocols
  • Wayland-cursor
  • Wayland-EGL

Once you have all the necessary dependencies, you can build GTK by using Meson:

$ meson _build .
$ cd _build
$ ninja

You can run the test suite using:

$ meson test

And, finally, you can install GTK using:

$ sudo ninja install

Complete information about installing GTK and related libraries can be found in the file:

docs/reference/gtk/html/gtk-building.html

Or online

Building from git

The GTK sources are hosted on gitlab.gnome.org. The main development branch is called main, and stable branches are named after their minor version, for example gtk-4-10.

How to report bugs

Bugs should be reported on the issues page.

In the bug report please include:

  • Information about your system. For instance:

    • which version of GTK you are using
    • what operating system and version
    • for Linux, which distribution
    • if you built GTK, the list of options used to configure the build

    And anything else you think is relevant.

  • How to reproduce the bug.

    If you can reproduce it with one of the demo applications that are built in the demos/ subdirectory, on one of the test programs that are built in the tests/ subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.

  • If the bug was a crash, the exact text that was printed out when the crash occurred.

  • Further information such as stack traces may be useful, but is not necessary.

Contributing to GTK

Please, follow the contribution guide to know how to start contributing to GTK.

If you want to support GTK financially, please consider donating to the GNOME project, which runs the infrastructure hosting GTK.

Release notes

The release notes for GTK are part of the migration guide in the API reference. See:

Licensing terms

GTK is released under the terms of the GNU Lesser General Public License, version 2.1 or, at your option, any later version, as published by the Free Software Foundation.

Please, see the COPYING file for further information.

GTK includes a small number of source files under the Apache license:

  • A fork of the roaring bitmaps implementation in gtk/roaring
  • An adaptation of timsort from python in gtk/timsort