mirror of
https://gitlab.gnome.org/GNOME/gtk.git
synced 2024-09-19 21:40:22 +00:00
214f5a6f98
When we allocate a graphene_point_t on the stack, there's no guarantee that it will be aligned at an 8-byte boundary, which is an assumption made by gsk_pathop_encode() (which wants to use the lowest 3 bits to encode the operation). In the places where it matters, force the points on the stack and embedded in structs to be nicely aligned. By using a distinct type for this (a union with a suitable size and alignment), we ensure that the compiler will warn or error whenever we can't prove that a particular point is, in fact, suitably aligned. We can go from a `GskAlignedPoint *` to a `graphene_point_t *` (which is always valid, because the `GskAlignedPoint` is aligned) via &aligned_points[0].pt, but we cannot go back the other way (which is not always valid, because the `graphene_point_t` is not necessarily aligned nicely) without a cast. In practice, it seems that a graphene_point_t on x86_64 *is* usually placed at an 8-byte boundary, but this is not the case on 32-bit architectures or on s390x. In many cases we can avoid needing an explicit reference to the more complicated type by making use of a transparent union. There's already at least one transparent union in GSK's public API, so it's presumably portable enough to match GTK's requirements. Increasing the alignment of GskAlignedPoint also requires adjusting how a GskStandardContour is allocated and initialized. This data structure allocates extra memory to hold an array of GskAlignedPoint outside the bounds of the struct itself, and that array now needs to be aligned suitably. Previously the array started with at next byte after the flexible array of gskpathop, but the alignment of a gskpathop is only 4 bytes on 32-bit architectures, so depending on the number of gskpathop in the trailing flexible array, that pointer might be an unsuitable location to allocate a GskAlignedPoint. Resolves: https://gitlab.gnome.org/GNOME/gtk/-/issues/6395 Signed-off-by: Simon McVittie <smcv@debian.org>
99 lines
6.9 KiB
C
99 lines
6.9 KiB
C
/*
|
|
* Copyright © 2020 Benjamin Otte
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Authors: Benjamin Otte <otte@gnome.org>
|
|
*/
|
|
|
|
|
|
#pragma once
|
|
|
|
#include "gskpathprivate.h"
|
|
#include "gskpathpoint.h"
|
|
#include "gskpathopprivate.h"
|
|
#include "gskboundingboxprivate.h"
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
GskContour * gsk_standard_contour_new (GskPathFlags flags,
|
|
const GskAlignedPoint *points,
|
|
gsize n_points,
|
|
const gskpathop *ops,
|
|
gsize n_ops,
|
|
gssize offset);
|
|
|
|
GskContour * gsk_circle_contour_new (const graphene_point_t *center,
|
|
float radius);
|
|
GskContour * gsk_rect_contour_new (const graphene_rect_t *rect);
|
|
GskContour * gsk_rounded_rect_contour_new (const GskRoundedRect *rounded_rect);
|
|
|
|
const char * gsk_contour_get_type_name (const GskContour *self);
|
|
void gsk_contour_copy (GskContour * dest,
|
|
const GskContour *src);
|
|
GskContour * gsk_contour_dup (const GskContour *src);
|
|
GskContour * gsk_contour_reverse (const GskContour *src);
|
|
|
|
gsize gsk_contour_get_size (const GskContour *self);
|
|
GskPathFlags gsk_contour_get_flags (const GskContour *self);
|
|
void gsk_contour_print (const GskContour *self,
|
|
GString *string);
|
|
gboolean gsk_contour_get_bounds (const GskContour *self,
|
|
GskBoundingBox *bounds);
|
|
gboolean gsk_contour_get_stroke_bounds (const GskContour *self,
|
|
const GskStroke *stroke,
|
|
GskBoundingBox *bounds);
|
|
gboolean gsk_contour_foreach (const GskContour *self,
|
|
GskPathForeachFunc func,
|
|
gpointer user_data);
|
|
int gsk_contour_get_winding (const GskContour *self,
|
|
const graphene_point_t *point);
|
|
gsize gsk_contour_get_n_ops (const GskContour *self);
|
|
gboolean gsk_contour_get_closest_point (const GskContour *self,
|
|
const graphene_point_t *point,
|
|
float threshold,
|
|
GskPathPoint *result,
|
|
float *out_dist);
|
|
void gsk_contour_get_position (const GskContour *self,
|
|
const GskPathPoint *point,
|
|
graphene_point_t *pos);
|
|
void gsk_contour_get_tangent (const GskContour *self,
|
|
const GskPathPoint *point,
|
|
GskPathDirection direction,
|
|
graphene_vec2_t *tangent);
|
|
float gsk_contour_get_curvature (const GskContour *self,
|
|
const GskPathPoint *point,
|
|
GskPathDirection direction,
|
|
graphene_point_t *center);
|
|
void gsk_contour_add_segment (const GskContour *self,
|
|
GskPathBuilder *builder,
|
|
gboolean emit_move_to,
|
|
const GskPathPoint *start,
|
|
const GskPathPoint *end);
|
|
|
|
gpointer gsk_contour_init_measure (const GskContour *self,
|
|
float tolerance,
|
|
float *out_length);
|
|
void gsk_contour_free_measure (const GskContour *self,
|
|
gpointer data);
|
|
void gsk_contour_get_point (const GskContour *self,
|
|
gpointer measure_data,
|
|
float distance,
|
|
GskPathPoint *result);
|
|
float gsk_contour_get_distance (const GskContour *self,
|
|
const GskPathPoint *point,
|
|
gpointer measure_data);
|
|
|
|
G_END_DECLS
|