gtk/testsuite/a11y/text.c
Simon McVittie a8bb71383a tests: Fix signature of GtkTestATContext::update-selection-bound handlers
The signal is declared in GtkTestATContext with 0 parameters, but these
handlers were written as if the signal had one `guint` parameter.
On some architectures this accidentally works as intended, but on
others (reproduced on i386 and riscv64) the test tries to use arbitrary
stack contents as the `TestData *` and crashes when it tries to
dereference the resulting non-pointer.

Resolves: https://gitlab.gnome.org/GNOME/gtk/-/issues/6490
Signed-off-by: Simon McVittie <smcv@debian.org>
2024-07-27 00:59:03 +01:00

185 lines
5.2 KiB
C

#include <gtk/gtk.h>
#include "gtk/gtkatcontextprivate.h"
#include "gtk/gtkaccessibletextprivate.h"
typedef struct
{
guint update_caret_pos_count;
guint caret_pos;
guint update_selection_bound_count;
guint update_text_contents_count;
GtkAccessibleTextContentChange change;
guint start;
guint end;
GBytes *contents;
} TestData;
static void
test_data_clear (TestData *td)
{
td->update_caret_pos_count = 0;
td->caret_pos = G_MAXUINT;
td->update_selection_bound_count = 0;
td->update_text_contents_count = 0;
td->change = 0;
td->start = G_MAXUINT;
td->end = G_MAXUINT;
g_clear_pointer (&td->contents, g_bytes_unref);
}
static void
update_caret_pos (GtkATContext *context,
guint caret_pos,
gpointer data)
{
TestData *td = data;
td->update_caret_pos_count++;
td->caret_pos = caret_pos;
}
static void
update_selection_bound (GtkATContext *context,
gpointer data)
{
TestData *td = data;
td->update_selection_bound_count++;
}
static void
update_text_contents (GtkATContext *context,
GtkAccessibleTextContentChange change,
guint start,
guint end,
GBytes *contents,
gpointer data)
{
TestData *td = data;
td->update_text_contents_count++;
td->change = change;
td->start = start;
td->end = end;
g_clear_pointer (&td->contents, g_bytes_unref);
td->contents = g_bytes_ref (contents);
}
static void
test_text_accessible_text (void)
{
GtkWidget *text = gtk_text_new ();
GBytes *bytes;
gsize len;
gboolean res;
gsize n_ranges;
GtkAccessibleTextRange *ranges = NULL;
char **attr_names, **attr_values;
const char *string;
PangoAttrList *attrs;
PangoAttribute *attr;
GtkATContext *context;
TestData td = { 0, };
unsigned int start, end;
g_object_ref_sink (text);
context = gtk_accessible_get_at_context (GTK_ACCESSIBLE (text));
gtk_at_context_realize (context);
g_signal_connect (context, "update-caret-position", G_CALLBACK (update_caret_pos), &td);
g_signal_connect (context, "update-selection-bound", G_CALLBACK (update_selection_bound), &td);
g_signal_connect (context, "update-text-contents", G_CALLBACK (update_text_contents), &td);
test_data_clear (&td);
gtk_editable_set_text (GTK_EDITABLE (text), "abc def");
g_assert_cmpuint (td.update_text_contents_count, ==, 1);
g_assert_cmpuint (td.change, ==, GTK_ACCESSIBLE_TEXT_CONTENT_CHANGE_INSERT);
g_assert_cmpuint (td.start, ==, 0);
g_assert_cmpuint (td.end, ==, 7);
g_assert_cmpstr ("abc def", ==, g_bytes_get_data (td.contents, NULL));
attrs = pango_attr_list_new ();
attr = pango_attr_underline_new (PANGO_UNDERLINE_DOUBLE);
attr->start_index = 1;
attr->end_index = 2;
pango_attr_list_insert (attrs, attr);
gtk_text_set_attributes (GTK_TEXT (text), attrs);
pango_attr_list_unref (attrs);
test_data_clear (&td);
gtk_editable_select_region (GTK_EDITABLE (text), 1, 2);
g_assert_cmpuint (td.update_caret_pos_count, ==, 1);
g_assert_cmpuint (td.caret_pos, ==, 2);
bytes = gtk_accessible_text_get_contents (GTK_ACCESSIBLE_TEXT (text), 0, G_MAXINT);
string = g_bytes_get_data (bytes, &len);
g_assert_cmpint (len, ==, 8);
g_assert_cmpstr (string, ==, "abc def");
g_bytes_unref (bytes);
bytes = gtk_accessible_text_get_contents_at (GTK_ACCESSIBLE_TEXT (text), 1, GTK_ACCESSIBLE_TEXT_GRANULARITY_WORD, &start, &end);
string = g_bytes_get_data (bytes, &len);
g_assert_cmpint (len, ==, 5);
g_assert_cmpint (start, ==, 0);
g_assert_cmpint (end, ==, 4);
g_assert_cmpstr (string, ==, "abc ");
g_bytes_unref (bytes);
g_assert_cmpint (gtk_accessible_text_get_caret_position (GTK_ACCESSIBLE_TEXT (text)), ==, 2);
res = gtk_accessible_text_get_selection (GTK_ACCESSIBLE_TEXT (text), &n_ranges, &ranges);
g_assert_true (res);
g_assert_cmpint (n_ranges, ==, 1);
g_assert_cmpuint (ranges[0].start, ==, 1);
g_assert_cmpuint (ranges[0].length, ==, 1);
g_free (ranges);
res = gtk_accessible_text_get_attributes (GTK_ACCESSIBLE_TEXT (text), 1, &n_ranges, &ranges, &attr_names, &attr_values);
g_assert_true (res);
g_assert_cmpint (n_ranges, ==, 1);
g_assert_cmpuint (ranges[0].start, ==, 1);
g_assert_cmpuint (ranges[0].length, ==, 1);
g_assert_cmpstr (attr_names[0], ==, GTK_ACCESSIBLE_ATTRIBUTE_UNDERLINE);
g_assert_cmpstr (attr_values[0], ==, GTK_ACCESSIBLE_ATTRIBUTE_UNDERLINE_DOUBLE);
g_free (ranges);
g_strfreev (attr_names);
g_strfreev (attr_values);
test_data_clear (&td);
gtk_editable_delete_text (GTK_EDITABLE (text), 1, 2);
g_assert_cmpuint (td.update_text_contents_count, ==, 1);
g_assert_cmpuint (td.change, ==, GTK_ACCESSIBLE_TEXT_CONTENT_CHANGE_REMOVE);
g_assert_cmpuint (td.start, ==, 1);
g_assert_cmpuint (td.end, ==, 2);
g_assert_cmpstr ("b", ==, g_bytes_get_data (td.contents, NULL));
test_data_clear (&td);
gtk_at_context_unrealize (context);
g_object_unref (text);
}
int
main (int argc, char *argv[])
{
gtk_test_init (&argc, &argv, NULL);
g_test_add_func ("/a11y/text/accessible-text", test_text_accessible_text);
return g_test_run ();
}