AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
15cc85db29
gtk2/gtk/gtkfilechooserwidget.c

8613 lines
277 KiB
C
Raw Normal View History

Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* -*- Mode: C; c-file-style: "gnu"; tab-width: 8 -*- */
Revert name change svn path=/trunk/; revision=20724
2008-07-01 22:57:50 +00:00
/* GTK - The GIMP Toolkit
Initial revision
2003-03-21 20:34:02 +00:00
* gtkfilechooserwidget.c: Embeddable file selector widget
* Copyright (C) 2003, Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
Change FSF Address
2012-02-27 13:01:10 +00:00
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
Initial revision
2003-03-21 20:34:02 +00:00
*/
Include "config.h" instead of <config.h> Command used: find -name 2008-06-21 Johan Dahlin <jdahlin@async.com.br> * *.[ch]: Include "config.h" instead of <config.h> Command used: find -name \*.[ch]|xargs perl -p -i -e 's/^#include <config.h>/#include "config.h"/g' Rubberstamped by Mitch and Tim svn path=/trunk/; revision=20669
2008-06-22 14:28:52 +00:00
#include "config.h"
Boilerplate reduction
2006-05-02 23:56:43 +00:00
Initial revision
2003-03-21 20:34:02 +00:00
#include "gtkfilechooserwidget.h"
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
#include "gtkfilechooserwidgetprivate.h"
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#include "gtkbindings.h"
file chooser: Clean up includes
2015-01-28 15:35:49 +00:00
#include "gtkbutton.h"
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#include "gtkcelllayout.h"
#include "gtkcellrendererpixbuf.h"
#include "gtkcellrenderertext.h"
#include "gtkcheckmenuitem.h"
#include "gtkclipboard.h"
#include "gtkcomboboxtext.h"
#include "gtkentry.h"
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
#include "gtkstack.h"
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#include "gtkexpander.h"
#include "gtkfilechooserprivate.h"
#include "gtkfilechooserdialog.h"
New private interface to help negotiate the default size of the widget. Fri Feb 27 18:46:27 2004 Jonathan Blandford <jrb@redhat.com> * gtk/gtkfilechooserembed.h: New private interface to help negotiate the default size of the widget. Still a bit buggy, but better than the old behavior. * gtk/gtkfilechooserdefault.c: Implement the embed interface. * gtk/gtkfilechooserwidget.c: Proxy the embed interface. * gtk/gtkfilechooserdialog.c: Use the embed interface.
2004-02-27 23:51:16 +00:00
#include "gtkfilechooserembed.h"
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#include "gtkfilechooserentry.h"
#include "gtkfilechooserutils.h"
#include "gtkfilechooser.h"
#include "gtkfilesystem.h"
#include "gtkfilesystemmodel.h"
#include "gtkgrid.h"
#include "gtkicontheme.h"
#include "gtklabel.h"
#include "gtkmarshalers.h"
#include "gtkmessagedialog.h"
#include "gtkmountoperation.h"
#include "gtkpaned.h"
#include "gtkpathbar.h"
#include "gtkplacessidebar.h"
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
#include "gtkplacessidebarprivate.h"
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
#include "gtkplacesviewprivate.h"
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#include "gtkprivate.h"
#include "gtkrecentmanager.h"
file chooser: search improvements Make it so that typing switches to search unless we have a better use for the key events, and stop search if the entry is emptied.
2015-01-24 18:32:31 +00:00
#include "gtksearchentry.h"
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#include "gtkseparatormenuitem.h"
#include "gtksettings.h"
#include "gtksizegroup.h"
#include "gtksizerequest.h"
#include "gtktooltip.h"
#include "gtktreednd.h"
#include "gtktreeprivate.h"
#include "gtktreeselection.h"
#include "gtkbox.h"
Split GtkWindowGroup into its own file gtkwindow.c is too big and too messy. This is a small step towards making it better.
2014-06-04 10:18:03 +00:00
#include "gtkwindowgroup.h"
Intern some more strings. 2005-09-01 Matthias Clasen <mclasen@redhat.com> * gdk/*.c: Intern some more strings. * gtk/gtkintl.h: * gtk/*.c: Define an I_() macro and use it instead of the bulky g_intern_static_string().
2005-09-01 05:11:46 +00:00
#include "gtkintl.h"
file chooser: Allow opening folders in the file manager This has been suggested in https://bugzilla.gnome.org/show_bug.cgi?id=325150#c2
2015-02-12 04:34:04 +00:00
#include "gtkshow.h"
#include "gtkmain.h"
file chooser: Avoid animated scrolling for editing Avoid scrolling animation when scrolling to where we want to insert the new folder, since adding the entry doesn't do the right thing if the treeview is still scrolling. An alternative would be to wait for the animated scrolling to reach its target before starting the editing, but this is easier. https://bugzilla.gnome.org/show_bug.cgi?id=729366
2015-03-02 21:22:56 +00:00
#include "gtkscrollable.h"
file chooser: Set default widget in create folder popover This is using the new default widget functionality for popovers to make Enter in the entry activate the Create button. https://bugzilla.gnome.org/show_bug.cgi?id=747664
2015-04-17 04:14:28 +00:00
#include "gtkpopover.h"
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
#include "gtkrevealer.h"
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
#include "gtkspinner.h"
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
#include "gtkseparator.h"
#include "gtkmodelbutton.h"
#include "gtkgesturelongpress.h"
file chooser: Allow activating without double-click Interpret a unmodified primary click on the selection like a double click. This makes it possible to activate a file or open a folder without using double-click.
2015-07-31 11:03:25 +00:00
#include "gtkdebug.h"
fix preprocessor conditional confusion. (G_OS_UNIX/G_OS_WIN32 stuff) Tue Dec 16 15:01:10 2003 Manish Singh <yosh@gimp.org> * gtk/gtkfilechooserwidget.c: fix preprocessor conditional confusion. (G_OS_UNIX/G_OS_WIN32 stuff)
2003-12-16 22:58:58 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#include <cairo-gobject.h>
Move documentation to inline comments: GtkFileChooserWidget
2011-04-11 02:09:38 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#ifdef HAVE_UNISTD_H
#include <unistd.h>
#endif
#ifdef G_OS_WIN32
#include <io.h>
#endif
Add docs
2014-02-20 00:36:55 +00:00
/**
* SECTION:gtkfilechooserwidget
docs: Trivial typo fix
2014-05-20 02:47:59 +00:00
* @Short_description: A file chooser widget
Add docs
2014-02-20 00:36:55 +00:00
* @Title: GtkFileChooserWidget
* @See_also: #GtkFileChooserDialog
*
* #GtkFileChooserWidget is a widget for choosing files.
* It exposes the #GtkFileChooser interface, and you should
* use the methods of this interface to interact with the
* widget.
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Values for GtkSelection-related "info" fields */
#define SELECTION_TEXT 0
#define SELECTION_URI 1
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
/* 150 mseconds of delay */
#define LOCATION_CHANGED_TIMEOUT 150
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Profiling stuff */
#undef PROFILE_FILE_CHOOSER
#ifdef PROFILE_FILE_CHOOSER
#ifndef F_OK
#define F_OK 0
#endif
Move documentation to inline comments: GtkFileChooserWidget
2011-04-11 02:09:38 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#define PROFILE_INDENT 4
static int profile_indent;
static void
profile_add_indent (int indent)
{
profile_indent += indent;
if (profile_indent < 0)
g_error ("You screwed up your indentation");
}
void
_gtk_file_chooser_profile_log (const char *func, int indent, const char *msg1, const char *msg2)
Move GtkFileChooserWidgetPrivate to gtkfilechooserwidget.c In addition, remove the unused "file_system" field from that structure.
2013-04-12 01:50:57 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
char *str;
if (indent < 0)
profile_add_indent (indent);
if (profile_indent == 0)
str = g_strdup_printf ("MARK: %s %s %s", func ? func : "", msg1 ? msg1 : "", msg2 ? msg2 : "");
else
str = g_strdup_printf ("MARK: %*c %s %s %s", profile_indent - 1, ' ', func ? func : "", msg1 ? msg1 : "", msg2 ? msg2 : "");
access (str, F_OK);
g_free (str);
if (indent > 0)
profile_add_indent (indent);
}
#define profile_start(x, y) _gtk_file_chooser_profile_log (G_STRFUNC, PROFILE_INDENT, x, y)
#define profile_end(x, y) _gtk_file_chooser_profile_log (G_STRFUNC, -PROFILE_INDENT, x, y)
#define profile_msg(x, y) _gtk_file_chooser_profile_log (NULL, 0, x, y)
#else
#define profile_start(x, y)
#define profile_end(x, y)
#define profile_msg(x, y)
#endif
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
enum {
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
PROP_SEARCH_MODE = 1,
PROP_SUBTITLE
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
};
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
typedef enum {
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
LOAD_EMPTY, /* There is no model */
LOAD_PRELOAD, /* Model is loading and a timer is running; model isn't inserted into the tree yet */
LOAD_LOADING, /* Timeout expired, model is inserted into the tree, but not fully loaded yet */
LOAD_FINISHED /* Model is fully loaded and inserted into the tree */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
} LoadState;
typedef enum {
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
RELOAD_EMPTY, /* No folder has been set */
RELOAD_HAS_FOLDER /* We have a folder, although it may not be completely loaded yet; no need to reload */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
} ReloadState;
typedef enum {
LOCATION_MODE_PATH_BAR,
LOCATION_MODE_FILENAME_ENTRY
} LocationMode;
typedef enum {
OPERATION_MODE_BROWSE,
OPERATION_MODE_SEARCH,
file-chooser: make enter location an operation mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 17:49:54 +00:00
OPERATION_MODE_ENTER_LOCATION,
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
OPERATION_MODE_OTHER_LOCATIONS,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
OPERATION_MODE_RECENT
} OperationMode;
typedef enum {
STARTUP_MODE_RECENT,
STARTUP_MODE_CWD
} StartupMode;
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
typedef enum {
CLOCK_FORMAT_24,
CLOCK_FORMAT_12
} ClockFormat;
typedef enum {
DATE_FORMAT_REGULAR,
DATE_FORMAT_WITH_TIME
} DateFormat;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
struct _GtkFileChooserWidgetPrivate {
GtkFileChooserAction action;
GtkFileSystem *file_system;
/* Save mode widgets */
GtkWidget *save_widgets;
GtkWidget *save_widgets_table;
/* The file browsing widgets */
GtkWidget *browse_widgets_hpaned;
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
GtkWidget *browse_header_revealer;
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
GtkWidget *browse_header_stack;
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
GtkWidget *browse_files_stack;
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
GtkWidget *browse_files_swin;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkWidget *browse_files_tree_view;
file chooser: Note when searching remote locations Inform the user that we won't search recursively when searching in remote locations.
2015-07-24 20:26:32 +00:00
GtkWidget *remote_warning_bar;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkWidget *browse_files_popover;
file chooser: Code cleanups Shorten excessively long field names.
2015-07-02 21:36:00 +00:00
GtkWidget *add_shortcut_item;
GtkWidget *hidden_files_item;
GtkWidget *size_column_item;
GtkWidget *copy_file_location_item;
GtkWidget *visit_file_item;
GtkWidget *open_folder_item;
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
GtkWidget *rename_file_item;
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
GtkWidget *trash_file_item;
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
GtkWidget *delete_file_item;
file chooser: Code cleanups Shorten excessively long field names.
2015-07-02 21:36:00 +00:00
GtkWidget *sort_directories_item;
GtkWidget *show_time_item;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkWidget *browse_new_folder_button;
GtkSizeGroup *browse_path_bar_size_group;
GtkWidget *browse_path_bar;
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
GtkWidget *new_folder_name_entry;
GtkWidget *new_folder_create_button;
GtkWidget *new_folder_error_label;
GtkWidget *new_folder_popover;
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
GtkWidget *rename_file_name_entry;
GtkWidget *rename_file_rename_button;
GtkWidget *rename_file_error_label;
GtkWidget *rename_file_popover;
GFile *rename_file_source_file;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkGesture *long_press_gesture;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileSystemModel *browse_files_model;
char *browse_files_last_selected_name;
GtkWidget *places_sidebar;
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
GtkWidget *places_view;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
StartupMode startup_mode;
/* OPERATION_MODE_SEARCH */
GtkWidget *search_entry;
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
GtkWidget *search_spinner;
guint show_progress_timeout;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkSearchEngine *search_engine;
GtkQuery *search_query;
GtkFileSystemModel *search_model;
file chooser: Add and use a model search engine This search engine reuses the GFileInfo that is already loaded for the file list, to ensure that hits from the current directory always appear promptly.
2015-07-01 19:51:20 +00:00
GtkFileSystemModel *model_for_search;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* OPERATION_MODE_RECENT */
GtkRecentManager *recent_manager;
GtkFileSystemModel *recent_model;
guint load_recent_id;
Fix filechooser actionbar visibility The actionbar was always visible, even when there is no filter and no extra widget to show. Now we only show it when there is something to show.
2014-05-24 04:00:00 +00:00
GtkWidget *extra_and_filters;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkWidget *filter_combo_hbox;
GtkWidget *filter_combo;
GtkWidget *preview_box;
GtkWidget *preview_label;
GtkWidget *preview_widget;
GtkWidget *extra_align;
GtkWidget *extra_widget;
GtkWidget *location_entry_box;
GtkWidget *location_entry;
LocationMode location_mode;
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
GtkWidget *external_entry;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Handles */
GCancellable *file_list_drag_data_received_cancellable;
GCancellable *update_current_folder_cancellable;
GCancellable *should_respond_get_info_cancellable;
GCancellable *file_exists_get_info_cancellable;
LoadState load_state;
ReloadState reload_state;
guint load_timeout_id;
OperationMode operation_mode;
GSList *pending_select_files;
GtkFileFilter *current_filter;
GSList *filters;
GtkBookmarksManager *bookmarks_manager;
int num_volumes;
int num_shortcuts;
int num_bookmarks;
gulong volumes_changed_id;
gulong bookmarks_changed_id;
GFile *current_volume_file;
GFile *current_folder;
GFile *preview_file;
char *preview_display_name;
GtkTreeViewColumn *list_name_column;
GtkCellRenderer *list_name_renderer;
GtkCellRenderer *list_pixbuf_renderer;
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
GtkTreeViewColumn *list_time_column;
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
GtkCellRenderer *list_date_renderer;
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
GtkCellRenderer *list_time_renderer;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkTreeViewColumn *list_size_column;
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
GtkCellRenderer *list_size_renderer;
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
GtkTreeViewColumn *list_location_column;
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
GtkCellRenderer *list_location_renderer;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
guint location_changed_id;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gulong settings_signal_id;
int icon_size;
GSource *focus_entry_idle;
gulong toplevel_set_focus_id;
GtkWidget *toplevel_last_focus_widget;
gint sort_column;
GtkSortType sort_order;
/* Flags */
guint local_only : 1;
guint preview_widget_active : 1;
guint use_preview_label : 1;
guint select_multiple : 1;
guint show_hidden : 1;
file chooser: Fix gtk_file_chooser_set_show_hidden We should not override an explicitly set show-hidden value when loading the setting. https://bugzilla.gnome.org/show_bug.cgi?id=610925
2015-07-24 01:54:47 +00:00
guint show_hidden_set : 1;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
guint sort_directories_first : 1;
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
guint show_time : 1;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
guint do_overwrite_confirmation : 1;
guint list_sort_ascending : 1;
guint shortcuts_current_folder_active : 1;
guint show_size_column : 1;
guint create_folders : 1;
guint auto_selecting_first_row : 1;
};
#define MAX_LOADING_TIME 500
#define DEFAULT_NEW_FOLDER_NAME _("Type name of new folder")
/* Signal IDs */
enum {
LOCATION_POPUP,
LOCATION_POPUP_ON_PASTE,
UP_FOLDER,
DOWN_FOLDER,
HOME_FOLDER,
DESKTOP_FOLDER,
QUICK_BOOKMARK,
LOCATION_TOGGLE_POPUP,
SHOW_HIDDEN,
SEARCH_SHORTCUT,
RECENT_SHORTCUT,
file chooser: Add a shortcut to focus the sidebar Alt+P used to do this in the gtk2 filechooser (well, sometimes). Add this back as a key binding. https://bugzilla.gnome.org/show_bug.cgi?id=720684
2015-07-07 04:24:19 +00:00
PLACES_SHORTCUT,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
LAST_SIGNAL
};
static guint signals[LAST_SIGNAL] = { 0 };
#define MODEL_ATTRIBUTES "standard::name,standard::type,standard::display-name," \
"standard::is-hidden,standard::is-backup,standard::size," \
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
"standard::content-type,time::modified,time::access," \
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
"access::can-rename,access::can-delete,access::can-trash," \
"standard::target-uri"
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
enum {
/* the first 3 must be these due to settings caching sort column */
MODEL_COL_NAME,
MODEL_COL_SIZE,
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
MODEL_COL_TIME,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
MODEL_COL_FILE,
MODEL_COL_NAME_COLLATED,
MODEL_COL_IS_FOLDER,
MODEL_COL_IS_SENSITIVE,
MODEL_COL_SURFACE,
MODEL_COL_SIZE_TEXT,
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
MODEL_COL_DATE_TEXT,
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
MODEL_COL_TIME_TEXT,
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
MODEL_COL_LOCATION_TEXT,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
MODEL_COL_ELLIPSIZE,
MODEL_COL_NUM_COLUMNS
};
/* This list of types is passed to _gtk_file_system_model_new*() */
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
#define MODEL_COLUMN_TYPES \
MODEL_COL_NUM_COLUMNS, \
G_TYPE_STRING, /* MODEL_COL_NAME */ \
G_TYPE_INT64, /* MODEL_COL_SIZE */ \
G_TYPE_LONG, /* MODEL_COL_TIME */ \
G_TYPE_FILE, /* MODEL_COL_FILE */ \
G_TYPE_STRING, /* MODEL_COL_NAME_COLLATED */ \
G_TYPE_BOOLEAN, /* MODEL_COL_IS_FOLDER */ \
G_TYPE_BOOLEAN, /* MODEL_COL_IS_SENSITIVE */ \
CAIRO_GOBJECT_TYPE_SURFACE, /* MODEL_COL_SURFACE */ \
G_TYPE_STRING, /* MODEL_COL_SIZE_TEXT */ \
G_TYPE_STRING, /* MODEL_COL_DATE_TEXT */ \
G_TYPE_STRING, /* MODEL_COL_TIME_TEXT */ \
G_TYPE_STRING, /* MODEL_COL_LOCATION_TEXT */ \
PANGO_TYPE_ELLIPSIZE_MODE /* MODEL_COL_ELLIPSIZE */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Identifiers for target types */
enum {
GTK_TREE_MODEL_ROW,
Move GtkFileChooserWidgetPrivate to gtkfilechooserwidget.c In addition, remove the unused "file_system" field from that structure.
2013-04-12 01:50:57 +00:00
};
Move documentation to inline comments: GtkFileChooserWidget
2011-04-11 02:09:38 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#define DEFAULT_RECENT_FILES_LIMIT 50
/* Icon size for if we can't get it from the theme */
#define FALLBACK_ICON_SIZE 16
#define PREVIEW_HBOX_SPACING 12
#define NUM_LINES 45
#define NUM_CHARS 60
static void gtk_file_chooser_widget_iface_init (GtkFileChooserIface *iface);
static void gtk_file_chooser_embed_default_iface_init (GtkFileChooserEmbedIface *iface);
gtk: Don't use GObjectClass.constructor Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 22:22:42 +00:00
static void gtk_file_chooser_widget_constructed (GObject *object);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void gtk_file_chooser_widget_finalize (GObject *object);
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
static void gtk_file_chooser_widget_set_property (GObject *object,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
guint prop_id,
const GValue *value,
GParamSpec *pspec);
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
static void gtk_file_chooser_widget_get_property (GObject *object,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
guint prop_id,
GValue *value,
GParamSpec *pspec);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void gtk_file_chooser_widget_dispose (GObject *object);
static void gtk_file_chooser_widget_show_all (GtkWidget *widget);
static void gtk_file_chooser_widget_realize (GtkWidget *widget);
static void gtk_file_chooser_widget_map (GtkWidget *widget);
static void gtk_file_chooser_widget_unmap (GtkWidget *widget);
static void gtk_file_chooser_widget_hierarchy_changed (GtkWidget *widget,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkWidget *previous_toplevel);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void gtk_file_chooser_widget_style_updated (GtkWidget *widget);
static void gtk_file_chooser_widget_screen_changed (GtkWidget *widget,
file chooser: search improvements Make it so that typing switches to search unless we have a better use for the key events, and stop search if the entry is emptied.
2015-01-24 18:32:31 +00:00
GdkScreen *previous_screen);
Revert "file chooser: Don't start search too eagerly" This reverts commit f126157bfa9e8a550067fa169de24697add028bb.
2015-06-27 17:44:26 +00:00
static gboolean gtk_file_chooser_widget_key_press_event (GtkWidget *widget,
GdkEventKey *event);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
static gboolean gtk_file_chooser_widget_set_current_folder (GtkFileChooser *chooser,
GFile *folder,
GError **error);
static gboolean gtk_file_chooser_widget_update_current_folder (GtkFileChooser *chooser,
GFile *folder,
gboolean keep_trail,
gboolean clear_entry,
GError **error);
static GFile * gtk_file_chooser_widget_get_current_folder (GtkFileChooser *chooser);
static void gtk_file_chooser_widget_set_current_name (GtkFileChooser *chooser,
const gchar *name);
static gchar * gtk_file_chooser_widget_get_current_name (GtkFileChooser *chooser);
static gboolean gtk_file_chooser_widget_select_file (GtkFileChooser *chooser,
GFile *file,
GError **error);
static void gtk_file_chooser_widget_unselect_file (GtkFileChooser *chooser,
GFile *file);
static void gtk_file_chooser_widget_select_all (GtkFileChooser *chooser);
static void gtk_file_chooser_widget_unselect_all (GtkFileChooser *chooser);
static GSList * gtk_file_chooser_widget_get_files (GtkFileChooser *chooser);
static GFile * gtk_file_chooser_widget_get_preview_file (GtkFileChooser *chooser);
static GtkFileSystem *gtk_file_chooser_widget_get_file_system (GtkFileChooser *chooser);
static void gtk_file_chooser_widget_add_filter (GtkFileChooser *chooser,
GtkFileFilter *filter);
static void gtk_file_chooser_widget_remove_filter (GtkFileChooser *chooser,
GtkFileFilter *filter);
static GSList * gtk_file_chooser_widget_list_filters (GtkFileChooser *chooser);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static gboolean gtk_file_chooser_widget_add_shortcut_folder (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError **error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static gboolean gtk_file_chooser_widget_remove_shortcut_folder (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError **error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static GSList * gtk_file_chooser_widget_list_shortcut_folders (GtkFileChooser *chooser);
static void gtk_file_chooser_widget_get_default_size (GtkFileChooserEmbed *chooser_embed,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint *default_width,
gint *default_height);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static gboolean gtk_file_chooser_widget_should_respond (GtkFileChooserEmbed *chooser_embed);
static void gtk_file_chooser_widget_initial_focus (GtkFileChooserEmbed *chooser_embed);
static void add_selection_to_recent_list (GtkFileChooserWidget *impl);
static void location_popup_handler (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *path);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void location_popup_on_paste_handler (GtkFileChooserWidget *impl);
static void location_toggle_popup_handler (GtkFileChooserWidget *impl);
static void up_folder_handler (GtkFileChooserWidget *impl);
static void down_folder_handler (GtkFileChooserWidget *impl);
static void home_folder_handler (GtkFileChooserWidget *impl);
static void desktop_folder_handler (GtkFileChooserWidget *impl);
static void quick_bookmark_handler (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint bookmark_index);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void show_hidden_handler (GtkFileChooserWidget *impl);
static void search_shortcut_handler (GtkFileChooserWidget *impl);
static void recent_shortcut_handler (GtkFileChooserWidget *impl);
file chooser: Add a shortcut to focus the sidebar Alt+P used to do this in the gtk2 filechooser (well, sometimes). Add this back as a key binding. https://bugzilla.gnome.org/show_bug.cgi?id=720684
2015-07-07 04:24:19 +00:00
static void places_shortcut_handler (GtkFileChooserWidget *impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void update_appearance (GtkFileChooserWidget *impl);
static void operation_mode_set (GtkFileChooserWidget *impl, OperationMode mode);
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
static void location_mode_set (GtkFileChooserWidget *impl, LocationMode new_mode);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void set_current_filter (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileFilter *filter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void check_preview_change (GtkFileChooserWidget *impl);
static void filter_combo_changed (GtkComboBox *combo_box,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooserWidget *impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static gboolean list_select_func (GtkTreeSelection *selection,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreeModel *model,
GtkTreePath *path,
gboolean path_currently_selected,
gpointer data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void list_selection_changed (GtkTreeSelection *tree_selection,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooserWidget *impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void list_row_activated (GtkTreeView *tree_view,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreePath *path,
GtkTreeViewColumn *column,
GtkFileChooserWidget *impl);
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
static void list_cursor_changed (GtkTreeView *treeview,
GtkFileChooserWidget *impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void path_bar_clicked (GtkPathBar *path_bar,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GFile *child,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gboolean child_is_hidden,
GtkFileChooserWidget *impl);
static void update_cell_renderer_attributes (GtkFileChooserWidget *impl);
static void load_remove_timer (GtkFileChooserWidget *impl, LoadState new_load_state);
static void browse_files_center_selected_row (GtkFileChooserWidget *impl);
static void location_switch_to_path_bar (GtkFileChooserWidget *impl);
static void stop_loading_and_clear_list_model (GtkFileChooserWidget *impl,
gboolean remove_from_treeview);
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
static GSList *get_selected_files (GtkFileChooserWidget *impl);
static GSList *get_selected_infos (GtkFileChooserWidget *impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void search_setup_widgets (GtkFileChooserWidget *impl);
static void search_stop_searching (GtkFileChooserWidget *impl,
gboolean remove_query);
static void search_clear_model (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean remove_from_treeview);
file chooser: Simplify search entry callback
2015-01-28 21:02:03 +00:00
static void search_entry_activate_cb (GtkFileChooserWidget *impl);
file chooser: Make Escape go out of search mode This works in most other places where we have search, and is the expected behavior.
2015-01-28 21:06:02 +00:00
static void search_entry_stop_cb (GtkFileChooserWidget *impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void settings_load (GtkFileChooserWidget *impl);
gtkfilechooserwidget: When using an extra widget, show or hide the filter combo as appropriate https://bugzilla.gnome.org/show_bug.cgi?id=742653
2015-01-09 15:31:08 +00:00
static void show_filters (GtkFileChooserWidget *impl,
gboolean show);
file chooser: Don't show recent in save mode Don't show Recent in the sidebar when we are in save mode. We also ignore the startup-mode = recent in save mode now - we don't want to populate the file list with recent files if Recent is not on the sidebar. If you really want to go there, you can still enter recent:// in the location entry. https://bugzilla.gnome.org/show_bug.cgi?id=751653
2015-07-01 15:40:15 +00:00
static gboolean recent_files_setting_is_enabled (GtkFileChooserWidget *impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void recent_start_loading (GtkFileChooserWidget *impl);
static void recent_stop_loading (GtkFileChooserWidget *impl);
static void recent_clear_model (GtkFileChooserWidget *impl,
gboolean remove_from_treeview);
static gboolean recent_should_respond (GtkFileChooserWidget *impl);
static void set_file_system_backend (GtkFileChooserWidget *impl);
static void unset_file_system_backend (GtkFileChooserWidget *impl);
file chooser: Consistently clear model caches This was not done for all models in all places, leading to e.g. icon theme updates not applying correctly to search results.
2015-07-02 21:31:29 +00:00
static void clear_model_cache (GtkFileChooserWidget *impl,
gint column);
static void set_model_filter (GtkFileChooserWidget *impl,
GtkFileFilter *filter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
GtkFileChooserWidget: derive from GtkBox, not GtkVBox
2011-06-07 22:36:22 +00:00
G_DEFINE_TYPE_WITH_CODE (GtkFileChooserWidget, gtk_file_chooser_widget, GTK_TYPE_BOX,
gtk: Use new macros for defining private data https://bugzilla.gnome.org/show_bug.cgi?id=702996
2013-06-27 19:02:52 +00:00
G_ADD_PRIVATE (GtkFileChooserWidget)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_IMPLEMENT_INTERFACE (GTK_TYPE_FILE_CHOOSER,
gtk_file_chooser_widget_iface_init)
G_IMPLEMENT_INTERFACE (GTK_TYPE_FILE_CHOOSER_EMBED,
gtk_file_chooser_embed_default_iface_init));
Initial revision
2003-03-21 20:34:02 +00:00
static void
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_file_chooser_widget_iface_init (GtkFileChooserIface *iface)
Initial revision
2003-03-21 20:34:02 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
iface->select_file = gtk_file_chooser_widget_select_file;
iface->unselect_file = gtk_file_chooser_widget_unselect_file;
iface->select_all = gtk_file_chooser_widget_select_all;
iface->unselect_all = gtk_file_chooser_widget_unselect_all;
iface->get_files = gtk_file_chooser_widget_get_files;
iface->get_preview_file = gtk_file_chooser_widget_get_preview_file;
iface->get_file_system = gtk_file_chooser_widget_get_file_system;
iface->set_current_folder = gtk_file_chooser_widget_set_current_folder;
iface->get_current_folder = gtk_file_chooser_widget_get_current_folder;
iface->set_current_name = gtk_file_chooser_widget_set_current_name;
iface->get_current_name = gtk_file_chooser_widget_get_current_name;
iface->add_filter = gtk_file_chooser_widget_add_filter;
iface->remove_filter = gtk_file_chooser_widget_remove_filter;
iface->list_filters = gtk_file_chooser_widget_list_filters;
iface->add_shortcut_folder = gtk_file_chooser_widget_add_shortcut_folder;
iface->remove_shortcut_folder = gtk_file_chooser_widget_remove_shortcut_folder;
iface->list_shortcut_folders = gtk_file_chooser_widget_list_shortcut_folders;
}
Initial revision
2003-03-21 20:34:02 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
gtk_file_chooser_embed_default_iface_init (GtkFileChooserEmbedIface *iface)
{
iface->get_default_size = gtk_file_chooser_widget_get_default_size;
iface->should_respond = gtk_file_chooser_widget_should_respond;
iface->initial_focus = gtk_file_chooser_widget_initial_focus;
}
Initial revision
2003-03-21 20:34:02 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
pending_select_files_free (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_slist_free_full (priv->pending_select_files, g_object_unref);
priv->pending_select_files = NULL;
Initial revision
2003-03-21 20:34:02 +00:00
}
static void
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
pending_select_files_add (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file)
Initial revision
2003-03-21 20:34:02 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk: Use new macros for defining private data https://bugzilla.gnome.org/show_bug.cgi?id=702996
2013-06-27 19:02:52 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->pending_select_files =
g_slist_prepend (priv->pending_select_files, g_object_ref (file));
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
gtk_file_chooser_widget_finalize (GObject *object)
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (object);
GtkFileChooserWidgetPrivate *priv = impl->priv;
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
if (priv->location_changed_id > 0)
g_source_remove (priv->location_changed_id);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
unset_file_system_backend (impl);
g_free (priv->browse_files_last_selected_name);
Initial revision
2003-03-21 20:34:02 +00:00
file chooser: Memory handling fixes I forgot to clean up the long press gesture, and in additon, creating the rename popover from the ui template was causing the tree view to not be disposed when the file chooser goes away. Work around this by manually unsetting the relative-to widget of the popover in dispose.
2015-07-20 15:11:00 +00:00
g_slist_free_full (priv->filters, g_object_unref);
New private interface to help negotiate the default size of the widget. Fri Feb 27 18:46:27 2004 Jonathan Blandford <jrb@redhat.com> * gtk/gtkfilechooserembed.h: New private interface to help negotiate the default size of the widget. Still a bit buggy, but better than the old behavior. * gtk/gtkfilechooserdefault.c: Implement the embed interface. * gtk/gtkfilechooserwidget.c: Proxy the embed interface. * gtk/gtkfilechooserdialog.c: Use the embed interface.
2004-02-27 23:51:16 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->current_filter)
g_object_unref (priv->current_filter);
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->current_volume_file)
g_object_unref (priv->current_volume_file);
if (priv->current_folder)
g_object_unref (priv->current_folder);
if (priv->preview_file)
g_object_unref (priv->preview_file);
if (priv->browse_path_bar_size_group)
g_object_unref (priv->browse_path_bar_size_group);
/* Free all the Models we have */
stop_loading_and_clear_list_model (impl, FALSE);
search_clear_model (impl, FALSE);
recent_clear_model (impl, FALSE);
file chooser: Add and use a model search engine This search engine reuses the GFileInfo that is already loaded for the file list, to ensure that hits from the current directory always appear promptly.
2015-07-01 19:51:20 +00:00
g_clear_object (&impl->priv->model_for_search);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* stopping the load above should have cleared this */
g_assert (priv->load_timeout_id == 0);
g_free (priv->preview_display_name);
impl->priv = NULL;
G_OBJECT_CLASS (gtk_file_chooser_widget_parent_class)->finalize (object);
Initial revision
2003-03-21 20:34:02 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Shows an error dialog set as transient for the specified window */
Initial revision
2003-03-21 20:34:02 +00:00
static void
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
error_message_with_parent (GtkWindow *parent,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const char *msg,
const char *detail)
Initial revision
2003-03-21 20:34:02 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkWidget *dialog;
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
dialog = gtk_message_dialog_new (parent,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_ERROR,
GTK_BUTTONS_OK,
"%s",
msg);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
"%s", detail);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (parent && gtk_window_has_group (parent))
gtk_window_group_add_window (gtk_window_get_group (parent),
GTK_WINDOW (dialog));
gtk_dialog_run (GTK_DIALOG (dialog));
gtk_widget_destroy (dialog);
}
/* Returns a toplevel GtkWindow, or NULL if none */
static GtkWindow *
get_toplevel (GtkWidget *widget)
{
GtkWidget *toplevel;
toplevel = gtk_widget_get_toplevel (widget);
if (!gtk_widget_is_toplevel (toplevel))
return NULL;
else
return GTK_WINDOW (toplevel);
}
/* Shows an error dialog for the file chooser */
static void
error_message (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const char *msg,
const char *detail)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
error_message_with_parent (get_toplevel (GTK_WIDGET (impl)), msg, detail);
}
/* Shows a simple error dialog relative to a path. Frees the GError as well. */
static void
error_dialog (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const char *msg,
GFile *file,
GError *error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
if (error)
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
char *uri = NULL;
char *text;
if (file)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
uri = g_file_get_uri (file);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
text = g_strdup_printf (msg, uri);
error_message (impl, text, error->message);
g_free (text);
g_free (uri);
g_error_free (error);
Add a construct-only 'file_system' property, split test case into testfilechooser, testfilechooser-vfs
2003-03-26 17:09:26 +00:00
}
Initial revision
2003-03-21 20:34:02 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Shows an error dialog about not being able to create a folder */
Initial revision
2003-03-21 20:34:02 +00:00
static void
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
error_creating_folder_dialog (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError *error)
Initial revision
2003-03-21 20:34:02 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
error_dialog (impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_("The folder could not be created"),
file, error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Shows an error about not being able to create a folder because a file with
* the same name is already there.
*/
static void
error_creating_folder_over_existing_file_dialog (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError *error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
error_dialog (impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_("The folder could not be created, as a file with the same "
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
"name already exists. Try using a different name for the "
"folder, or rename the file first."),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
file, error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
error_with_file_under_nonfolder (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *parent_file)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GError *error;
error = NULL;
g_set_error_literal (&error, G_IO_ERROR, G_IO_ERROR_NOT_DIRECTORY,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_("You need to choose a valid filename."));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
error_dialog (impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_("Cannot create a file under %s as it is not a folder"),
parent_file, error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
error_filename_to_long_dialog (GtkFileChooserWidget *impl)
{
error_message (impl,
_("Cannot create file as the filename is too long"),
_("Try using a shorter name."));
}
/* Shows an error about not being able to select a folder because a file with
* the same name is already there.
*/
static void
error_selecting_folder_over_existing_file_dialog (GtkFileChooserWidget *impl)
{
error_message (impl,
_("You may only select folders"),
_("The item that you selected is not a folder try using a different item."));
}
/* Shows an error dialog about not being able to create a filename */
static void
error_building_filename_dialog (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GError *error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
error_dialog (impl, _("Invalid file name"),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
NULL, error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Shows an error dialog when we cannot switch to a folder */
static void
error_changing_folder_dialog (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError *error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
error_dialog (impl, _("The folder contents could not be displayed"),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
file, error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
static void
error_deleting_file (GtkFileChooserWidget *impl,
GFile *file,
GError *error)
{
error_dialog (impl, _("The file could not be deleted"), file, error);
}
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
static void
error_trashing_file (GtkFileChooserWidget *impl,
GFile *file,
GError *error)
{
Fix a minor typo
2015-07-07 19:51:55 +00:00
error_dialog (impl, _("The file could not be moved to the Trash"), file, error);
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Changes folders, displaying an error dialog if this fails */
static gboolean
change_folder_and_display_error (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
gboolean clear_entry)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GError *error;
gboolean result;
g_return_val_if_fail (G_IS_FILE (file), FALSE);
/* We copy the path because of this case:
*
* list_row_activated()
* fetches path from model; path belongs to the model (*)
* calls change_folder_and_display_error()
* calls gtk_file_chooser_set_current_folder_file()
* changing folders fails, sets model to NULL, thus freeing the path in (*)
*/
error = NULL;
result = gtk_file_chooser_widget_update_current_folder (GTK_FILE_CHOOSER (impl), file, TRUE, clear_entry, &error);
if (!result)
error_changing_folder_dialog (impl, file, error);
return result;
}
static void
emit_default_size_changed (GtkFileChooserWidget *impl)
{
profile_msg (" emit default-size-changed start", NULL);
g_signal_emit_by_name (impl, "default-size-changed");
profile_msg (" emit default-size-changed end", NULL);
}
static void
update_preview_widget_visibility (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->use_preview_label)
{
if (!priv->preview_label)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
priv->preview_label = gtk_label_new (priv->preview_display_name);
gtk_box_pack_start (GTK_BOX (priv->preview_box), priv->preview_label, FALSE, FALSE, 0);
gtk_box_reorder_child (GTK_BOX (priv->preview_box), priv->preview_label, 0);
gtk_label_set_ellipsize (GTK_LABEL (priv->preview_label), PANGO_ELLIPSIZE_MIDDLE);
gtk_widget_show (priv->preview_label);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
{
if (priv->preview_label)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
gtk_widget_destroy (priv->preview_label);
priv->preview_label = NULL;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
if (priv->preview_widget_active && priv->preview_widget)
gtk_widget_show (priv->preview_box);
else
gtk_widget_hide (priv->preview_box);
if (!gtk_widget_get_mapped (GTK_WIDGET (impl)))
emit_default_size_changed (impl);
}
static void
set_preview_widget (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkWidget *preview_widget)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (preview_widget == priv->preview_widget)
return;
if (priv->preview_widget)
gtk_container_remove (GTK_CONTAINER (priv->preview_box),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->preview_widget);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->preview_widget = preview_widget;
if (priv->preview_widget)
{
gtk_widget_show (priv->preview_widget);
gtk_box_pack_start (GTK_BOX (priv->preview_box), priv->preview_widget, TRUE, TRUE, 0);
gtk_box_reorder_child (GTK_BOX (priv->preview_box),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->preview_widget,
(priv->use_preview_label && priv->preview_label) ? 1 : 0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
update_preview_widget_visibility (impl);
}
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
static void
new_folder_popover_active (GtkWidget *button,
GParamSpec *pspec,
GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_entry_set_text (GTK_ENTRY (priv->new_folder_name_entry), "");
gtk_widget_set_sensitive (priv->new_folder_create_button, FALSE);
gtk_label_set_text (GTK_LABEL (priv->new_folder_error_label), "");
}
struct FileExistsData
{
GtkFileChooserWidget *impl;
gboolean file_exists_and_is_not_folder;
GFile *parent_file;
GFile *file;
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
GtkWidget *error_label;
GtkWidget *button;
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
};
static void
name_exists_get_info_cb (GCancellable *cancellable,
GFileInfo *info,
const GError *error,
gpointer user_data)
{
struct FileExistsData *data = user_data;
GtkFileChooserWidget *impl = data->impl;
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (cancellable != priv->file_exists_get_info_cancellable)
goto out;
priv->file_exists_get_info_cancellable = NULL;
if (g_cancellable_is_cancelled (cancellable))
goto out;
if (info != NULL)
{
const gchar *msg;
if (_gtk_file_info_consider_as_directory (info))
msg = _("A folder with that name already exists");
else
msg = _("A file with that name already exists");
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_widget_set_sensitive (data->button, FALSE);
gtk_label_set_text (GTK_LABEL (data->error_label), msg);
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
}
else
{
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_widget_set_sensitive (data->button, TRUE);
file chooser: Redo the trailing space warning Redo this slightly differently, so we can keep all the simple checks in one place. This will make it easier to reuse the code for file renaming.
2015-07-05 00:12:00 +00:00
/* Don't clear the label here, it may contain a warning */
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
}
out:
g_object_unref (impl);
g_object_unref (data->file);
g_free (data);
g_object_unref (cancellable);
}
static void
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
check_valid_child_name (GtkFileChooserWidget *impl,
GFile *parent,
const gchar *name,
gboolean is_folder,
file chooser: Allow rename-to-self When checking for a name clash for renaming, don't complain if the name is unchanged. That's harmless.
2015-07-07 01:39:39 +00:00
GFile *original,
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
GtkWidget *error_label,
GtkWidget *button)
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_widget_set_sensitive (button, FALSE);
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
if (name[0] == '\0')
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label), "");
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
else if (strcmp (name, ".") == 0)
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label),
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
is_folder ? _("A folder cannot be called “.”")
: _("A file cannot be called “.”"));
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
else if (strcmp (name, "..") == 0)
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label),
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
is_folder ? _("A folder cannot be called “..”")
: _("A file cannot be called “..”"));
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
else if (strchr (name, '/') != NULL)
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label),
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
is_folder ? _("Folder names cannot contain “/”")
: _("File names cannot contain “/”"));
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
else
{
GFile *file;
GError *error = NULL;
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label), "");
file chooser: Redo the trailing space warning Redo this slightly differently, so we can keep all the simple checks in one place. This will make it easier to reuse the code for file renaming.
2015-07-05 00:12:00 +00:00
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file = g_file_get_child_for_display_name (parent, name, &error);
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
if (file == NULL)
{
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label), error->message);
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
g_error_free (error);
}
file chooser: Allow rename-to-self When checking for a name clash for renaming, don't complain if the name is unchanged. That's harmless.
2015-07-07 01:39:39 +00:00
else if (original && g_file_equal (original, file))
{
gtk_widget_set_sensitive (button, TRUE);
g_object_unref (file);
}
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
else
{
struct FileExistsData *data;
file chooser: Redo the trailing space warning Redo this slightly differently, so we can keep all the simple checks in one place. This will make it easier to reuse the code for file renaming.
2015-07-05 00:12:00 +00:00
/* Warn the user about questionable names that are technically valid */
if (g_ascii_isspace (name[0]))
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label),
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
is_folder ? _("Folder names should not begin with a space")
: _("File names should not begin with a space"));
file chooser: Redo the trailing space warning Redo this slightly differently, so we can keep all the simple checks in one place. This will make it easier to reuse the code for file renaming.
2015-07-05 00:12:00 +00:00
else if (g_ascii_isspace (name[strlen (name) - 1]))
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label),
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
is_folder ? _("Folder names should not end with a space")
: _("File names should not end with a space"));
file chooser: Redo the trailing space warning Redo this slightly differently, so we can keep all the simple checks in one place. This will make it easier to reuse the code for file renaming.
2015-07-05 00:12:00 +00:00
else if (name[0] == '.')
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_label_set_text (GTK_LABEL (error_label),
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
is_folder ? _("Folder names starting with a “.” are hidden")
: _("File names starting with a “.” are hidden"));
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
data = g_new0 (struct FileExistsData, 1);
data->impl = g_object_ref (impl);
data->file = g_object_ref (file);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
data->error_label = error_label;
data->button = button;
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
if (priv->file_exists_get_info_cancellable)
g_cancellable_cancel (priv->file_exists_get_info_cancellable);
priv->file_exists_get_info_cancellable =
_gtk_file_system_get_info (priv->file_system,
file,
"standard::type",
name_exists_get_info_cb,
data);
g_object_unref (file);
}
}
}
static void
new_folder_name_changed (GtkEntry *entry,
GtkFileChooserWidget *impl)
{
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
check_valid_child_name (impl,
priv->current_folder,
gtk_entry_get_text (entry),
TRUE,
file chooser: Allow rename-to-self When checking for a name clash for renaming, don't complain if the name is unchanged. That's harmless.
2015-07-07 01:39:39 +00:00
NULL,
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
priv->new_folder_error_label,
priv->new_folder_create_button);
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
}
static void
new_folder_create_clicked (GtkButton *button,
GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GError *error = NULL;
GFile *file;
const gchar *name;
name = gtk_entry_get_text (GTK_ENTRY (priv->new_folder_name_entry));
file = g_file_get_child_for_display_name (priv->current_folder, name, &error);
gtk_widget_hide (priv->new_folder_popover);
if (file)
{
if (g_file_make_directory (file, NULL, &error))
change_folder_and_display_error (impl, file, FALSE);
else
error_creating_folder_dialog (impl, file, error);
g_object_unref (file);
}
else
error_creating_folder_dialog (impl, file, error);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
struct selection_check_closure {
GtkFileChooserWidget *impl;
int num_selected;
gboolean all_files;
gboolean all_folders;
};
/* Used from gtk_tree_selection_selected_foreach() */
static void
selection_check_foreach_cb (GtkTreeModel *model,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
struct selection_check_closure *closure;
gboolean is_folder;
GFile *file;
gtk_tree_model_get (model, iter,
MODEL_COL_FILE, &file,
MODEL_COL_IS_FOLDER, &is_folder,
-1);
if (file == NULL)
return;
g_object_unref (file);
closure = data;
closure->num_selected++;
closure->all_folders = closure->all_folders && is_folder;
closure->all_files = closure->all_files && !is_folder;
}
/* Checks whether the selected items in the file list are all files or all folders */
static void
selection_check (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint *num_selected,
gboolean *all_files,
gboolean *all_folders)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
struct selection_check_closure closure;
GtkTreeSelection *selection;
closure.impl = impl;
closure.num_selected = 0;
closure.all_files = TRUE;
closure.all_folders = TRUE;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_selected_foreach (selection,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
selection_check_foreach_cb,
&closure);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_assert (closure.num_selected == 0 || !(closure.all_files && closure.all_folders));
if (num_selected)
*num_selected = closure.num_selected;
if (all_files)
*all_files = closure.all_files;
if (all_folders)
*all_folders = closure.all_folders;
}
static gboolean
file_is_recent_uri (GFile *file)
{
GFile *recent;
gboolean same;
recent = g_file_new_for_uri ("recent:///");
same = g_file_equal (file, recent);
g_object_unref (recent);
return same;
}
static void
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
places_sidebar_open_location_cb (GtkPlacesSidebar *sidebar,
GFile *location,
GtkPlacesOpenFlags open_flags,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gboolean clear_entry;
Trivial: remove outdated comment
2015-06-04 19:14:04 +00:00
/* In the Save modes, we want to preserve what the user typed in the filename
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
* entry, so that he may choose another folder without erasing his typed name.
*/
if (priv->location_entry
&& !(priv->action == GTK_FILE_CHOOSER_ACTION_SAVE
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
|| priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
clear_entry = TRUE;
else
clear_entry = FALSE;
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
location_mode_set (impl, LOCATION_MODE_PATH_BAR);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (file_is_recent_uri (location))
operation_mode_set (impl, OPERATION_MODE_RECENT);
else
change_folder_and_display_error (impl, location, clear_entry);
}
/* Callback used when the places sidebar needs us to display an error message */
static void
places_sidebar_show_error_message_cb (GtkPlacesSidebar *sidebar,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const char *primary,
const char *secondary,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
error_message (impl, primary, secondary);
}
static gboolean
key_is_left_or_right (GdkEventKey *event)
{
guint modifiers;
modifiers = gtk_accelerator_get_default_mod_mask ();
return ((event->keyval == GDK_KEY_Right
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
|| event->keyval == GDK_KEY_KP_Right
|| event->keyval == GDK_KEY_Left
|| event->keyval == GDK_KEY_KP_Left)
&& (event->state & modifiers) == 0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static gboolean
file chooser: Trigger location entry not just from file list Use the same code that brings up the location entry on '/', '~' or '.' also when the focus is not on the file list. This prevents those key presses on the sidebar from ending up in the search entry.
2015-06-27 19:23:24 +00:00
should_trigger_location_entry (GtkWidget *widget,
GdkEventKey *event)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GdkModifierType no_text_input_mask;
no_text_input_mask =
gtk_widget_get_modifier_mask (widget, GDK_MODIFIER_INTENT_NO_TEXT_INPUT);
if ((event->keyval == GDK_KEY_slash
|| event->keyval == GDK_KEY_KP_Divide
file chooser: Open location entry on '.' Typing ./ is a fairly common practice to enter a location relative to the cwd, so make this open the location entry.
2015-06-27 19:06:25 +00:00
|| event->keyval == GDK_KEY_period
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#ifdef G_OS_UNIX
|| event->keyval == GDK_KEY_asciitilde
#endif
) && !(event->state & no_text_input_mask))
file chooser: Trigger location entry not just from file list Use the same code that brings up the location entry on '/', '~' or '.' also when the focus is not on the file list. This prevents those key presses on the sidebar from ending up in the search entry.
2015-06-27 19:23:24 +00:00
return TRUE;
return FALSE;
}
/* Handles key press events on the file list, so that we can trap Enter to
* activate the default button on our own. Also, checks to see if “/” has been
* pressed.
*/
static gboolean
browse_files_key_press_event_cb (GtkWidget *widget,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GdkEventKey *event,
gpointer data)
file chooser: Trigger location entry not just from file list Use the same code that brings up the location entry on '/', '~' or '.' also when the focus is not on the file list. This prevents those key presses on the sidebar from ending up in the search entry.
2015-06-27 19:23:24 +00:00
{
GtkFileChooserWidget *impl = (GtkFileChooserWidget *) data;
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Tweak bindings in save mode In save modes, the entry is really more for entering a name than entering a full location, so don't go there eagerly when '.', '/' or '~' are pressed. Make Ctrl-L work better in this mode too.
2015-06-27 19:54:49 +00:00
if (should_trigger_location_entry (widget, event) &&
(priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
location_popup_handler (impl, event->string);
return TRUE;
}
if (key_is_left_or_right (event))
{
file chooser: Improve keynav Some internal containers were erroneously taking focus, interrupting the flow of tab keynav, and using arrow keynav to go from the file list to the sidebar did not work anymore, after the recent sidebar rewrite.
2015-06-27 16:23:48 +00:00
if (gtk_widget_child_focus (priv->places_sidebar, GTK_DIR_LEFT))
return TRUE;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
if ((event->keyval == GDK_KEY_Return
|| event->keyval == GDK_KEY_ISO_Enter
|| event->keyval == GDK_KEY_KP_Enter
|| event->keyval == GDK_KEY_space
|| event->keyval == GDK_KEY_KP_Space)
&& !(event->state & gtk_accelerator_get_default_mod_mask ())
&& !(priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkWindow *window;
window = get_toplevel (widget);
if (window)
{
GtkWidget *default_widget, *focus_widget;
default_widget = gtk_window_get_default_widget (window);
focus_widget = gtk_window_get_focus (window);
if (widget != default_widget &&
!(widget == focus_widget && (!default_widget || !gtk_widget_get_sensitive (default_widget))))
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
gtk_window_activate_default (window);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return TRUE;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
}
return FALSE;
}
Revert "file chooser: Don't start search too eagerly" This reverts commit f126157bfa9e8a550067fa169de24697add028bb.
2015-06-27 17:44:26 +00:00
static gboolean
gtk_file_chooser_widget_key_press_event (GtkWidget *widget,
GdkEventKey *event)
{
GtkFileChooserWidget *impl = (GtkFileChooserWidget *) widget;
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Trigger location entry not just from file list Use the same code that brings up the location entry on '/', '~' or '.' also when the focus is not on the file list. This prevents those key presses on the sidebar from ending up in the search entry.
2015-06-27 19:23:24 +00:00
if (should_trigger_location_entry (widget, event))
{
file chooser: Tweak bindings in save mode In save modes, the entry is really more for entering a name than entering a full location, so don't go there eagerly when '.', '/' or '~' are pressed. Make Ctrl-L work better in this mode too.
2015-06-27 19:54:49 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
{
location_popup_handler (impl, event->string);
return TRUE;
}
file chooser: Trigger location entry not just from file list Use the same code that brings up the location entry on '/', '~' or '.' also when the focus is not on the file list. This prevents those key presses on the sidebar from ending up in the search entry.
2015-06-27 19:23:24 +00:00
}
file chooser: Tweak bindings in save mode In save modes, the entry is really more for entering a name than entering a full location, so don't go there eagerly when '.', '/' or '~' are pressed. Make Ctrl-L work better in this mode too.
2015-06-27 19:54:49 +00:00
else if (gtk_search_entry_handle_event (GTK_SEARCH_ENTRY (priv->search_entry), (GdkEvent *)event))
Revert "file chooser: Don't start search too eagerly" This reverts commit f126157bfa9e8a550067fa169de24697add028bb.
2015-06-27 17:44:26 +00:00
{
if (priv->operation_mode != OPERATION_MODE_SEARCH)
operation_mode_set (impl, OPERATION_MODE_SEARCH);
return TRUE;
}
if (GTK_WIDGET_CLASS (gtk_file_chooser_widget_parent_class)->key_press_event (widget, event))
return TRUE;
return FALSE;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Callback used from gtk_tree_selection_selected_foreach(); adds a bookmark for
* each selected item in the file list.
*/
static void
add_bookmark_foreach_cb (GtkTreeModel *model,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = (GtkFileChooserWidget *) data;
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFile *file;
gtk_tree_model_get (model, iter,
MODEL_COL_FILE, &file,
-1);
_gtk_bookmarks_manager_insert_bookmark (priv->bookmarks_manager, file, 0, NULL); /* NULL-GError */
g_object_unref (file);
}
/* Callback used when the "Add to Bookmarks" menu item is activated */
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
add_to_shortcuts_cb (GSimpleAction *action,
GVariant *parameter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_selected_foreach (selection,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
add_bookmark_foreach_cb,
impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
static gboolean
confirm_delete (GtkFileChooserWidget *impl,
GFileInfo *info)
{
GtkWindow *toplevel;
GtkWidget *dialog;
gint response;
const gchar *name;
name = g_file_info_get_display_name (info);
toplevel = get_toplevel (GTK_WIDGET (impl));
dialog = gtk_message_dialog_new (toplevel,
GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_QUESTION,
GTK_BUTTONS_NONE,
file chooser: Make delete confirmation match nautilus No need to diverge here.
2015-07-07 03:03:56 +00:00
_("Are you sure you want to permanently delete “%s”?"),
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
name);
file chooser: Make delete confirmation match nautilus No need to diverge here.
2015-07-07 03:03:56 +00:00
gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
_("If you delete an item, it will be permanently lost."));
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
gtk_dialog_add_button (GTK_DIALOG (dialog), _("_Cancel"), GTK_RESPONSE_CANCEL);
gtk_dialog_add_button (GTK_DIALOG (dialog), _("_Delete"), GTK_RESPONSE_ACCEPT);
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
gtk_dialog_set_alternative_button_order (GTK_DIALOG (dialog),
GTK_RESPONSE_ACCEPT,
GTK_RESPONSE_CANCEL,
-1);
G_GNUC_END_IGNORE_DEPRECATIONS
gtk_dialog_set_default_response (GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);
if (gtk_window_has_group (toplevel))
gtk_window_group_add_window (gtk_window_get_group (toplevel), GTK_WINDOW (dialog));
response = gtk_dialog_run (GTK_DIALOG (dialog));
gtk_widget_destroy (dialog);
return (response == GTK_RESPONSE_ACCEPT);
}
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
static void
delete_selected_cb (GtkTreeModel *model,
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
{
GtkFileChooserWidget *impl = data;
GFile *file;
GFileInfo *info;
GError *error = NULL;
file = _gtk_file_system_model_get_file (GTK_FILE_SYSTEM_MODEL (model), iter);
info = _gtk_file_system_model_get_info (GTK_FILE_SYSTEM_MODEL (model), iter);
if (confirm_delete (impl, info))
{
if (!g_file_delete (file, NULL, &error))
error_deleting_file (impl, file, error);
}
}
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
delete_file_cb (GSimpleAction *action,
GVariant *parameter,
gpointer data)
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
gtk_tree_selection_selected_foreach (selection, delete_selected_cb, impl);
}
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
static void
trash_selected_cb (GtkTreeModel *model,
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
{
GtkFileChooserWidget *impl = data;
GFile *file;
GError *error = NULL;
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
file = _gtk_file_system_model_get_file (GTK_FILE_SYSTEM_MODEL (model), iter);
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
if (!g_file_trash (file, NULL, &error))
error_trashing_file (impl, file, error);
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
}
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
trash_file_cb (GSimpleAction *action,
GVariant *parameter,
gpointer data)
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
gtk_tree_selection_selected_foreach (selection, trash_selected_cb, impl);
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
}
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
static void
rename_file_name_changed (GtkEntry *entry,
GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFileType file_type;
file_type = g_file_query_file_type (priv->rename_file_source_file,
G_FILE_QUERY_INFO_NONE, NULL);
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
check_valid_child_name (impl,
priv->current_folder,
gtk_entry_get_text (entry),
file_type == G_FILE_TYPE_DIRECTORY,
file chooser: Allow rename-to-self When checking for a name clash for renaming, don't complain if the name is unchanged. That's harmless.
2015-07-07 01:39:39 +00:00
priv->rename_file_source_file,
wip: reshuffle name checks
2015-07-07 01:35:03 +00:00
priv->rename_file_error_label,
priv->rename_file_rename_button);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
}
static void
rename_file_end (GtkPopover *popover,
GtkFileChooserWidget *impl)
{
g_object_unref (impl->priv->rename_file_source_file);
}
static void
rename_file_rename_clicked (GtkButton *button,
GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFile *dest;
const gchar* new_name;
gtk_widget_hide (priv->rename_file_popover);
new_name = gtk_entry_get_text (GTK_ENTRY (priv->rename_file_name_entry));
dest = g_file_get_parent (priv->rename_file_source_file);
if (dest)
{
GFile *child;
GError *error = NULL;
child = g_file_get_child (dest, new_name);
if (child)
{
if (!g_file_move (priv->rename_file_source_file, child, G_FILE_COPY_NONE,
NULL, NULL, NULL, &error))
error_dialog (impl, _("The file could not be renamed"), child, error);
g_object_unref (child);
}
g_object_unref (dest);
}
}
static void
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
rename_selected_cb (GtkTreeModel *model,
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
{
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
GtkFileChooserWidget *impl = data;
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GdkRectangle rect;
gchar *filename;
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
gtk_tree_model_get (model, iter,
MODEL_COL_FILE, &priv->rename_file_source_file,
-1);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
gtk_tree_view_get_cell_area (GTK_TREE_VIEW (priv->browse_files_tree_view),
path, priv->list_name_column, &rect);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
gtk_tree_view_convert_tree_to_widget_coords (GTK_TREE_VIEW (priv->browse_files_tree_view),
rect.x, rect.y, &rect.x, &rect.y);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
filename = g_file_get_basename (priv->rename_file_source_file);
gtk_entry_set_text (GTK_ENTRY(priv->rename_file_name_entry), filename);
g_free (filename);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
gtk_popover_set_pointing_to (GTK_POPOVER (priv->rename_file_popover), &rect);
gtk_widget_show (priv->rename_file_popover);
gtk_widget_grab_focus (priv->rename_file_popover);
}
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
rename_file_cb (GSimpleAction *action,
GVariant *parameter,
gpointer data)
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
/* insensitive until we change the name */
gtk_widget_set_sensitive (priv->rename_file_rename_button, FALSE);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_selected_foreach (selection, rename_selected_cb, impl);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* callback used to set data to clipboard */
static void
copy_file_get_cb (GtkClipboard *clipboard,
GtkSelectionData *selection_data,
guint info,
gpointer data)
{
GSList *selected_files = data;
if (selected_files)
{
gint num_files = g_slist_length (selected_files);
gchar **uris;
gint i;
GSList *l;
uris = g_new (gchar *, num_files + 1);
uris[num_files] = NULL; /* null terminator */
i = 0;
for (l = selected_files; l; l = l->next)
{
GFile *file = (GFile *) l->data;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (info == SELECTION_URI)
uris[i] = g_file_get_uri (file);
else /* if (info == SELECTION_TEXT) - let this be the fallback */
uris[i] = g_file_get_parse_name (file);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
i++;
}
if (info == SELECTION_URI)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_selection_data_set_uris (selection_data, uris);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else /* if (info == SELECTION_TEXT) - let this be the fallback */
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
char *str = g_strjoinv (" ", uris);
gtk_selection_data_set_text (selection_data, str, -1);
g_free (str);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_strfreev (uris);
}
}
/* callback used to clear the clipboard data */
static void
copy_file_clear_cb (GtkClipboard *clipboard,
gpointer data)
{
GSList *selected_files = data;
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
g_slist_free_full (selected_files, g_object_unref);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Callback used when the "Copy file’s location" menu item is activated */
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
copy_file_location_cb (GSimpleAction *action,
GVariant *parameter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GSList *selected_files = NULL;
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
selected_files = get_selected_files (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (selected_files)
{
GtkClipboard *clipboard;
GtkTargetList *target_list;
GtkTargetEntry *targets;
int n_targets;
clipboard = gtk_widget_get_clipboard (GTK_WIDGET (impl), GDK_SELECTION_CLIPBOARD);
target_list = gtk_target_list_new (NULL, 0);
gtk_target_list_add_text_targets (target_list, SELECTION_TEXT);
gtk_target_list_add_uri_targets (target_list, SELECTION_URI);
targets = gtk_target_table_new_from_list (target_list, &n_targets);
gtk_target_list_unref (target_list);
gtk_clipboard_set_with_data (clipboard, targets, n_targets,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
copy_file_get_cb,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
copy_file_clear_cb,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
selected_files);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_target_table_free (targets, n_targets);
}
}
/* Callback used when the "Visit this file" menu item is activated */
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
visit_file_cb (GSimpleAction *action,
GVariant *parameter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GSList *files;
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
files = get_selected_files (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Sigh, just use the first one */
if (files)
{
GFile *file = files->data;
gtk_file_chooser_widget_select_file (GTK_FILE_CHOOSER (impl), file, NULL); /* NULL-GError */
}
Code cleanup Use g_slist_free_full more consistently. This commit just converts the obvious cases where g_slist_forall is directly followed by g_slist_free.
2015-07-31 21:57:04 +00:00
g_slist_free_full (files, g_object_unref);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Allow opening folders in the file manager This has been suggested in https://bugzilla.gnome.org/show_bug.cgi?id=325150#c2
2015-02-12 04:34:04 +00:00
/* Callback used when the "Open this folder" menu item is activated */
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
open_folder_cb (GSimpleAction *action,
GVariant *parameter,
gpointer data)
file chooser: Allow opening folders in the file manager This has been suggested in https://bugzilla.gnome.org/show_bug.cgi?id=325150#c2
2015-02-12 04:34:04 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
file chooser: Allow opening folders in the file manager This has been suggested in https://bugzilla.gnome.org/show_bug.cgi?id=325150#c2
2015-02-12 04:34:04 +00:00
GSList *files;
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
files = get_selected_files (impl);
file chooser: Allow opening folders in the file manager This has been suggested in https://bugzilla.gnome.org/show_bug.cgi?id=325150#c2
2015-02-12 04:34:04 +00:00
/* Sigh, just use the first one */
if (files)
{
GFile *file = files->data;
gchar *uri;
uri = g_file_get_uri (file);
gtk_show_uri (gtk_widget_get_screen (GTK_WIDGET (impl)), uri, gtk_get_current_event_time (), NULL);
g_free (uri);
}
Code cleanup Use g_slist_free_full more consistently. This commit just converts the obvious cases where g_slist_forall is directly followed by g_slist_free.
2015-07-31 21:57:04 +00:00
g_slist_free_full (files, g_object_unref);
file chooser: Allow opening folders in the file manager This has been suggested in https://bugzilla.gnome.org/show_bug.cgi?id=325150#c2
2015-02-12 04:34:04 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* callback used when the "Show Hidden Files" menu item is toggled */
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
change_show_hidden_state (GSimpleAction *action,
GVariant *state,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
g_simple_action_set_state (action, state);
g_object_set (impl, "show-hidden", g_variant_get_boolean (state), NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Callback used when the "Show Size Column" menu item is toggled */
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
change_show_size_state (GSimpleAction *action,
GVariant *state,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
g_simple_action_set_state (action, state);
priv->show_size_column = g_variant_get_boolean (state);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_view_column_set_visible (priv->list_size_column,
priv->show_size_column);
}
GtkFileChooser: Add a menuitem for 'sort directories first' This has been requested repeatedly.
2014-11-03 05:02:13 +00:00
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
change_sort_directories_first_state (GSimpleAction *action,
GVariant *state,
gpointer data)
GtkFileChooser: Add a menuitem for 'sort directories first' This has been requested repeatedly.
2014-11-03 05:02:13 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
GtkFileChooser: Add a menuitem for 'sort directories first' This has been requested repeatedly.
2014-11-03 05:02:13 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSortable *sortable;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
g_simple_action_set_state (action, state);
priv->sort_directories_first = g_variant_get_boolean (state);
GtkFileChooser: Add a menuitem for 'sort directories first' This has been requested repeatedly.
2014-11-03 05:02:13 +00:00
/* force resorting */
sortable = GTK_TREE_SORTABLE (priv->browse_files_model);
if (sortable == NULL)
return;
gtk_tree_sortable_set_sort_column_id (sortable,
GTK_TREE_SORTABLE_UNSORTED_SORT_COLUMN_ID,
priv->sort_order);
gtk_tree_sortable_set_sort_column_id (sortable,
priv->sort_column,
priv->sort_order);
}
file chooser: Consistently clear model caches This was not done for all models in all places, leading to e.g. icon theme updates not applying correctly to search results.
2015-07-02 21:31:29 +00:00
static void
clear_model_cache (GtkFileChooserWidget *impl,
gint column)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->browse_files_model)
_gtk_file_system_model_clear_cache (priv->browse_files_model, column);
if (priv->search_model)
_gtk_file_system_model_clear_cache (priv->search_model, column);
if (priv->recent_model)
_gtk_file_system_model_clear_cache (priv->recent_model, column);
}
static void
set_model_filter (GtkFileChooserWidget *impl,
GtkFileFilter *filter)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->browse_files_model)
_gtk_file_system_model_set_filter (priv->browse_files_model, filter);
if (priv->search_model)
_gtk_file_system_model_set_filter (priv->search_model, filter);
if (priv->recent_model)
_gtk_file_system_model_set_filter (priv->recent_model, filter);
}
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
static void
update_time_renderer_visible (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_object_set (priv->list_time_renderer,
"visible", priv->show_time,
NULL);
file chooser: Consistently clear model caches This was not done for all models in all places, leading to e.g. icon theme updates not applying correctly to search results.
2015-07-02 21:31:29 +00:00
clear_model_cache (impl, MODEL_COL_DATE_TEXT);
clear_model_cache (impl, MODEL_COL_TIME_TEXT);
file chooser: Improve column sizing Allow the name and location columns to be resized, but arrange for their sizing to be reset when the column layout changes (either by the location column appearing/disappearing, or by the time column changing between mtime and atime. This gives a decent compromise between good automatic sizing and user control.
2015-07-03 16:22:39 +00:00
gtk_widget_queue_draw (priv->browse_files_tree_view);
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
}
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
change_show_time_state (GSimpleAction *action,
GVariant *state,
gpointer data)
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkFileChooserWidget *impl = data;
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
g_simple_action_set_state (action, state);
priv->show_time = g_variant_get_boolean (state);
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
update_time_renderer_visible (impl);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Shows an error dialog about not being able to select a dragged file */
static void
error_selecting_dragged_file_dialog (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError *error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
error_dialog (impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_("Could not select file"),
file, error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
file_list_drag_data_select_uris (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gchar **uris)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
int i;
char *uri;
GtkFileChooser *chooser = GTK_FILE_CHOOSER (impl);
for (i = 1; uris[i]; i++)
{
GFile *file;
GError *error = NULL;
uri = uris[i];
file = g_file_new_for_uri (uri);
gtk_file_chooser_widget_select_file (chooser, file, &error);
if (error)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
error_selecting_dragged_file_dialog (impl, file, error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_object_unref (file);
}
}
struct FileListDragData
{
GtkFileChooserWidget *impl;
gchar **uris;
GFile *file;
};
static void
file_list_drag_data_received_get_info_cb (GCancellable *cancellable,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFileInfo *info,
const GError *error,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gboolean cancelled = g_cancellable_is_cancelled (cancellable);
struct FileListDragData *data = user_data;
GtkFileChooser *chooser = GTK_FILE_CHOOSER (data->impl);
GtkFileChooserWidgetPrivate *priv = data->impl->priv;
if (cancellable != priv->file_list_drag_data_received_cancellable)
goto out;
priv->file_list_drag_data_received_cancellable = NULL;
if (cancelled || error)
goto out;
if ((priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SAVE) &&
data->uris[1] == 0 && !error && _gtk_file_info_consider_as_directory (info))
change_folder_and_display_error (data->impl, data->file, FALSE);
else
{
file chooser: Fix compiler warnings Fix warnings due to -Wdeclaration-after-statement and -Wshadow.
2015-05-31 01:25:48 +00:00
GError *local_error = NULL;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_file_chooser_widget_unselect_all (chooser);
file chooser: Fix compiler warnings Fix warnings due to -Wdeclaration-after-statement and -Wshadow.
2015-05-31 01:25:48 +00:00
gtk_file_chooser_widget_select_file (chooser, data->file, &local_error);
if (local_error)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
error_selecting_dragged_file_dialog (data->impl, data->file, local_error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
browse_files_center_selected_row (data->impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
if (priv->select_multiple)
file_list_drag_data_select_uris (data->impl, data->uris);
out:
g_object_unref (data->impl);
g_strfreev (data->uris);
g_object_unref (data->file);
g_free (data);
g_object_unref (cancellable);
}
static void
file_list_drag_data_received_cb (GtkWidget *widget,
GdkDragContext *context,
gint x,
gint y,
GtkSelectionData *selection_data,
guint info,
guint time_,
file chooser: Fix compiler warnings Fix warnings due to -Wdeclaration-after-statement and -Wshadow.
2015-05-31 01:25:48 +00:00
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Fix compiler warnings Fix warnings due to -Wdeclaration-after-statement and -Wshadow.
2015-05-31 01:25:48 +00:00
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (user_data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
gchar **uris;
char *uri;
GFile *file;
/* Allow only drags from other widgets; see bug #533891. */
if (gtk_drag_get_source_widget (context) == widget)
{
g_signal_stop_emission_by_name (widget, "drag-data-received");
return;
}
/* Parse the text/uri-list string, navigate to the first one */
uris = gtk_selection_data_get_uris (selection_data);
if (uris && uris[0])
{
struct FileListDragData *data;
uri = uris[0];
file = g_file_new_for_uri (uri);
data = g_new0 (struct FileListDragData, 1);
data->impl = g_object_ref (impl);
data->uris = uris;
data->file = file;
if (priv->file_list_drag_data_received_cancellable)
g_cancellable_cancel (priv->file_list_drag_data_received_cancellable);
priv->file_list_drag_data_received_cancellable =
_gtk_file_system_get_info (priv->file_system, file,
"standard::type",
file_list_drag_data_received_get_info_cb,
data);
}
g_signal_stop_emission_by_name (widget, "drag-data-received");
}
/* Don't do anything with the drag_drop signal */
static gboolean
file_list_drag_drop_cb (GtkWidget *widget,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GdkDragContext *context,
gint x,
gint y,
guint time_,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
g_signal_stop_emission_by_name (widget, "drag-drop");
return TRUE;
}
gtkfilechooserwidget: show drop hints on gtkplacessidebar Now with the API addition on gtkplacessidebar, we can show some hints for the drop targets. https://bugzilla.gnome.org/show_bug.cgi?id=747793
2015-04-11 15:36:41 +00:00
static void
file_list_drag_begin_cb (GtkWidget *widget,
GdkDragContext *context,
GtkFileChooserWidget *impl)
{
gtk_places_sidebar_set_drop_targets_visible (GTK_PLACES_SIDEBAR (impl->priv->places_sidebar),
TRUE,
context);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Disable the normal tree drag motion handler, it makes it look like you're
dropping the dragged item onto a tree item */
static gboolean
file_list_drag_motion_cb (GtkWidget *widget,
GdkDragContext *context,
gint x,
gint y,
guint time_,
GtkFileChooserWidget *impl)
{
g_signal_stop_emission_by_name (widget, "drag-motion");
return TRUE;
}
gtkfilechooserwidget: show drop hints on gtkplacessidebar Now with the API addition on gtkplacessidebar, we can show some hints for the drop targets. https://bugzilla.gnome.org/show_bug.cgi?id=747793
2015-04-11 15:36:41 +00:00
static void
file_list_drag_end_cb (GtkWidget *widget,
GdkDragContext *context,
gpointer user_data)
{
GtkFileChooserWidget *impl;
impl = GTK_FILE_CHOOSER_WIDGET (user_data);
gtk_places_sidebar_set_drop_targets_visible (GTK_PLACES_SIDEBAR (impl->priv->places_sidebar),
FALSE,
context);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Sensitizes the "Copy file’s location" and other context menu items if there is actually
* a selection active.
*/
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
check_file_list_popover_sensitivity (GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gint num_selected;
gboolean all_files;
gboolean all_folders;
gboolean active;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GActionGroup *actions;
GAction *action, *action2;
actions = gtk_widget_get_action_group (priv->browse_files_tree_view, "item");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
selection_check (impl, &num_selected, &all_files, &all_folders);
active = (num_selected != 0);
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "copy-location");
g_simple_action_set_enabled (G_SIMPLE_ACTION (action), active);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "add-shortcut");
g_simple_action_set_enabled (G_SIMPLE_ACTION (action), active && all_folders);
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "visit");
g_simple_action_set_enabled (G_SIMPLE_ACTION (action), active);
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "open");
g_simple_action_set_enabled (G_SIMPLE_ACTION (action), (num_selected == 1) && all_folders);
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "rename");
if (num_selected == 1)
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GSList *infos;
GFileInfo *info;
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
infos = get_selected_infos (impl);
info = G_FILE_INFO (infos->data);
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
g_simple_action_set_enabled (G_SIMPLE_ACTION (action),
g_file_info_get_attribute_boolean (info, G_FILE_ATTRIBUTE_ACCESS_CAN_RENAME));
g_slist_free_full (infos, g_object_unref);
}
else
g_simple_action_set_enabled (G_SIMPLE_ACTION (action), FALSE);
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "delete");
action2 = g_action_map_lookup_action (G_ACTION_MAP (actions), "trash");
if (num_selected == 1)
{
GSList *infos;
GFileInfo *info;
infos = get_selected_infos (impl);
info = G_FILE_INFO (infos->data);
if (g_file_info_get_attribute_boolean (info, G_FILE_ATTRIBUTE_ACCESS_CAN_TRASH))
{
g_simple_action_set_enabled (G_SIMPLE_ACTION (action2), TRUE);
gtk_widget_set_visible (priv->delete_file_item, FALSE);
gtk_widget_set_visible (priv->trash_file_item, TRUE);
}
else if (g_file_info_get_attribute_boolean (info, G_FILE_ATTRIBUTE_ACCESS_CAN_DELETE))
{
g_simple_action_set_enabled (G_SIMPLE_ACTION (action), TRUE);
gtk_widget_set_visible (priv->delete_file_item, TRUE);
gtk_widget_set_visible (priv->trash_file_item, FALSE);
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
}
else
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
g_simple_action_set_enabled (G_SIMPLE_ACTION (action2), FALSE);
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
gtk_widget_set_visible (priv->delete_file_item, FALSE);
gtk_widget_set_visible (priv->trash_file_item, TRUE);
}
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
g_slist_free_full (infos, g_object_unref);
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
}
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
else
{
gtk_widget_set_visible (priv->delete_file_item, FALSE);
gtk_widget_set_visible (priv->trash_file_item, TRUE);
g_simple_action_set_enabled (G_SIMPLE_ACTION (action2), FALSE);
}
}
static GActionEntry entries[] = {
{ "visit", visit_file_cb, NULL, NULL, NULL },
{ "open", open_folder_cb, NULL, NULL, NULL },
{ "copy-location", copy_file_location_cb, NULL, NULL, NULL },
{ "add-shortcut", add_to_shortcuts_cb, NULL, NULL, NULL },
{ "rename", rename_file_cb, NULL, NULL, NULL },
{ "delete", delete_file_cb, NULL, NULL, NULL },
{ "trash", trash_file_cb, NULL, NULL, NULL },
{ "toggle-show-hidden", NULL, NULL, "false", change_show_hidden_state },
{ "toggle-show-size", NULL, NULL, "false", change_show_size_state },
{ "toggle-show-time", NULL, NULL, "false", change_show_time_state },
{ "toggle-sort-dirs-first", NULL, NULL, "false", change_sort_directories_first_state }
};
static void
add_actions (GtkFileChooserWidget *impl)
{
GActionGroup *actions;
actions = G_ACTION_GROUP (g_simple_action_group_new ());
g_action_map_add_action_entries (G_ACTION_MAP (actions),
entries, G_N_ELEMENTS (entries),
impl);
gtk_widget_insert_action_group (GTK_WIDGET (impl->priv->browse_files_tree_view), "item", actions);
g_object_unref (actions);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static GtkWidget *
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
append_separator (GtkWidget *box)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkWidget *separator;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
separator = g_object_new (GTK_TYPE_SEPARATOR,
"orientation", GTK_ORIENTATION_HORIZONTAL,
"visible", TRUE,
"margin-start", 12,
"margin-end", 12,
"margin-top", 6,
"margin-bottom", 6,
NULL);
gtk_container_add (GTK_CONTAINER (box), separator);
return separator;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
/* Constructs the popup menu for the file list if needed */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static GtkWidget *
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
add_button (GtkWidget *box,
const gchar *label,
const gchar *action)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkWidget *item;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
item = g_object_new (GTK_TYPE_MODEL_BUTTON,
"visible", TRUE,
"action-name", action,
"text", label,
NULL);
gtk_container_add (GTK_CONTAINER (box), item);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return item;
}
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
file_list_build_popover (GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GtkWidget *box;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
if (priv->browse_files_popover)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
priv->browse_files_popover = gtk_popover_new (priv->browse_files_tree_view);
box = gtk_box_new (GTK_ORIENTATION_VERTICAL, 0);
g_object_set (box, "margin", 10, NULL);
gtk_widget_show (box);
gtk_container_add (GTK_CONTAINER (priv->browse_files_popover), box);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
priv->visit_file_item = add_button (box, _("_Visit File"), "item.visit");
priv->open_folder_item = add_button (box, _("_Open With File Manager"), "item.open");
priv->copy_file_location_item = add_button (box, _("_Copy Location"), "item.copy-location");
priv->add_shortcut_item = add_button (box, _("_Add to Bookmarks"), "item.add-shortcut");
priv->rename_file_item = add_button (box, _("_Rename"), "item.rename");
priv->delete_file_item = add_button (box, _("_Delete"), "item.delete");
priv->trash_file_item = add_button (box, _("_Move to Trash"), "item.trash");
file chooser: Allow deleting files This is another often requestsed feature for save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 03:46:11 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
append_separator (box);
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
priv->hidden_files_item = add_button (box, _("Show _Hidden Files"), "item.toggle-show-hidden");
priv->size_column_item = add_button (box, _("Show _Size Column"), "item.toggle-show-size");
priv->show_time_item = add_button (box, _("Show _Time"), "item.toggle-show-time");
priv->sort_directories_item = add_button (box, _("Sort _Folders before Files"), "item.toggle-sort-dirs-first");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
/* Updates the popover for the file list, creating it if necessary */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
file_list_update_popover (GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
GActionGroup *actions;
GAction *action;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
file_list_build_popover (impl);
check_file_list_popover_sensitivity (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* The sensitivity of the Add to Bookmarks item is set in
* bookmarks_check_add_sensitivity()
*/
file chooser: Separate out delete and trash We only ever show one of the two context menu items (and we prefer Move to Trash over Delete). Only use the confirmation dialog when deleting.
2015-07-07 02:57:40 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER ||
priv->operation_mode != OPERATION_MODE_BROWSE)
{
gtk_widget_set_visible (priv->rename_file_item, FALSE);
gtk_widget_set_visible (priv->delete_file_item, FALSE);
gtk_widget_set_visible (priv->trash_file_item, FALSE);
}
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
file chooser: Code cleanups Shorten excessively long field names.
2015-07-02 21:36:00 +00:00
gtk_widget_set_visible (priv->visit_file_item, (priv->operation_mode != OPERATION_MODE_BROWSE));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
actions = gtk_widget_get_action_group (priv->browse_files_tree_view, "item");
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "toggle-show-hidden");
g_simple_action_set_state (G_SIMPLE_ACTION (action), g_variant_new_boolean (priv->show_hidden));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "toggle-show-size");
g_simple_action_set_state (G_SIMPLE_ACTION (action), g_variant_new_boolean (priv->show_size_column));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "toggle-show-time");
g_simple_action_set_state (G_SIMPLE_ACTION (action), g_variant_new_boolean (priv->show_time));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
action = g_action_map_lookup_action (G_ACTION_MAP (actions), "toggle-sort-dirs-first");
g_simple_action_set_state (G_SIMPLE_ACTION (action), g_variant_new_boolean (priv->sort_directories_first));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
file_list_show_popover (GtkFileChooserWidget *impl,
file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
2015-07-17 12:56:06 +00:00
gdouble x,
gdouble y)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
2015-07-17 12:56:06 +00:00
GdkRectangle rect;
GtkTreeSelection *selection;
GtkTreeModel *model;
GList *list;
GtkTreePath *path;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
file_list_update_popover (impl);
file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
2015-07-17 12:56:06 +00:00
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
list = gtk_tree_selection_get_selected_rows (selection, &model);
path = list->data;
gtk_tree_view_get_cell_area (GTK_TREE_VIEW (priv->browse_files_tree_view), path, NULL, &rect);
gtk_tree_view_convert_bin_window_to_widget_coords (GTK_TREE_VIEW (priv->browse_files_tree_view),
rect.x, rect.y, &rect.x, &rect.y);
rect.x = CLAMP (x - 20, 0, gtk_widget_get_allocated_width (priv->browse_files_tree_view) - 40);
rect.width = 40;
g_list_free_full (list, (GDestroyNotify) gtk_tree_path_free);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
2015-07-17 12:56:06 +00:00
gtk_popover_set_pointing_to (GTK_POPOVER (priv->browse_files_popover), &rect);
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
gtk_widget_show (priv->browse_files_popover);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Callback used for the GtkWidget::popup-menu signal of the file list */
static gboolean
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
list_popup_menu_cb (GtkWidget *widget,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
2015-07-17 12:56:06 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
file_list_show_popover (impl,
0.5 * gtk_widget_get_allocated_width (GTK_WIDGET (priv->browse_files_tree_view)),
0.5 * gtk_widget_get_allocated_height (GTK_WIDGET (priv->browse_files_tree_view)));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return TRUE;
}
file chooser: Allow activating without double-click Interpret a unmodified primary click on the selection like a double click. This makes it possible to activate a file or open a folder without using double-click.
2015-07-31 11:03:25 +00:00
static void
get_selection_modifiers (GtkWidget *widget,
GdkEventButton *event,
gboolean *modify,
gboolean *extend)
{
GdkModifierType mask;
*modify = FALSE;
*extend = FALSE;
mask = gtk_widget_get_modifier_mask (widget, GDK_MODIFIER_INTENT_MODIFY_SELECTION);
if ((event->state & mask) == mask)
*modify = TRUE;
mask = gtk_widget_get_modifier_mask (widget, GDK_MODIFIER_INTENT_EXTEND_SELECTION);
if ((event->state & mask) == mask)
*extend = TRUE;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Callback used when a button is pressed on the file list. We trap button 3 to
* bring up a popup menu.
*/
static gboolean
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
list_button_press_event_cb (GtkWidget *widget,
GdkEventButton *event,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
static gboolean in_press = FALSE;
file chooser: Allow activating without double-click Interpret a unmodified primary click on the selection like a double click. This makes it possible to activate a file or open a folder without using double-click.
2015-07-31 11:03:25 +00:00
GtkTreePath *path;
GtkTreeViewColumn *column;
GdkDevice *device;
gboolean modify, extend, is_touchscreen;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (in_press)
return FALSE;
file chooser: Allow activating without double-click Interpret a unmodified primary click on the selection like a double click. This makes it possible to activate a file or open a folder without using double-click.
2015-07-31 11:03:25 +00:00
device = gdk_event_get_source_device ((GdkEvent *) event);
is_touchscreen = gtk_simulate_touchscreen () ||
gdk_device_get_source (device) == GDK_SOURCE_TOUCHSCREEN;
get_selection_modifiers (widget, event, &modify, &extend);
if (!is_touchscreen &&
!modify && !extend &&
event->button == GDK_BUTTON_PRIMARY &&
gtk_tree_view_get_path_at_pos (GTK_TREE_VIEW (priv->browse_files_tree_view),
event->x, event->y,
&path, &column, NULL, NULL))
{
GtkTreeSelection *selection;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
if (gtk_tree_selection_path_is_selected (selection, path))
{
list_row_activated (GTK_TREE_VIEW (priv->browse_files_tree_view), path, column, impl);
gtk_tree_path_free (path);
return TRUE;
}
gtk_tree_path_free (path);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (!gdk_event_triggers_context_menu ((GdkEvent *) event))
return FALSE;
in_press = TRUE;
gtk_widget_event (priv->browse_files_tree_view, (GdkEvent *) event);
in_press = FALSE;
file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
2015-07-17 12:56:06 +00:00
file_list_show_popover (impl, event->x, event->y);
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return TRUE;
}
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
static void
long_press_cb (GtkGesture *gesture,
gdouble x,
gdouble y,
GtkFileChooserWidget *impl)
{
file chooser: Improve popover positioning We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
2015-07-17 12:56:06 +00:00
file_list_show_popover (impl, x, y);
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
typedef struct {
OperationMode operation_mode;
gint general_column;
gint model_column;
} ColumnMap;
/* Sets the sort column IDs for the file list; needs to be done whenever we
* change the model on the treeview.
*/
static void
file_list_set_sort_column_ids (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Really stop typeahead search popups GtkTreeView is a bad widget and constantly resets the search-column behind our back. We need to re-unset it every time a model is set :-(
2015-03-03 23:02:09 +00:00
gtk_tree_view_set_search_column (GTK_TREE_VIEW (priv->browse_files_tree_view), -1);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_view_column_set_sort_column_id (priv->list_name_column, MODEL_COL_NAME);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_tree_view_column_set_sort_column_id (priv->list_time_column, MODEL_COL_TIME);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_view_column_set_sort_column_id (priv->list_size_column, MODEL_COL_SIZE);
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
gtk_tree_view_column_set_sort_column_id (priv->list_location_column, MODEL_COL_LOCATION_TEXT);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static gboolean
file_list_query_tooltip_cb (GtkWidget *widget,
gint x,
gint y,
gboolean keyboard_tip,
GtkTooltip *tooltip,
gpointer user_data)
{
GtkFileChooserWidget *impl = user_data;
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeModel *model;
GtkTreePath *path;
GtkTreeIter iter;
GFile *file;
gchar *filename;
if (priv->operation_mode == OPERATION_MODE_BROWSE)
return FALSE;
if (!gtk_tree_view_get_tooltip_context (GTK_TREE_VIEW (priv->browse_files_tree_view),
&x, &y,
keyboard_tip,
&model, &path, &iter))
return FALSE;
Whitespace fixes
2015-08-03 00:58:19 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_model_get (model, &iter,
MODEL_COL_FILE, &file,
-1);
if (file == NULL)
{
gtk_tree_path_free (path);
return FALSE;
}
filename = g_file_get_path (file);
gtk_tooltip_set_text (tooltip, filename);
gtk_tree_view_set_tooltip_row (GTK_TREE_VIEW (priv->browse_files_tree_view),
tooltip,
path);
g_free (filename);
g_object_unref (file);
gtk_tree_path_free (path);
return TRUE;
}
static void
set_icon_cell_renderer_fixed_size (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gint xpad, ypad;
gtk_cell_renderer_get_padding (priv->list_pixbuf_renderer, &xpad, &ypad);
Whitespace fixes
2015-08-03 00:58:19 +00:00
gtk_cell_renderer_set_fixed_size (priv->list_pixbuf_renderer,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
xpad * 2 + priv->icon_size,
ypad * 2 + priv->icon_size);
}
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
static gboolean
location_changed_timeout_cb (gpointer user_data)
{
GtkFileChooserWidget *impl = user_data;
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_file_chooser_unselect_all (GTK_FILE_CHOOSER (impl));
check_preview_change (impl);
g_signal_emit_by_name (impl, "selection-changed", 0);
priv->location_changed_id = 0;
return G_SOURCE_REMOVE;
}
static void
reset_location_timeout (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->location_changed_id > 0)
g_source_remove (priv->location_changed_id);
priv->location_changed_id = g_timeout_add (LOCATION_CHANGED_TIMEOUT,
location_changed_timeout_cb,
impl);
g_source_set_name_by_id (priv->location_changed_id, "[gtk+] location_changed_timeout_cb");
}
static void
file chooser: Don't react to entry changes in select-folder mode In select-folder mode, we are putting the directory name into the entry ourselves. Then the entry appends a /. If we react to this 'spontaneous' change of the entry by clearing the list selection, this will in turn make us clear the entry. We don't want that. https://bugzilla.gnome.org/show_bug.cgi?id=726855
2014-03-22 02:06:24 +00:00
location_entry_changed_cb (GtkEditable *editable,
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
GtkFileChooserWidget *impl)
{
file chooser: Don't react to entry changes in select-folder mode In select-folder mode, we are putting the directory name into the entry ourselves. Then the entry appends a /. If we react to this 'spontaneous' change of the entry by clearing the list selection, this will in turn make us clear the entry. We don't want that. https://bugzilla.gnome.org/show_bug.cgi?id=726855
2014-03-22 02:06:24 +00:00
if (impl->priv->action != GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
reset_location_timeout (impl);
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser entry: Capture Escape and emit :hide-entry Make the file chooser entry optionally capture Escape and emit a signal. Make the file chooser widget hide the entry on that signal and go back to the path bar. This gives us a two-level undo: location entry -> path bar -> dialog close. When the location entry is permanently displayed in the header for save mode, we still let the first Escape close the dialog.
2015-06-27 05:40:04 +00:00
static void
location_entry_close_clicked (GtkFileChooserWidget *impl)
{
location_mode_set (impl, LOCATION_MODE_PATH_BAR);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
location_entry_setup (GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
gtk_entry_set_placeholder_text (GTK_ENTRY (priv->location_entry), _("Location"));
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
g_signal_connect (priv->location_entry, "changed",
G_CALLBACK (location_entry_changed_cb), impl);
file chooser entry: Capture Escape and emit :hide-entry Make the file chooser entry optionally capture Escape and emit a signal. Make the file chooser widget hide the entry on that signal and go back to the path bar. This gives us a two-level undo: location entry -> path bar -> dialog close. When the location entry is permanently displayed in the header for save mode, we still let the first Escape close the dialog.
2015-06-27 05:40:04 +00:00
g_signal_connect_swapped (priv->location_entry, "hide-entry",
G_CALLBACK (location_entry_close_clicked), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_file_chooser_entry_set_local_only (GTK_FILE_CHOOSER_ENTRY (priv->location_entry), priv->local_only);
_gtk_file_chooser_entry_set_action (GTK_FILE_CHOOSER_ENTRY (priv->location_entry), priv->action);
gtk_entry_set_width_chars (GTK_ENTRY (priv->location_entry), 45);
gtk_entry_set_activates_default (GTK_ENTRY (priv->location_entry), TRUE);
}
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
static void
location_entry_disconnect (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->location_entry)
g_signal_handlers_disconnect_by_func (priv->location_entry, location_entry_changed_cb, impl);
}
static void
location_entry_create (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (!priv->location_entry)
{
file chooser entry: Capture Escape and emit :hide-entry Make the file chooser entry optionally capture Escape and emit a signal. Make the file chooser widget hide the entry on that signal and go back to the path bar. This gives us a two-level undo: location entry -> path bar -> dialog close. When the location entry is permanently displayed in the header for save mode, we still let the first Escape close the dialog.
2015-06-27 05:40:04 +00:00
priv->location_entry = _gtk_file_chooser_entry_new (TRUE, TRUE);
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
location_entry_setup (impl);
}
}
file chooser: Make bindings work in save entry With the name entry being in the header bar now, we no longer get bindings working by just letting the key event bubble up, we have to explicitly apply them on key events that the save entry is not handling.
2015-07-17 03:36:51 +00:00
static gboolean
external_entry_key_press (GtkWidget *entry,
GdkEventKey *event,
GtkFileChooserWidget *impl)
{
/* Since the entry is not a descendent of the file chooser widget
* in this case, we need to manually make our bindings apply.
*/
return gtk_bindings_activate_event (G_OBJECT (impl), event);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Creates the widgets specific to Save mode */
static void
save_widgets_create (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkWidget *vbox;
GtkWidget *widget;
file chooser: Fix a crash The save_widgets_create function was not safe against being called multiple times in save mode, calling gtk_file_chooser_set_create_folders was a way to trigger this crash.
2015-07-22 23:07:20 +00:00
if (priv->save_widgets != NULL ||
(priv->external_entry && priv->location_entry == priv->external_entry))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return;
location_switch_to_path_bar (impl);
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
gtk_places_sidebar_set_location (GTK_PLACES_SIDEBAR (priv->places_sidebar), priv->current_folder);
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
if (priv->external_entry)
{
location_entry_disconnect (impl);
priv->location_entry = priv->external_entry;
location_entry_setup (impl);
file chooser: Make bindings work in save entry With the name entry being in the header bar now, we no longer get bindings working by just letting the key event bubble up, we have to explicitly apply them on key events that the save entry is not handling.
2015-07-17 03:36:51 +00:00
g_signal_connect_after (priv->external_entry, "key-press-event",
G_CALLBACK (external_entry_key_press), impl);
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
return;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 12);
file-chooser: style save mode name box as a search bar So we get a bottom border etc. https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:26:08 +00:00
gtk_style_context_add_class (gtk_widget_get_style_context (vbox), "search-bar");
gtk_container_set_border_width (GTK_CONTAINER (vbox), 0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->save_widgets_table = gtk_grid_new ();
file-chooser: style save mode name box as a search bar So we get a bottom border etc. https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:26:08 +00:00
gtk_container_set_border_width (GTK_CONTAINER (priv->save_widgets_table), 10);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_box_pack_start (GTK_BOX (vbox), priv->save_widgets_table, FALSE, FALSE, 0);
gtk_widget_show (priv->save_widgets_table);
gtk_grid_set_row_spacing (GTK_GRID (priv->save_widgets_table), 12);
gtk_grid_set_column_spacing (GTK_GRID (priv->save_widgets_table), 12);
/* Label */
widget = gtk_label_new_with_mnemonic (_("_Name:"));
gtk_widget_set_halign (widget, GTK_ALIGN_START);
gtk_widget_set_valign (widget, GTK_ALIGN_CENTER);
gtk_grid_attach (GTK_GRID (priv->save_widgets_table), widget, 0, 0, 1, 1);
gtk_widget_show (widget);
/* Location entry */
location_entry_create (impl);
gtk_widget_set_hexpand (priv->location_entry, TRUE);
gtk_grid_attach (GTK_GRID (priv->save_widgets_table), priv->location_entry, 1, 0, 1, 1);
gtk_widget_show (priv->location_entry);
gtk_label_set_mnemonic_widget (GTK_LABEL (widget), priv->location_entry);
priv->save_widgets = vbox;
gtk_box_pack_start (GTK_BOX (impl), priv->save_widgets, FALSE, FALSE, 0);
gtk_box_reorder_child (GTK_BOX (impl), priv->save_widgets, 0);
gtk_widget_show (priv->save_widgets);
}
/* Destroys the widgets specific to Save mode */
static void
save_widgets_destroy (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
if (priv->external_entry && priv->external_entry == priv->location_entry)
{
file chooser: Make bindings work in save entry With the name entry being in the header bar now, we no longer get bindings working by just letting the key event bubble up, we have to explicitly apply them on key events that the save entry is not handling.
2015-07-17 03:36:51 +00:00
g_signal_handlers_disconnect_by_func (priv->external_entry, external_entry_key_press, impl);
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
location_entry_disconnect (impl);
priv->location_entry = NULL;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->save_widgets == NULL)
return;
gtk_widget_destroy (priv->save_widgets);
priv->save_widgets = NULL;
priv->save_widgets_table = NULL;
priv->location_entry = NULL;
}
/* Turns on the path bar widget. Can be called even if we are already in that
* mode.
*/
static void
location_switch_to_path_bar (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->location_entry)
{
gtk_widget_destroy (priv->location_entry);
priv->location_entry = NULL;
}
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_header_stack), "pathbar");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Turns on the location entry. Can be called even if we are already in that
* mode.
*/
static void
location_switch_to_filename_entry (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
/* when in search or recent files mode, we are not showing the
file-chooser: allow views to extend to the sides of the dialog https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-07 21:18:56 +00:00
* browse_header_box container, so there's no point in switching
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
* to it.
*/
if (priv->operation_mode == OPERATION_MODE_SEARCH ||
priv->operation_mode == OPERATION_MODE_RECENT)
return;
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
gtk_revealer_set_reveal_child (GTK_REVEALER (priv->browse_header_revealer), TRUE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (!priv->location_entry)
{
location_entry_create (impl);
gtk_box_pack_start (GTK_BOX (priv->location_entry_box), priv->location_entry, TRUE, TRUE, 0);
}
_gtk_file_chooser_entry_set_base_folder (GTK_FILE_CHOOSER_ENTRY (priv->location_entry), priv->current_folder);
gtk_widget_show (priv->location_entry);
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_header_stack), "location");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_grab_focus (priv->location_entry);
}
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
/* Sets a new location mode.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
static void
location_mode_set (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
LocationMode new_mode)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
{
GtkWindow *toplevel;
GtkWidget *current_focus;
gboolean switch_to_file_list;
switch (new_mode)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
case LOCATION_MODE_PATH_BAR:
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* The location_entry will disappear when we switch to path bar mode. So,
* we'll focus the file list in that case, to avoid having a window with
* no focused widget.
*/
toplevel = get_toplevel (GTK_WIDGET (impl));
switch_to_file_list = FALSE;
if (toplevel)
{
current_focus = gtk_window_get_focus (toplevel);
if (!current_focus || current_focus == priv->location_entry)
switch_to_file_list = TRUE;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
location_switch_to_path_bar (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (switch_to_file_list)
gtk_widget_grab_focus (priv->browse_files_tree_view);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
case LOCATION_MODE_FILENAME_ENTRY:
location_switch_to_filename_entry (impl);
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
default:
g_assert_not_reached ();
return;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
priv->location_mode = new_mode;
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
g_object_notify (G_OBJECT (impl), "subtitle");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
/* Callback used when the places sidebar asks us to show other locations */
static void
places_sidebar_show_other_locations_cb (GtkPlacesSidebar *sidebar,
GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
priv->preview_widget_active = FALSE;
update_preview_widget_visibility (impl);
operation_mode_set (impl, OPERATION_MODE_OTHER_LOCATIONS);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
location_toggle_popup_handler (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Make Ctrl-L work in search mode There is no real reason to not allow this. The transition is not quite as smooth as it should be, currently, but at least it works.
2015-07-04 04:13:13 +00:00
if ((priv->operation_mode == OPERATION_MODE_RECENT ||
priv->operation_mode == OPERATION_MODE_SEARCH) &&
file chooser: Make Ctrl-L work in recent Just switch to browse mode when we see Ctrl-L in recent mode. https://bugzilla.gnome.org/show_bug.cgi?id=660450
2015-01-18 22:21:14 +00:00
(priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER))
operation_mode_set (impl, OPERATION_MODE_BROWSE);
file chooser: Tweak bindings in save mode In save modes, the entry is really more for entering a name than entering a full location, so don't go there eagerly when '.', '/' or '~' are pressed. Make Ctrl-L work better in this mode too.
2015-06-27 19:54:49 +00:00
/* If the file entry is not visible, show it (it is _always_
* visible in save modes, handle these first).
* If it is visible, turn it off only if it is focused.
* Otherwise, switch to the entry.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
file chooser: Tweak bindings in save mode In save modes, the entry is really more for entering a name than entering a full location, so don't go there eagerly when '.', '/' or '~' are pressed. Make Ctrl-L work better in this mode too.
2015-06-27 19:54:49 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
gtk_widget_grab_focus (priv->location_entry);
}
else if (priv->location_mode == LOCATION_MODE_PATH_BAR)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
location_mode_set (impl, LOCATION_MODE_FILENAME_ENTRY);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (priv->location_mode == LOCATION_MODE_FILENAME_ENTRY)
{
if (gtk_widget_has_focus (priv->location_entry))
{
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
location_mode_set (impl, LOCATION_MODE_PATH_BAR);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
{
gtk_widget_grab_focus (priv->location_entry);
}
}
}
gtk: Don't use GObjectClass.constructor Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 22:22:42 +00:00
static void
gtk_file_chooser_widget_constructed (GObject *object)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gtk: Don't use GObjectClass.constructor Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 22:22:42 +00:00
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (object);
GtkFileChooserWidgetPrivate *priv = impl->priv;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
profile_start ("start", NULL);
gtk: Don't use GObjectClass.constructor Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 22:22:42 +00:00
G_OBJECT_CLASS (gtk_file_chooser_widget_parent_class)->constructed (object);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_assert (priv->file_system);
update_appearance (impl);
profile_end ("end", NULL);
}
Fix filechooser actionbar visibility The actionbar was always visible, even when there is no filter and no extra widget to show. Now we only show it when there is something to show.
2014-05-24 04:00:00 +00:00
static void
update_extra_and_filters (GtkFileChooserWidget *impl)
{
gtk_widget_set_visible (impl->priv->extra_and_filters,
gtk_widget_get_visible (impl->priv->extra_align) ||
gtk_widget_get_visible (impl->priv->filter_combo_hbox));
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Sets the extra_widget by packing it in the appropriate place */
static void
set_extra_widget (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkWidget *extra_widget)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (extra_widget)
{
g_object_ref (extra_widget);
/* FIXME: is this right ? */
gtk_widget_show (extra_widget);
}
if (priv->extra_widget)
{
gtk_container_remove (GTK_CONTAINER (priv->extra_align), priv->extra_widget);
g_object_unref (priv->extra_widget);
}
priv->extra_widget = extra_widget;
if (priv->extra_widget)
{
gtk_container_add (GTK_CONTAINER (priv->extra_align), priv->extra_widget);
gtk_widget_show (priv->extra_align);
}
else
gtk_widget_hide (priv->extra_align);
Fix filechooser actionbar visibility The actionbar was always visible, even when there is no filter and no extra widget to show. Now we only show it when there is something to show.
2014-05-24 04:00:00 +00:00
gtkfilechooserwidget: When using an extra widget, show or hide the filter combo as appropriate https://bugzilla.gnome.org/show_bug.cgi?id=742653
2015-01-09 15:31:08 +00:00
/* Calls update_extra_and_filters */
show_filters (impl, priv->filters != NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
switch_to_home_dir (GtkFileChooserWidget *impl)
{
const gchar *home = g_get_home_dir ();
GFile *home_file;
if (home == NULL)
return;
home_file = g_file_new_for_path (home);
gtk_file_chooser_set_current_folder_file (GTK_FILE_CHOOSER (impl), home_file, NULL); /* NULL-GError */
g_object_unref (home_file);
}
static void
set_local_only (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean local_only)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (local_only != priv->local_only)
{
priv->local_only = local_only;
if (priv->location_entry)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_gtk_file_chooser_entry_set_local_only (GTK_FILE_CHOOSER_ENTRY (priv->location_entry), local_only);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_places_sidebar_set_local_only (GTK_PLACES_SIDEBAR (priv->places_sidebar), local_only);
if (local_only && priv->current_folder &&
!_gtk_file_has_native_path (priv->current_folder))
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
/* If we are pointing to a non-local folder, make an effort to change
* back to a local folder, but it's really up to the app to not cause
* such a situation, so we ignore errors.
*/
switch_to_home_dir (impl);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
}
/* Sets the file chooser to multiple selection mode */
static void
set_select_multiple (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean select_multiple,
gboolean property_notify)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
GtkSelectionMode mode;
if (select_multiple == priv->select_multiple)
return;
mode = select_multiple ? GTK_SELECTION_MULTIPLE : GTK_SELECTION_SINGLE;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_set_mode (selection, mode);
gtk_tree_view_set_rubber_banding (GTK_TREE_VIEW (priv->browse_files_tree_view), select_multiple);
priv->select_multiple = select_multiple;
g_object_notify (G_OBJECT (impl), "select-multiple");
check_preview_change (impl);
}
static void
set_file_system_backend (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
profile_start ("start for backend", "default");
priv->file_system = _gtk_file_system_new ();
profile_end ("end", NULL);
}
static void
unset_file_system_backend (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_object_unref (priv->file_system);
priv->file_system = NULL;
}
/* Takes the folder stored in a row in the recent_model, and puts it in the pathbar */
static void
put_recent_folder_in_pathbar (GtkFileChooserWidget *impl, GtkTreeIter *iter)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFile *file;
gtk_tree_model_get (GTK_TREE_MODEL (priv->recent_model), iter,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
MODEL_COL_FILE, &file,
-1);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_path_bar_set_file (GTK_PATH_BAR (priv->browse_path_bar), file, FALSE);
g_object_unref (file);
}
file-chooser: merge path bar mode and location mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 16:18:37 +00:00
/* Sets the location bar in the appropriate mode according to the
* current operation mode and action. This is the central function
* for dealing with the pathbar’s widgets; as long as impl->action and
* impl->operation_mode are set correctly, then calling this function
* will update all the pathbar’s widgets.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
static void
file-chooser: merge path bar mode and location mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 16:18:37 +00:00
location_bar_update (GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file-chooser: merge path bar mode and location mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 16:18:37 +00:00
gboolean visible = TRUE;
gboolean create_folder_visible = FALSE;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
switch (priv->operation_mode)
{
file-chooser: make enter location an operation mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 17:49:54 +00:00
case OPERATION_MODE_ENTER_LOCATION:
break;
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
case OPERATION_MODE_OTHER_LOCATIONS:
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
case OPERATION_MODE_BROWSE:
break;
case OPERATION_MODE_RECENT:
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
GtkTreeSelection *selection;
gboolean have_selected;
GtkTreeIter iter;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Save mode means single-selection mode, so the following is valid */
have_selected = gtk_tree_selection_get_selected (selection, NULL, &iter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (have_selected)
Trivial code cleanup
2015-07-09 00:32:03 +00:00
put_recent_folder_in_pathbar (impl, &iter);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
}
file-chooser: merge path bar mode and location mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 16:18:37 +00:00
visible = FALSE;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
break;
case OPERATION_MODE_SEARCH:
break;
default:
g_assert_not_reached ();
return;
}
file-chooser: merge path bar mode and location mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 16:18:37 +00:00
if (visible)
{
if (priv->create_folders
&& priv->action != GTK_FILE_CHOOSER_ACTION_OPEN
&& priv->operation_mode != OPERATION_MODE_RECENT)
create_folder_visible = TRUE;
}
gtk_widget_set_visible (priv->browse_new_folder_button, create_folder_visible);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
operation_mode_stop (GtkFileChooserWidget *impl,
OperationMode mode)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
if (mode == OPERATION_MODE_SEARCH)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Add and use a model search engine This search engine reuses the GFileInfo that is already loaded for the file list, to ensure that hits from the current directory always appear promptly.
2015-07-01 19:51:20 +00:00
g_clear_object (&impl->priv->model_for_search);
file chooser: Clear search entry when it goes away Keeping the entry contents conflicts with type-to-search.
2015-07-07 00:50:08 +00:00
search_stop_searching (impl, TRUE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
search_clear_model (impl, TRUE);
file chooser: Note when searching remote locations Inform the user that we won't search recursively when searching in remote locations.
2015-07-24 20:26:32 +00:00
gtk_widget_hide (impl->priv->remote_warning_bar);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
}
file-chooser: make enter location an operation mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 17:49:54 +00:00
static void
operation_mode_set_enter_location (GtkFileChooserWidget *impl)
{
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_files_stack), "list");
file chooser: Fix up some focus issues Better to switch the visible stack child early, since GtkStack has its own focus handling now.
2015-01-19 00:42:58 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_header_stack), "location");
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
gtk_revealer_set_reveal_child (GTK_REVEALER (priv->browse_header_revealer), TRUE);
file-chooser: make enter location an operation mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 17:49:54 +00:00
location_bar_update (impl);
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
gtk_widget_set_sensitive (priv->filter_combo, TRUE);
file chooser: Fix up some focus issues Better to switch the visible stack child early, since GtkStack has its own focus handling now.
2015-01-19 00:42:58 +00:00
location_mode_set (impl, LOCATION_MODE_FILENAME_ENTRY);
file-chooser: make enter location an operation mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 17:49:54 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
operation_mode_set_browse (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
gtk_places_sidebar_set_location (GTK_PLACES_SIDEBAR (priv->places_sidebar), priv->current_folder);
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_files_stack), "list");
file chooser: Ensure we update subtitles Notify the ::subtitle property when modes change that may affect it. Also ensure that we update the location mode when we switch back to the pathbar.
2015-07-08 21:42:34 +00:00
location_mode_set (impl, LOCATION_MODE_PATH_BAR);
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_header_stack), "pathbar");
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
gtk_revealer_set_reveal_child (GTK_REVEALER (priv->browse_header_revealer), TRUE);
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
gtk_widget_set_sensitive (priv->filter_combo, TRUE);
file chooser: Ensure we update subtitles Notify the ::subtitle property when modes change that may affect it. Also ensure that we update the location mode when we switch back to the pathbar.
2015-07-08 21:42:34 +00:00
g_object_notify (G_OBJECT (impl), "subtitle");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
operation_mode_set_search (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
GtkWidget *visible_widget;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_assert (priv->search_model == NULL);
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
visible_widget = gtk_stack_get_visible_child (GTK_STACK (priv->browse_files_stack));
if (visible_widget != priv->places_view &&
visible_widget != priv->browse_files_swin)
{
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_files_stack), "list");
}
file chooser: Fix up some focus issues Better to switch the visible stack child early, since GtkStack has its own focus handling now.
2015-01-19 00:42:58 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_header_stack), "search");
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
gtk_revealer_set_reveal_child (GTK_REVEALER (priv->browse_header_revealer), TRUE);
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
location_bar_update (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
search_setup_widgets (impl);
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
gtk_entry_grab_focus_without_selecting (GTK_ENTRY (priv->search_entry));
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
gtk_widget_set_sensitive (priv->filter_combo, FALSE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
operation_mode_set_recent (GtkFileChooserWidget *impl)
{
trivial refactoring
2015-01-18 21:57:21 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFile *file;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_files_stack), "list");
file chooser: Fix up some focus issues Better to switch the visible stack child early, since GtkStack has its own focus handling now.
2015-01-19 00:42:58 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_header_stack), "pathbar");
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
gtk_revealer_set_reveal_child (GTK_REVEALER (priv->browse_header_revealer), FALSE);
trivial refactoring
2015-01-18 21:57:21 +00:00
location_bar_update (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
recent_start_loading (impl);
trivial refactoring
2015-01-18 21:57:21 +00:00
file = g_file_new_for_uri ("recent:///");
gtk_places_sidebar_set_location (GTK_PLACES_SIDEBAR (priv->places_sidebar), file);
file chooser: Ensure we update subtitles Notify the ::subtitle property when modes change that may affect it. Also ensure that we update the location mode when we switch back to the pathbar.
2015-07-08 21:42:34 +00:00
g_object_notify (G_OBJECT (impl), "subtitle");
trivial refactoring
2015-01-18 21:57:21 +00:00
g_object_unref (file);
file chooser: Make search work again The last round of filechooser redesign work had left search somewhat dysfunctional. This commit fixes things up enough that search is once again a working feature of the file chooser.
2015-01-18 23:59:43 +00:00
gtk_widget_set_sensitive (priv->filter_combo, TRUE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
static void
operation_mode_set_other_locations (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_files_stack), "other_locations");
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_header_stack), "pathbar");
gtk_revealer_set_reveal_child (GTK_REVEALER (priv->browse_header_revealer), FALSE);
location_bar_update (impl);
stop_loading_and_clear_list_model (impl, TRUE);
recent_stop_loading (impl);
search_stop_searching (impl, TRUE);
recent_clear_model (impl, TRUE);
search_clear_model (impl, TRUE);
gtk_widget_set_sensitive (priv->filter_combo, FALSE);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
operation_mode_set (GtkFileChooserWidget *impl, OperationMode mode)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
OperationMode old_mode;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
operation_mode_stop (impl, priv->operation_mode);
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
old_mode = priv->operation_mode;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->operation_mode = mode;
switch (priv->operation_mode)
{
file-chooser: make enter location an operation mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 17:49:54 +00:00
case OPERATION_MODE_ENTER_LOCATION:
operation_mode_set_enter_location (impl);
break;
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
case OPERATION_MODE_OTHER_LOCATIONS:
operation_mode_set_other_locations (impl);
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
case OPERATION_MODE_BROWSE:
operation_mode_set_browse (impl);
break;
case OPERATION_MODE_SEARCH:
operation_mode_set_search (impl);
break;
case OPERATION_MODE_RECENT:
operation_mode_set_recent (impl);
break;
default:
g_assert_not_reached ();
return;
}
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
if ((old_mode == OPERATION_MODE_SEARCH) != (mode == OPERATION_MODE_SEARCH))
g_object_notify (G_OBJECT (impl), "search-mode");
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
g_object_notify (G_OBJECT (impl), "subtitle");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* This function is basically a do_all function.
*
* It sets the visibility on all the widgets based on the current state, and
* moves the custom_widget if needed.
*/
static void
update_appearance (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
save_widgets_create (impl);
file chooser: Don't show recent in save mode Don't show Recent in the sidebar when we are in save mode. We also ignore the startup-mode = recent in save mode now - we don't want to populate the file list with recent files if Recent is not on the sidebar. If you really want to go there, you can still enter recent:// in the location entry. https://bugzilla.gnome.org/show_bug.cgi?id=751653
2015-07-01 15:40:15 +00:00
gtk_places_sidebar_set_show_recent (GTK_PLACES_SIDEBAR (priv->places_sidebar), FALSE);
file chooser: Don't show Trash in save mode You can't save there...
2015-07-03 16:51:03 +00:00
gtk_places_sidebar_set_show_trash (GTK_PLACES_SIDEBAR (priv->places_sidebar), FALSE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->select_multiple)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
g_warning ("Save mode cannot be set in conjunction with multiple selection mode. "
"Re-setting to single selection mode.");
set_select_multiple (impl, FALSE, TRUE);
}
file chooser: Don't show recent in save mode Don't show Recent in the sidebar when we are in save mode. We also ignore the startup-mode = recent in save mode now - we don't want to populate the file list with recent files if Recent is not on the sidebar. If you really want to go there, you can still enter recent:// in the location entry. https://bugzilla.gnome.org/show_bug.cgi?id=751653
2015-07-01 15:40:15 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
save_widgets_destroy (impl);
file chooser: Don't show recent in save mode Don't show Recent in the sidebar when we are in save mode. We also ignore the startup-mode = recent in save mode now - we don't want to populate the file list with recent files if Recent is not on the sidebar. If you really want to go there, you can still enter recent:// in the location entry. https://bugzilla.gnome.org/show_bug.cgi?id=751653
2015-07-01 15:40:15 +00:00
gtk_places_sidebar_set_show_recent (GTK_PLACES_SIDEBAR (priv->places_sidebar), recent_files_setting_is_enabled (impl));
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
location_mode_set (impl, priv->location_mode);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
if (priv->location_entry)
_gtk_file_chooser_entry_set_action (GTK_FILE_CHOOSER_ENTRY (priv->location_entry), priv->action);
file-chooser: merge path bar mode and location mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 16:18:37 +00:00
location_bar_update (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* This *is* needed; we need to redraw the file list because the "sensitivity"
* of files may change depending whether we are in a file or folder-only mode.
*/
gtk_widget_queue_draw (priv->browse_files_tree_view);
emit_default_size_changed (impl);
}
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
static gchar *
gtk_file_chooser_widget_get_subtitle (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gchar *subtitle;
if (priv->operation_mode == OPERATION_MODE_SEARCH)
{
gchar *location;
file chooser: Be more careful with subtitles We were showing things like "Searching in (null)" if the current folder is not in the sidebar. Avoid that by falling back to using current_folder. Pointed out by Carlos Soriano.
2015-07-15 03:48:09 +00:00
subtitle = _("Searching");
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
location = gtk_places_sidebar_get_location_title (GTK_PLACES_SIDEBAR (priv->places_sidebar));
file chooser: Be more careful with subtitles We were showing things like "Searching in (null)" if the current folder is not in the sidebar. Avoid that by falling back to using current_folder. Pointed out by Carlos Soriano.
2015-07-15 03:48:09 +00:00
if (location)
{
subtitle = g_strdup_printf (_("Searching in %s"), location);
g_free (location);
}
else if (priv->current_folder)
{
GFileInfo *info;
info = g_file_query_info (priv->current_folder,
G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME,
G_FILE_QUERY_INFO_NONE,
NULL,
NULL);
if (info)
{
subtitle = g_strdup_printf (_("Searching in %s"), g_file_info_get_display_name (info));
g_object_unref (info);
}
}
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
}
else if (priv->operation_mode == OPERATION_MODE_ENTER_LOCATION ||
(priv->operation_mode == OPERATION_MODE_BROWSE &&
priv->location_mode == LOCATION_MODE_FILENAME_ENTRY))
{
if (priv->local_only)
subtitle = g_strdup (_("Enter location"));
else
subtitle = g_strdup (_("Enter location or URL"));
}
else
{
subtitle = NULL;
}
return subtitle;
}
file chooser: Fix gtk_file_chooser_set_show_hidden We should not override an explicitly set show-hidden value when loading the setting. https://bugzilla.gnome.org/show_bug.cgi?id=610925
2015-07-24 01:54:47 +00:00
static void
set_show_hidden (GtkFileChooserWidget *impl,
gboolean show_hidden)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->show_hidden != show_hidden)
{
priv->show_hidden = show_hidden;
if (priv->browse_files_model)
_gtk_file_system_model_set_show_hidden (priv->browse_files_model, show_hidden);
}
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
gtk_file_chooser_widget_set_property (GObject *object,
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
guint prop_id,
const GValue *value,
GParamSpec *pspec)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (object);
GtkFileChooserWidgetPrivate *priv = impl->priv;
switch (prop_id)
{
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
case PROP_SEARCH_MODE:
if (g_value_get_boolean (value))
operation_mode_set (impl, OPERATION_MODE_SEARCH);
else
file chooser: Load a directory when leaving search Ensure that some folder contents are shown in the list when we leave search mode. https://bugzilla.gnome.org/show_bug.cgi?id=743659
2015-01-28 23:15:19 +00:00
{
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
if (gtk_stack_get_visible_child (GTK_STACK (priv->browse_files_stack)) != priv->places_view)
{
operation_mode_set (impl, OPERATION_MODE_BROWSE);
if (priv->current_folder)
change_folder_and_display_error (impl, priv->current_folder, FALSE);
else
switch_to_home_dir (impl);
}
file chooser: Load a directory when leaving search Ensure that some folder contents are shown in the list when we leave search mode. https://bugzilla.gnome.org/show_bug.cgi?id=743659
2015-01-28 23:15:19 +00:00
else
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
{
operation_mode_set (impl, OPERATION_MODE_OTHER_LOCATIONS);
}
file chooser: Load a directory when leaving search Ensure that some folder contents are shown in the list when we leave search mode. https://bugzilla.gnome.org/show_bug.cgi?id=743659
2015-01-28 23:15:19 +00:00
}
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
case GTK_FILE_CHOOSER_PROP_ACTION:
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooserAction action = g_value_get_enum (value);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (action != priv->action)
{
gtk_file_chooser_widget_unselect_all (GTK_FILE_CHOOSER (impl));
Whitespace fixes
2015-08-03 00:58:19 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if ((action == GTK_FILE_CHOOSER_ACTION_SAVE ||
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
&& priv->select_multiple)
{
g_warning ("Tried to change the file chooser action to SAVE or CREATE_FOLDER, but "
"this is not allowed in multiple selection mode. Resetting the file chooser "
"to single selection mode.");
set_select_multiple (impl, FALSE, TRUE);
}
priv->action = action;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
update_cell_renderer_attributes (impl);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
update_appearance (impl);
settings_load (impl);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
break;
case GTK_FILE_CHOOSER_PROP_FILTER:
set_current_filter (impl, g_value_get_object (value));
break;
case GTK_FILE_CHOOSER_PROP_LOCAL_ONLY:
set_local_only (impl, g_value_get_boolean (value));
break;
case GTK_FILE_CHOOSER_PROP_PREVIEW_WIDGET:
set_preview_widget (impl, g_value_get_object (value));
break;
case GTK_FILE_CHOOSER_PROP_PREVIEW_WIDGET_ACTIVE:
priv->preview_widget_active = g_value_get_boolean (value);
update_preview_widget_visibility (impl);
break;
case GTK_FILE_CHOOSER_PROP_USE_PREVIEW_LABEL:
priv->use_preview_label = g_value_get_boolean (value);
update_preview_widget_visibility (impl);
break;
case GTK_FILE_CHOOSER_PROP_EXTRA_WIDGET:
set_extra_widget (impl, g_value_get_object (value));
break;
case GTK_FILE_CHOOSER_PROP_SELECT_MULTIPLE:
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean select_multiple = g_value_get_boolean (value);
if ((priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
&& select_multiple)
{
g_warning ("Tried to set the file chooser to multiple selection mode, but this is "
"not allowed in SAVE or CREATE_FOLDER modes. Ignoring the change and "
"leaving the file chooser in single selection mode.");
return;
}
set_select_multiple (impl, select_multiple, FALSE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
break;
case GTK_FILE_CHOOSER_PROP_SHOW_HIDDEN:
file chooser: Fix gtk_file_chooser_set_show_hidden We should not override an explicitly set show-hidden value when loading the setting. https://bugzilla.gnome.org/show_bug.cgi?id=610925
2015-07-24 01:54:47 +00:00
priv->show_hidden_set = TRUE;
set_show_hidden (impl, g_value_get_boolean (value));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
break;
case GTK_FILE_CHOOSER_PROP_DO_OVERWRITE_CONFIRMATION:
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean do_overwrite_confirmation = g_value_get_boolean (value);
priv->do_overwrite_confirmation = do_overwrite_confirmation;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
break;
case GTK_FILE_CHOOSER_PROP_CREATE_FOLDERS:
{
gboolean create_folders = g_value_get_boolean (value);
priv->create_folders = create_folders;
update_appearance (impl);
}
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
}
}
static void
gtk_file_chooser_widget_get_property (GObject *object,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
guint prop_id,
GValue *value,
GParamSpec *pspec)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (object);
GtkFileChooserWidgetPrivate *priv = impl->priv;
switch (prop_id)
{
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
case PROP_SEARCH_MODE:
g_value_set_boolean (value, priv->operation_mode == OPERATION_MODE_SEARCH);
break;
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
case PROP_SUBTITLE:
g_value_take_string (value, gtk_file_chooser_widget_get_subtitle (impl));
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
case GTK_FILE_CHOOSER_PROP_ACTION:
g_value_set_enum (value, priv->action);
break;
case GTK_FILE_CHOOSER_PROP_FILTER:
g_value_set_object (value, priv->current_filter);
break;
case GTK_FILE_CHOOSER_PROP_LOCAL_ONLY:
g_value_set_boolean (value, priv->local_only);
break;
case GTK_FILE_CHOOSER_PROP_PREVIEW_WIDGET:
g_value_set_object (value, priv->preview_widget);
break;
case GTK_FILE_CHOOSER_PROP_PREVIEW_WIDGET_ACTIVE:
g_value_set_boolean (value, priv->preview_widget_active);
break;
case GTK_FILE_CHOOSER_PROP_USE_PREVIEW_LABEL:
g_value_set_boolean (value, priv->use_preview_label);
break;
case GTK_FILE_CHOOSER_PROP_EXTRA_WIDGET:
g_value_set_object (value, priv->extra_widget);
break;
case GTK_FILE_CHOOSER_PROP_SELECT_MULTIPLE:
g_value_set_boolean (value, priv->select_multiple);
break;
case GTK_FILE_CHOOSER_PROP_SHOW_HIDDEN:
g_value_set_boolean (value, priv->show_hidden);
break;
case GTK_FILE_CHOOSER_PROP_DO_OVERWRITE_CONFIRMATION:
g_value_set_boolean (value, priv->do_overwrite_confirmation);
break;
case GTK_FILE_CHOOSER_PROP_CREATE_FOLDERS:
g_value_set_boolean (value, priv->create_folders);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
}
}
/* This cancels everything that may be going on in the background. */
static void
cancel_all_operations (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
pending_select_files_free (impl);
if (priv->file_list_drag_data_received_cancellable)
{
g_cancellable_cancel (priv->file_list_drag_data_received_cancellable);
priv->file_list_drag_data_received_cancellable = NULL;
}
if (priv->update_current_folder_cancellable)
{
g_cancellable_cancel (priv->update_current_folder_cancellable);
priv->update_current_folder_cancellable = NULL;
}
if (priv->should_respond_get_info_cancellable)
{
g_cancellable_cancel (priv->should_respond_get_info_cancellable);
priv->should_respond_get_info_cancellable = NULL;
}
if (priv->file_exists_get_info_cancellable)
{
g_cancellable_cancel (priv->file_exists_get_info_cancellable);
priv->file_exists_get_info_cancellable = NULL;
}
search_stop_searching (impl, TRUE);
recent_stop_loading (impl);
}
/* Removes the settings signal handler. It's safe to call multiple times */
static void
remove_settings_signal (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GdkScreen *screen)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->settings_signal_id)
{
GtkSettings *settings;
settings = gtk_settings_get_for_screen (screen);
g_signal_handler_disconnect (settings,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->settings_signal_id);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->settings_signal_id = 0;
}
}
static void
gtk_file_chooser_widget_dispose (GObject *object)
{
GtkFileChooserWidget *impl = (GtkFileChooserWidget *) object;
GtkFileChooserWidgetPrivate *priv = impl->priv;
cancel_all_operations (impl);
file chooser: Memory handling fixes I forgot to clean up the long press gesture, and in additon, creating the rename popover from the ui template was causing the tree view to not be disposed when the file chooser goes away. Work around this by manually unsetting the relative-to widget of the popover in dispose.
2015-07-20 15:11:00 +00:00
if (priv->rename_file_popover)
gtk_popover_set_relative_to (GTK_POPOVER (priv->rename_file_popover), NULL);
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
if (priv->browse_files_popover)
{
gtk_widget_destroy (priv->browse_files_popover);
priv->browse_files_popover = NULL;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->extra_widget)
{
g_object_unref (priv->extra_widget);
priv->extra_widget = NULL;
}
remove_settings_signal (impl, gtk_widget_get_screen (GTK_WIDGET (impl)));
if (priv->bookmarks_manager)
{
_gtk_bookmarks_manager_free (priv->bookmarks_manager);
priv->bookmarks_manager = NULL;
}
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
if (priv->external_entry && priv->location_entry == priv->external_entry)
{
location_entry_disconnect (impl);
priv->external_entry = NULL;
}
file chooser: Memory handling fixes I forgot to clean up the long press gesture, and in additon, creating the rename popover from the ui template was causing the tree view to not be disposed when the file chooser goes away. Work around this by manually unsetting the relative-to widget of the popover in dispose.
2015-07-20 15:11:00 +00:00
g_clear_object (&priv->long_press_gesture);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
G_OBJECT_CLASS (gtk_file_chooser_widget_parent_class)->dispose (object);
}
/* We override show-all since we have internal widgets that
docs: use apostrophes in *n't
2014-02-07 18:32:47 +00:00
* shouldn’t be shown when you call show_all(), like the filter
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
* combo box.
*/
static void
gtk_file_chooser_widget_show_all (GtkWidget *widget)
{
GtkFileChooserWidget *impl = (GtkFileChooserWidget *) widget;
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_widget_show (widget);
if (priv->extra_widget)
gtk_widget_show_all (priv->extra_widget);
}
/* Handler for GtkWindow::set-focus; this is where we save the last-focused
* widget on our toplevel. See gtk_file_chooser_widget_hierarchy_changed()
*/
static void
toplevel_set_focus_cb (GtkWindow *window,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkWidget *focus,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
priv->toplevel_last_focus_widget = gtk_window_get_focus (window);
}
/* We monitor the focus widget on our toplevel to be able to know which widget
docs: use proper quotes
2014-02-05 18:07:34 +00:00
* was last focused at the time our “should_respond” method gets called.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
static void
gtk_file_chooser_widget_hierarchy_changed (GtkWidget *widget,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkWidget *previous_toplevel)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (widget);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkWidget *toplevel;
toplevel = gtk_widget_get_toplevel (widget);
Whitespace fixes
2015-08-03 00:58:19 +00:00
if (previous_toplevel &&
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->toplevel_set_focus_id != 0)
{
g_signal_handler_disconnect (previous_toplevel,
priv->toplevel_set_focus_id);
priv->toplevel_set_focus_id = 0;
priv->toplevel_last_focus_widget = NULL;
}
if (gtk_widget_is_toplevel (toplevel))
{
g_assert (priv->toplevel_set_focus_id == 0);
priv->toplevel_set_focus_id = g_signal_connect (toplevel, "set-focus",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_CALLBACK (toplevel_set_focus_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->toplevel_last_focus_widget = gtk_window_get_focus (GTK_WINDOW (toplevel));
}
}
/* Changes the icons wherever it is needed */
static void
change_icon_theme (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gint width, height;
profile_start ("start", NULL);
if (gtk_icon_size_lookup (GTK_ICON_SIZE_MENU, &width, &height))
priv->icon_size = MAX (width, height);
else
priv->icon_size = FALLBACK_ICON_SIZE;
/* the first cell in the first column is the icon column, and we have a fixed size there */
set_icon_cell_renderer_fixed_size (impl);
file chooser: Consistently clear model caches This was not done for all models in all places, leading to e.g. icon theme updates not applying correctly to search results.
2015-07-02 21:31:29 +00:00
clear_model_cache (impl, MODEL_COL_SURFACE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_queue_resize (priv->browse_files_tree_view);
profile_end ("end", NULL);
}
/* Callback used when a GtkSettings value changes */
static void
settings_notify_cb (GObject *object,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GParamSpec *pspec,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
const char *name;
profile_start ("start", NULL);
name = g_param_spec_get_name (pspec);
if (strcmp (name, "gtk-icon-theme-name") == 0)
change_icon_theme (impl);
profile_end ("end", NULL);
}
/* Installs a signal handler for GtkSettings so that we can monitor changes in
* the icon theme.
*/
static void
check_icon_theme (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkSettings *settings;
profile_start ("start", NULL);
if (priv->settings_signal_id)
{
profile_end ("end", NULL);
return;
}
if (gtk_widget_has_screen (GTK_WIDGET (impl)))
{
settings = gtk_settings_get_for_screen (gtk_widget_get_screen (GTK_WIDGET (impl)));
priv->settings_signal_id = g_signal_connect (settings, "notify",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_CALLBACK (settings_notify_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
change_icon_theme (impl);
}
profile_end ("end", NULL);
}
static void
gtk_file_chooser_widget_style_updated (GtkWidget *widget)
{
GtkFileChooserWidget *impl;
profile_start ("start", NULL);
impl = GTK_FILE_CHOOSER_WIDGET (widget);
profile_msg (" parent class style_udpated start", NULL);
GTK_WIDGET_CLASS (gtk_file_chooser_widget_parent_class)->style_updated (widget);
profile_msg (" parent class style_updated end", NULL);
if (gtk_widget_has_screen (GTK_WIDGET (impl)))
change_icon_theme (impl);
emit_default_size_changed (impl);
profile_end ("end", NULL);
}
static void
gtk_file_chooser_widget_screen_changed (GtkWidget *widget,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GdkScreen *previous_screen)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl;
profile_start ("start", NULL);
impl = GTK_FILE_CHOOSER_WIDGET (widget);
if (GTK_WIDGET_CLASS (gtk_file_chooser_widget_parent_class)->screen_changed)
GTK_WIDGET_CLASS (gtk_file_chooser_widget_parent_class)->screen_changed (widget, previous_screen);
remove_settings_signal (impl, previous_screen);
check_icon_theme (impl);
emit_default_size_changed (impl);
profile_end ("end", NULL);
}
static void
set_sort_column (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSortable *sortable;
sortable = GTK_TREE_SORTABLE (gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view)));
/* can happen when we're still populating the model */
if (sortable == NULL)
return;
gtk_tree_sortable_set_sort_column_id (sortable,
priv->sort_column,
priv->sort_order);
}
static void
settings_load (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gboolean show_hidden;
gboolean show_size_column;
gboolean sort_directories_first;
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
DateFormat date_format;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gint sort_column;
GtkSortType sort_order;
StartupMode startup_mode;
gint sidebar_width;
GSettings *settings;
settings = _gtk_file_chooser_get_settings_for_widget (GTK_WIDGET (impl));
show_hidden = g_settings_get_boolean (settings, SETTINGS_KEY_SHOW_HIDDEN);
show_size_column = g_settings_get_boolean (settings, SETTINGS_KEY_SHOW_SIZE_COLUMN);
sort_column = g_settings_get_enum (settings, SETTINGS_KEY_SORT_COLUMN);
sort_order = g_settings_get_enum (settings, SETTINGS_KEY_SORT_ORDER);
sidebar_width = g_settings_get_int (settings, SETTINGS_KEY_SIDEBAR_WIDTH);
startup_mode = g_settings_get_enum (settings, SETTINGS_KEY_STARTUP_MODE);
sort_directories_first = g_settings_get_boolean (settings, SETTINGS_KEY_SORT_DIRECTORIES_FIRST);
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
date_format = g_settings_get_enum (settings, SETTINGS_KEY_DATE_FORMAT);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Fix gtk_file_chooser_set_show_hidden We should not override an explicitly set show-hidden value when loading the setting. https://bugzilla.gnome.org/show_bug.cgi?id=610925
2015-07-24 01:54:47 +00:00
if (!priv->show_hidden_set)
set_show_hidden (impl, show_hidden);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->show_size_column = show_size_column;
gtk_tree_view_column_set_visible (priv->list_size_column, show_size_column);
priv->sort_column = sort_column;
priv->sort_order = sort_order;
priv->startup_mode = startup_mode;
priv->sort_directories_first = sort_directories_first;
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
priv->show_time = date_format == DATE_FORMAT_WITH_TIME;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* We don't call set_sort_column() here as the models may not have been
* created yet. The individual functions that create and set the models will
* call set_sort_column() themselves.
*/
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
update_time_renderer_visible (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_paned_set_position (GTK_PANED (priv->browse_widgets_hpaned), sidebar_width);
}
static void
settings_save (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GSettings *settings;
settings = _gtk_file_chooser_get_settings_for_widget (GTK_WIDGET (impl));
/* All the other state */
g_settings_set_enum (settings, SETTINGS_KEY_LOCATION_MODE, priv->location_mode);
g_settings_set_boolean (settings, SETTINGS_KEY_SHOW_HIDDEN,
gtk_file_chooser_get_show_hidden (GTK_FILE_CHOOSER (impl)));
g_settings_set_boolean (settings, SETTINGS_KEY_SHOW_SIZE_COLUMN, priv->show_size_column);
GtkFileChooser: Add a menuitem for 'sort directories first' This has been requested repeatedly.
2014-11-03 05:02:13 +00:00
g_settings_set_boolean (settings, SETTINGS_KEY_SORT_DIRECTORIES_FIRST, priv->sort_directories_first);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_settings_set_enum (settings, SETTINGS_KEY_SORT_COLUMN, priv->sort_column);
g_settings_set_enum (settings, SETTINGS_KEY_SORT_ORDER, priv->sort_order);
g_settings_set_int (settings, SETTINGS_KEY_SIDEBAR_WIDTH,
GtkFileChooser: Add a menuitem for 'sort directories first' This has been requested repeatedly.
2014-11-03 05:02:13 +00:00
gtk_paned_get_position (GTK_PANED (priv->browse_widgets_hpaned)));
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
g_settings_set_enum (settings, SETTINGS_KEY_DATE_FORMAT, priv->show_time ? DATE_FORMAT_WITH_TIME : DATE_FORMAT_REGULAR);
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Now apply the settings */
g_settings_apply (settings);
}
/* GtkWidget::realize method */
static void
gtk_file_chooser_widget_realize (GtkWidget *widget)
{
GtkFileChooserWidget *impl;
impl = GTK_FILE_CHOOSER_WIDGET (widget);
GTK_WIDGET_CLASS (gtk_file_chooser_widget_parent_class)->realize (widget);
emit_default_size_changed (impl);
}
/* Changes the current folder to $CWD */
static void
switch_to_cwd (GtkFileChooserWidget *impl)
{
char *current_working_dir;
current_working_dir = g_get_current_dir ();
gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (impl), current_working_dir);
g_free (current_working_dir);
}
file chooser: Respect recent settings When recent files are not supported in gvfs, or turned off by settings, we should not try to load them even if the startup mode says so. This prevents inconsistency with the places sidebar where 'Recent' will not appear in this case.
2015-05-30 13:21:16 +00:00
static gboolean
recent_files_setting_is_enabled (GtkFileChooserWidget *impl)
{
GtkSettings *settings;
gboolean enabled;
settings = gtk_widget_get_settings (GTK_WIDGET (impl));
g_object_get (settings, "gtk-recent-files-enabled", &enabled, NULL);
return enabled;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Sets the file chooser to showing Recent Files or $CWD, depending on the
docs: use proper apostrophe https://wiki.gnome.org/Design/OS/Typography
2014-02-07 18:01:26 +00:00
* user’s settings.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
static void
set_startup_mode (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Avoid animations when setting up There is no need to animate things when we are just setting up the startup mode, so disable transitions in the revealer and the stack. Pointed out by Carlos Soriano
2015-07-09 00:15:07 +00:00
GtkRevealerTransitionType revealer_transition;
GtkStackTransitionType stack_transition;
/* turn off animations for this setup */
revealer_transition
= gtk_revealer_get_transition_type (GTK_REVEALER (priv->browse_header_revealer));
gtk_revealer_set_transition_type (GTK_REVEALER (priv->browse_header_revealer),
GTK_REVEALER_TRANSITION_TYPE_NONE);
stack_transition
= gtk_stack_get_transition_type (GTK_STACK (priv->browse_header_stack));
gtk_stack_set_transition_type (GTK_STACK (priv->browse_header_stack),
GTK_STACK_TRANSITION_TYPE_NONE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
switch (priv->startup_mode)
{
case STARTUP_MODE_RECENT:
file chooser: Don't show recent in save mode Don't show Recent in the sidebar when we are in save mode. We also ignore the startup-mode = recent in save mode now - we don't want to populate the file list with recent files if Recent is not on the sidebar. If you really want to go there, you can still enter recent:// in the location entry. https://bugzilla.gnome.org/show_bug.cgi?id=751653
2015-07-01 15:40:15 +00:00
if (gtk_places_sidebar_get_show_recent (GTK_PLACES_SIDEBAR (priv->places_sidebar)))
file chooser: Respect recent settings When recent files are not supported in gvfs, or turned off by settings, we should not try to load them even if the startup mode says so. This prevents inconsistency with the places sidebar where 'Recent' will not appear in this case.
2015-05-30 13:21:16 +00:00
{
operation_mode_set (impl, OPERATION_MODE_RECENT);
break;
}
/* else fall thru */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
case STARTUP_MODE_CWD:
switch_to_cwd (impl);
break;
default:
g_assert_not_reached ();
}
file chooser: Avoid animations when setting up There is no need to animate things when we are just setting up the startup mode, so disable transitions in the revealer and the stack. Pointed out by Carlos Soriano
2015-07-09 00:15:07 +00:00
gtk_stack_set_transition_type (GTK_STACK (priv->browse_header_stack),
stack_transition);
gtk_revealer_set_transition_type (GTK_REVEALER (priv->browse_header_revealer),
revealer_transition);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static gboolean
shortcut_exists (GtkFileChooserWidget *impl, GFile *needle)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GSList *haystack;
GSList *l;
gboolean exists;
exists = FALSE;
haystack = gtk_places_sidebar_list_shortcuts (GTK_PLACES_SIDEBAR (priv->places_sidebar));
for (l = haystack; l; l = l->next)
{
GFile *hay;
hay = G_FILE (l->data);
if (g_file_equal (hay, needle))
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
exists = TRUE;
break;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
g_slist_free_full (haystack, g_object_unref);
return exists;
}
static void
add_cwd_to_sidebar_if_needed (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
char *cwd;
GFile *cwd_file;
GFile *home_file;
Whitespace fixes
2015-08-03 00:58:19 +00:00
cwd = g_get_current_dir ();
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
cwd_file = g_file_new_for_path (cwd);
g_free (cwd);
if (shortcut_exists (impl, cwd_file))
goto out;
home_file = g_file_new_for_path (g_get_home_dir ());
/* We only add an item for $CWD if it is different from $HOME. This way,
* applications which get launched from a shell in a terminal (by someone who
* knows what they are doing) will get an item for $CWD in the places sidebar,
* and "normal" applications launched from the desktop shell (whose $CWD is
* $HOME) won't get any extra clutter in the sidebar.
*/
if (!g_file_equal (home_file, cwd_file))
gtk_places_sidebar_add_shortcut (GTK_PLACES_SIDEBAR (priv->places_sidebar), cwd_file);
g_object_unref (home_file);
out:
g_object_unref (cwd_file);
}
/* GtkWidget::map method */
static void
gtk_file_chooser_widget_map (GtkWidget *widget)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (widget);
GtkFileChooserWidgetPrivate *priv = impl->priv;
profile_start ("start", NULL);
GTK_WIDGET_CLASS (gtk_file_chooser_widget_parent_class)->map (widget);
settings_load (impl);
add_cwd_to_sidebar_if_needed (impl);
if (priv->operation_mode == OPERATION_MODE_BROWSE)
{
switch (priv->reload_state)
{
case RELOAD_EMPTY:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
set_startup_mode (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
break;
Whitespace fixes
2015-08-03 00:58:19 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
case RELOAD_HAS_FOLDER:
/* Nothing; we are already loading or loaded, so we
* don't need to reload
*/
break;
default:
g_assert_not_reached ();
}
}
profile_end ("end", NULL);
}
/* GtkWidget::unmap method */
static void
gtk_file_chooser_widget_unmap (GtkWidget *widget)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (widget);
GtkFileChooserWidgetPrivate *priv = impl->priv;
settings_save (impl);
cancel_all_operations (impl);
priv->reload_state = RELOAD_EMPTY;
GTK_WIDGET_CLASS (gtk_file_chooser_widget_parent_class)->unmap (widget);
}
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
static gint
compare_directory (GtkFileSystemModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gboolean dir_a, dir_b;
dir_a = g_value_get_boolean (_gtk_file_system_model_get_value (model, a, MODEL_COL_IS_FOLDER));
dir_b = g_value_get_boolean (_gtk_file_system_model_get_value (model, b, MODEL_COL_IS_FOLDER));
if (priv->sort_directories_first && dir_a != dir_b)
return priv->list_sort_ascending ? (dir_a ? -1 : 1) : (dir_a ? 1 : -1);
return 0;
}
static gint
compare_name (GtkFileSystemModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
GtkFileChooserWidget *impl)
{
const char *key_a, *key_b;
gint result;
key_a = g_value_get_string (_gtk_file_system_model_get_value (model, a, MODEL_COL_NAME_COLLATED));
key_b = g_value_get_string (_gtk_file_system_model_get_value (model, b, MODEL_COL_NAME_COLLATED));
if (key_a && key_b)
result = strcmp (key_a, key_b);
else if (key_a)
result = 1;
else if (key_b)
result = -1;
else
result = 0;
return result;
}
static gint
compare_size (GtkFileSystemModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
GtkFileChooserWidget *impl)
{
gint64 size_a, size_b;
size_a = g_value_get_int64 (_gtk_file_system_model_get_value (model, a, MODEL_COL_SIZE));
size_b = g_value_get_int64 (_gtk_file_system_model_get_value (model, b, MODEL_COL_SIZE));
return size_a < size_b ? -1 : (size_a == size_b ? 0 : 1);
}
static gint
compare_time (GtkFileSystemModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
GtkFileChooserWidget *impl)
{
glong ta, tb;
ta = g_value_get_long (_gtk_file_system_model_get_value (model, a, MODEL_COL_TIME));
tb = g_value_get_long (_gtk_file_system_model_get_value (model, b, MODEL_COL_TIME));
return ta < tb ? -1 : (ta == tb ? 0 : 1);
}
static gint
compare_location (GtkFileSystemModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
GtkFileChooserWidget *impl)
{
const char *key_a, *key_b;
key_a = g_value_get_string (_gtk_file_system_model_get_value (model, a, MODEL_COL_LOCATION_TEXT));
key_b = g_value_get_string (_gtk_file_system_model_get_value (model, b, MODEL_COL_LOCATION_TEXT));
return g_strcmp0 (key_a, key_b);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Sort callback for the filename column */
static gint
name_sort_func (GtkTreeModel *model,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreeIter *a,
GtkTreeIter *b,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
GtkFileSystemModel *fs_model = GTK_FILE_SYSTEM_MODEL (model);
GtkFileChooserWidget *impl = user_data;
gint result;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
result = compare_directory (fs_model, a, b, impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
if (result == 0)
result = compare_name (fs_model, a, b, impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
return result;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Sort callback for the size column */
static gint
size_sort_func (GtkTreeModel *model,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreeIter *a,
GtkTreeIter *b,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
GtkFileSystemModel *fs_model = GTK_FILE_SYSTEM_MODEL (model);
GtkFileChooserWidget *impl = user_data;
gint result;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
result = compare_directory (fs_model, a, b, impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
if (result == 0)
result = compare_size (fs_model, a, b, impl);
return result;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
/* Sort callback for the time column */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static gint
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
time_sort_func (GtkTreeModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
GtkFileSystemModel *fs_model = GTK_FILE_SYSTEM_MODEL (model);
GtkFileChooserWidget *impl = user_data;
gint result;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
result = compare_directory (fs_model, a, b, impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
if (result == 0)
result = compare_time (fs_model, a, b, impl);
return result;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Sort search results better Set a default sort function that sorts results from the current folder first.
2015-06-27 06:22:23 +00:00
static gint
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
recent_sort_func (GtkTreeModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
gpointer user_data)
file chooser: Sort search results better Set a default sort function that sorts results from the current folder first.
2015-06-27 06:22:23 +00:00
{
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
GtkFileSystemModel *fs_model = GTK_FILE_SYSTEM_MODEL (model);
GtkFileChooserWidget *impl = user_data;
gint result;
file chooser: Sort search results better Set a default sort function that sorts results from the current folder first.
2015-06-27 06:22:23 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
result = compare_time (fs_model, a, b, impl);
file chooser: Sort search results better Set a default sort function that sorts results from the current folder first.
2015-06-27 06:22:23 +00:00
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
if (result == 0)
result = compare_name (fs_model, a, b, impl);
if (result == 0)
result = compare_location (fs_model, a, b, impl);
return result;
}
static gint
search_sort_func (GtkTreeModel *model,
GtkTreeIter *a,
GtkTreeIter *b,
gpointer user_data)
{
GtkFileSystemModel *fs_model = GTK_FILE_SYSTEM_MODEL (model);
GtkFileChooserWidget *impl = user_data;
gint result;
result = compare_location (fs_model, a, b, impl);
if (result == 0)
result = compare_name (fs_model, a, b, impl);
if (result == 0)
result = compare_time (fs_model, a, b, impl);
return result;
file chooser: Sort search results better Set a default sort function that sorts results from the current folder first.
2015-06-27 06:22:23 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Callback used when the sort column changes. We cache the sort order for use
* in name_sort_func().
*/
static void
list_sort_column_changed_cb (GtkTreeSortable *sortable,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gint sort_column_id;
GtkSortType sort_type;
if (gtk_tree_sortable_get_sort_column_id (sortable, &sort_column_id, &sort_type))
{
priv->list_sort_ascending = (sort_type == GTK_SORT_ASCENDING);
priv->sort_column = sort_column_id;
priv->sort_order = sort_type;
}
}
static void
set_busy_cursor (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean busy)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkWidget *widget;
GtkWindow *toplevel;
GdkDisplay *display;
GdkCursor *cursor;
toplevel = get_toplevel (GTK_WIDGET (impl));
widget = GTK_WIDGET (toplevel);
if (!toplevel || !gtk_widget_get_realized (widget))
return;
display = gtk_widget_get_display (widget);
if (busy)
Use standard cursor names This changes GTK+ to use gdk_cursor_new_from_name() with the 'standard' css names, instead of GdkCursorType. https://bugzilla.gnome.org/show_bug.cgi?id=652085
2015-05-10 02:50:02 +00:00
cursor = gdk_cursor_new_from_name (display, "progress");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
cursor = NULL;
gdk_window_set_cursor (gtk_widget_get_window (widget), cursor);
gdk_display_flush (display);
if (cursor)
g_object_unref (cursor);
}
file chooser: Improve column sizing Allow the name and location columns to be resized, but arrange for their sizing to be reset when the column layout changes (either by the location column appearing/disappearing, or by the time column changing between mtime and atime. This gives a decent compromise between good automatic sizing and user control.
2015-07-03 16:22:39 +00:00
static void
update_columns (GtkFileChooserWidget *impl,
gboolean location_visible,
const gchar *time_title)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gboolean need_resize = FALSE;
if (gtk_tree_view_column_get_visible (priv->list_location_column) != location_visible)
{
gtk_tree_view_column_set_visible (priv->list_location_column, location_visible);
need_resize = TRUE;
}
if (g_strcmp0 (gtk_tree_view_column_get_title (priv->list_time_column), time_title) != 0)
{
gtk_tree_view_column_set_title (priv->list_time_column, time_title);
need_resize = TRUE;
}
if (need_resize)
{
/* This undoes user resizing of columns when the columns change. */
gtk_tree_view_column_set_expand (priv->list_name_column, TRUE);
gtk_tree_view_column_set_expand (priv->list_location_column, TRUE);
gtk_tree_view_columns_autosize (GTK_TREE_VIEW (priv->browse_files_tree_view));
}
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Creates a sort model to wrap the file system model and sets it on the tree view */
static void
load_set_model (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
profile_start ("start", NULL);
g_assert (priv->browse_files_model != NULL);
profile_msg (" gtk_tree_view_set_model start", NULL);
gtk_tree_view_set_model (GTK_TREE_VIEW (priv->browse_files_tree_view),
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
GTK_TREE_MODEL (priv->browse_files_model));
file chooser: Improve column sizing Allow the name and location columns to be resized, but arrange for their sizing to be reset when the column layout changes (either by the location column appearing/disappearing, or by the time column changing between mtime and atime. This gives a decent compromise between good automatic sizing and user control.
2015-07-03 16:22:39 +00:00
update_columns (impl, FALSE, _("Modified"));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file_list_set_sort_column_ids (impl);
set_sort_column (impl);
profile_msg (" gtk_tree_view_set_model end", NULL);
priv->list_sort_ascending = TRUE;
file chooser: Add and use a model search engine This search engine reuses the GFileInfo that is already loaded for the file list, to ensure that hits from the current directory always appear promptly.
2015-07-01 19:51:20 +00:00
g_set_object (&priv->model_for_search, priv->browse_files_model);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
profile_end ("end", NULL);
}
/* Timeout callback used when the loading timer expires */
static gboolean
load_timeout_cb (gpointer data)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (data);
GtkFileChooserWidgetPrivate *priv = impl->priv;
profile_start ("start", NULL);
g_assert (priv->load_state == LOAD_PRELOAD);
g_assert (priv->load_timeout_id != 0);
g_assert (priv->browse_files_model != NULL);
priv->load_timeout_id = 0;
priv->load_state = LOAD_LOADING;
load_set_model (impl);
profile_end ("end", NULL);
return FALSE;
}
/* Sets up a new load timer for the model and switches to the LOAD_PRELOAD state */
static void
load_setup_timer (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_assert (priv->load_timeout_id == 0);
g_assert (priv->load_state != LOAD_PRELOAD);
priv->load_timeout_id = gdk_threads_add_timeout (MAX_LOADING_TIME, load_timeout_cb, impl);
g_source_set_name_by_id (priv->load_timeout_id, "[gtk+] load_timeout_cb");
priv->load_state = LOAD_PRELOAD;
}
/* Removes the load timeout; changes the impl->load_state to the specified value. */
static void
load_remove_timer (GtkFileChooserWidget *impl, LoadState new_load_state)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->load_timeout_id != 0)
{
g_assert (priv->load_state == LOAD_PRELOAD);
g_source_remove (priv->load_timeout_id);
priv->load_timeout_id = 0;
}
else
g_assert (priv->load_state == LOAD_EMPTY ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->load_state == LOAD_LOADING ||
priv->load_state == LOAD_FINISHED);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_assert (new_load_state == LOAD_EMPTY ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
new_load_state == LOAD_LOADING ||
new_load_state == LOAD_FINISHED);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->load_state = new_load_state;
}
/* Selects the first row in the file list */
static void
browse_files_select_first_row (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreePath *path;
GtkTreeIter dummy_iter;
GtkTreeModel *tree_model;
tree_model = gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view));
if (!tree_model)
return;
path = gtk_tree_path_new_from_indices (0, -1);
/* If the list is empty, do nothing. */
if (gtk_tree_model_get_iter (tree_model, &dummy_iter, path))
{
/* Although the following call to gtk_tree_view_set_cursor() is intended to
* only change the focus to the first row (not select it), GtkTreeView *will*
* select the row anyway due to bug #492206. So, we'll use a flag to
* keep our own callbacks from changing the location_entry when the selection
* is changed. This entire function, browse_files_select_first_row(), may
* go away when that bug is fixed in GtkTreeView.
*/
priv->auto_selecting_first_row = TRUE;
gtk_tree_view_set_cursor (GTK_TREE_VIEW (priv->browse_files_tree_view), path, NULL, FALSE);
priv->auto_selecting_first_row = FALSE;
}
gtk_tree_path_free (path);
}
struct center_selected_row_closure {
GtkFileChooserWidget *impl;
gboolean already_centered;
};
/* Callback used from gtk_tree_selection_selected_foreach(); centers the
* selected row in the tree view.
*/
static void
center_selected_row_foreach_cb (GtkTreeModel *model,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
struct center_selected_row_closure *closure;
closure = data;
if (closure->already_centered)
return;
gtk_tree_view_scroll_to_cell (GTK_TREE_VIEW (closure->impl->priv->browse_files_tree_view), path, NULL, TRUE, 0.5, 0.0);
closure->already_centered = TRUE;
}
/* Centers the selected row in the tree view */
static void
browse_files_center_selected_row (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
struct center_selected_row_closure closure;
GtkTreeSelection *selection;
closure.impl = impl;
closure.already_centered = FALSE;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_selected_foreach (selection, center_selected_row_foreach_cb, &closure);
}
static gboolean
show_and_select_files (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GSList *files)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
GtkFileSystemModel *fsmodel;
gboolean enabled_hidden, removed_filters;
gboolean selected_a_file;
GSList *walk;
g_assert (priv->load_state == LOAD_FINISHED);
g_assert (priv->browse_files_model != NULL);
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
fsmodel = GTK_FILE_SYSTEM_MODEL (gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view)));
g_assert (fsmodel == priv->browse_files_model);
enabled_hidden = priv->show_hidden;
removed_filters = (priv->current_filter == NULL);
selected_a_file = FALSE;
for (walk = files; walk; walk = walk->next)
{
GFile *file = walk->data;
GtkTreeIter iter;
/* Is it a hidden file? */
if (!_gtk_file_system_model_get_iter_for_file (fsmodel, &iter, file))
continue;
if (!_gtk_file_system_model_iter_is_visible (fsmodel, &iter))
{
GFileInfo *info = _gtk_file_system_model_get_info (fsmodel, &iter);
if (!enabled_hidden &&
(g_file_info_get_is_hidden (info) ||
g_file_info_get_is_backup (info)))
{
g_object_set (impl, "show-hidden", TRUE, NULL);
enabled_hidden = TRUE;
}
}
/* Is it a filtered file? */
if (!_gtk_file_system_model_get_iter_for_file (fsmodel, &iter, file))
continue; /* re-get the iter as it may change when the model refilters */
if (!_gtk_file_system_model_iter_is_visible (fsmodel, &iter))
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Maybe we should have a way to ask the fsmodel if it had filtered a file */
if (!removed_filters)
{
set_current_filter (impl, NULL);
removed_filters = TRUE;
}
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Okay, can we select the file now? */
if (!_gtk_file_system_model_get_iter_for_file (fsmodel, &iter, file))
continue;
if (_gtk_file_system_model_iter_is_visible (fsmodel, &iter))
{
GtkTreePath *path;
gtk_tree_selection_select_iter (selection, &iter);
path = gtk_tree_model_get_path (GTK_TREE_MODEL (fsmodel), &iter);
gtk_tree_view_set_cursor (GTK_TREE_VIEW (priv->browse_files_tree_view),
path, NULL, FALSE);
gtk_tree_path_free (path);
selected_a_file = TRUE;
}
}
browse_files_center_selected_row (impl);
return selected_a_file;
}
/* Processes the pending operation when a folder is finished loading */
static void
pending_select_files_process (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_assert (priv->load_state == LOAD_FINISHED);
g_assert (priv->browse_files_model != NULL);
if (priv->pending_select_files)
{
show_and_select_files (impl, priv->pending_select_files);
pending_select_files_free (impl);
browse_files_center_selected_row (impl);
}
else
{
/* We only select the first row if the chooser is actually mapped ---
* selecting the first row is to help the user when he is interacting with
* the chooser, but sometimes a chooser works not on behalf of the user,
* but rather on behalf of something else like GtkFileChooserButton. In
* that case, the chooser's selection should be what the caller expects,
* as the user can't see that something else got selected. See bug #165264.
*/
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN &&
gtk_widget_get_mapped (GTK_WIDGET (impl)))
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
browse_files_select_first_row (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
g_assert (priv->pending_select_files == NULL);
}
static void
show_error_on_reading_current_folder (GtkFileChooserWidget *impl, GError *error)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFileInfo *info;
char *msg;
info = g_file_query_info (priv->current_folder,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME,
G_FILE_QUERY_INFO_NONE,
NULL,
NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (info)
{
msg = g_strdup_printf (_("Could not read the contents of %s"), g_file_info_get_display_name (info));
g_object_unref (info);
}
else
msg = g_strdup (_("Could not read the contents of the folder"));
error_message (impl, msg, error->message);
g_free (msg);
}
/* Callback used when the file system model finishes loading */
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
browse_files_model_finished_loading_cb (GtkFileSystemModel *model,
GError *error,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
profile_start ("start", NULL);
if (error)
show_error_on_reading_current_folder (impl, error);
if (priv->load_state == LOAD_PRELOAD)
{
load_remove_timer (impl, LOAD_FINISHED);
load_set_model (impl);
}
else if (priv->load_state == LOAD_LOADING)
{
/* Nothing */
}
else
{
/* We can't g_assert_not_reached(), as something other than us may have
* initiated a folder reload. See #165556.
*/
profile_end ("end", NULL);
return;
}
g_assert (priv->load_timeout_id == 0);
priv->load_state = LOAD_FINISHED;
pending_select_files_process (impl);
set_busy_cursor (impl, FALSE);
#ifdef PROFILE_FILE_CHOOSER
access ("MARK: *** FINISHED LOADING", F_OK);
#endif
profile_end ("end", NULL);
}
static void
stop_loading_and_clear_list_model (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean remove)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
load_remove_timer (impl, LOAD_EMPTY);
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_set_object (&priv->browse_files_model, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (remove)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_view_set_model (GTK_TREE_VIEW (priv->browse_files_tree_view), NULL);
}
GtkFileChooserWidget: Use ratio in formatted times This matches what we do in other places now.
2014-08-22 05:47:21 +00:00
/* Replace 'target' with 'replacement' in the input string. */
static gchar *
string_replace (const gchar *input,
const gchar *target,
const gchar *replacement)
{
gchar **pieces;
gchar *output;
pieces = g_strsplit (input, target, -1);
output = g_strjoinv (replacement, pieces);
g_strfreev (pieces);
return output;
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
static void
replace_ratio (gchar **str)
{
if (g_get_charset (NULL))
{
gchar *ret;
ret = string_replace (*str, ":", "\xE2\x80\x8E∶");
g_free (*str);
*str = ret;
}
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static char *
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
my_g_format_date_for_display (GtkFileChooserWidget *impl,
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
glong secs)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GDateTime *now, *time;
GTimeSpan time_diff;
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
ClockFormat clock_format;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
const gchar *format;
gchar *date_str;
GSettings *settings;
time = g_date_time_new_from_unix_local (secs);
settings = _gtk_file_chooser_get_settings_for_widget (GTK_WIDGET (impl));
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
clock_format = g_settings_get_enum (settings, "clock-format");
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
now = g_date_time_new_now_local ();
time_diff = g_date_time_difference (now, time);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Translators: see g_date_time_format() for details on the format */
if (time_diff >= 0 && time_diff < G_TIME_SPAN_DAY)
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
{
file chooser: Add a way to toggle time display
2015-07-02 17:44:19 +00:00
if (priv->show_time)
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
format = "";
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
else if (clock_format == CLOCK_FORMAT_24)
format = _("%H:%M");
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
else
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
format = _("%l:%M %p");
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else if (time_diff >= 0 && time_diff < 2 * G_TIME_SPAN_DAY)
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
{
format = _("Yesterday");
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else if (time_diff >= 0 && time_diff < 7 * G_TIME_SPAN_DAY)
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
{
format = "%a"; /* Days from last week */
}
else if (g_date_time_get_year (now) == g_date_time_get_year (time))
{
format = _("%-e %b");
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
{
format = N_("%-e %b %Y");
}
date_str = g_date_time_format (time, format);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
replace_ratio (&date_str);
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_date_time_unref (now);
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
g_date_time_unref (time);
return date_str;
}
static char *
my_g_format_time_for_display (GtkFileChooserWidget *impl,
glong secs)
{
GDateTime *time;
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
ClockFormat clock_format;
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
const gchar *format;
gchar *date_str;
GSettings *settings;
time = g_date_time_new_from_unix_local (secs);
settings = _gtk_file_chooser_get_settings_for_widget (GTK_WIDGET (impl));
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
clock_format = g_settings_get_enum (settings, "clock-format");
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
file chooser: Clean up enum handling Use g_settings_get_set_enum to handle the clock and date format settings.
2015-07-02 21:47:30 +00:00
if (clock_format == CLOCK_FORMAT_24)
format = _("%H:%M");
else
format = _("%l:%M %p");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
date_str = g_date_time_format (time, format);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
replace_ratio (&date_str);
GtkFileChooserWidget: Use ratio in formatted times This matches what we do in other places now.
2014-08-22 05:47:21 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_date_time_unref (time);
return date_str;
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
copy_attribute (GFileInfo *to,
GFileInfo *from,
const gchar *attribute)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GFileAttributeType type;
gpointer value;
if (g_file_info_get_attribute_data (from, attribute, &type, &value, NULL))
g_file_info_set_attribute (to, attribute, type, value);
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
file_system_model_got_thumbnail (GObject *object,
GAsyncResult *res,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileSystemModel *model = data; /* might be unreffed if operation was cancelled */
GFile *file = G_FILE (object);
GFileInfo *queried, *info;
GtkTreeIter iter;
queried = g_file_query_info_finish (file, res, NULL);
if (queried == NULL)
return;
gdk_threads_enter ();
/* now we know model is valid */
/* file was deleted */
if (!_gtk_file_system_model_get_iter_for_file (model, &iter, file))
{
Don't leak the queried file info https://bugzilla.gnome.org/show_bug.cgi?id=554618
2014-02-21 19:02:37 +00:00
g_object_unref (queried);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gdk_threads_leave ();
return;
}
info = g_file_info_dup (_gtk_file_system_model_get_info (model, &iter));
copy_attribute (info, queried, G_FILE_ATTRIBUTE_THUMBNAIL_PATH);
copy_attribute (info, queried, G_FILE_ATTRIBUTE_THUMBNAILING_FAILED);
copy_attribute (info, queried, G_FILE_ATTRIBUTE_STANDARD_ICON);
_gtk_file_system_model_update_file (model, file, info);
g_object_unref (info);
Don't leak the queried file info https://bugzilla.gnome.org/show_bug.cgi?id=554618
2014-02-21 19:02:37 +00:00
g_object_unref (queried);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gdk_threads_leave ();
}
static gboolean
file_system_model_set (GtkFileSystemModel *model,
GFile *file,
GFileInfo *info,
int column,
GValue *value,
gpointer data)
{
GtkFileChooserWidget *impl = data;
GtkFileChooserWidgetPrivate *priv = impl->priv;
Whitespace fixes
2015-08-03 00:58:19 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
switch (column)
{
case MODEL_COL_FILE:
g_value_set_object (value, file);
break;
case MODEL_COL_NAME:
if (info == NULL)
g_value_set_string (value, DEFAULT_NEW_FOLDER_NAME);
Whitespace fixes
2015-08-03 00:58:19 +00:00
else
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_value_set_string (value, g_file_info_get_display_name (info));
break;
case MODEL_COL_NAME_COLLATED:
if (info == NULL)
g_value_take_string (value, g_utf8_collate_key_for_filename (DEFAULT_NEW_FOLDER_NAME, -1));
Whitespace fixes
2015-08-03 00:58:19 +00:00
else
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_value_take_string (value, g_utf8_collate_key_for_filename (g_file_info_get_display_name (info), -1));
break;
case MODEL_COL_IS_FOLDER:
g_value_set_boolean (value, info == NULL || _gtk_file_info_consider_as_directory (info));
break;
case MODEL_COL_IS_SENSITIVE:
if (info)
{
gboolean sensitive = TRUE;
if (!(priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
|| priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
sensitive = TRUE; /* for file modes... */
}
else if (!_gtk_file_info_consider_as_directory (info))
{
sensitive = FALSE; /* for folder modes, files are not sensitive... */
}
else
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* ... and for folder modes, folders are sensitive only if the filter says so */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkTreeIter iter;
if (!_gtk_file_system_model_get_iter_for_file (model, &iter, file))
g_assert_not_reached ();
sensitive = !_gtk_file_system_model_iter_is_filtered_out (model, &iter);
}
g_value_set_boolean (value, sensitive);
}
else
g_value_set_boolean (value, TRUE);
break;
case MODEL_COL_SURFACE:
if (info)
{
if (g_file_info_has_attribute (info, G_FILE_ATTRIBUTE_STANDARD_ICON))
{
g_value_take_boxed (value, _gtk_file_info_render_icon (info, GTK_WIDGET (impl), priv->icon_size));
}
else
{
GtkTreeModel *tree_model;
file chooser: Don't leave out icons by accident We only load thumbnails when we find that the row is in the visible range of the treeview. It seems that animated scrolling makes it so that the bottommost row stays out of the visible range until it is too late. To work around this, extend the range by one row in each direction. http://bugzilla.gnome.org/show_bug.cgi?id=753142
2015-08-03 00:42:42 +00:00
GtkTreePath *start, *end;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkTreeIter iter;
file chooser: Don't leave out icons by accident We only load thumbnails when we find that the row is in the visible range of the treeview. It seems that animated scrolling makes it so that the bottommost row stays out of the visible range until it is too late. To work around this, extend the range by one row in each direction. http://bugzilla.gnome.org/show_bug.cgi?id=753142
2015-08-03 00:42:42 +00:00
gboolean visible;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->browse_files_tree_view == NULL ||
g_file_info_has_attribute (info, "filechooser::queried"))
return FALSE;
tree_model = gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view));
if (tree_model != GTK_TREE_MODEL (model))
return FALSE;
file chooser: Don't leave out icons by accident We only load thumbnails when we find that the row is in the visible range of the treeview. It seems that animated scrolling makes it so that the bottommost row stays out of the visible range until it is too late. To work around this, extend the range by one row in each direction. http://bugzilla.gnome.org/show_bug.cgi?id=753142
2015-08-03 00:42:42 +00:00
if (!_gtk_file_system_model_get_iter_for_file (model, &iter, file))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_assert_not_reached ();
file chooser: Don't leave out icons by accident We only load thumbnails when we find that the row is in the visible range of the treeview. It seems that animated scrolling makes it so that the bottommost row stays out of the visible range until it is too late. To work around this, extend the range by one row in each direction. http://bugzilla.gnome.org/show_bug.cgi?id=753142
2015-08-03 00:42:42 +00:00
if (gtk_tree_view_get_visible_range (GTK_TREE_VIEW (priv->browse_files_tree_view), &start, &end))
{
GtkTreePath *path;
gtk_tree_path_prev (start);
gtk_tree_path_next (end);
path = gtk_tree_model_get_path (tree_model, &iter);
visible = gtk_tree_path_compare (start, path) != 1 &&
gtk_tree_path_compare (path, end) != 1;
gtk_tree_path_free (path);
gtk_tree_path_free (start);
gtk_tree_path_free (end);
}
else
visible = TRUE;
if (visible)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
g_file_info_set_attribute_boolean (info, "filechooser::queried", TRUE);
g_file_query_info_async (file,
G_FILE_ATTRIBUTE_THUMBNAIL_PATH ","
G_FILE_ATTRIBUTE_THUMBNAILING_FAILED ","
G_FILE_ATTRIBUTE_STANDARD_ICON,
G_FILE_QUERY_INFO_NONE,
G_PRIORITY_DEFAULT,
_gtk_file_system_model_get_cancellable (model),
file_system_model_got_thumbnail,
model);
}
return FALSE;
}
}
else
file chooser: Avoid triggering assertions cairo surfaces are boxed types, so don't try to set them with g_value_set_object().
2015-03-02 20:53:35 +00:00
g_value_set_boxed (value, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
break;
case MODEL_COL_SIZE:
g_value_set_int64 (value, info ? g_file_info_get_size (info) : 0);
break;
case MODEL_COL_SIZE_TEXT:
if (info == NULL || _gtk_file_info_consider_as_directory (info))
g_value_set_string (value, NULL);
else
g_value_take_string (value, g_format_size (g_file_info_get_size (info)));
break;
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
case MODEL_COL_TIME:
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
case MODEL_COL_DATE_TEXT:
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
case MODEL_COL_TIME_TEXT:
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
glong time;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (info == NULL)
break;
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
if (priv->operation_mode == OPERATION_MODE_RECENT)
time = (glong) g_file_info_get_attribute_uint64 (info, G_FILE_ATTRIBUTE_TIME_ACCESS);
else
time = (glong) g_file_info_get_attribute_uint64 (info, G_FILE_ATTRIBUTE_TIME_MODIFIED);
if (column == MODEL_COL_TIME)
g_value_set_long (value, time);
else if (time == 0)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_value_set_static_string (value, _("Unknown"));
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
else if (column == MODEL_COL_DATE_TEXT)
g_value_take_string (value, my_g_format_date_for_display (impl, time));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
g_value_take_string (value, my_g_format_time_for_display (impl, time));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
break;
}
case MODEL_COL_ELLIPSIZE:
g_value_set_enum (value, info ? PANGO_ELLIPSIZE_END : PANGO_ELLIPSIZE_NONE);
break;
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
case MODEL_COL_LOCATION_TEXT:
{
GFile *home_location;
GFile *dir_location;
gchar *location;
home_location = g_file_new_for_path (g_get_home_dir ());
file chooser: Avoid warnings from the location column Avoid criticals that would come out of this code if file is / or NULL.
2015-03-02 20:38:29 +00:00
if (file)
dir_location = g_file_get_parent (file);
else
dir_location = NULL;
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
file chooser: Make location column work better The location column did not work for search results in recent://. Fix that by looking at the target uri in this case. Show the location column in recent mode. And make it more similar to nautilus by showing the full path if it is not below $HOME.
2015-06-27 05:07:32 +00:00
if (dir_location && file_is_recent_uri (dir_location))
{
const char *target_uri;
GFile *target;
target_uri = g_file_info_get_attribute_string (info, G_FILE_ATTRIBUTE_STANDARD_TARGET_URI);
target = g_file_new_for_uri (target_uri);
g_object_unref (dir_location);
dir_location = g_file_get_parent (target);
g_object_unref (target);
}
if (!dir_location)
file chooser: Improve location column formatting
2015-07-03 05:19:05 +00:00
location = g_strdup ("/");
else if (priv->current_folder && g_file_equal (priv->current_folder, dir_location))
file chooser: Make location column work better The location column did not work for search results in recent://. Fix that by looking at the target uri in this case. Show the location column in recent mode. And make it more similar to nautilus by showing the full path if it is not below $HOME.
2015-06-27 05:07:32 +00:00
location = g_strdup ("");
else if (g_file_equal (home_location, dir_location))
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
location = g_strdup (_("Home"));
file chooser: Make location column work better The location column did not work for search results in recent://. Fix that by looking at the target uri in this case. Show the location column in recent mode. And make it more similar to nautilus by showing the full path if it is not below $HOME.
2015-06-27 05:07:32 +00:00
else if (g_file_has_prefix (dir_location, home_location))
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
{
gchar *relative_path;
relative_path = g_file_get_relative_path (home_location, dir_location);
location = g_filename_display_name (relative_path);
g_free (relative_path);
}
else
file chooser: Make location column work better The location column did not work for search results in recent://. Fix that by looking at the target uri in this case. Show the location column in recent mode. And make it more similar to nautilus by showing the full path if it is not below $HOME.
2015-06-27 05:07:32 +00:00
location = g_file_get_path (dir_location);
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
g_value_take_string (value, location);
file chooser: Avoid warnings from the location column Avoid criticals that would come out of this code if file is / or NULL.
2015-03-02 20:38:29 +00:00
if (dir_location)
g_object_unref (dir_location);
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
g_object_unref (home_location);
}
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
default:
g_assert_not_reached ();
break;
}
return TRUE;
}
/* Gets rid of the old list model and creates a new one for the current folder */
static gboolean
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
set_list_model (GtkFileChooserWidget *impl,
GError **error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_assert (priv->current_folder != NULL);
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
if (priv->browse_files_model &&
_gtk_file_system_model_get_directory (priv->browse_files_model) == priv->current_folder)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return TRUE;
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
profile_start ("start", NULL);
stop_loading_and_clear_list_model (impl, TRUE);
set_busy_cursor (impl, TRUE);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->browse_files_model =
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_file_system_model_new_for_directory (priv->current_folder,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
MODEL_ATTRIBUTES,
file_system_model_set,
impl,
MODEL_COLUMN_TYPES);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_file_system_model_set_show_hidden (priv->browse_files_model, priv->show_hidden);
profile_msg (" set sort function", NULL);
gtk_tree_sortable_set_sort_func (GTK_TREE_SORTABLE (priv->browse_files_model), MODEL_COL_NAME, name_sort_func, impl, NULL);
gtk_tree_sortable_set_sort_func (GTK_TREE_SORTABLE (priv->browse_files_model), MODEL_COL_SIZE, size_sort_func, impl, NULL);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_tree_sortable_set_sort_func (GTK_TREE_SORTABLE (priv->browse_files_model), MODEL_COL_TIME, time_sort_func, impl, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_sortable_set_default_sort_func (GTK_TREE_SORTABLE (priv->browse_files_model), NULL, NULL, NULL);
set_sort_column (impl);
priv->list_sort_ascending = TRUE;
g_signal_connect (priv->browse_files_model, "sort-column-changed",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_CALLBACK (list_sort_column_changed_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
load_setup_timer (impl); /* This changes the state to LOAD_PRELOAD */
g_signal_connect (priv->browse_files_model, "finished-loading",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_CALLBACK (browse_files_model_finished_loading_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_file_system_model_set_filter (priv->browse_files_model, priv->current_filter);
profile_end ("end", NULL);
return TRUE;
}
struct update_chooser_entry_selected_foreach_closure {
int num_selected;
GtkTreeIter first_selected_iter;
};
static gint
compare_utf8_filenames (const gchar *a,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *b)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gchar *a_folded, *b_folded;
gint retval;
a_folded = g_utf8_strdown (a, -1);
b_folded = g_utf8_strdown (b, -1);
retval = strcmp (a_folded, b_folded);
g_free (a_folded);
g_free (b_folded);
return retval;
}
static void
update_chooser_entry_selected_foreach (GtkTreeModel *model,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
struct update_chooser_entry_selected_foreach_closure *closure;
closure = data;
closure->num_selected++;
if (closure->num_selected == 1)
closure->first_selected_iter = *iter;
}
static void
update_chooser_entry (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
struct update_chooser_entry_selected_foreach_closure closure;
/* no need to update the file chooser's entry if there's no entry */
if (priv->operation_mode == OPERATION_MODE_SEARCH ||
!priv->location_entry)
return;
if (!(priv->action == GTK_FILE_CHOOSER_ACTION_SAVE
|| priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER
|| ((priv->action == GTK_FILE_CHOOSER_ACTION_OPEN
|| priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
&& priv->location_mode == LOCATION_MODE_FILENAME_ENTRY)))
return;
g_assert (priv->location_entry != NULL);
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
closure.num_selected = 0;
gtk_tree_selection_selected_foreach (selection, update_chooser_entry_selected_foreach, &closure);
if (closure.num_selected == 0)
{
if (priv->operation_mode == OPERATION_MODE_RECENT)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_gtk_file_chooser_entry_set_base_folder (GTK_FILE_CHOOSER_ENTRY (priv->location_entry), NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
goto maybe_clear_entry;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (closure.num_selected == 1)
{
if (priv->operation_mode == OPERATION_MODE_BROWSE)
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFileInfo *info;
gboolean change_entry;
info = _gtk_file_system_model_get_info (priv->browse_files_model, &closure.first_selected_iter);
/* If the cursor moved to the row of the newly created folder,
* retrieving info will return NULL.
*/
if (!info)
return;
g_free (priv->browse_files_last_selected_name);
priv->browse_files_last_selected_name =
g_strdup (g_file_info_get_display_name (info));
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
/* Don't change the name when clicking on a folder... */
change_entry = !_gtk_file_info_consider_as_directory (info);
}
else
change_entry = TRUE; /* ... unless we are in SELECT_FOLDER mode */
if (change_entry && !priv->auto_selecting_first_row)
{
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
g_signal_handlers_block_by_func (priv->location_entry, G_CALLBACK (location_entry_changed_cb), impl);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_entry_set_text (GTK_ENTRY (priv->location_entry), priv->browse_files_last_selected_name);
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
g_signal_handlers_unblock_by_func (priv->location_entry, G_CALLBACK (location_entry_changed_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
_gtk_file_chooser_entry_select_filename (GTK_FILE_CHOOSER_ENTRY (priv->location_entry));
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (priv->operation_mode == OPERATION_MODE_RECENT
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
&& priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
{
GFile *folder;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Set the base folder on the name entry, so it will do completion relative to the correct recent-folder */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_tree_model_get (GTK_TREE_MODEL (priv->recent_model), &closure.first_selected_iter,
MODEL_COL_FILE, &folder,
-1);
_gtk_file_chooser_entry_set_base_folder (GTK_FILE_CHOOSER_ENTRY (priv->location_entry), folder);
g_object_unref (folder);
return;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
{
g_assert (!(priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER));
/* Multiple selection, so just clear the entry. */
g_free (priv->browse_files_last_selected_name);
priv->browse_files_last_selected_name = NULL;
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
g_signal_handlers_block_by_func (priv->location_entry, G_CALLBACK (location_entry_changed_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_entry_set_text (GTK_ENTRY (priv->location_entry), "");
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
g_signal_handlers_unblock_by_func (priv->location_entry, G_CALLBACK (location_entry_changed_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return;
}
maybe_clear_entry:
if ((priv->action == GTK_FILE_CHOOSER_ACTION_OPEN || priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
&& priv->browse_files_last_selected_name)
{
const char *entry_text;
int len;
gboolean clear_entry;
entry_text = gtk_entry_get_text (GTK_ENTRY (priv->location_entry));
len = strlen (entry_text);
if (len != 0)
{
/* The file chooser entry may have appended a "/" to its text.
* So take it out, and compare the result to the old selection.
*/
if (entry_text[len - 1] == G_DIR_SEPARATOR)
{
gchar *tmp;
tmp = g_strndup (entry_text, len - 1);
clear_entry = (compare_utf8_filenames (priv->browse_files_last_selected_name, tmp) == 0);
g_free (tmp);
}
else
clear_entry = (compare_utf8_filenames (priv->browse_files_last_selected_name, entry_text) == 0);
}
else
clear_entry = FALSE;
if (clear_entry)
file-chooser: emit selection-changed when location entry changes too https://bugzilla.gnome.org/show_bug.cgi?id=547988
2014-02-28 20:19:00 +00:00
{
g_signal_handlers_block_by_func (priv->location_entry, G_CALLBACK (location_entry_changed_cb), impl);
gtk_entry_set_text (GTK_ENTRY (priv->location_entry), "");
g_signal_handlers_unblock_by_func (priv->location_entry, G_CALLBACK (location_entry_changed_cb), impl);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
}
static gboolean
gtk_file_chooser_widget_set_current_folder (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError **error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
return gtk_file_chooser_widget_update_current_folder (chooser, file, FALSE, FALSE, error);
}
struct UpdateCurrentFolderData
{
GtkFileChooserWidget *impl;
GFile *file;
gboolean keep_trail;
gboolean clear_entry;
GFile *original_file;
GError *original_error;
};
static void
update_current_folder_mount_enclosing_volume_cb (GCancellable *cancellable,
GtkFileSystemVolume *volume,
const GError *error,
gpointer user_data)
{
struct UpdateCurrentFolderData *data = user_data;
GtkFileChooserWidget *impl = data->impl;
GtkFileChooserWidgetPrivate *priv = impl->priv;
gboolean cancelled = g_cancellable_is_cancelled (cancellable);
if (cancellable != priv->update_current_folder_cancellable)
goto out;
priv->update_current_folder_cancellable = NULL;
set_busy_cursor (impl, FALSE);
if (cancelled)
goto out;
if (error)
{
error_changing_folder_dialog (data->impl, data->file, g_error_copy (error));
priv->reload_state = RELOAD_EMPTY;
goto out;
}
change_folder_and_display_error (impl, data->file, data->clear_entry);
out:
GtkFileChooserWidget: Fix a crash for when the widget was unrefed right after setting a current folder. Keep a reference to the widget while the async operation is ongoing. https://bugzilla.gnome.org/show_bug.cgi?id=725164
2015-01-20 16:54:03 +00:00
g_object_unref (data->impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_object_unref (data->file);
g_free (data);
g_object_unref (cancellable);
}
static void
update_current_folder_get_info_cb (GCancellable *cancellable,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFileInfo *info,
const GError *error,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gboolean cancelled = g_cancellable_is_cancelled (cancellable);
struct UpdateCurrentFolderData *data = user_data;
GtkFileChooserWidget *impl = data->impl;
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (cancellable != priv->update_current_folder_cancellable)
goto out;
priv->update_current_folder_cancellable = NULL;
priv->reload_state = RELOAD_EMPTY;
set_busy_cursor (impl, FALSE);
if (cancelled)
goto out;
if (error)
{
GFile *parent_file;
if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_NOT_MOUNTED))
{
GMountOperation *mount_operation;
GtkWidget *toplevel;
g_object_unref (cancellable);
toplevel = gtk_widget_get_toplevel (GTK_WIDGET (impl));
mount_operation = gtk_mount_operation_new (GTK_WINDOW (toplevel));
set_busy_cursor (impl, TRUE);
priv->update_current_folder_cancellable =
_gtk_file_system_mount_enclosing_volume (priv->file_system, data->file,
mount_operation,
update_current_folder_mount_enclosing_volume_cb,
data);
return;
}
if (!data->original_file)
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
data->original_file = g_object_ref (data->file);
data->original_error = g_error_copy (error);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
parent_file = g_file_get_parent (data->file);
/* get parent path and try to change the folder to that */
if (parent_file)
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_object_unref (data->file);
data->file = parent_file;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_object_unref (cancellable);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* restart the update current folder operation */
priv->reload_state = RELOAD_HAS_FOLDER;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->update_current_folder_cancellable =
_gtk_file_system_get_info (priv->file_system, data->file,
"standard::type",
update_current_folder_get_info_cb,
data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
set_busy_cursor (impl, TRUE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
{
/* Error and bail out, ignoring "not found" errors since they're useless:
* they only happen when a program defaults to a folder that has been (re)moved.
*/
if (!g_error_matches (data->original_error, G_IO_ERROR, G_IO_ERROR_NOT_FOUND))
error_changing_folder_dialog (impl, data->original_file, data->original_error);
else
g_error_free (data->original_error);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_object_unref (data->original_file);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
goto out;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
if (data->original_file)
{
/* Error and bail out, ignoring "not found" errors since they're useless:
* they only happen when a program defaults to a folder that has been (re)moved.
*/
if (!g_error_matches (data->original_error, G_IO_ERROR, G_IO_ERROR_NOT_FOUND))
error_changing_folder_dialog (impl, data->original_file, data->original_error);
else
g_error_free (data->original_error);
g_object_unref (data->original_file);
}
if (! _gtk_file_info_consider_as_directory (info))
goto out;
_gtk_path_bar_set_file (GTK_PATH_BAR (priv->browse_path_bar), data->file, data->keep_trail);
if (priv->current_folder != data->file)
{
if (priv->current_folder)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_object_unref (priv->current_folder);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->current_folder = g_object_ref (data->file);
}
priv->reload_state = RELOAD_HAS_FOLDER;
/* Set the folder on the save entry */
if (priv->location_entry)
{
_gtk_file_chooser_entry_set_base_folder (GTK_FILE_CHOOSER_ENTRY (priv->location_entry),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->current_folder);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (data->clear_entry)
gtk_entry_set_text (GTK_ENTRY (priv->location_entry), "");
}
/* Create a new list model. This is slightly evil; we store the result value
* but perform more actions rather than returning immediately even if it
* generates an error.
*/
set_list_model (impl, NULL);
/* Refresh controls */
gtk_places_sidebar_set_location (GTK_PLACES_SIDEBAR (priv->places_sidebar), priv->current_folder);
file chooser: Ensure we update subtitles Notify the ::subtitle property when modes change that may affect it. Also ensure that we update the location mode when we switch back to the pathbar.
2015-07-08 21:42:34 +00:00
g_object_notify (G_OBJECT (impl), "subtitle");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_signal_emit_by_name (impl, "current-folder-changed", 0);
check_preview_change (impl);
g_signal_emit_by_name (impl, "selection-changed", 0);
out:
GtkFileChooserWidget: Fix a crash for when the widget was unrefed right after setting a current folder. Keep a reference to the widget while the async operation is ongoing. https://bugzilla.gnome.org/show_bug.cgi?id=725164
2015-01-20 16:54:03 +00:00
g_object_unref (data->impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_object_unref (data->file);
g_free (data);
g_object_unref (cancellable);
}
static gboolean
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_file_chooser_widget_update_current_folder (GtkFileChooser *chooser,
GFile *file,
gboolean keep_trail,
gboolean clear_entry,
GError **error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
struct UpdateCurrentFolderData *data;
profile_start ("start", NULL);
g_object_ref (file);
operation_mode_set (impl, OPERATION_MODE_BROWSE);
if (priv->local_only && !_gtk_file_has_native_path (file))
{
g_set_error_literal (error,
GTK_FILE_CHOOSER_ERROR,
GTK_FILE_CHOOSER_ERROR_BAD_FILENAME,
_("Cannot change to folder because it is not local"));
g_object_unref (file);
profile_end ("end - not local", NULL);
return FALSE;
}
if (priv->update_current_folder_cancellable)
g_cancellable_cancel (priv->update_current_folder_cancellable);
/* Test validity of path here. */
data = g_new0 (struct UpdateCurrentFolderData, 1);
GtkFileChooserWidget: Fix a crash for when the widget was unrefed right after setting a current folder. Keep a reference to the widget while the async operation is ongoing. https://bugzilla.gnome.org/show_bug.cgi?id=725164
2015-01-20 16:54:03 +00:00
data->impl = g_object_ref (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
data->file = g_object_ref (file);
data->keep_trail = keep_trail;
data->clear_entry = clear_entry;
priv->reload_state = RELOAD_HAS_FOLDER;
priv->update_current_folder_cancellable =
_gtk_file_system_get_info (priv->file_system, file,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
"standard::type",
update_current_folder_get_info_cb,
data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
set_busy_cursor (impl, TRUE);
g_object_unref (file);
profile_end ("end", NULL);
return TRUE;
}
static GFile *
gtk_file_chooser_widget_get_current_folder (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
if (priv->operation_mode == OPERATION_MODE_RECENT)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return NULL;
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->current_folder)
return g_object_ref (priv->current_folder);
return NULL;
}
static void
gtk_file_chooser_widget_set_current_name (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *name)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_return_if_fail (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
pending_select_files_free (impl);
gtk_entry_set_text (GTK_ENTRY (priv->location_entry), name);
}
static gchar *
gtk_file_chooser_widget_get_current_name (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_return_val_if_fail (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER,
NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return g_strdup (gtk_entry_get_text (GTK_ENTRY (priv->location_entry)));
}
static gboolean
gtk_file_chooser_widget_select_file (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError **error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFile *parent_file;
gboolean same_path;
parent_file = g_file_get_parent (file);
if (!parent_file)
return gtk_file_chooser_set_current_folder_file (chooser, file, error);
if (priv->operation_mode == OPERATION_MODE_SEARCH ||
priv->operation_mode == OPERATION_MODE_RECENT ||
priv->load_state == LOAD_EMPTY)
{
same_path = FALSE;
}
else
{
g_assert (priv->current_folder != NULL);
same_path = g_file_equal (parent_file, priv->current_folder);
}
if (same_path && priv->load_state == LOAD_FINISHED)
{
gboolean result;
GSList files;
files.data = (gpointer) file;
files.next = NULL;
result = show_and_select_files (impl, &files);
g_object_unref (parent_file);
return result;
}
pending_select_files_add (impl, file);
if (!same_path)
{
gboolean result;
result = gtk_file_chooser_set_current_folder_file (chooser, parent_file, error);
g_object_unref (parent_file);
return result;
}
g_object_unref (parent_file);
return TRUE;
}
static void
gtk_file_chooser_widget_unselect_file (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreeView *tree_view;
GtkTreeModel *model;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkTreeIter iter;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
tree_view = GTK_TREE_VIEW (priv->browse_files_tree_view);
model = gtk_tree_view_get_model (tree_view);
if (!model)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (!_gtk_file_system_model_get_iter_for_file (GTK_FILE_SYSTEM_MODEL (model), &iter, file))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_tree_selection_unselect_iter (gtk_tree_view_get_selection (tree_view), &iter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static gboolean
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
maybe_select (GtkTreeModel *model,
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (data);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
gboolean is_sensitive;
gboolean is_folder;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_model_get (model, iter,
MODEL_COL_IS_FOLDER, &is_folder,
MODEL_COL_IS_SENSITIVE, &is_sensitive,
-1);
if (is_sensitive &&
((is_folder && priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER) ||
(!is_folder && priv->action == GTK_FILE_CHOOSER_ACTION_OPEN)))
gtk_tree_selection_select_iter (selection, iter);
else
gtk_tree_selection_unselect_iter (selection, iter);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return FALSE;
}
static void
gtk_file_chooser_widget_select_all (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->operation_mode == OPERATION_MODE_SEARCH ||
priv->operation_mode == OPERATION_MODE_RECENT)
{
GtkTreeSelection *selection;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_select_all (selection);
return;
}
if (priv->select_multiple)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_tree_model_foreach (GTK_TREE_MODEL (priv->browse_files_model),
maybe_select, impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
gtk_file_chooser_widget_unselect_all (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_unselect_all (selection);
pending_select_files_free (impl);
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Checks whether the filename entry for Save modes contains a well-formed filename.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*
* is_well_formed_ret - whether what the user typed passes gkt_file_system_make_path()
*
* is_empty_ret - whether the file entry is totally empty
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* is_file_part_empty_ret - whether the file part is empty (will be if user types
* "foobar/", and the path will be “$cwd/foobar”)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
check_save_entry (GtkFileChooserWidget *impl,
GFile **file_ret,
gboolean *is_well_formed_ret,
gboolean *is_empty_ret,
gboolean *is_file_part_empty_ret,
gboolean *is_folder)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkFileChooserEntry *chooser_entry;
GFile *current_folder;
const char *file_part;
Strip leading and trailing whitespace from filechooser save filenames This makes a local copy of the file part of the entry to strip it transparently Since this is assumed to be a mistake, the user is not notified. https://bugzilla.gnome.org/show_bug.cgi?id=593372
2015-07-01 23:23:15 +00:00
char *file_part_stripped;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GFile *file;
GError *error;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_assert (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER ||
((priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER) &&
priv->location_mode == LOCATION_MODE_FILENAME_ENTRY));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
chooser_entry = GTK_FILE_CHOOSER_ENTRY (priv->location_entry);
if (strlen (gtk_entry_get_text (GTK_ENTRY (chooser_entry))) == 0)
{
*file_ret = NULL;
*is_well_formed_ret = TRUE;
*is_empty_ret = TRUE;
*is_file_part_empty_ret = TRUE;
*is_folder = FALSE;
return;
}
*is_empty_ret = FALSE;
current_folder = _gtk_file_chooser_entry_get_current_folder (chooser_entry);
if (!current_folder)
{
*file_ret = NULL;
*is_well_formed_ret = FALSE;
*is_file_part_empty_ret = FALSE;
*is_folder = FALSE;
return;
}
file_part = _gtk_file_chooser_entry_get_file_part (chooser_entry);
Strip leading and trailing whitespace from filechooser save filenames This makes a local copy of the file part of the entry to strip it transparently Since this is assumed to be a mistake, the user is not notified. https://bugzilla.gnome.org/show_bug.cgi?id=593372
2015-07-01 23:23:15 +00:00
/* Copy and strip leading and trailing whitespace */
file_part_stripped = g_strstrip (g_strdup (file_part));
if (!file_part_stripped || file_part_stripped[0] == '\0')
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
*file_ret = current_folder;
*is_well_formed_ret = TRUE;
*is_file_part_empty_ret = TRUE;
*is_folder = TRUE;
Strip leading and trailing whitespace from filechooser save filenames This makes a local copy of the file part of the entry to strip it transparently Since this is assumed to be a mistake, the user is not notified. https://bugzilla.gnome.org/show_bug.cgi?id=593372
2015-07-01 23:23:15 +00:00
g_free (file_part_stripped);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return;
}
*is_file_part_empty_ret = FALSE;
error = NULL;
Strip leading and trailing whitespace from filechooser save filenames This makes a local copy of the file part of the entry to strip it transparently Since this is assumed to be a mistake, the user is not notified. https://bugzilla.gnome.org/show_bug.cgi?id=593372
2015-07-01 23:23:15 +00:00
file = g_file_get_child_for_display_name (current_folder, file_part_stripped, &error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_object_unref (current_folder);
Strip leading and trailing whitespace from filechooser save filenames This makes a local copy of the file part of the entry to strip it transparently Since this is assumed to be a mistake, the user is not notified. https://bugzilla.gnome.org/show_bug.cgi?id=593372
2015-07-01 23:23:15 +00:00
g_free (file_part_stripped);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (!file)
{
error_building_filename_dialog (impl, error);
*file_ret = NULL;
*is_well_formed_ret = FALSE;
*is_folder = FALSE;
return;
}
*file_ret = file;
*is_well_formed_ret = TRUE;
*is_folder = _gtk_file_chooser_entry_get_is_folder (chooser_entry, file);
}
struct get_files_closure {
GtkFileChooserWidget *impl;
GSList *result;
GFile *file_from_entry;
};
static void
get_files_foreach (GtkTreeModel *model,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Remove a wrong assumption The code for getting the selected files was assuming that we are always in browse mode, and was causing warnings when hitting Ctrl-L twice, right after opening the file chooser. The fix is to simple use the model that is passed into the callback.
2015-07-03 14:52:39 +00:00
GtkFileSystemModel *fs_model = GTK_FILE_SYSTEM_MODEL (model);
struct get_files_closure *info = data;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GFile *file;
file = _gtk_file_system_model_get_file (fs_model, iter);
if (!info->file_from_entry || !g_file_equal (info->file_from_entry, file))
info->result = g_slist_prepend (info->result, g_object_ref (file));
}
static GSList *
gtk_file_chooser_widget_get_files (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
struct get_files_closure info;
GtkWindow *toplevel;
GtkWidget *current_focus;
gboolean file_list_seen;
info.impl = impl;
info.result = NULL;
info.file_from_entry = NULL;
if (priv->operation_mode == OPERATION_MODE_SEARCH)
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
return get_selected_files (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->operation_mode == OPERATION_MODE_RECENT)
{
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
file_list_seen = TRUE;
goto file_entry;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
return get_selected_files (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
toplevel = get_toplevel (GTK_WIDGET (impl));
if (toplevel)
current_focus = gtk_window_get_focus (toplevel);
else
current_focus = NULL;
file_list_seen = FALSE;
if (current_focus == priv->browse_files_tree_view)
{
GtkTreeSelection *selection;
file_list:
file_list_seen = TRUE;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_selected_foreach (selection, get_files_foreach, &info);
/* If there is no selection in the file list, we probably have this situation:
*
* 1. The user typed a filename in the SAVE filename entry ("foo.txt").
* 2. He then double-clicked on a folder ("bar") in the file list
*
* So we want the selection to be "bar/foo.txt". Jump to the case for the
* filename entry to see if that is the case.
*/
if (info.result == NULL && priv->location_entry)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
goto file_entry;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (priv->location_entry && current_focus == priv->location_entry)
{
gboolean is_well_formed, is_empty, is_file_part_empty, is_folder;
file_entry:
check_save_entry (impl, &info.file_from_entry, &is_well_formed, &is_empty, &is_file_part_empty, &is_folder);
if (is_empty)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
goto out;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (!is_well_formed)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return NULL;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (info.file_from_entry)
info.result = g_slist_prepend (info.result, info.file_from_entry);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
else if (!file_list_seen)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
goto file_list;
else
return NULL;
}
else if (priv->toplevel_last_focus_widget == priv->browse_files_tree_view)
goto file_list;
else if (priv->location_entry && priv->toplevel_last_focus_widget == priv->location_entry)
goto file_entry;
else
{
/* The focus is on a dialog's action area button or something else */
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
goto file_entry;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
goto file_list;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
out:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* If there's no folder selected, and we're in SELECT_FOLDER mode,
* then we fall back to the current directory
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER &&
info.result == NULL)
{
GFile *current_folder;
current_folder = gtk_file_chooser_get_current_folder_file (chooser);
if (current_folder)
info.result = g_slist_prepend (info.result, current_folder);
}
return g_slist_reverse (info.result);
}
GFile *
gtk_file_chooser_widget_get_preview_file (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->preview_file)
return g_object_ref (priv->preview_file);
else
return NULL;
}
static GtkFileSystem *
gtk_file_chooser_widget_get_file_system (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
return priv->file_system;
}
/* Shows or hides the filter widgets */
static void
show_filters (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean show)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_widget_set_visible (priv->filter_combo_hbox, show);
Fix filechooser actionbar visibility The actionbar was always visible, even when there is no filter and no extra widget to show. Now we only show it when there is something to show.
2014-05-24 04:00:00 +00:00
update_extra_and_filters (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
gtk_file_chooser_widget_add_filter (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileFilter *filter)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
const gchar *name;
if (g_slist_find (priv->filters, filter))
{
g_warning ("gtk_file_chooser_add_filter() called on filter already in list\n");
return;
}
g_object_ref_sink (filter);
priv->filters = g_slist_append (priv->filters, filter);
name = gtk_file_filter_get_name (filter);
if (!name)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
name = "Untitled filter"; /* Place-holder, doesn't need to be marked for translation */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT (priv->filter_combo), name);
if (!g_slist_find (priv->filters, priv->current_filter))
set_current_filter (impl, filter);
show_filters (impl, TRUE);
}
static void
gtk_file_chooser_widget_remove_filter (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileFilter *filter)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeModel *model;
GtkTreeIter iter;
gint filter_index;
filter_index = g_slist_index (priv->filters, filter);
if (filter_index < 0)
{
g_warning ("gtk_file_chooser_remove_filter() called on filter not in list\n");
return;
}
priv->filters = g_slist_remove (priv->filters, filter);
if (filter == priv->current_filter)
{
if (priv->filters)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
set_current_filter (impl, priv->filters->data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
set_current_filter (impl, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Remove row from the combo box */
model = gtk_combo_box_get_model (GTK_COMBO_BOX (priv->filter_combo));
if (!gtk_tree_model_iter_nth_child (model, &iter, NULL, filter_index))
g_assert_not_reached ();
gtk_list_store_remove (GTK_LIST_STORE (model), &iter);
g_object_unref (filter);
if (!priv->filters)
show_filters (impl, FALSE);
}
static GSList *
gtk_file_chooser_widget_list_filters (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
return g_slist_copy (priv->filters);
}
static gboolean
gtk_file_chooser_widget_add_shortcut_folder (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError **error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_places_sidebar_add_shortcut (GTK_PLACES_SIDEBAR (priv->places_sidebar), file);
return TRUE;
}
static gboolean
gtk_file_chooser_widget_remove_shortcut_folder (GtkFileChooser *chooser,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFile *file,
GError **error)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_places_sidebar_remove_shortcut (GTK_PLACES_SIDEBAR (priv->places_sidebar), file);
return TRUE;
}
static GSList *
gtk_file_chooser_widget_list_shortcut_folders (GtkFileChooser *chooser)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser);
GtkFileChooserWidgetPrivate *priv = impl->priv;
return gtk_places_sidebar_list_shortcuts (GTK_PLACES_SIDEBAR (priv->places_sidebar));
}
/* Guesses a size based upon font sizes */
static void
find_good_size_from_style (GtkWidget *widget,
gint *width,
gint *height)
{
GtkStyleContext *context;
GtkStateFlags state;
double font_size;
GdkScreen *screen;
double resolution;
context = gtk_widget_get_style_context (widget);
state = gtk_widget_get_state_flags (widget);
screen = gtk_widget_get_screen (widget);
if (screen)
{
resolution = gdk_screen_get_resolution (screen);
if (resolution < 0.0) /* will be -1 if the resolution is not defined in the GdkScreen */
resolution = 96.0;
}
else
resolution = 96.0; /* wheeee */
gtk_style_context_get (context, state, "font-size", &font_size, NULL);
font_size = font_size * resolution / 72.0 + 0.5;
*width = font_size * NUM_CHARS;
*height = font_size * NUM_LINES;
}
static void
gtk_file_chooser_widget_get_default_size (GtkFileChooserEmbed *chooser_embed,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint *default_width,
gint *default_height)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser_embed);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkRequisition req;
int x, y, width, height;
GSettings *settings;
settings = _gtk_file_chooser_get_settings_for_widget (GTK_WIDGET (impl));
g_settings_get (settings, SETTINGS_KEY_WINDOW_POSITION, "(ii)", &x, &y);
g_settings_get (settings, SETTINGS_KEY_WINDOW_SIZE, "(ii)", &width, &height);
if (x >= 0 && y >= 0 && width > 0 && height > 0)
{
*default_width = width;
*default_height = height;
return;
}
find_good_size_from_style (GTK_WIDGET (chooser_embed), default_width, default_height);
if (priv->preview_widget_active &&
priv->preview_widget &&
gtk_widget_get_visible (priv->preview_widget))
{
gtk_widget_get_preferred_size (priv->preview_box,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
&req, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*default_width += PREVIEW_HBOX_SPACING + req.width;
}
if (priv->extra_widget &&
gtk_widget_get_visible (priv->extra_widget))
{
gtk_widget_get_preferred_size (priv->extra_align,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
&req, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*default_height += gtk_box_get_spacing (GTK_BOX (chooser_embed)) + req.height;
}
}
struct switch_folder_closure {
GtkFileChooserWidget *impl;
GFile *file;
int num_selected;
};
/* Used from gtk_tree_selection_selected_foreach() in switch_to_selected_folder() */
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
switch_folder_foreach_cb (GtkTreeModel *model,
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
struct switch_folder_closure *closure;
closure = data;
file chooser: Don't open folders unexpectedly Folders that show up among search results were unexpectedly returned even for GTK_FILE_CHOOSER_ACTION_OPEN. Change things around so that we switch to the folder instead, which is the behavior we had in GTK+ 2.x. https://bugzilla.gnome.org/show_bug.cgi?id=744204
2015-02-14 01:43:06 +00:00
closure->file = _gtk_file_system_model_get_file (GTK_FILE_SYSTEM_MODEL (model), iter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
closure->num_selected++;
}
/* Changes to the selected folder in the list view */
static void
switch_to_selected_folder (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
struct switch_folder_closure closure;
/* We do this with foreach() rather than get_selected() as we may be in
* multiple selection mode
*/
closure.impl = impl;
closure.file = NULL;
closure.num_selected = 0;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_selected_foreach (selection, switch_folder_foreach_cb, &closure);
g_assert (closure.file && closure.num_selected == 1);
change_folder_and_display_error (impl, closure.file, FALSE);
}
/* Gets the GFileInfo for the selected row in the file list; assumes single
* selection mode.
*/
static GFileInfo *
get_selected_file_info_from_file_list (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean *had_selection)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
GtkTreeIter iter;
GFileInfo *info;
g_assert (!priv->select_multiple);
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
if (!gtk_tree_selection_get_selected (selection, NULL, &iter))
{
*had_selection = FALSE;
return NULL;
}
*had_selection = TRUE;
info = _gtk_file_system_model_get_info (priv->browse_files_model, &iter);
return info;
}
/* Gets the display name of the selected file in the file list; assumes single
* selection mode and that something is selected.
*/
static const gchar *
get_display_name_from_file_list (GtkFileChooserWidget *impl)
{
GFileInfo *info;
gboolean had_selection;
info = get_selected_file_info_from_file_list (impl, &had_selection);
g_assert (had_selection);
g_assert (info != NULL);
return g_file_info_get_display_name (info);
}
static void
add_custom_button_to_dialog (GtkDialog *dialog,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *mnemonic_label,
gint response_id)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkWidget *button;
button = gtk_button_new_with_mnemonic (mnemonic_label);
gtk_widget_set_can_default (button, TRUE);
gtk_widget_show (button);
gtk_dialog_add_action_widget (GTK_DIALOG (dialog), button, response_id);
}
/* Presents an overwrite confirmation dialog; returns whether we should accept
* the filename.
*/
static gboolean
confirm_dialog_should_accept_filename (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *file_part,
const gchar *folder_display_name)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkWindow *toplevel;
GtkWidget *dialog;
int response;
toplevel = get_toplevel (GTK_WIDGET (impl));
dialog = gtk_message_dialog_new (toplevel,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_QUESTION,
GTK_BUTTONS_NONE,
_("A file named “%s” already exists. Do you want to replace it?"),
file_part);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_("The file already exists in “%s”. Replacing it will "
"overwrite its contents."),
folder_display_name);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_dialog_add_button (GTK_DIALOG (dialog), _("_Cancel"), GTK_RESPONSE_CANCEL);
add_custom_button_to_dialog (GTK_DIALOG (dialog), _("_Replace"), GTK_RESPONSE_ACCEPT);
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
gtk_dialog_set_alternative_button_order (GTK_DIALOG (dialog),
GTK_RESPONSE_ACCEPT,
GTK_RESPONSE_CANCEL,
-1);
G_GNUC_END_IGNORE_DEPRECATIONS
gtk_dialog_set_default_response (GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);
if (gtk_window_has_group (toplevel))
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_window_group_add_window (gtk_window_get_group (toplevel), GTK_WINDOW (dialog));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
response = gtk_dialog_run (GTK_DIALOG (dialog));
gtk_widget_destroy (dialog);
return (response == GTK_RESPONSE_ACCEPT);
}
struct GetDisplayNameData
{
GtkFileChooserWidget *impl;
gchar *file_part;
};
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Every time we request a response explicitly, we need to save the selection to
* the recently-used list, as requesting a response means, “the dialog is confirmed”.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
static void
request_response_and_add_to_recent_list (GtkFileChooserWidget *impl)
{
g_signal_emit_by_name (impl, "response-requested");
add_selection_to_recent_list (impl);
}
static void
confirmation_confirm_get_info_cb (GCancellable *cancellable,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFileInfo *info,
const GError *error,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gboolean cancelled = g_cancellable_is_cancelled (cancellable);
gboolean should_respond = FALSE;
struct GetDisplayNameData *data = user_data;
GtkFileChooserWidgetPrivate *priv = data->impl->priv;
if (cancellable != priv->should_respond_get_info_cancellable)
goto out;
priv->should_respond_get_info_cancellable = NULL;
if (cancelled)
goto out;
if (error)
/* Huh? Did the folder disappear? Let the caller deal with it */
should_respond = TRUE;
else
should_respond = confirm_dialog_should_accept_filename (data->impl, data->file_part, g_file_info_get_display_name (info));
set_busy_cursor (data->impl, FALSE);
if (should_respond)
request_response_and_add_to_recent_list (data->impl);
out:
g_object_unref (data->impl);
g_free (data->file_part);
g_free (data);
g_object_unref (cancellable);
}
/* Does overwrite confirmation if appropriate, and returns whether the dialog
* should respond. Can get the file part from the file list or the save entry.
*/
static gboolean
should_respond_after_confirm_overwrite (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *file_part,
GFile *parent_file)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkFileChooserConfirmation conf;
if (!priv->do_overwrite_confirmation)
return TRUE;
conf = GTK_FILE_CHOOSER_CONFIRMATION_CONFIRM;
g_signal_emit_by_name (impl, "confirm-overwrite", &conf);
switch (conf)
{
case GTK_FILE_CHOOSER_CONFIRMATION_CONFIRM:
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
struct GetDisplayNameData *data;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_assert (file_part != NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
data = g_new0 (struct GetDisplayNameData, 1);
data->impl = g_object_ref (impl);
data->file_part = g_strdup (file_part);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (priv->should_respond_get_info_cancellable)
g_cancellable_cancel (priv->should_respond_get_info_cancellable);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->should_respond_get_info_cancellable =
_gtk_file_system_get_info (priv->file_system, parent_file,
"standard::display-name",
confirmation_confirm_get_info_cb,
data);
set_busy_cursor (data->impl, TRUE);
return FALSE;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
case GTK_FILE_CHOOSER_CONFIRMATION_ACCEPT_FILENAME:
return TRUE;
case GTK_FILE_CHOOSER_CONFIRMATION_SELECT_AGAIN:
return FALSE;
default:
g_assert_not_reached ();
return FALSE;
}
}
static void
name_entry_get_parent_info_cb (GCancellable *cancellable,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFileInfo *info,
const GError *error,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
gboolean parent_is_folder = FALSE;
gboolean parent_is_accessible = FALSE;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gboolean cancelled = g_cancellable_is_cancelled (cancellable);
struct FileExistsData *data = user_data;
GtkFileChooserWidget *impl = data->impl;
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (cancellable != priv->should_respond_get_info_cancellable)
goto out;
priv->should_respond_get_info_cancellable = NULL;
set_busy_cursor (impl, FALSE);
if (cancelled)
goto out;
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
if (info)
{
parent_is_folder = _gtk_file_info_consider_as_directory (info);
parent_is_accessible = g_file_info_has_attribute (info, "access::can-execute") &&
g_file_info_get_attribute_boolean (info, "access::can-execute");
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
if (parent_is_folder && parent_is_accessible)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
request_response_and_add_to_recent_list (impl); /* even if the file doesn't exist, apps can make good use of that (e.g. Emacs) */
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
{
if (data->file_exists_and_is_not_folder)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
gboolean retval;
char *file_part;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Dup the string because the string may be modified
* depending on what clients do in the confirm-overwrite
* signal and this corrupts the pointer
*/
file_part = g_strdup (_gtk_file_chooser_entry_get_file_part (GTK_FILE_CHOOSER_ENTRY (priv->location_entry)));
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
retval = should_respond_after_confirm_overwrite (impl, file_part, data->parent_file);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_free (file_part);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (retval)
request_response_and_add_to_recent_list (impl);
}
else
request_response_and_add_to_recent_list (impl);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
|| priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GError *mkdir_error = NULL;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* In both cases (SELECT_FOLDER and CREATE_FOLDER), if you type
* "/blah/nonexistent" you *will* want a folder created.
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
set_busy_cursor (impl, TRUE);
g_file_make_directory (data->file, NULL, &mkdir_error);
set_busy_cursor (impl, FALSE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (!mkdir_error)
request_response_and_add_to_recent_list (impl);
else
error_creating_folder_dialog (impl, data->file, mkdir_error);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_assert_not_reached ();
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
else if (parent_is_folder)
{
GError *error;
error = NULL;
g_set_error_literal (&error, G_IO_ERROR, G_IO_ERROR_PERMISSION_DENIED,
_("You do not have access to the specified folder."));
error_changing_folder_dialog (impl, data->parent_file, error);
}
else if (info)
{
/* The parent exists, but it's not a folder!
* Someone probably typed existing_file.txt/subfile.txt
*/
error_with_file_under_nonfolder (impl, data->parent_file);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
{
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
GError *error_copy;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
/* The parent folder is not readable for some reason */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
error_copy = g_error_copy (error);
error_changing_folder_dialog (impl, data->parent_file, error_copy);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
out:
g_object_unref (data->impl);
g_object_unref (data->file);
g_object_unref (data->parent_file);
g_free (data);
g_object_unref (cancellable);
}
static void
file_exists_get_info_cb (GCancellable *cancellable,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GFileInfo *info,
const GError *error,
gpointer user_data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gboolean data_ownership_taken = FALSE;
gboolean cancelled = g_cancellable_is_cancelled (cancellable);
gboolean file_exists;
gboolean is_folder;
gboolean needs_parent_check = FALSE;
struct FileExistsData *data = user_data;
GtkFileChooserWidget *impl = data->impl;
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (cancellable != priv->file_exists_get_info_cancellable)
goto out;
priv->file_exists_get_info_cancellable = NULL;
set_busy_cursor (impl, FALSE);
if (cancelled)
goto out;
file_exists = (info != NULL);
is_folder = (file_exists && _gtk_file_info_consider_as_directory (info));
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN)
{
if (is_folder)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
change_folder_and_display_error (impl, data->file, TRUE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
if (file_exists)
request_response_and_add_to_recent_list (impl); /* user typed an existing filename; we are done */
else
needs_parent_check = TRUE; /* file doesn't exist; see if its parent exists */
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
if (file_exists && !is_folder)
{
/* Oops, the user typed the name of an existing path which is not
* a folder
*/
error_creating_folder_over_existing_file_dialog (impl, data->file,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_error_copy (error));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
{
needs_parent_check = TRUE;
}
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
{
if (!file_exists)
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
needs_parent_check = TRUE;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
if (is_folder)
{
/* User typed a folder; we are done */
request_response_and_add_to_recent_list (impl);
}
else
error_selecting_folder_over_existing_file_dialog (impl);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
{
if (is_folder)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
change_folder_and_display_error (impl, data->file, TRUE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
if (!file_exists && g_error_matches (error, G_IO_ERROR, G_IO_ERROR_FILENAME_TOO_LONG))
error_filename_to_long_dialog (data->impl);
else
needs_parent_check = TRUE;
}
else
{
g_assert_not_reached();
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (needs_parent_check)
{
/* check that everything up to the last path component exists (i.e. the parent) */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
data->file_exists_and_is_not_folder = file_exists && !is_folder;
data_ownership_taken = TRUE;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (priv->should_respond_get_info_cancellable)
g_cancellable_cancel (priv->should_respond_get_info_cancellable);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->should_respond_get_info_cancellable =
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_gtk_file_system_get_info (priv->file_system,
data->parent_file,
filechooser: check if we can access the parent folder If we manually enter an unaccessible path in the entry, e.g "/root/foo.txt", we should receive an error saying that the folder is not accessible instead of showing the replace confirmation dialog. https://bugzilla.gnome.org/show_bug.cgi?id=753969
2015-08-22 16:20:17 +00:00
"standard::type,access::can-execute",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
name_entry_get_parent_info_cb,
data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
set_busy_cursor (impl, TRUE);
}
out:
if (!data_ownership_taken)
{
g_object_unref (impl);
g_object_unref (data->file);
g_object_unref (data->parent_file);
g_free (data);
}
g_object_unref (cancellable);
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
paste_text_received (GtkClipboard *clipboard,
const gchar *text,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GFile *file;
if (!text)
return;
file = g_file_new_for_uri (text);
if (!gtk_file_chooser_widget_select_file (GTK_FILE_CHOOSER (impl), file, NULL))
location_popup_handler (impl, text);
g_object_unref (file);
}
/* Handler for the "location-popup-on-paste" keybinding signal */
static void
location_popup_on_paste_handler (GtkFileChooserWidget *impl)
{
GtkClipboard *clipboard = gtk_widget_get_clipboard (GTK_WIDGET (impl),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_SELECTION_CLIPBOARD);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_clipboard_request_text (clipboard,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
(GtkClipboardTextReceivedFunc) paste_text_received,
impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Implementation for GtkFileChooserEmbed::should_respond() */
static void
add_selection_to_recent_list (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GSList *files;
GSList *l;
files = gtk_file_chooser_widget_get_files (GTK_FILE_CHOOSER (impl));
for (l = files; l; l = l->next)
{
GFile *file = l->data;
char *uri;
uri = g_file_get_uri (file);
if (uri)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
gtk_recent_manager_add_item (priv->recent_manager, uri);
g_free (uri);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
Code cleanup Use g_slist_free_full more consistently. This commit just converts the obvious cases where g_slist_forall is directly followed by g_slist_free.
2015-07-31 21:57:04 +00:00
g_slist_free_full (files, g_object_unref);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static gboolean
gtk_file_chooser_widget_should_respond (GtkFileChooserEmbed *chooser_embed)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser_embed);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkWidget *toplevel;
GtkWidget *current_focus;
gboolean retval;
toplevel = gtk_widget_get_toplevel (GTK_WIDGET (impl));
g_assert (GTK_IS_WINDOW (toplevel));
retval = FALSE;
current_focus = gtk_window_get_focus (GTK_WINDOW (toplevel));
if (current_focus == priv->browse_files_tree_view)
{
/* The following array encodes what we do based on the priv->action and the
* number of files selected.
*/
typedef enum {
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
NOOP, /* Do nothing (don't respond) */
RESPOND, /* Respond immediately */
RESPOND_OR_SWITCH, /* Respond immediately if the selected item is a file; switch to it if it is a folder */
ALL_FILES, /* Respond only if everything selected is a file */
ALL_FOLDERS, /* Respond only if everything selected is a folder */
SAVE_ENTRY, /* Go to the code for handling the save entry */
NOT_REACHED /* Sanity check */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
} ActionToTake;
static const ActionToTake what_to_do[4][3] = {
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* 0 selected 1 selected many selected */
/* ACTION_OPEN */ { NOOP, RESPOND_OR_SWITCH, ALL_FILES },
/* ACTION_SAVE */ { SAVE_ENTRY, RESPOND_OR_SWITCH, NOT_REACHED },
/* ACTION_SELECT_FOLDER */ { RESPOND, ALL_FOLDERS, ALL_FOLDERS },
/* ACTION_CREATE_FOLDER */ { SAVE_ENTRY, ALL_FOLDERS, NOT_REACHED }
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
};
int num_selected;
gboolean all_files, all_folders;
int k;
ActionToTake action;
file_list:
g_assert (priv->action >= GTK_FILE_CHOOSER_ACTION_OPEN && priv->action <= GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER);
if (priv->operation_mode == OPERATION_MODE_RECENT)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
goto save_entry;
else
{
retval = recent_should_respond (impl);
goto out;
}
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
selection_check (impl, &num_selected, &all_files, &all_folders);
if (num_selected > 2)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
k = 2;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
k = num_selected;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
action = what_to_do [priv->action] [k];
switch (action)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
case NOOP:
return FALSE;
case RESPOND:
retval = TRUE;
goto out;
case RESPOND_OR_SWITCH:
g_assert (num_selected == 1);
if (all_folders)
{
switch_to_selected_folder (impl);
return FALSE;
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
{
retval = should_respond_after_confirm_overwrite (impl,
get_display_name_from_file_list (impl),
priv->current_folder);
goto out;
}
else
{
retval = TRUE;
goto out;
}
case ALL_FILES:
retval = all_files;
goto out;
case ALL_FOLDERS:
retval = all_folders;
goto out;
case SAVE_ENTRY:
goto save_entry;
default:
g_assert_not_reached ();
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if ((priv->location_entry != NULL) && (current_focus == priv->location_entry))
{
GFile *file;
gboolean is_well_formed, is_empty, is_file_part_empty;
gboolean is_folder;
GtkFileChooserEntry *entry;
save_entry:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_assert (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER ||
((priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER) &&
priv->location_mode == LOCATION_MODE_FILENAME_ENTRY));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
entry = GTK_FILE_CHOOSER_ENTRY (priv->location_entry);
check_save_entry (impl, &file, &is_well_formed, &is_empty, &is_file_part_empty, &is_folder);
if (!is_well_formed)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
if (!is_empty &&
priv->action == GTK_FILE_CHOOSER_ACTION_SAVE &&
priv->operation_mode == OPERATION_MODE_RECENT)
{
/* FIXME: ERROR_NO_FOLDER */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#if 0
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* We'll #ifdef this out, as the fucking treeview selects its first row,
* thus changing our assumption that no selection is present - setting
* a selection causes the error message from path_bar_set_mode() to go away,
* but we want the user to see that message!
*/
gtk_widget_grab_focus (priv->browse_files_tree_view);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
#endif
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
}
/* FIXME: else show an "invalid filename" error as the pathbar mode? */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return FALSE;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (is_empty)
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
/* FIXME: ERROR_NO_FILENAME */
gtk_widget_grab_focus (priv->location_entry);
return FALSE;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
goto file_list;
}
g_assert (file != NULL);
if (is_folder)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
{
change_folder_and_display_error (impl, file, TRUE);
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
/* The folder already exists, so we do not need to create it.
* Just respond to terminate the dialog.
*/
retval = TRUE;
}
else
{
g_assert_not_reached ();
}
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
struct FileExistsData *data;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* We need to check whether file exists and whether it is a folder -
* the GtkFileChooserEntry *does* report is_folder==FALSE as a false
* negative (it doesn't know yet if your last path component is a
* folder).
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
data = g_new0 (struct FileExistsData, 1);
data->impl = g_object_ref (impl);
data->file = g_object_ref (file);
data->parent_file = _gtk_file_chooser_entry_get_current_folder (entry);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (priv->file_exists_get_info_cancellable)
g_cancellable_cancel (priv->file_exists_get_info_cancellable);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->file_exists_get_info_cancellable =
_gtk_file_system_get_info (priv->file_system, file,
"standard::type",
file_exists_get_info_cb,
data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
set_busy_cursor (impl, TRUE);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_object_unref (file);
}
else if (priv->toplevel_last_focus_widget == priv->browse_files_tree_view)
{
/* The focus is on a dialog's action area button, *and* the widget that
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* was focused immediately before it is the file list.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
goto file_list;
}
else if (priv->operation_mode == OPERATION_MODE_SEARCH && priv->toplevel_last_focus_widget == priv->search_entry)
{
file chooser: Simplify search entry callback
2015-01-28 21:02:03 +00:00
search_entry_activate_cb (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return FALSE;
}
else if (priv->location_entry && priv->toplevel_last_focus_widget == priv->location_entry)
{
/* The focus is on a dialog's action area button, *and* the widget that
* was focused immediately before it is the location entry.
*/
goto save_entry;
}
else
/* The focus is on a dialog's action area button or something else */
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
goto save_entry;
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
goto file_list;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
out:
if (retval)
add_selection_to_recent_list (impl);
return retval;
}
/* Implementation for GtkFileChooserEmbed::initial_focus() */
static void
gtk_file_chooser_widget_initial_focus (GtkFileChooserEmbed *chooser_embed)
{
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (chooser_embed);
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkWidget *widget;
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
{
if (priv->location_mode == LOCATION_MODE_PATH_BAR
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
|| priv->operation_mode == OPERATION_MODE_RECENT)
widget = priv->browse_files_tree_view;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
widget = priv->location_entry;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
widget = priv->location_entry;
else
{
g_assert_not_reached ();
widget = NULL;
}
g_assert (widget != NULL);
gtk_widget_grab_focus (widget);
}
static void
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
selected_foreach_get_file_cb (GtkTreeModel *model,
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GSList **list;
GFile *file;
list = data;
gtk_tree_model_get (model, iter, MODEL_COL_FILE, &file, -1);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* The file already has a new ref courtesy of gtk_tree_model_get();
* this will be unreffed by the caller
*/
*list = g_slist_prepend (*list, file);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static GSList *
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
get_selected_files (GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GSList *result;
GtkTreeSelection *selection;
result = NULL;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
file chooser: Fix multi-selection Even if we only ever hit the code with a singleton selection, calling gtk_tree_selection_get_selected is not ok if the tree selection mode allows multi-selection. Replace all calls to gtk_tree_selection_get_selected in the file chooser code with callback loops iterating over the selection. This problem was introduced with the recently added rename and delete menuitems.
2015-07-09 01:31:40 +00:00
gtk_tree_selection_selected_foreach (selection, selected_foreach_get_file_cb, &result);
result = g_slist_reverse (result);
return result;
}
static void
selected_foreach_get_info_cb (GtkTreeModel *model,
GtkTreePath *path,
GtkTreeIter *iter,
gpointer data)
{
GSList **list;
GFileInfo *info;
list = data;
info = _gtk_file_system_model_get_info (GTK_FILE_SYSTEM_MODEL (model), iter);
*list = g_slist_prepend (*list, g_object_ref (info));
}
static GSList *
get_selected_infos (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GSList *result;
GtkTreeSelection *selection;
result = NULL;
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
gtk_tree_selection_selected_foreach (selection, selected_foreach_get_info_cb, &result);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
result = g_slist_reverse (result);
return result;
}
file chooser: Use batched insertion for search results This helps avoiding excess work when procesing many search results, as typically happens with short search strings and recursive search. https://bugzilla.gnome.org/show_bug.cgi?id=751169
2015-06-18 16:20:21 +00:00
/* Callback used from GtkSearchEngine when we get new hits */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
file chooser: Use batched insertion for search results This helps avoiding excess work when procesing many search results, as typically happens with short search strings and recursive search. https://bugzilla.gnome.org/show_bug.cgi?id=751169
2015-06-18 16:20:21 +00:00
search_engine_hits_added_cb (GtkSearchEngine *engine,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GList *hits,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
Use infos from search engine instead of getting them again When the search engine provides hits with GFileInfo, use that to add the hits to the model directly, without going through another round of async get_info calls. To do this, we add a batched variant of the _gtk_file_system_model_update_file call that takes lists of GFiles and GFileInfos. Again, we can avoid repeated resorting that happens when the files are updated individually.
2015-06-18 19:18:30 +00:00
GList *l, *files, *files_with_info, *infos;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GFile *file;
file chooser: Use batched insertion for search results This helps avoiding excess work when procesing many search results, as typically happens with short search strings and recursive search. https://bugzilla.gnome.org/show_bug.cgi?id=751169
2015-06-18 16:20:21 +00:00
files = NULL;
Use infos from search engine instead of getting them again When the search engine provides hits with GFileInfo, use that to add the hits to the model directly, without going through another round of async get_info calls. To do this, we add a batched variant of the _gtk_file_system_model_update_file call that takes lists of GFiles and GFileInfos. Again, we can avoid repeated resorting that happens when the files are updated individually.
2015-06-18 19:18:30 +00:00
files_with_info = NULL;
infos = NULL;
file chooser: Use batched insertion for search results This helps avoiding excess work when procesing many search results, as typically happens with short search strings and recursive search. https://bugzilla.gnome.org/show_bug.cgi?id=751169
2015-06-18 16:20:21 +00:00
for (l = hits; l; l = l->next)
{
search engine: Pass file infos along for hits
2015-06-18 18:31:02 +00:00
GtkSearchHit *hit = (GtkSearchHit *)l->data;
Avoid more GFile<>uri roundtrips Make GtkSearchHit carry a GFile instead of an uri. Most of the search engines already have the object around, and converting to an uri and back is unnecessary extra work.
2015-07-24 04:40:59 +00:00
file = g_object_ref (hit->file);
Use infos from search engine instead of getting them again When the search engine provides hits with GFileInfo, use that to add the hits to the model directly, without going through another round of async get_info calls. To do this, we add a batched variant of the _gtk_file_system_model_update_file call that takes lists of GFiles and GFileInfos. Again, we can avoid repeated resorting that happens when the files are updated individually.
2015-06-18 19:18:30 +00:00
if (hit->info)
{
files_with_info = g_list_prepend (files_with_info, file);
infos = g_list_prepend (infos, g_object_ref (hit->info));
}
else
files = g_list_prepend (files, file);
file chooser: Use batched insertion for search results This helps avoiding excess work when procesing many search results, as typically happens with short search strings and recursive search. https://bugzilla.gnome.org/show_bug.cgi?id=751169
2015-06-18 16:20:21 +00:00
}
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
Use infos from search engine instead of getting them again When the search engine provides hits with GFileInfo, use that to add the hits to the model directly, without going through another round of async get_info calls. To do this, we add a batched variant of the _gtk_file_system_model_update_file call that takes lists of GFiles and GFileInfos. Again, we can avoid repeated resorting that happens when the files are updated individually.
2015-06-18 19:18:30 +00:00
_gtk_file_system_model_update_files (impl->priv->search_model,
files_with_info, infos);
file chooser: Use batched insertion for search results This helps avoiding excess work when procesing many search results, as typically happens with short search strings and recursive search. https://bugzilla.gnome.org/show_bug.cgi?id=751169
2015-06-18 16:20:21 +00:00
_gtk_file_system_model_add_and_query_files (impl->priv->search_model,
Use infos from search engine instead of getting them again When the search engine provides hits with GFileInfo, use that to add the hits to the model directly, without going through another round of async get_info calls. To do this, we add a batched variant of the _gtk_file_system_model_update_file call that takes lists of GFiles and GFileInfos. Again, we can avoid repeated resorting that happens when the files are updated individually.
2015-06-18 19:18:30 +00:00
files, MODEL_ATTRIBUTES);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use batched insertion for search results This helps avoiding excess work when procesing many search results, as typically happens with short search strings and recursive search. https://bugzilla.gnome.org/show_bug.cgi?id=751169
2015-06-18 16:20:21 +00:00
g_list_free_full (files, g_object_unref);
Use infos from search engine instead of getting them again When the search engine provides hits with GFileInfo, use that to add the hits to the model directly, without going through another round of async get_info calls. To do this, we add a batched variant of the _gtk_file_system_model_update_file call that takes lists of GFiles and GFileInfos. Again, we can avoid repeated resorting that happens when the files are updated individually.
2015-06-18 19:18:30 +00:00
g_list_free_full (files_with_info, g_object_unref);
g_list_free_full (infos, g_object_unref);
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (impl->priv->browse_files_stack), "list");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Callback used from GtkSearchEngine when the query is done running */
static void
search_engine_finished_cb (GtkSearchEngine *engine,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (data);
GtkFileChooserWidgetPrivate *priv = impl->priv;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
set_busy_cursor (impl, FALSE);
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
gtk_widget_hide (priv->search_spinner);
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
if (priv->show_progress_timeout)
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
{
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
g_source_remove (priv->show_progress_timeout);
priv->show_progress_timeout = 0;
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
}
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
if (gtk_tree_model_iter_n_children (GTK_TREE_MODEL (priv->search_model), NULL) == 0)
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_files_stack), "empty");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Displays a generic error when we cannot create a GtkSearchEngine.
* It would be better if _gtk_search_engine_new() gave us a GError
docs: use apostrophes in *n't
2014-02-07 18:32:47 +00:00
* with a better message, but it doesn’t do that right now.
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
*/
static void
search_error_could_not_create_client (GtkFileChooserWidget *impl)
{
error_message (impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_("Could not start the search process"),
_("The program was not able to create a connection to the indexer "
"daemon. Please make sure it is running."));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
search_engine_error_cb (GtkSearchEngine *engine,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *message,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooserWidget *impl = GTK_FILE_CHOOSER_WIDGET (data);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
search_stop_searching (impl, TRUE);
error_message (impl, _("Could not send the search request"), message);
}
/* Frees the data in the search_model */
static void
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
search_clear_model (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean remove)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (!priv->search_model)
return;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (remove &&
gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view)) == GTK_TREE_MODEL (priv->search_model))
gtk_tree_view_set_model (GTK_TREE_VIEW (priv->browse_files_tree_view), NULL);
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
g_clear_object (&priv->search_model);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Stops any ongoing searches; does not touch the search_model */
static void
search_stop_searching (GtkFileChooserWidget *impl,
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
gboolean remove_query)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Clear search entry when it goes away Keeping the entry contents conflicts with type-to-search.
2015-07-07 00:50:08 +00:00
if (remove_query && priv->search_entry)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
file chooser: Clear search entry when it goes away Keeping the entry contents conflicts with type-to-search.
2015-07-07 00:50:08 +00:00
gtk_entry_set_text (GTK_ENTRY (priv->search_entry), "");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->search_engine)
{
_gtk_search_engine_stop (priv->search_engine);
filechooser: Disconnect signal handlers from search engine before destroying The search engine might stay alive longer due to extra temporary refs, so the signal handlers should be removed for the filechooser to ignore these properly. https://bugzilla.gnome.org/show_bug.cgi?id=745479
2015-03-03 12:34:03 +00:00
g_signal_handlers_disconnect_by_data (priv->search_engine, impl);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_clear_object (&priv->search_engine);
file chooser: Make Escape work in search entry Arrange things so that hitting Escape during a running search stops the search, but leaves the search results around, and hitting Escape again leaves the search mode.
2015-06-27 05:23:16 +00:00
set_busy_cursor (impl, FALSE);
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
gtk_widget_hide (priv->search_spinner);
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
}
if (priv->show_progress_timeout)
{
g_source_remove (priv->show_progress_timeout);
priv->show_progress_timeout = 0;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
}
/* Creates the search_model and puts it in the tree view */
static void
search_setup_model (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_assert (priv->search_model == NULL);
priv->search_model = _gtk_file_system_model_new (file_system_model_set,
impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
MODEL_COLUMN_TYPES);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Sort search results better Set a default sort function that sorts results from the current folder first.
2015-06-27 06:22:23 +00:00
gtk_tree_sortable_set_default_sort_func (GTK_TREE_SORTABLE (priv->search_model),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
search_sort_func,
impl, NULL);
file chooser: Sort search results better Set a default sort function that sorts results from the current folder first.
2015-06-27 06:22:23 +00:00
gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE (priv->search_model),
GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID,
GTK_SORT_ASCENDING);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_view_set_model (GTK_TREE_VIEW (priv->browse_files_tree_view),
GTK_TREE_MODEL (priv->search_model));
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
gtk_tree_view_column_set_sort_column_id (priv->list_name_column, -1);
gtk_tree_view_column_set_sort_column_id (priv->list_time_column, -1);
gtk_tree_view_column_set_sort_column_id (priv->list_size_column, -1);
gtk_tree_view_column_set_sort_column_id (priv->list_location_column, -1);
file chooser: Improve column sizing Allow the name and location columns to be resized, but arrange for their sizing to be reset when the column layout changes (either by the location column appearing/disappearing, or by the time column changing between mtime and atime. This gives a decent compromise between good automatic sizing and user control.
2015-07-03 16:22:39 +00:00
update_columns (impl, TRUE, _("Modified"));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
static gboolean
show_spinner (gpointer data)
{
GtkFileChooserWidget *impl = data;
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
gtk_widget_show (priv->search_spinner);
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
priv->show_progress_timeout = 0;
return G_SOURCE_REMOVE;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Creates a new query with the specified text and launches it */
static void
search_start_query (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *query_text)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Make search in recent work All that was needed here was to set the query location.
2015-06-27 04:21:53 +00:00
GFile *file;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
if (gtk_stack_get_visible_child (GTK_STACK (priv->browse_files_stack)) == priv->places_view)
return;
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
stop_loading_and_clear_list_model (impl, TRUE);
recent_stop_loading (impl);
recent_clear_model (impl, TRUE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
search_stop_searching (impl, FALSE);
search_clear_model (impl, TRUE);
search_setup_model (impl);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
set_busy_cursor (impl, TRUE);
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
priv->show_progress_timeout = g_timeout_add (1500, show_spinner, impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
gtk_stack_set_visible_child_name (GTK_STACK (priv->browse_files_stack), "list");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->search_engine == NULL)
priv->search_engine = _gtk_search_engine_new ();
if (!priv->search_engine)
{
set_busy_cursor (impl, FALSE);
file chooser: Refine search progress display Move the spinner to the search bar, so we can keep it around until the search is over.
2015-07-15 04:03:09 +00:00
gtk_widget_hide (priv->search_spinner);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
search_error_could_not_create_client (impl); /* lame; we don't get an error code or anything */
return;
}
if (!priv->search_query)
{
GtkQuery: Cleanups Strip leading underscores from GtkQuery api, and clean up the sources a bit.
2015-05-16 04:45:25 +00:00
priv->search_query = gtk_query_new ();
gtk_query_set_text (priv->search_query, query_text);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Allow to limit search Add a button to allow restricting search to the current folder (and subdirectories). This makes the search more useful, and makes the file chooser more similar to nautilus.
2015-02-14 05:48:26 +00:00
file chooser: Make search in recent work All that was needed here was to set the query location.
2015-06-27 04:21:53 +00:00
file = gtk_places_sidebar_get_location (GTK_PLACES_SIDEBAR (priv->places_sidebar));
if (file)
file chooser: Allow to limit search Add a button to allow restricting search to the current folder (and subdirectories). This makes the search more useful, and makes the file chooser more similar to nautilus.
2015-02-14 05:48:26 +00:00
{
Store locations as GFile It is a bit pointless to have the file chooser get a uri from an existing GFile to put in the query, only to have some of the search engines reconstruct a GFile from it.
2015-07-24 19:29:51 +00:00
gtk_query_set_location (priv->search_query, file);
file chooser: Make search in recent work All that was needed here was to set the query location.
2015-06-27 04:21:53 +00:00
g_object_unref (file);
file chooser: Allow to limit search Add a button to allow restricting search to the current folder (and subdirectories). This makes the search more useful, and makes the file chooser more similar to nautilus.
2015-02-14 05:48:26 +00:00
}
Always pass a location into the query Failure to do so was causing search to start from the home dir when the current folder is not represented on the sidebar.
2015-07-24 19:37:03 +00:00
else
gtk_query_set_location (priv->search_query, priv->current_folder);
file chooser: Allow to limit search Add a button to allow restricting search to the current folder (and subdirectories). This makes the search more useful, and makes the file chooser more similar to nautilus.
2015-02-14 05:48:26 +00:00
file chooser: Add and use a model search engine This search engine reuses the GFileInfo that is already loaded for the file list, to ensure that hits from the current directory always appear promptly.
2015-07-01 19:51:20 +00:00
_gtk_search_engine_set_model (priv->search_engine, priv->model_for_search);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_search_engine_set_query (priv->search_engine, priv->search_query);
g_signal_connect (priv->search_engine, "hits-added",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_CALLBACK (search_engine_hits_added_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_signal_connect (priv->search_engine, "finished",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_CALLBACK (search_engine_finished_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_signal_connect (priv->search_engine, "error",
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
G_CALLBACK (search_engine_error_cb), impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_search_engine_start (priv->search_engine);
file chooser: Note when searching remote locations Inform the user that we won't search recursively when searching in remote locations.
2015-07-24 20:26:32 +00:00
if (_gtk_file_consider_as_remote (gtk_query_get_location (priv->search_query)))
gtk_widget_show (priv->remote_warning_bar);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Callback used when the user presses Enter while typing on the search
* entry; starts the query
*/
static void
file chooser: Simplify search entry callback
2015-01-28 21:02:03 +00:00
search_entry_activate_cb (GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
const char *text;
filechooser: Only do search_start_query() while we are in search mode This signal can be emitted by GtkSearchEntry after search has been cancelled, and other operation mode is set. It doesn't make sense to populate the search model in that state anymore, so just avoid doing it. https://bugzilla.gnome.org/show_bug.cgi?id=745479
2015-03-03 16:43:14 +00:00
if (priv->operation_mode != OPERATION_MODE_SEARCH)
return;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
text = gtk_entry_get_text (GTK_ENTRY (priv->search_entry));
/* reset any existing query object */
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_set_object (&priv->search_query, NULL);
file chooser: search improvements Make it so that typing switches to search unless we have a better use for the key events, and stop search if the entry is emptied.
2015-01-24 18:32:31 +00:00
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
gtk_places_view_set_search_query (GTK_PLACES_VIEW (priv->places_view), text);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (text[0] != '\0')
search_start_query (impl, text);
file chooser: Stop search when entry is cleared
2015-07-15 04:12:33 +00:00
else
search_stop_searching (impl, FALSE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Make Escape go out of search mode This works in most other places where we have search, and is the expected behavior.
2015-01-28 21:06:02 +00:00
static void
search_entry_stop_cb (GtkFileChooserWidget *impl)
{
file chooser: Make Escape work in search entry Arrange things so that hitting Escape during a running search stops the search, but leaves the search results around, and hitting Escape again leaves the search mode.
2015-06-27 05:23:16 +00:00
if (impl->priv->search_engine)
search_stop_searching (impl, FALSE);
else
g_object_set (impl, "search-mode", FALSE, NULL);
file chooser: Make Escape go out of search mode This works in most other places where we have search, and is the expected behavior.
2015-01-28 21:06:02 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Hides the path bar and creates the search entry */
static void
search_setup_widgets (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
/* if there already is a query, restart it */
if (priv->search_query)
{
GtkQuery: Make API follow GTK+ conversions We generally have const getters for strings, and the two users of this API were promptly leaking the (unexpected) copy they got from gtk_query_get_location and gtk_query_get_text.
2015-07-22 00:39:29 +00:00
const gchar *query;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
query = gtk_query_get_text (priv->search_query);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (query)
{
gtk_entry_set_text (GTK_ENTRY (priv->search_entry), query);
search_start_query (impl, query);
}
else
{
g_object_unref (priv->search_query);
priv->search_query = NULL;
}
}
}
/*
* Recent files support
*/
/* Frees the data in the recent_model */
static void
recent_clear_model (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gboolean remove)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (!priv->recent_model)
return;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
if (remove)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_view_set_model (GTK_TREE_VIEW (priv->browse_files_tree_view), NULL);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_set_object (&priv->recent_model, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Stops any ongoing loading of the recent files list; does
* not touch the recent_model
*/
static void
recent_stop_loading (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->load_recent_id)
{
g_source_remove (priv->load_recent_id);
priv->load_recent_id = 0;
}
}
static void
recent_setup_model (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_assert (priv->recent_model == NULL);
priv->recent_model = _gtk_file_system_model_new (file_system_model_set,
impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
MODEL_COLUMN_TYPES);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_gtk_file_system_model_set_filter (priv->recent_model, priv->current_filter);
file chooser: Don't allow resorting recent files They are inherently sorted by access time.
2015-07-02 09:10:05 +00:00
gtk_tree_sortable_set_default_sort_func (GTK_TREE_SORTABLE (priv->recent_model),
file chooser: Set fixed sort functions for recent and search
2015-07-03 05:35:49 +00:00
recent_sort_func,
file chooser: Don't allow resorting recent files They are inherently sorted by access time.
2015-07-02 09:10:05 +00:00
impl, NULL);
gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE (priv->recent_model),
GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID,
GTK_SORT_DESCENDING);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
typedef struct
{
GtkFileChooserWidget *impl;
GList *items;
} RecentLoadData;
static void
recent_idle_cleanup (gpointer data)
{
RecentLoadData *load_data = data;
GtkFileChooserWidget *impl = load_data->impl;
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_tree_view_set_model (GTK_TREE_VIEW (priv->browse_files_tree_view),
GTK_TREE_MODEL (priv->recent_model));
file chooser: Don't allow resorting recent files They are inherently sorted by access time.
2015-07-02 09:10:05 +00:00
gtk_tree_view_set_search_column (GTK_TREE_VIEW (priv->browse_files_tree_view), -1);
gtk_tree_view_column_set_sort_column_id (priv->list_name_column, -1);
gtk_tree_view_column_set_sort_column_id (priv->list_time_column, -1);
gtk_tree_view_column_set_sort_column_id (priv->list_size_column, -1);
gtk_tree_view_column_set_sort_column_id (priv->list_location_column, -1);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Improve column sizing Allow the name and location columns to be resized, but arrange for their sizing to be reset when the column layout changes (either by the location column appearing/disappearing, or by the time column changing between mtime and atime. This gives a decent compromise between good automatic sizing and user control.
2015-07-03 16:22:39 +00:00
update_columns (impl, TRUE, _("Accessed"));
file chooser: Improve the mode switching operation Avoid reloading models unnecessarily, e.g. when the user switches to search and back without starting a search. Keep the current list contents visible until a search is actually started. Also, synchronize any changes in the column layout with the corresponding model changes.
2015-07-02 23:12:55 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
set_busy_cursor (impl, FALSE);
file chooser: Don't allow resorting recent files They are inherently sorted by access time.
2015-07-02 09:10:05 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->load_recent_id = 0;
file chooser: Don't allow resorting recent files They are inherently sorted by access time.
2015-07-02 09:10:05 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_free (load_data);
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Populates the file system model with the GtkRecentInfo* items
* in the provided list; frees the items
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
populate_model_with_recent_items (GtkFileChooserWidget *impl,
GList *items)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gint limit;
GList *l;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint n;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
limit = DEFAULT_RECENT_FILES_LIMIT;
n = 0;
for (l = items; l; l = l->next)
{
GtkRecentInfo *info = l->data;
GFile *file;
file = g_file_new_for_uri (gtk_recent_info_get_uri (info));
_gtk_file_system_model_add_and_query_file (priv->recent_model,
file,
MODEL_ATTRIBUTES);
g_object_unref (file);
n++;
if (limit != -1 && n >= limit)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
break;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Add and use a model search engine This search engine reuses the GFileInfo that is already loaded for the file list, to ensure that hits from the current directory always appear promptly.
2015-07-01 19:51:20 +00:00
g_set_object (&priv->model_for_search, priv->recent_model);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
populate_model_with_folders (GtkFileChooserWidget *impl,
GList *items)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GList *folders;
GList *l;
folders = _gtk_file_chooser_extract_recent_folders (items);
for (l = folders; l; l = l->next)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
_gtk_file_system_model_add_and_query_file (priv->recent_model,
G_FILE (l->data),
MODEL_ATTRIBUTES);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_list_free_full (folders, g_object_unref);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static gboolean
recent_idle_load (gpointer data)
{
RecentLoadData *load_data = data;
GtkFileChooserWidget *impl = load_data->impl;
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (!priv->recent_manager)
return FALSE;
load_data->items = gtk_recent_manager_get_items (priv->recent_manager);
if (!load_data->items)
return FALSE;
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN)
populate_model_with_recent_items (impl, load_data->items);
else
populate_model_with_folders (impl, load_data->items);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_list_free_full (load_data->items, (GDestroyNotify) gtk_recent_info_unref);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
load_data->items = NULL;
return FALSE;
}
static void
recent_start_loading (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
RecentLoadData *load_data;
recent_stop_loading (impl);
recent_clear_model (impl, TRUE);
recent_setup_model (impl);
set_busy_cursor (impl, TRUE);
g_assert (priv->load_recent_id == 0);
load_data = g_new (RecentLoadData, 1);
load_data->impl = impl;
load_data->items = NULL;
/* begin lazy loading the recent files into the model */
filechooser: Use same priority everywhere I managed to stall recent files today while trying to save a GTK testcase in glade that contained enough spinning spinners that the CPU was saturated just redrawing things. I had to navigate the filesystem!
2015-03-25 03:27:33 +00:00
priv->load_recent_id = gdk_threads_add_idle_full (G_PRIORITY_DEFAULT,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
recent_idle_load,
load_data,
recent_idle_cleanup);
all: Name more idles and timeouts Following up from 438cd857c49242244dda2923ac447f36464b9e72, name more timeouts and idles. The original grep was missing checking for gdk_threads_add_*() functions (at least for some of the files). https://bugzilla.gnome.org/show_bug.cgi?id=726870
2014-03-22 11:44:01 +00:00
g_source_set_name_by_id (priv->load_recent_id, "[gtk+] recent_idle_load");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Called from ::should_respond(). We return whether there are selected
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
* files in the recent files list.
*/
static gboolean
recent_should_respond (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkTreeSelection *selection;
g_assert (priv->operation_mode == OPERATION_MODE_RECENT);
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
return (gtk_tree_selection_count_selected_rows (selection) != 0);
}
static void
set_current_filter (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileFilter *filter)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->current_filter != filter)
{
int filter_index;
file chooser: Consistently clear model caches This was not done for all models in all places, leading to e.g. icon theme updates not applying correctly to search results.
2015-07-02 21:31:29 +00:00
/* NULL filters are allowed to reset to non-filtered status */
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
filter_index = g_slist_index (priv->filters, filter);
if (priv->filters && filter && filter_index < 0)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->current_filter)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_object_unref (priv->current_filter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
priv->current_filter = filter;
if (priv->current_filter)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_object_ref_sink (priv->current_filter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->filters)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_combo_box_set_active (GTK_COMBO_BOX (priv->filter_combo), filter_index);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Consistently clear model caches This was not done for all models in all places, leading to e.g. icon theme updates not applying correctly to search results.
2015-07-02 21:31:29 +00:00
clear_model_cache (impl, MODEL_COL_IS_SENSITIVE);
set_model_filter (impl, priv->current_filter);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_object_notify (G_OBJECT (impl), "filter");
}
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
filter_combo_changed (GtkComboBox *combo_box,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint new_index;
GtkFileFilter *new_filter;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
new_index = gtk_combo_box_get_active (combo_box);
new_filter = g_slist_nth_data (priv->filters, new_index);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
set_current_filter (impl, new_filter);
}
static void
check_preview_change (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
GtkTreePath *path;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GFile *new_file;
char *new_display_name;
GtkTreeModel *model;
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
GtkTreeSelection *selection;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
model = gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view));
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view));
if (gtk_tree_selection_get_mode (selection) == GTK_SELECTION_SINGLE ||
gtk_tree_selection_get_mode (selection) == GTK_SELECTION_BROWSE)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkTreeIter iter;
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
if (gtk_tree_selection_get_selected (selection, NULL, &iter))
path = gtk_tree_model_get_path (model, &iter);
else
path = NULL;
}
else
{
gtk_tree_view_get_cursor (GTK_TREE_VIEW (priv->browse_files_tree_view), &path, NULL);
if (path && !gtk_tree_selection_path_is_selected (selection, path))
{
gtk_tree_path_free (path);
path = NULL;
}
}
if (path)
{
GtkTreeIter iter;
gtk_tree_model_get_iter (model, &iter, path);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_model_get (model, &iter,
MODEL_COL_FILE, &new_file,
MODEL_COL_NAME, &new_display_name,
-1);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
gtk_tree_path_free (path);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
{
new_file = NULL;
new_display_name = NULL;
}
if (new_file != priv->preview_file &&
!(new_file && priv->preview_file &&
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_file_equal (new_file, priv->preview_file)))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
if (priv->preview_file)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
g_object_unref (priv->preview_file);
g_free (priv->preview_display_name);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (new_file)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
priv->preview_file = new_file;
priv->preview_display_name = new_display_name;
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
else
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
{
priv->preview_file = NULL;
priv->preview_display_name = NULL;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_free (new_display_name);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->use_preview_label && priv->preview_label)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gtk_label_set_text (GTK_LABEL (priv->preview_label), priv->preview_display_name);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_signal_emit_by_name (impl, "update-preview");
}
else
{
if (new_file)
g_object_unref (new_file);
g_free (new_display_name);
}
}
static gboolean
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
list_select_func (GtkTreeSelection *selection,
GtkTreeModel *model,
GtkTreePath *path,
gboolean path_currently_selected,
gpointer data)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidget *impl = data;
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
GtkTreeIter iter;
gboolean is_sensitive;
gboolean is_folder;
if (!gtk_tree_model_get_iter (model, &iter, path))
return FALSE;
gtk_tree_model_get (model, &iter,
MODEL_COL_IS_SENSITIVE, &is_sensitive,
MODEL_COL_IS_FOLDER, &is_folder,
-1);
if (!is_sensitive || !is_folder)
return FALSE;
}
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return TRUE;
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
list_selection_changed (GtkTreeSelection *selection,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Avoid doing excess work Whenever we change directories, we unset the model, and then we set a new model. This causes several emissions of GtkTreeSelection::changed, for each of which we do a bunch of work to update the path bar, the location entry, etc. We can savely ignore some of these signals, and do less work.
2015-07-09 01:06:58 +00:00
if (gtk_tree_view_get_model (GTK_TREE_VIEW (priv->browse_files_tree_view)) == NULL)
return;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->location_entry)
update_chooser_entry (impl);
file-chooser: merge path bar mode and location mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 16:18:37 +00:00
location_bar_update (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
check_preview_change (impl);
g_signal_emit_by_name (impl, "selection-changed", 0);
}
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
static void
list_cursor_changed (GtkTreeView *list,
GtkFileChooserWidget *impl)
{
check_preview_change (impl);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Callback used when a row in the file list is activated */
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
list_row_activated (GtkTreeView *tree_view,
GtkTreePath *path,
GtkTreeViewColumn *column,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFile *file;
GtkTreeIter iter;
GtkTreeModel *model;
gboolean is_folder;
gboolean is_sensitive;
model = gtk_tree_view_get_model (tree_view);
if (!gtk_tree_model_get_iter (model, &iter, path))
return;
gtk_tree_model_get (model, &iter,
MODEL_COL_FILE, &file,
MODEL_COL_IS_FOLDER, &is_folder,
MODEL_COL_IS_SENSITIVE, &is_sensitive,
-1);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (is_sensitive && is_folder && file)
{
change_folder_and_display_error (impl, file, FALSE);
goto out;
}
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SAVE)
g_signal_emit_by_name (impl, "file-activated");
out:
if (file)
g_object_unref (file);
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
path_bar_clicked (GtkPathBar *path_bar,
GFile *file,
GFile *child_file,
gboolean child_is_hidden,
GtkFileChooserWidget *impl)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
if (child_file)
pending_select_files_add (impl, child_file);
if (!change_folder_and_display_error (impl, file, FALSE))
return;
/* Say we have "/foo/bar/[.baz]" and the user clicks on "bar". We should then
* show hidden files so that ".baz" appears in the file list, as it will still
* be shown in the path bar: "/foo/[bar]/.baz"
*/
if (child_is_hidden)
g_object_set (impl, "show-hidden", TRUE, NULL);
}
static void
update_cell_renderer_attributes (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_tree_view_column_set_attributes (priv->list_name_column,
priv->list_pixbuf_renderer,
"surface", MODEL_COL_SURFACE,
"sensitive", MODEL_COL_IS_SENSITIVE,
NULL);
gtk_tree_view_column_set_attributes (priv->list_name_column,
priv->list_name_renderer,
"text", MODEL_COL_NAME,
"ellipsize", MODEL_COL_ELLIPSIZE,
"sensitive", MODEL_COL_IS_SENSITIVE,
NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_tree_view_column_set_attributes (priv->list_size_column,
priv->list_size_renderer,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
"text", MODEL_COL_SIZE_TEXT,
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
"sensitive", MODEL_COL_IS_SENSITIVE,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
NULL);
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
gtk_tree_view_column_set_attributes (priv->list_time_column,
priv->list_date_renderer,
"text", MODEL_COL_DATE_TEXT,
"sensitive", MODEL_COL_IS_SENSITIVE,
NULL);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_tree_view_column_set_attributes (priv->list_time_column,
priv->list_time_renderer,
"text", MODEL_COL_TIME_TEXT,
"sensitive", MODEL_COL_IS_SENSITIVE,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
NULL);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_tree_view_column_set_attributes (priv->list_location_column,
priv->list_location_renderer,
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
"text", MODEL_COL_LOCATION_TEXT,
"sensitive", MODEL_COL_IS_SENSITIVE,
NULL);
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
update_time_renderer_visible (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
location_set_user_text (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *path)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
gtk_entry_set_text (GTK_ENTRY (priv->location_entry), path);
gtk_editable_set_position (GTK_EDITABLE (priv->location_entry), -1);
}
static void
location_popup_handler (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
const gchar *path)
file chooser: Make ~ and / work in recent Complained about in https://bugzilla.gnome.org/show_bug.cgi?id=743117
2015-01-18 21:18:12 +00:00
{
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->operation_mode != OPERATION_MODE_BROWSE)
{
operation_mode_set (impl, OPERATION_MODE_BROWSE);
if (priv->current_folder)
change_folder_and_display_error (impl, priv->current_folder, FALSE);
file chooser: Ensure a folder is loaded when browsing Just showing an empty list when the user hits Ctrl-l in recent files is not very useful. Load the home directory instead.
2015-04-06 02:27:23 +00:00
else
switch_to_home_dir (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser: Make ~ and / work in recent Complained about in https://bugzilla.gnome.org/show_bug.cgi?id=743117
2015-01-18 21:18:12 +00:00
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
if (priv->action == GTK_FILE_CHOOSER_ACTION_OPEN ||
priv->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER)
{
if (!path)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
return;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
location_mode_set (impl, LOCATION_MODE_FILENAME_ENTRY);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
location_set_user_text (impl, path);
}
else if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gtk_widget_grab_focus (priv->location_entry);
if (path != NULL)
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
location_set_user_text (impl, path);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
else
g_assert_not_reached ();
}
/* Handler for the "up-folder" keybinding signal */
static void
up_folder_handler (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
_gtk_path_bar_up (GTK_PATH_BAR (priv->browse_path_bar));
}
/* Handler for the "down-folder" keybinding signal */
static void
down_folder_handler (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
_gtk_path_bar_down (GTK_PATH_BAR (priv->browse_path_bar));
}
/* Handler for the "home-folder" keybinding signal */
static void
home_folder_handler (GtkFileChooserWidget *impl)
{
switch_to_home_dir (impl);
}
/* Handler for the "desktop-folder" keybinding signal */
static void
desktop_folder_handler (GtkFileChooserWidget *impl)
{
const char *name;
/* "To disable a directory, point it to the homedir."
* See http://freedesktop.org/wiki/Software/xdg-user-dirs
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
*/
name = g_get_user_special_dir (G_USER_DIRECTORY_DESKTOP);
if (!g_strcmp0 (name, g_get_home_dir ()))
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
return;
gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (impl), name);
}
/* Handler for the "search-shortcut" keybinding signal */
static void
search_shortcut_handler (GtkFileChooserWidget *impl)
{
file chooser: Make search shortcut toggle This is more in line with having a toggle button for search, and it matches what we do e.g. in nautilus.
2015-06-29 15:39:22 +00:00
GtkFileChooserWidgetPrivate *priv = impl->priv;
if (priv->operation_mode == OPERATION_MODE_SEARCH)
{
operation_mode_set (impl, OPERATION_MODE_BROWSE);
if (priv->current_folder)
change_folder_and_display_error (impl, priv->current_folder, FALSE);
else
switch_to_home_dir (impl);
}
else
operation_mode_set (impl, OPERATION_MODE_SEARCH);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
/* Handler for the "recent-shortcut" keybinding signal */
static void
recent_shortcut_handler (GtkFileChooserWidget *impl)
{
operation_mode_set (impl, OPERATION_MODE_RECENT);
}
file chooser: Add a shortcut to focus the sidebar Alt+P used to do this in the gtk2 filechooser (well, sometimes). Add this back as a key binding. https://bugzilla.gnome.org/show_bug.cgi?id=720684
2015-07-07 04:24:19 +00:00
/* Handler for the "places-shortcut" keybinding signal */
static void
places_shortcut_handler (GtkFileChooserWidget *impl)
{
gtk_widget_child_focus (impl->priv->places_sidebar, GTK_DIR_LEFT);
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
quick_bookmark_handler (GtkFileChooserWidget *impl,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint bookmark_index)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
GFile *file;
file = gtk_places_sidebar_get_nth_bookmark (GTK_PLACES_SIDEBAR (priv->places_sidebar), bookmark_index);
if (file)
{
change_folder_and_display_error (impl, file, FALSE);
g_object_unref (file);
}
}
static void
show_hidden_handler (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
g_object_set (impl, "show-hidden", !priv->show_hidden, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
add_normal_and_shifted_binding (GtkBindingSet *binding_set,
guint keyval,
GdkModifierType modifiers,
const gchar *signal_name)
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
{
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
keyval, modifiers,
signal_name, 0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
keyval, modifiers | GDK_SHIFT_MASK,
signal_name, 0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
gtk_file_chooser_widget_class_init (GtkFileChooserWidgetClass *class)
{
static const guint quick_bookmark_keyvals[10] = {
GDK_KEY_1, GDK_KEY_2, GDK_KEY_3, GDK_KEY_4, GDK_KEY_5, GDK_KEY_6, GDK_KEY_7, GDK_KEY_8, GDK_KEY_9, GDK_KEY_0
};
GObjectClass *gobject_class = G_OBJECT_CLASS (class);
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class);
GtkBindingSet *binding_set;
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
gint i;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gobject_class->finalize = gtk_file_chooser_widget_finalize;
gtk: Don't use GObjectClass.constructor Use the newer constructed instead, which has a fast path in GObject.
2014-06-26 22:22:42 +00:00
gobject_class->constructed = gtk_file_chooser_widget_constructed;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gobject_class->set_property = gtk_file_chooser_widget_set_property;
gobject_class->get_property = gtk_file_chooser_widget_get_property;
gobject_class->dispose = gtk_file_chooser_widget_dispose;
widget_class->show_all = gtk_file_chooser_widget_show_all;
widget_class->realize = gtk_file_chooser_widget_realize;
widget_class->map = gtk_file_chooser_widget_map;
widget_class->unmap = gtk_file_chooser_widget_unmap;
widget_class->hierarchy_changed = gtk_file_chooser_widget_hierarchy_changed;
widget_class->style_updated = gtk_file_chooser_widget_style_updated;
widget_class->screen_changed = gtk_file_chooser_widget_screen_changed;
Revert "file chooser: Don't start search too eagerly" This reverts commit f126157bfa9e8a550067fa169de24697add028bb.
2015-06-27 17:44:26 +00:00
widget_class->key_press_event = gtk_file_chooser_widget_key_press_event;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/*
* Signals
*/
/**
* GtkFileChooserWidget::location-popup:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
* @path: a string that gets put in the text entry for the file name
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::location-popup signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* This is used to make the file chooser show a "Location" prompt which
* the user can use to manually type the name of the file he wishes to select.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The default bindings for this signal are `Control + L` with a @path string
* of "" (the empty string). It is also bound to `/` with a @path string of
* "`/`" (a slash): this lets you type `/` and immediately type a path name.
* On Unix systems, this is bound to `~` (tilde) with a @path string of "~"
* itself for access to home directories.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[LOCATION_POPUP] =
g_signal_new_class_handler (I_("location-popup"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (location_popup_handler),
NULL, NULL,
_gtk_marshal_VOID__STRING,
G_TYPE_NONE, 1, G_TYPE_STRING);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::location-popup-on-paste:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::location-popup-on-paste signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* This is used to make the file chooser show a "Location" prompt when the user
* pastes into a #GtkFileChooserWidget.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Control + V`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[LOCATION_POPUP_ON_PASTE] =
g_signal_new_class_handler (I_("location-popup-on-paste"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (location_popup_on_paste_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::location-toggle-popup:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::location-toggle-popup signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* This is used to toggle the visibility of a "Location" prompt which the user
* can use to manually type the name of the file he wishes to select.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Control + L`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[LOCATION_TOGGLE_POPUP] =
g_signal_new_class_handler (I_("location-toggle-popup"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (location_toggle_popup_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::up-folder:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::up-folder signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* This is used to make the file chooser go to the parent of the current folder
* in the file hierarchy.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Alt + Up`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[UP_FOLDER] =
g_signal_new_class_handler (I_("up-folder"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (up_folder_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::down-folder:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::down-folder signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* This is used to make the file chooser go to a child of the current folder
* in the file hierarchy. The subfolder that will be used is displayed in the
* path bar widget of the file chooser. For example, if the path bar is showing
* "/foo/bar/baz", with bar currently displayed, then this will cause the file
* chooser to switch to the "baz" subfolder.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Alt + Down`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[DOWN_FOLDER] =
g_signal_new_class_handler (I_("down-folder"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (down_folder_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::home-folder:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::home-folder signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
* This is used to make the file chooser show the user's home
* folder in the file list.
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Alt + Home`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[HOME_FOLDER] =
g_signal_new_class_handler (I_("home-folder"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (home_folder_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::desktop-folder:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::desktop-folder signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
* This is used to make the file chooser show the user's Desktop
* folder in the file list.
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Alt + D`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[DESKTOP_FOLDER] =
g_signal_new_class_handler (I_("desktop-folder"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (desktop_folder_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::quick-bookmark:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* @bookmark_index: the number of the bookmark to switch to
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::quick-bookmark signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* This is used to make the file chooser switch to the bookmark specified
* in the @bookmark_index parameter. For example, if you have three bookmarks,
* you can pass 0, 1, 2 to this signal to switch to each of them, respectively.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Alt + 1`, `Alt + 2`,
* etc. until `Alt + 0`. Note that in the default binding, that
* `Alt + 1` is actually defined to switch to the bookmark at index
* 0, and so on successively; `Alt + 0` is defined to switch to the
* bookmark at index 10.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[QUICK_BOOKMARK] =
g_signal_new_class_handler (I_("quick-bookmark"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (quick_bookmark_handler),
NULL, NULL,
_gtk_marshal_VOID__INT,
G_TYPE_NONE, 1, G_TYPE_INT);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::show-hidden:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::show-hidden signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
* This is used to make the file chooser display hidden files.
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Control + H`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[SHOW_HIDDEN] =
g_signal_new_class_handler (I_("show-hidden"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (show_hidden_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::search-shortcut:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::search-shortcut signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
* This is used to make the file chooser show the search entry.
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Alt + S`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[SEARCH_SHORTCUT] =
g_signal_new_class_handler (I_("search-shortcut"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (search_shortcut_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
/**
* GtkFileChooserWidget::recent-shortcut:
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* @widget: the object which received the signal
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* The ::recent-shortcut signal is a [keybinding signal][GtkBindingSignal]
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
* which gets emitted when the user asks for it.
*
* This is used to make the file chooser show the Recent location.
*
docs: don't use <keycap> tags
2014-02-05 00:29:00 +00:00
* The default binding for this signal is `Alt + R`.
docs: add docs for GtkFileChooserWidget signals https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 10:36:38 +00:00
*/
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
signals[RECENT_SHORTCUT] =
g_signal_new_class_handler (I_("recent-shortcut"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (recent_shortcut_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
file chooser: Add a shortcut to focus the sidebar Alt+P used to do this in the gtk2 filechooser (well, sometimes). Add this back as a key binding. https://bugzilla.gnome.org/show_bug.cgi?id=720684
2015-07-07 04:24:19 +00:00
/**
* GtkFileChooserWidget::places-shortcut:
* @widget: the object which received the signal
*
* The ::places-shortcut signal is a [keybinding signal][GtkBindingSignal]
* which gets emitted when the user asks for it.
*
* This is used to move the focus to the places sidebar.
*
* The default binding for this signal is `Alt + P`.
*/
signals[PLACES_SHORTCUT] =
g_signal_new_class_handler (I_("places-shortcut"),
G_OBJECT_CLASS_TYPE (class),
G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
G_CALLBACK (places_shortcut_handler),
NULL, NULL,
_gtk_marshal_VOID__VOID,
G_TYPE_NONE, 0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
binding_set = gtk_binding_set_by_class (class);
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_l, GDK_CONTROL_MASK,
"location-toggle-popup",
0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_v, GDK_CONTROL_MASK,
"location-popup-on-paste",
0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
add_normal_and_shifted_binding (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_Up, GDK_MOD1_MASK,
"up-folder");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
add_normal_and_shifted_binding (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_KP_Up, GDK_MOD1_MASK,
"up-folder");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
add_normal_and_shifted_binding (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_Down, GDK_MOD1_MASK,
"down-folder");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
add_normal_and_shifted_binding (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_KP_Down, GDK_MOD1_MASK,
"down-folder");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_Home, GDK_MOD1_MASK,
"home-folder",
0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_KP_Home, GDK_MOD1_MASK,
"home-folder",
0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_d, GDK_MOD1_MASK,
"desktop-folder",
0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_KEY_h, GDK_CONTROL_MASK,
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
"show-hidden",
0);
gtk_binding_entry_add_signal (binding_set,
GDK_KEY_s, GDK_MOD1_MASK,
"search-shortcut",
0);
file chooser: Add Ctrl-F as search shortcut This is what nautilus uses, and is more discoverable than the somewhat easter-egg Alt-S, which is still supported.
2015-06-29 15:40:14 +00:00
gtk_binding_entry_add_signal (binding_set,
GDK_KEY_f, GDK_CONTROL_MASK,
"search-shortcut",
0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_binding_entry_add_signal (binding_set,
GDK_KEY_r, GDK_MOD1_MASK,
"recent-shortcut",
0);
file chooser: Add a shortcut to focus the sidebar Alt+P used to do this in the gtk2 filechooser (well, sometimes). Add this back as a key binding. https://bugzilla.gnome.org/show_bug.cgi?id=720684
2015-07-07 04:24:19 +00:00
gtk_binding_entry_add_signal (binding_set,
GDK_KEY_p, GDK_MOD1_MASK,
"places-shortcut",
0);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
for (i = 0; i < 10; i++)
gtk_binding_entry_add_signal (binding_set,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
quick_bookmark_keyvals[i], GDK_MOD1_MASK,
"quick-bookmark",
1, G_TYPE_INT, i);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
file chooser: Add a search-mode property This will be used to control search from the dialog.
2015-01-28 20:00:08 +00:00
g_object_class_install_property (gobject_class, PROP_SEARCH_MODE,
g_param_spec_boolean ("search-mode",
P_("Search mode"),
P_("Search mode"),
FALSE,
G_PARAM_READWRITE));
file chooser widget: Expose a "subtitle" property Give the file chooser widget a "subtitle" property, which contains a short string that explains the current mode.
2015-06-27 01:14:37 +00:00
g_object_class_install_property (gobject_class, PROP_SUBTITLE,
g_param_spec_string ("subtitle",
P_("Subtitle"),
P_("Subtitle"),
"",
G_PARAM_READABLE));
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
_gtk_file_chooser_install_properties (gobject_class);
/* Bind class to template */
gtk_widget_class_set_template_from_resource (widget_class,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
"/org/gtk/libgtk/ui/gtkfilechooserwidget.ui");
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* A *lot* of widgets that we need to handle .... */
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_widgets_hpaned);
GtkFileChooser: Indicate if search comes up empty This is a neice touch and helps to understand what is going on.
2015-05-02 03:04:35 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_files_stack);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, places_sidebar);
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, places_view);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_files_tree_view);
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_files_swin);
file chooser: Use a revealer Use a revealer to manage the visibility of the header area where we show the pathbar, the location entry or search. This is a bit smoother, and makes search more similar to a search bar.
2015-06-17 03:46:34 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_header_revealer);
file-chooser: move location entry into same place as pathbar https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-08 17:13:01 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_header_stack);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_new_folder_button);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_path_bar_size_group);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, browse_path_bar);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, filter_combo_hbox);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, filter_combo);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, preview_box);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, extra_align);
Fix filechooser actionbar visibility The actionbar was always visible, even when there is no filter and no extra widget to show. Now we only show it when there is something to show.
2014-05-24 04:00:00 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, extra_and_filters);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, location_entry_box);
file-chooser: add a search bar instead of using a path bar mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 15:47:07 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, search_entry);
file chooser: Add search progress Show a spinner if no search reasults have shown up yet and the search is still going, after 2 seconds.
2015-07-03 06:08:59 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, search_spinner);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_name_column);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_pixbuf_renderer);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_name_renderer);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_time_column);
file chooser: Improve time and date formatting Use the same formats as nautilus, and put date and time in separate cells, so they are neatly aligned.
2015-07-02 09:37:59 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_date_renderer);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_time_renderer);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_size_column);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_size_renderer);
file chooser: Add a location column for search In search, we show files from differnt locations, and it makes sense to show where they come from. This makes the file chooser more similar to nautilus, too.
2015-02-14 04:50:06 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_location_column);
file chooser: Use access time for recent files Use access time for sorting the recent files, and show it in the list instead of mtime.
2015-07-01 21:04:17 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, list_location_renderer);
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, new_folder_name_entry);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, new_folder_create_button);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, new_folder_error_label);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, new_folder_popover);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, rename_file_name_entry);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, rename_file_rename_button);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, rename_file_error_label);
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, rename_file_popover);
file chooser: Note when searching remote locations Inform the user that we won't search recursively when searching in remote locations.
2015-07-24 20:26:32 +00:00
gtk_widget_class_bind_template_child_private (widget_class, GtkFileChooserWidget, remote_warning_bar);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* And a *lot* of callbacks to bind ... */
gtk_widget_class_bind_template_callback (widget_class, browse_files_key_press_event_cb);
gtk_widget_class_bind_template_callback (widget_class, file_list_drag_drop_cb);
gtk_widget_class_bind_template_callback (widget_class, file_list_drag_data_received_cb);
gtk_widget_class_bind_template_callback (widget_class, list_popup_menu_cb);
gtk_widget_class_bind_template_callback (widget_class, file_list_query_tooltip_cb);
gtk_widget_class_bind_template_callback (widget_class, list_button_press_event_cb);
gtk_widget_class_bind_template_callback (widget_class, list_row_activated);
gtkfilechooserwidget: show drop hints on gtkplacessidebar Now with the API addition on gtkplacessidebar, we can show some hints for the drop targets. https://bugzilla.gnome.org/show_bug.cgi?id=747793
2015-04-11 15:36:41 +00:00
gtk_widget_class_bind_template_callback (widget_class, file_list_drag_begin_cb);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_callback (widget_class, file_list_drag_motion_cb);
gtkfilechooserwidget: show drop hints on gtkplacessidebar Now with the API addition on gtkplacessidebar, we can show some hints for the drop targets. https://bugzilla.gnome.org/show_bug.cgi?id=747793
2015-04-11 15:36:41 +00:00
gtk_widget_class_bind_template_callback (widget_class, file_list_drag_end_cb);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_callback (widget_class, list_selection_changed);
GtkFileChooser: Make preview update more understandable Implement Federico's suggestion: In single-selection mode, just use the selected row, In multi-selection mode, use the cursor row as long as it is in the selection. https://bugzilla.gnome.org/show_bug.cgi?id=154709
2014-10-19 21:54:28 +00:00
gtk_widget_class_bind_template_callback (widget_class, list_cursor_changed);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_widget_class_bind_template_callback (widget_class, filter_combo_changed);
gtk_widget_class_bind_template_callback (widget_class, path_bar_clicked);
gtk_widget_class_bind_template_callback (widget_class, places_sidebar_open_location_cb);
gtk_widget_class_bind_template_callback (widget_class, places_sidebar_show_error_message_cb);
filechooserwidget: use places view to manage fixed devices Previous patch modified places sidebar widget to stop handling fixed devices by adding an "Other Locations..." item. Up to now, however, these changes are isolated from each other since the bundled file manager widgets ignore the sidebar requests for external management of fixed devices and networks. To fix that, make the file chooser widget be aware of the GtkPlacesSidebar::show-other-locations signal and, when requested, show places view to manage the fixed devices and networks. https://bugzilla.gnome.org/show_bug.cgi?id=752034
2015-07-14 17:48:49 +00:00
gtk_widget_class_bind_template_callback (widget_class, places_sidebar_show_other_locations_cb);
file-chooser: add a search bar instead of using a path bar mode https://bugzilla.gnome.org/show_bug.cgi?id=722211
2014-04-09 15:47:07 +00:00
gtk_widget_class_bind_template_callback (widget_class, search_entry_activate_cb);
file chooser: Make Escape go out of search mode This works in most other places where we have search, and is the expected behavior.
2015-01-28 21:06:02 +00:00
gtk_widget_class_bind_template_callback (widget_class, search_entry_stop_cb);
Use a popover for creating new folders
2015-04-10 00:56:54 +00:00
gtk_widget_class_bind_template_callback (widget_class, new_folder_popover_active);
gtk_widget_class_bind_template_callback (widget_class, new_folder_name_changed);
gtk_widget_class_bind_template_callback (widget_class, new_folder_create_clicked);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_widget_class_bind_template_callback (widget_class, rename_file_name_changed);
gtk_widget_class_bind_template_callback (widget_class, rename_file_rename_clicked);
gtk_widget_class_bind_template_callback (widget_class, rename_file_end);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
static void
post_process_ui (GtkFileChooserWidget *impl)
{
GtkTreeSelection *selection;
GtkCellRenderer *cell;
GList *cells;
file chooser: Ensure the path bar is initialized There are some cases where we can end up showing the path bar without ever setting a file on it. One example is: 1) Open file chooser 2) Hit ~ 3) Hit Ctrl-L While this is a bit of a workaround, at least it makes sure that we never end up with an empty space where the path bar is supposed to be.
2015-01-18 22:13:12 +00:00
GFile *file;
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Some qdata, qdata can't be set with GtkBuilder */
g_object_set_data (G_OBJECT (impl->priv->browse_files_tree_view), "fmq-name", "file_list");
g_object_set_data (G_OBJECT (impl->priv->browse_files_tree_view), I_("GtkFileChooserWidget"), impl);
/* Setup file list treeview */
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (impl->priv->browse_files_tree_view));
gtk_tree_selection_set_select_function (selection,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
list_select_func,
impl, NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_tree_view_enable_model_drag_source (GTK_TREE_VIEW (impl->priv->browse_files_tree_view),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
GDK_BUTTON1_MASK,
NULL, 0,
GDK_ACTION_COPY | GDK_ACTION_MOVE);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
gtk_drag_source_add_uri_targets (impl->priv->browse_files_tree_view);
gtk_drag_dest_set (impl->priv->browse_files_tree_view,
GTK_DEST_DEFAULT_ALL,
NULL, 0,
GDK_ACTION_COPY | GDK_ACTION_MOVE);
gtk_drag_dest_add_uri_targets (impl->priv->browse_files_tree_view);
/* File browser treemodel columns are shared between GtkFileChooser implementations,
* so we don't set cell renderer attributes in GtkBuilder, but rather keep that
* in code.
*/
file_list_set_sort_column_ids (impl);
update_cell_renderer_attributes (impl);
/* Get the combo's text renderer and set ellipsize parameters,
* perhaps GtkComboBoxText should declare the cell renderer
* as an 'internal-child', then we could configure it in GtkBuilder
* instead of hard coding it here.
*/
cells = gtk_cell_layout_get_cells (GTK_CELL_LAYOUT (impl->priv->filter_combo));
g_assert (cells);
cell = cells->data;
g_object_set (G_OBJECT (cell),
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
"ellipsize", PANGO_ELLIPSIZE_END,
NULL);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
g_list_free (cells);
/* Set the GtkPathBar file system backend */
_gtk_path_bar_set_file_system (GTK_PATH_BAR (impl->priv->browse_path_bar), impl->priv->file_system);
file chooser: Ensure the path bar is initialized There are some cases where we can end up showing the path bar without ever setting a file on it. One example is: 1) Open file chooser 2) Hit ~ 3) Hit Ctrl-L While this is a bit of a workaround, at least it makes sure that we never end up with an empty space where the path bar is supposed to be.
2015-01-18 22:13:12 +00:00
file = g_file_new_for_path ("/");
_gtk_path_bar_set_file (GTK_PATH_BAR (impl->priv->browse_path_bar), file, FALSE);
g_object_unref (file);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
/* Set the fixed size icon renderer, this requires
* that priv->icon_size be already setup.
*/
set_icon_cell_renderer_fixed_size (impl);
file chooser: Set default widget in create folder popover This is using the new default widget functionality for popovers to make Enter in the entry activate the Create button. https://bugzilla.gnome.org/show_bug.cgi?id=747664
2015-04-17 04:14:28 +00:00
gtk_popover_set_default_widget (GTK_POPOVER (impl->priv->new_folder_popover), impl->priv->new_folder_create_button);
file chooser: Allow renaming files This has often been requested as a useful feature in save mode. Based on a patch by John Beard, https://bugzilla.gnome.org/show_bug.cgi?id=325150
2015-07-05 01:16:55 +00:00
gtk_popover_set_default_widget (GTK_POPOVER (impl->priv->rename_file_popover), impl->priv->rename_file_rename_button);
file chooser: Memory handling fixes I forgot to clean up the long press gesture, and in additon, creating the rename popover from the ui template was causing the tree view to not be disposed when the file chooser goes away. Work around this by manually unsetting the relative-to widget of the popover in dispose.
2015-07-20 15:11:00 +00:00
gtk_popover_set_relative_to (GTK_POPOVER (impl->priv->rename_file_popover), impl->priv->browse_files_tree_view);
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
add_actions (impl);
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
}
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
void
gtk_file_chooser_widget_set_save_entry (GtkFileChooserWidget *impl,
GtkWidget *entry)
{
GtkFileChooserWidgetPrivate *priv = impl->priv;
g_return_if_fail (GTK_IS_FILE_CHOOSER_WIDGET (impl));
file chooser: Make unsetting save entry work Fix an overzealous assertion.
2015-07-04 02:45:58 +00:00
g_return_if_fail (entry == NULL || GTK_IS_FILE_CHOOSER_ENTRY (entry));
file chooser widget: Allow external save entry Prepare the file chooser to use an external entry in save mode, instead of the builtin one.
2015-06-27 04:07:59 +00:00
priv->external_entry = entry;
if (priv->action == GTK_FILE_CHOOSER_ACTION_SAVE ||
priv->action == GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER)
{
save_widgets_destroy (impl);
save_widgets_create (impl);
}
}
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
static void
gtk_file_chooser_widget_init (GtkFileChooserWidget *impl)
{
GtkFileChooserWidgetPrivate *priv;
profile_start ("start", NULL);
#ifdef PROFILE_FILE_CHOOSER
access ("MARK: *** CREATE FILE CHOOSER", F_OK);
#endif
impl->priv = gtk_file_chooser_widget_get_instance_private (impl);
priv = impl->priv;
priv->local_only = TRUE;
priv->preview_widget_active = TRUE;
priv->use_preview_label = TRUE;
priv->select_multiple = FALSE;
priv->show_hidden = FALSE;
priv->show_size_column = TRUE;
priv->icon_size = FALLBACK_ICON_SIZE;
priv->load_state = LOAD_EMPTY;
priv->reload_state = RELOAD_EMPTY;
priv->pending_select_files = NULL;
priv->location_mode = LOCATION_MODE_PATH_BAR;
priv->operation_mode = OPERATION_MODE_BROWSE;
priv->sort_column = MODEL_COL_NAME;
priv->sort_order = GTK_SORT_ASCENDING;
priv->recent_manager = gtk_recent_manager_get_default ();
priv->create_folders = TRUE;
priv->auto_selecting_first_row = FALSE;
/* Ensure GTK+ private types used by the template
* definition before calling gtk_widget_init_template()
*/
g_type_ensure (GTK_TYPE_PATH_BAR);
gtk_widget_init_template (GTK_WIDGET (impl));
gtk_widget_set_size_request (priv->browse_files_tree_view, 280, -1);
set_file_system_backend (impl);
priv->bookmarks_manager = _gtk_bookmarks_manager_new (NULL, NULL);
file chooser: Use a popover for the context menu Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
2015-07-16 14:45:14 +00:00
priv->long_press_gesture = gtk_gesture_long_press_new (priv->browse_files_tree_view);
gtk_gesture_single_set_touch_only (GTK_GESTURE_SINGLE (priv->long_press_gesture), TRUE);
g_signal_connect (priv->long_press_gesture, "pressed",
G_CALLBACK (long_press_cb), impl);
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
/* Setup various attributes and callbacks in the UI
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
* which cannot be done with GtkBuilder.
*/
post_process_ui (impl);
profile_end ("end", NULL);
}
/**
* gtk_file_chooser_widget_new:
* @action: Open or save mode for the widget
*
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
* Creates a new #GtkFileChooserWidget. This is a file chooser widget that can
Merge GtkFileChooserWidget and GtkFileChooserDefault It seems that alternate implementations of GtkFileChooserWidget never materialized. The split between GtkFileChooserWidget and GtkFileChooserDefault is awkward. The immediate problem is that it makes it difficult to document the keybinding signals. So it makes sense to drop the abstraction and just have one thing. https://bugzilla.gnome.org/show_bug.cgi?id=723157
2014-01-28 09:30:33 +00:00
* be embedded in custom windows, and it is the same widget that is used by
* #GtkFileChooserDialog.
*
docs: use Returns: consistently Instead of Return value:
2014-02-19 23:49:43 +00:00
* Returns: a new #GtkFileChooserWidget
Mark as 2.4 additions. Sat Nov 8 01:50:17 2003 Matthias Clasen <maclas@gmx.de> * gtk/gtkicontheme.c: * gtk/gtkfilechooserwidget.c (gtk_file_chooser_widget_new): * gtk/gtkfilechooserdialog.c (gtk_file_chooser_dialog_new): * gtk/gtkfilechooser.c (gtk_file_chooser_[un]select_all): Mark as 2.4 additions.
2003-11-08 00:51:10 +00:00
*
* Since: 2.4
Fixed docs. (gtk_file_chooser_remove_filter): Likewise. 2003-10-23 Federico Mena Quintero <federico@ximian.com> * gtk/gtkfilechooser.c (gtk_file_chooser_get_preview_uri): Fixed docs. (gtk_file_chooser_remove_filter): Likewise. (gtk_file_chooser_select_all): Added docs. (gtk_file_chooser_unselect_all): Likewise. * gtk/gtkfilechooserdialog.c (gtk_file_chooser_dialog_new): Added docs. * gtk/gtkfilechooserwidget.c (gtk_file_chooser_widget_new): Added docs.
2003-10-23 23:02:38 +00:00
**/
Initial revision
2003-03-21 20:34:02 +00:00
GtkWidget *
gtk_file_chooser_widget_new (GtkFileChooserAction action)
{
return g_object_new (GTK_TYPE_FILE_CHOOSER_WIDGET,
file chooser: Cleanups
2015-07-04 00:53:54 +00:00
"action", action,
NULL);
Initial revision
2003-03-21 20:34:02 +00:00
}
Reference in New Issue Copy Permalink