AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
718efc2f59
gtk2/testsuite/gtk/notify.c

683 lines
20 KiB
C
Raw Normal View History

Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
/* Gtk+ property notify tests
* Copyright (C) 2014 Matthias Clasen
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Library General Public License for more details.
*
* You should have received a copy of the GNU Library General Public
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
*/
#include <math.h>
#include <string.h>
#include <gtk/gtk.h>
#include <gtk/gtkunixprint.h>
Work towards succeeding make check under Wayland Skip tests that don't work under Wayland, such as tests for GtkPlug and GtkSocket.
2015-08-28 16:54:32 +00:00
#ifdef GDK_WINDOWING_WAYLAND
#include "gdk/wayland/gdkwayland.h"
#endif
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
typedef struct
{
const gchar *name;
gint count;
} NotifyData;
static void
count_notify (GObject *obj, GParamSpec *pspec, NotifyData *data)
{
if (g_strcmp0 (data->name, pspec->name) == 0)
data->count++;
}
/* Check that we get notifications when properties change.
* Also check that we don't emit redundant notifications for
* enum, flags, booleans, ints. We allow redundant notifications
* for strings, and floats
*/
static void
check_property (GObject *instance, GParamSpec *pspec)
{
if (G_TYPE_IS_ENUM (pspec->value_type))
{
GEnumClass *class;
gint i;
NotifyData data;
gulong id;
gint first;
gint value;
gint current_count;
class = g_type_class_ref (pspec->value_type);
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
g_object_get (instance, pspec->name, &value, NULL);
g_object_set (instance, pspec->name, value, NULL);
g_assert_cmpint (data.count, ==, 0);
if (class->values[0].value == value)
first = 1;
else
first = 0;
for (i = first; i < class->n_values; i++)
{
current_count = data.count + 1;
g_object_set (instance, pspec->name, class->values[i].value, NULL);
g_assert_cmpint (data.count, ==, current_count);
if (current_count == 10) /* just test a few */
break;
}
g_signal_handler_disconnect (instance, id);
g_type_class_unref (class);
}
else if (G_TYPE_IS_FLAGS (pspec->value_type))
{
GFlagsClass *class;
gint i;
NotifyData data;
gulong id;
guint value;
gint current_count;
class = g_type_class_ref (pspec->value_type);
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
g_object_get (instance, pspec->name, &value, NULL);
g_object_set (instance, pspec->name, value, NULL);
g_assert_cmpint (data.count, ==, 0);
for (i = 0; i < class->n_values; i++)
{
/* some flags have a 'none' member, skip it */
if (class->values[i].value == 0)
continue;
if ((value & class->values[i].value) != 0)
continue;
value |= class->values[i].value;
current_count = data.count + 1;
g_object_set (instance, pspec->name, value, NULL);
g_assert_cmpint (data.count, ==, current_count);
if (current_count == 10) /* just test a few */
break;
}
g_signal_handler_disconnect (instance, id);
g_type_class_unref (class);
}
else if (pspec->value_type == G_TYPE_BOOLEAN)
{
NotifyData data;
gboolean value;
gulong id;
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
g_object_get (instance, pspec->name, &value, NULL);
g_object_set (instance, pspec->name, value, NULL);
g_assert_cmpint (data.count, ==, 0);
g_object_set (instance, pspec->name, 1 - value, NULL);
g_assert_cmpint (data.count, ==, 1);
g_signal_handler_disconnect (instance, id);
}
else if (pspec->value_type == G_TYPE_INT)
{
GParamSpecInt *p = G_PARAM_SPEC_INT (pspec);
gint i;
NotifyData data;
gulong id;
gint value;
gint current_count;
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
g_object_get (instance, pspec->name, &value, NULL);
g_object_set (instance, pspec->name, value, NULL);
g_assert_cmpint (data.count, ==, 0);
for (i = p->minimum; i <= p->maximum; i++)
{
g_object_get (instance, pspec->name, &value, NULL);
if (value == i)
continue;
current_count = data.count + 1;
g_object_set (instance, pspec->name, i, NULL);
g_assert_cmpint (data.count, ==, current_count);
if (current_count == 10) /* just test a few */
break;
}
g_signal_handler_disconnect (instance, id);
}
else if (pspec->value_type == G_TYPE_UINT)
{
guint i;
NotifyData data;
gulong id;
guint value;
gint current_count;
guint minimum, maximum;
if (G_IS_PARAM_SPEC_UINT (pspec))
{
minimum = G_PARAM_SPEC_UINT (pspec)->minimum;
maximum = G_PARAM_SPEC_UINT (pspec)->maximum;
}
else /* random */
{
minimum = 0;
maximum = 1000;
}
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
g_object_get (instance, pspec->name, &value, NULL);
g_object_set (instance, pspec->name, value, NULL);
g_assert_cmpint (data.count, ==, 0);
for (i = minimum; i <= maximum; i++)
{
g_object_get (instance, pspec->name, &value, NULL);
if (value == i)
continue;
current_count = data.count + 1;
g_object_set (instance, pspec->name, i, NULL);
g_assert_cmpint (data.count, ==, current_count);
if (current_count == 10) /* just test a few */
break;
}
g_signal_handler_disconnect (instance, id);
}
else if (pspec->value_type == G_TYPE_STRING)
{
NotifyData data;
gulong id;
gchar *value;
gchar *new_value;
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
g_object_get (instance, pspec->name, &value, NULL);
/* don't check redundant notifications */
new_value = g_strconcat ("(", value, ".", value, ")", NULL);
g_object_set (instance, pspec->name, new_value, NULL);
g_assert_cmpint (data.count, ==, 1);
g_free (value);
g_free (new_value);
g_signal_handler_disconnect (instance, id);
}
else if (pspec->value_type == G_TYPE_DOUBLE)
{
GParamSpecDouble *p = G_PARAM_SPEC_DOUBLE (pspec);
guint i;
NotifyData data;
gulong id;
gdouble value;
gdouble new_value;
gint current_count;
gdouble delta;
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
/* don't check redundant notifications */
g_object_get (instance, pspec->name, &value, NULL);
if (p->maximum > 100 || p->minimum < -100)
delta = M_PI;
else
delta = (p->maximum - p->minimum) / 10.0;
new_value = p->minimum;
for (i = 0; i < 10; i++)
{
new_value += delta;
if (fabs (value - new_value) < p->epsilon)
continue;
if (new_value > p->maximum)
break;
current_count = data.count + 1;
g_object_set (instance, pspec->name, new_value, NULL);
g_assert_cmpint (data.count, ==, current_count);
}
g_signal_handler_disconnect (instance, id);
}
else if (pspec->value_type == G_TYPE_FLOAT)
{
GParamSpecFloat *p = G_PARAM_SPEC_FLOAT (pspec);
guint i;
NotifyData data;
gulong id;
gfloat value;
gfloat new_value;
gint current_count;
data.name = pspec->name;
data.count = 0;
id = g_signal_connect (instance, "notify", G_CALLBACK (count_notify), &data);
/* don't check redundant notifications */
g_object_get (instance, pspec->name, &value, NULL);
new_value = p->minimum;
for (i = 0; i < 10; i++)
{
if (fabs (value - new_value) < p->epsilon)
continue;
current_count = data.count + 1;
new_value += (p->maximum - p->minimum) / 10.0;
if (new_value > p->maximum)
break;
g_object_set (instance, pspec->name, new_value, NULL);
g_assert_cmpint (data.count, ==, current_count);
}
g_signal_handler_disconnect (instance, id);
}
else
{
if (g_test_verbose ())
g_print ("Skipping property %s.%s of type %s\n", g_type_name (pspec->owner_type), pspec->name, g_type_name (pspec->value_type));
}
}
static void
test_type (gconstpointer data)
{
GObjectClass *klass;
GObject *instance;
GParamSpec **pspecs;
guint n_pspecs, i;
GType type;
GdkDisplay *display;
type = * (GType *) data;
display = gdk_display_get_default ();
if (!G_TYPE_IS_CLASSED (type))
return;
if (G_TYPE_IS_ABSTRACT (type))
return;
if (!g_type_is_a (type, G_TYPE_OBJECT))
return;
/* non-GTK+ */
if (g_str_equal (g_type_name (type), "AtkObject") ||
g_str_equal (g_type_name (type), "GdkPixbufSimpleAnim"))
return;
/* Deprecated, not getting fixed */
if (g_str_equal (g_type_name (type), "GtkColorSelection") ||
Remove GtkUIManager
2016-10-16 17:28:11 +00:00
g_str_equal (g_type_name (type), "GtkNumerableIcon"))
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
return;
/* These can't be freely constructed/destroyed */
if (g_type_is_a (type, GTK_TYPE_APPLICATION) ||
g_type_is_a (type, GDK_TYPE_PIXBUF_LOADER) ||
Skip GdkDrawingContext in some tests GdkDrawingContext is not freely constructible, so we need to skip it in the notify and finalize tests.
2016-06-20 19:26:26 +00:00
g_type_is_a (type, GDK_TYPE_DRAWING_CONTEXT) ||
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
#ifdef G_OS_UNIX
g_type_is_a (type, GTK_TYPE_PRINT_JOB) ||
#endif
g_type_is_a (type, gdk_pixbuf_simple_anim_iter_get_type ()) ||
g_str_equal (g_type_name (type), "GdkX11DeviceManagerXI2") ||
Skip GdkX11DeviceManagerCore in notify tests We already skip the XI2 implementation, and the core one needs to the same treatment.
2016-01-03 15:34:40 +00:00
g_str_equal (g_type_name (type), "GdkX11DeviceManagerCore") ||
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
g_str_equal (g_type_name (type), "GdkX11Display") ||
g_str_equal (g_type_name (type), "GdkX11DisplayManager") ||
Skip GdkX11GLContext in some object tests Since it can't be constructed without specifying a GdkWindow, which we don't have here.
2014-10-22 03:46:11 +00:00
g_str_equal (g_type_name (type), "GdkX11Screen") ||
g_str_equal (g_type_name (type), "GdkX11GLContext"))
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
return;
/* This throws a critical when the connection is dropped */
if (g_type_is_a (type, GTK_TYPE_APP_CHOOSER_DIALOG))
return;
/* These leak their GDBusConnections */
if (g_type_is_a (type, GTK_TYPE_FILE_CHOOSER_BUTTON) ||
g_type_is_a (type, GTK_TYPE_FILE_CHOOSER_DIALOG) ||
g_type_is_a (type, GTK_TYPE_FILE_CHOOSER_WIDGET) ||
testsuite: Skip GtkFileChooserNative for notification tests Like all the other GtkFileChooser implementations, this one emits some unneeded notifications.
2015-11-15 00:03:10 +00:00
g_type_is_a (type, GTK_TYPE_FILE_CHOOSER_NATIVE) ||
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
g_type_is_a (type, GTK_TYPE_PLACES_SIDEBAR))
return;
notify test: Don't test object relying on dbus connections Don't test types that rely on a pre-existing dbus session bus. https://bugzilla.gnome.org/show_bug.cgi?id=749009
2015-05-06 10:39:14 +00:00
/* These rely on a d-bus session bus */
if (g_type_is_a (type, GTK_TYPE_MOUNT_OPERATION))
return;
Work towards succeeding make check under Wayland Skip tests that don't work under Wayland, such as tests for GtkPlug and GtkSocket.
2015-08-28 16:54:32 +00:00
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
klass = g_type_class_ref (type);
if (g_type_is_a (type, GTK_TYPE_SETTINGS))
instance = g_object_ref (gtk_settings_get_default ());
else if (g_type_is_a (type, GDK_TYPE_WINDOW))
{
API: gdk: Add gdk_window_new_popup() ... and use it.
2016-11-06 22:47:56 +00:00
instance = g_object_ref (gdk_window_new_popup (gdk_display_get_default (),
0,
&(GdkRectangle) { 0, 0, 100, 100 }));
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
}
else if (g_str_equal (g_type_name (type), "GdkX11Cursor"))
instance = g_object_new (type, "display", display, NULL);
else
instance = g_object_new (type, NULL);
if (g_type_is_a (type, G_TYPE_INITIALLY_UNOWNED))
g_object_ref_sink (instance);
pspecs = g_object_class_list_properties (klass, &n_pspecs);
for (i = 0; i < n_pspecs; ++i)
{
GParamSpec *pspec = pspecs[i];
if ((pspec->flags & G_PARAM_READABLE) == 0)
continue;
if ((pspec->flags & G_PARAM_WRITABLE) == 0)
continue;
if ((pspec->flags & G_PARAM_CONSTRUCT_ONLY) != 0)
continue;
/* non-GTK+ */
if (g_str_equal (g_type_name (pspec->owner_type), "AtkObject") ||
g_str_equal (g_type_name (pspec->owner_type), "GdkPixbufSimpleAnim") ||
g_str_equal (g_type_name (pspec->owner_type), "GMountOperation"))
continue;
/* set properties are best skipped */
if (pspec->value_type == G_TYPE_BOOLEAN &&
g_str_has_suffix (pspec->name, "-set"))
continue;
/* These are special */
if (g_type_is_a (pspec->owner_type, GTK_TYPE_WIDGET) &&
(g_str_equal (pspec->name, "has-focus") ||
g_str_equal (pspec->name, "has-default") ||
g_str_equal (pspec->name, "is-focus") ||
g_str_equal (pspec->name, "margin") ||
g_str_equal (pspec->name, "hexpand") ||
g_str_equal (pspec->name, "vexpand") ||
g_str_equal (pspec->name, "expand")
))
continue;
testsuite: Fix notify tests GtkStatusIcon tests don't work well under xwayland either, so just skip them unconditionally. GtkEntry now fails because the update of the im-module is no longer deferred to an idle, and (gtk-im-simple) is not a valid module name, so skip this property.
2015-12-04 18:17:37 +00:00
if (pspec->owner_type == GTK_TYPE_ENTRY &&
g_str_equal (pspec->name, "im-module"))
continue;
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
if (type == GTK_TYPE_SETTINGS)
continue;
notification tests: Skip GtkEntryCompletion::text-column This one is special.
2014-09-04 02:41:56 +00:00
if (g_type_is_a (pspec->owner_type, GTK_TYPE_ENTRY_COMPLETION) &&
g_str_equal (pspec->name, "text-column"))
continue;
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
if (g_type_is_a (pspec->owner_type, GTK_TYPE_MENU_ITEM) &&
g_str_equal (pspec->name, "accel-path"))
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_MENU) &&
(g_str_equal (pspec->name, "accel-path") ||
g_str_equal (pspec->name, "active")))
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_CHECK_MENU_ITEM) &&
g_str_equal (pspec->name, "active"))
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_COLOR_CHOOSER) &&
g_str_equal (pspec->name, "show-editor"))
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_NOTEBOOK) &&
g_str_equal (pspec->name, "page"))
continue;
Exclude GtkToggleButton::draw-indicator from the notification test We reverted to emitting redundant notifications for this, so don't assert that we don't.
2014-06-28 14:58:24 +00:00
if (g_type_is_a (pspec->owner_type, GTK_TYPE_TOGGLE_BUTTON) &&
g_str_equal (pspec->name, "draw-indicator"))
continue;
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
if (g_str_equal (g_type_name (type), "GtkRecentChooserMenu") &&
g_str_equal (pspec->name, "select-multiple"))
continue;
/* Really a bug in the way GtkButton and its subclasses interact:
* setting label etc on a subclass destroys the content, breaking
* e.g. GtkColorButton pretty badly
*/
if (type == GTK_TYPE_COLOR_BUTTON && pspec->owner_type == GTK_TYPE_BUTTON)
continue;
/* Too many special cases involving -set properties */
if (g_str_equal (g_type_name (pspec->owner_type), "GtkCellRendererText") ||
g_str_equal (g_type_name (pspec->owner_type), "GtkTextTag"))
continue;
/* Most things assume a model is set */
if (g_str_equal (g_type_name (pspec->owner_type), "GtkComboBox"))
continue;
/* Deprecated, not getting fixed */
Remove GtkActionGroup
2016-10-16 18:46:37 +00:00
if (g_str_equal (g_type_name (pspec->owner_type), "GtkAction"))
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_CONTAINER) &&
g_str_equal (pspec->name, "resize-mode"))
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_COLOR_BUTTON) &&
g_str_equal (pspec->name, "alpha"))
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_CELL_RENDERER_PIXBUF) &&
(g_str_equal (pspec->name, "follow-state") ||
g_str_equal (pspec->name, "stock-id") ||
g_str_equal (pspec->name, "stock-size") ||
g_str_equal (pspec->name, "stock-detail")))
continue;
if (g_type_is_a (pspec->owner_type, GTK_TYPE_MENU) &&
g_str_equal (pspec->name, "tearoff-state"))
continue;
notify test: Skip GtkWidget::double-buffered This property is now deprecated, and ignored, thus: no notification.
2014-06-22 16:09:52 +00:00
if (g_type_is_a (pspec->owner_type, GTK_TYPE_WIDGET) &&
g_str_equal (pspec->name, "double-buffered"))
continue;
Drop has-resize-grip from the notify test The setter is not doing anything, so we won't get notification.
2014-07-03 19:24:58 +00:00
if (g_type_is_a (pspec->owner_type, GTK_TYPE_WINDOW) &&
g_str_equal (pspec->name, "has-resize-grip"))
continue;
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
/* Can only be set on window widgets */
if (pspec->owner_type == GTK_TYPE_WIDGET &&
g_str_equal (pspec->name, "events"))
continue;
/* Can only be set on unmapped windows */
if (pspec->owner_type == GTK_TYPE_WINDOW &&
g_str_equal (pspec->name, "type-hint"))
continue;
/* Special restrictions on allowed values */
if (pspec->owner_type == GTK_TYPE_COMBO_BOX &&
(g_str_equal (pspec->name, "row-span-column") ||
g_str_equal (pspec->name, "column-span-column") ||
g_str_equal (pspec->name, "id-column") ||
g_str_equal (pspec->name, "active-id") ||
g_str_equal (pspec->name, "entry-text-column")))
continue;
if (pspec->owner_type == GTK_TYPE_ENTRY_COMPLETION &&
g_str_equal (pspec->name, "text-column"))
continue;
if (pspec->owner_type == GTK_TYPE_PRINT_OPERATION &&
(g_str_equal (pspec->name, "current-page") ||
g_str_equal (pspec->name, "n-pages")))
continue;
if (pspec->owner_type == GTK_TYPE_RANGE &&
g_str_equal (pspec->name, "fill-level"))
continue;
if (pspec->owner_type == GTK_TYPE_SPIN_BUTTON &&
g_str_equal (pspec->name, "value"))
continue;
if (pspec->owner_type == GTK_TYPE_STACK &&
g_str_equal (pspec->name, "visible-child-name"))
continue;
notify test: Exclude a few new properties The button properties don't make sense on GtkModelButton (indicating that GtkModelButton should really not be a GtkButton subclass).
2014-11-23 23:29:04 +00:00
if (pspec->owner_type == GTK_TYPE_POPOVER_MENU &&
g_str_equal (pspec->name, "visible-submenu"))
continue;
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
if (pspec->owner_type == GTK_TYPE_TEXT_VIEW &&
g_str_equal (pspec->name, "im-module"))
continue;
if (pspec->owner_type == GTK_TYPE_TOOLBAR &&
g_str_equal (pspec->name, "icon-size"))
continue;
if (pspec->owner_type == GTK_TYPE_TREE_SELECTION &&
g_str_equal (pspec->name, "mode")) /* requires a treeview */
continue;
if (pspec->owner_type == GTK_TYPE_TREE_VIEW &&
g_str_equal (pspec->name, "headers-clickable")) /* requires columns */
continue;
/* This one has a special-purpose default value */
if (g_type_is_a (type, GTK_TYPE_DIALOG) &&
g_str_equal (pspec->name, "use-header-bar"))
continue;
if (g_type_is_a (type, GTK_TYPE_ASSISTANT) &&
g_str_equal (pspec->name, "use-header-bar"))
continue;
notify test: Exclude a few new properties The button properties don't make sense on GtkModelButton (indicating that GtkModelButton should really not be a GtkButton subclass).
2014-11-23 23:29:04 +00:00
if (type == GTK_TYPE_MODEL_BUTTON &&
pspec->owner_type == GTK_TYPE_BUTTON)
continue;
Fix make check Don't try setting GtkShortcutsShortcut::accelerator to a random value, it only accepts strings that it can parse.
2015-10-27 17:26:50 +00:00
if (g_type_is_a (type, GTK_TYPE_SHORTCUTS_SHORTCUT) &&
g_str_equal (pspec->name, "accelerator"))
continue;
Skip GtkShortcutLabel::accelerator in notify test This property is not freely settable, since the string gets parsed.
2016-08-03 03:59:34 +00:00
if (g_type_is_a (type, GTK_TYPE_SHORTCUT_LABEL) &&
g_str_equal (pspec->name, "accelerator"))
continue;
notify test: Skip GtkFontButton::font-name This is not freely settable.
2016-04-26 03:08:39 +00:00
if (g_type_is_a (type, GTK_TYPE_FONT_CHOOSER) &&
g_str_equal (pspec->name, "font"))
continue;
if (g_type_is_a (type, GTK_TYPE_FONT_BUTTON) &&
g_str_equal (pspec->name, "font-name"))
continue;
test: Skip GtkScrolledWindow::max-content- properties The allowed values for the max-content- properties depend on the value of the min-content- properties, in a way that our simple test is not prepared to deal with. Just skip them for now.
2016-06-08 13:03:12 +00:00
/* these depend on the min-content- properties in a way that breaks our test */
if (g_type_is_a (type, GTK_TYPE_SCROLLED_WINDOW) &&
Fix build Commit 023f406c9617284ee3b88727df489f20cd066fd6 has a typo that results in this error: ../../../testsuite/gtk/notify.c: In function 'test_type': ../../../testsuite/gtk/notify.c:679:54: error: expected expression before ')' token (g_str_equal (pspec->name, "max-content-width") ||) ^
2016-06-08 13:20:02 +00:00
(g_str_equal (pspec->name, "max-content-width") ||
g_str_equal (pspec->name, "max-content-height")))
test: Skip GtkScrolledWindow::max-content- properties The allowed values for the max-content- properties depend on the value of the min-content- properties, in a way that our simple test is not prepared to deal with. Just skip them for now.
2016-06-08 13:03:12 +00:00
continue;
Add a test for property notification This tests just a few basic things for now. Mainly, that we don't emit redundant notifications for enum, flags, int and boolean properties. It also checks that we do emit the expected notifications when the value actually changes. This is checked for string, double and float properties as well. There is a large number of exceptions in the test, and a lot more checks that could be done. One class of exceptions is all the places where we have -set booleans to go along with another property. We should have a dedicated test for these pairs. Another class of exceptions is where naked objects created by g_object_new () just don't have the full functionality - e.g. a tree selection without a tree view does not work very well. We set up the instance object better for these situations.
2014-06-09 16:47:45 +00:00
if (g_test_verbose ())
g_print ("Property %s.%s\n", g_type_name (pspec->owner_type), pspec->name);
check_property (instance, pspec);
}
g_free (pspecs);
if (g_type_is_a (type, GDK_TYPE_WINDOW))
gdk_window_destroy (GDK_WINDOW (instance));
else
g_object_unref (instance);
g_type_class_unref (klass);
}
int
main (int argc, char **argv)
{
const GType *otypes;
guint i;
gchar *schema_dir;
gint result;
gtk_test_init (&argc, &argv);
gtk_test_register_all_types();
/* g_test_build_filename must be called after gtk_test_init */
schema_dir = g_test_build_filename (G_TEST_BUILT, "", NULL);
g_setenv ("GSETTINGS_SCHEMA_DIR", schema_dir, TRUE);
otypes = gtk_test_list_all_types (NULL);
for (i = 0; otypes[i]; i++)
{
gchar *testname;
testname = g_strdup_printf ("/Notification/%s", g_type_name (otypes[i]));
g_test_add_data_func (testname, &otypes[i], test_type);
g_free (testname);
}
result = g_test_run ();
g_free (schema_dir);
return result;
}
Reference in New Issue Copy Permalink