AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
d04f66eb52
gtk2/gtk/gtkcsslookupprivate.h

67 lines
2.7 KiB
C
Raw Normal View History

css: Redo StyleProvider interface We now use the GtkStleProviderPrivate interface, which hopefully is faster and more conformant to CSS. Long term, it definitely should be both. I would have liked to split this up into multiple commits, but couldn't find a way.
2011-12-28 21:59:55 +00:00
/* GTK - The GIMP Toolkit
* Copyright (C) 2011 Benjamin Otte <otte@gnome.org>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
Change FSF Address
2012-02-27 13:01:10 +00:00
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
css: Redo StyleProvider interface We now use the GtkStleProviderPrivate interface, which hopefully is faster and more conformant to CSS. Long term, it definitely should be both. I would have liked to split this up into multiple commits, but couldn't find a way.
2011-12-28 21:59:55 +00:00
*/
#ifndef __GTK_CSS_LOOKUP_PRIVATE_H__
#define __GTK_CSS_LOOKUP_PRIVATE_H__
#include <glib-object.h>
#include "gtk/gtkbitmaskprivate.h"
stylecontext: Always pass the static style ... to build_properties. There is always one available, so we can insist on that one. This simplifies a bunch of code.
2014-10-26 23:25:18 +00:00
#include "gtk/gtkcssstaticstyleprivate.h"
css: Feed sections to CSS lookup code
2012-01-01 22:16:35 +00:00
#include "gtk/gtkcsssection.h"
css: Redo StyleProvider interface We now use the GtkStleProviderPrivate interface, which hopefully is faster and more conformant to CSS. Long term, it definitely should be both. I would have liked to split this up into multiple commits, but couldn't find a way.
2011-12-28 21:59:55 +00:00
G_BEGIN_DECLS
typedef struct _GtkCssLookup GtkCssLookup;
Make _gtk_css_lookup_get_missing inline This is called a lot in the loop in gtk_css_style_provider_lookup which actually showed up on profiles.
2012-11-09 09:09:06 +00:00
typedef struct {
GtkCssSection *section;
GtkCssValue *value;
} GtkCssLookupValue;
struct _GtkCssLookup {
GtkBitmask *missing;
cssstyle: Don't store custom css properties This makes custom CSS properties no longer configurable. But it avoids crashes when loading custom themes, so that's a good thing. Testcase included. https://bugzilla.redhat.com/show_bug.cgi?id=1281234
2015-11-20 18:37:52 +00:00
GtkCssLookupValue values[GTK_CSS_PROPERTY_N_PROPERTIES];
Make _gtk_css_lookup_get_missing inline This is called a lot in the loop in gtk_css_style_provider_lookup which actually showed up on profiles.
2012-11-09 09:09:06 +00:00
};
css: Huge refactoring to avoid computing wrong values Here's the shortest description of the bug I can come up with: When computing values, we have 3 kinds of dependencies: (1) other properties ("currentColor" or em values) (2) inherited properties ("inherit") (3) generic things from the theme (@keyframes or @define-color) Previously, we passed the GtkStyleContext as an argument, because it provided these 3 things using: (1) _gtk_style_context_peek_property() (2) _gtk_style_context_peek_property(gtk_style_context_get_parent()) (3) context->priv->cascade However, this makes it impossible to lookup values other than the ones accessible via _gtk_style_context_peek_property(). And this is exactly what we are doing in gtk_style_context_update_cache(). So when the cache updates encountered case (1), they were looking up the values from the wrong style data. So this large patch essentially does nothing but replace the context argument in all compute functions with new arguments for the 3 cases above: (1) values (2) parent_values (3) provider We apparently have a lot of computing code.
2012-09-28 16:02:46 +00:00
GtkCssLookup * _gtk_css_lookup_new (const GtkBitmask *relevant);
void _gtk_css_lookup_free (GtkCssLookup *lookup);
Make _gtk_css_lookup_get_missing inline This is called a lot in the loop in gtk_css_style_provider_lookup which actually showed up on profiles.
2012-11-09 09:09:06 +00:00
static inline const GtkBitmask *_gtk_css_lookup_get_missing (const GtkCssLookup *lookup);
css: Huge refactoring to avoid computing wrong values Here's the shortest description of the bug I can come up with: When computing values, we have 3 kinds of dependencies: (1) other properties ("currentColor" or em values) (2) inherited properties ("inherit") (3) generic things from the theme (@keyframes or @define-color) Previously, we passed the GtkStyleContext as an argument, because it provided these 3 things using: (1) _gtk_style_context_peek_property() (2) _gtk_style_context_peek_property(gtk_style_context_get_parent()) (3) context->priv->cascade However, this makes it impossible to lookup values other than the ones accessible via _gtk_style_context_peek_property(). And this is exactly what we are doing in gtk_style_context_update_cache(). So when the cache updates encountered case (1), they were looking up the values from the wrong style data. So this large patch essentially does nothing but replace the context argument in all compute functions with new arguments for the 3 cases above: (1) values (2) parent_values (3) provider We apparently have a lot of computing code.
2012-09-28 16:02:46 +00:00
gboolean _gtk_css_lookup_is_missing (const GtkCssLookup *lookup,
guint id);
void _gtk_css_lookup_set (GtkCssLookup *lookup,
guint id,
GtkCssSection *section,
GtkCssValue *value);
void _gtk_css_lookup_resolve (GtkCssLookup *lookup,
css: Merge GtkStyleProviderPrivate into GtkStyleProvider This is just lots of renaming. The interface remains private, so the public API does not change, apart from removing the definition of the Interface object to avoid subclassing.
2017-10-31 03:31:46 +00:00
GtkStyleProvider *provider,
stylecontext: Always pass the static style ... to build_properties. There is always one available, so we can insist on that one. This simplifies a bunch of code.
2014-10-26 23:25:18 +00:00
GtkCssStaticStyle *style,
cssstyle: Split into GtkCssStyle and GtkCssAnimatedStyle GtkCssStyle is the base class to be used for all types of styles that do exist. GtkCssAnimatedStyle is the only implementation so far, that is exactly a copy/paste of the old GtkCssStyle code.
2014-10-23 02:10:03 +00:00
GtkCssStyle *parent_style);
css: Redo StyleProvider interface We now use the GtkStleProviderPrivate interface, which hopefully is faster and more conformant to CSS. Long term, it definitely should be both. I would have liked to split this up into multiple commits, but couldn't find a way.
2011-12-28 21:59:55 +00:00
Make _gtk_css_lookup_get_missing inline This is called a lot in the loop in gtk_css_style_provider_lookup which actually showed up on profiles.
2012-11-09 09:09:06 +00:00
static inline const GtkBitmask *
_gtk_css_lookup_get_missing (const GtkCssLookup *lookup)
{
return lookup->missing;
}
css: Redo StyleProvider interface We now use the GtkStleProviderPrivate interface, which hopefully is faster and more conformant to CSS. Long term, it definitely should be both. I would have liked to split this up into multiple commits, but couldn't find a way.
2011-12-28 21:59:55 +00:00
G_END_DECLS
#endif /* __GTK_CSS_LOOKUP_PRIVATE_H__ */
Reference in New Issue Copy Permalink