AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
d517804acd
gtk2/gtk/gtksidebarrow.c

628 lines
19 KiB
C
Raw Normal View History

gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
/* gtksidebarrow.c
*
* Copyright (C) 2015 Carlos Soriano <csoriano@gnome.org>
*
* This file is free software; you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License as
Do not use the LGPL v3 blurb for LGPL v2.1 files GTK+ is released under the terms of the GNU LGPL v2.1+.
2015-11-19 12:43:24 +00:00
* published by the Free Software Foundation; either version 2.1 of the
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
* License, or (at your option) any later version.
*
* This file is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
Do not use the LGPL v3 blurb for LGPL v2.1 files GTK+ is released under the terms of the GNU LGPL v2.1+.
2015-11-19 12:43:24 +00:00
* You should have received a copy of the GNU Lesser General Public License
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
#include "config.h"
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
#include "gtksidebarrowprivate.h"
/* For section and place type enums */
#include "gtkplacessidebarprivate.h"
#include "gtkwidget.h"
#include "gtkimage.h"
#include "gtklabel.h"
#include "gtkrevealer.h"
gtkplacessidebar: Show busy spinner in sidebar row during mount ops
2018-07-22 11:47:46 +00:00
#include "gtkspinner.h"
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
#include "gtkprivatetypebuiltins.h"
Drop gtkintl.h Include gtkprivate.h for I_() and glib-i18n.h for gettext macros.
2022-09-24 13:07:56 +00:00
#include "gtkprivate.h"
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
#ifdef HAVE_CLOUDPROVIDERS
Use the appropriate include for libcloudproviders Libcloudproviders has a single header entry point, so we shouldn't include a sub-header. Additionally, the include path provided by the pkg-config file is: -I${includedir}/cloudproviders So the include directive should be: #include <cloudproviders.h> The fact that it worked until now was an accident caused by the blanket: -I${includedir} we get for free; it broke the build when using libcloudproviders as a subproject.
2020-06-17 19:49:57 +00:00
#include <cloudproviders.h>
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
#endif
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
struct _GtkSidebarRow
{
GtkListBoxRow parent_instance;
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
GIcon *start_icon;
GIcon *end_icon;
GtkWidget *start_icon_widget;
GtkWidget *end_icon_widget;
Replace "gchar" with "char"
2020-07-24 18:40:36 +00:00
char *label;
char *tooltip;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
GtkWidget *label_widget;
gboolean ejectable;
GtkWidget *eject_button;
Replace "gint" with "int"
2020-07-24 13:54:49 +00:00
int order_index;
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
GtkPlacesSectionType section_type;
GtkPlacesPlaceType place_type;
Replace "gchar" with "char"
2020-07-24 18:40:36 +00:00
char *uri;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
GDrive *drive;
GVolume *volume;
GMount *mount;
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
GObject *cloud_provider_account;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gboolean placeholder;
GtkPlacesSidebar *sidebar;
GtkWidget *revealer;
gtkplacessidebar: Show busy spinner in sidebar row during mount ops
2018-07-22 11:47:46 +00:00
GtkWidget *busy_spinner;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
};
G_DEFINE_TYPE (GtkSidebarRow, gtk_sidebar_row, GTK_TYPE_LIST_BOX_ROW)
enum
{
PROP_0,
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
PROP_START_ICON,
PROP_END_ICON,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
PROP_LABEL,
PROP_TOOLTIP,
PROP_EJECTABLE,
PROP_SIDEBAR,
PROP_ORDER_INDEX,
PROP_SECTION_TYPE,
PROP_PLACE_TYPE,
PROP_URI,
PROP_DRIVE,
PROP_VOLUME,
PROP_MOUNT,
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
PROP_CLOUD_PROVIDER_ACCOUNT,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
PROP_PLACEHOLDER,
LAST_PROP
};
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
static GParamSpec *properties [LAST_PROP];
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
#ifdef HAVE_CLOUDPROVIDERS
static void
cloud_row_update (GtkSidebarRow *self)
{
CloudProvidersAccount *account;
GIcon *end_icon;
Replace "gint" with "int"
2020-07-24 13:54:49 +00:00
int provider_status;
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
account = CLOUD_PROVIDERS_ACCOUNT (self->cloud_provider_account);
provider_status = cloud_providers_account_get_status (account);
switch (provider_status)
{
case CLOUD_PROVIDERS_ACCOUNT_STATUS_IDLE:
end_icon = NULL;
break;
case CLOUD_PROVIDERS_ACCOUNT_STATUS_SYNCING:
end_icon = g_themed_icon_new ("emblem-synchronizing-symbolic");
break;
case CLOUD_PROVIDERS_ACCOUNT_STATUS_ERROR:
end_icon = g_themed_icon_new ("dialog-warning-symbolic");
break;
default:
return;
}
g_object_set (self,
"label", cloud_providers_account_get_name (account),
NULL);
g_object_set (self,
"tooltip", cloud_providers_account_get_status_details (account),
NULL);
g_object_set (self,
"end-icon", end_icon,
NULL);
if (end_icon != NULL)
g_object_unref (end_icon);
}
#endif
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
static void
gtk_sidebar_row_get_property (GObject *object,
guint prop_id,
GValue *value,
GParamSpec *pspec)
{
GtkSidebarRow *self = GTK_SIDEBAR_ROW (object);
switch (prop_id)
{
case PROP_SIDEBAR:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_object (value, self->sidebar);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
case PROP_START_ICON:
g_value_set_object (value, self->start_icon);
break;
case PROP_END_ICON:
g_value_set_object (value, self->end_icon);
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_LABEL:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_string (value, self->label);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_TOOLTIP:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_string (value, self->tooltip);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_EJECTABLE:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_boolean (value, self->ejectable);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_ORDER_INDEX:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_int (value, self->order_index);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_SECTION_TYPE:
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
g_value_set_enum (value, self->section_type);
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_PLACE_TYPE:
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
g_value_set_enum (value, self->place_type);
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_URI:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_string (value, self->uri);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_DRIVE:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_object (value, self->drive);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_VOLUME:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_object (value, self->volume);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_MOUNT:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_object (value, self->mount);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
case PROP_CLOUD_PROVIDER_ACCOUNT:
g_value_set_object (value, self->cloud_provider_account);
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_PLACEHOLDER:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_value_set_boolean (value, self->placeholder);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
}
}
static void
gtk_sidebar_row_set_property (GObject *object,
guint prop_id,
const GValue *value,
GParamSpec *pspec)
{
GtkSidebarRow *self = GTK_SIDEBAR_ROW (object);
switch (prop_id)
{
case PROP_SIDEBAR:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
self->sidebar = g_value_get_object (value);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
case PROP_START_ICON:
{
g_clear_object (&self->start_icon);
object = g_value_get_object (value);
if (object != NULL)
{
Fix fallout from g_object_ref change g_object_ref now returns the type of the object that was passed. Introduce cast as necessary to avoid warnings due to this.
2017-12-08 22:48:47 +00:00
self->start_icon = G_ICON (g_object_ref (object));
image: Remove icon-size argument from icon setters Instead, add a function gtk_image_set_icon_size() for the cases where overriding the icon size is necessary. Treat icon sizes the same way as pixel sizes, too. So gtk_image_clear() no longer unsets the icon size.
2017-11-15 00:43:13 +00:00
gtk_image_set_from_gicon (GTK_IMAGE (self->start_icon_widget), self->start_icon);
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
}
else
{
gtk_image_clear (GTK_IMAGE (self->start_icon_widget));
}
break;
}
case PROP_END_ICON:
{
g_clear_object (&self->end_icon);
object = g_value_get_object (value);
if (object != NULL)
{
Fix fallout from g_object_ref change g_object_ref now returns the type of the object that was passed. Introduce cast as necessary to avoid warnings due to this.
2017-12-08 22:48:47 +00:00
self->end_icon = G_ICON (g_object_ref (object));
image: Remove icon-size argument from icon setters Instead, add a function gtk_image_set_icon_size() for the cases where overriding the icon size is necessary. Treat icon sizes the same way as pixel sizes, too. So gtk_image_clear() no longer unsets the icon size.
2017-11-15 00:43:13 +00:00
gtk_image_set_from_gicon (GTK_IMAGE (self->end_icon_widget), self->end_icon);
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
gtk_widget_show (self->end_icon_widget);
}
else
{
gtk_image_clear (GTK_IMAGE (self->end_icon_widget));
gtk_widget_hide (self->end_icon_widget);
}
break;
}
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_LABEL:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_free (self->label);
self->label = g_strdup (g_value_get_string (value));
gtk_label_set_text (GTK_LABEL (self->label_widget), self->label);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_TOOLTIP:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_free (self->tooltip);
self->tooltip = g_strdup (g_value_get_string (value));
gtk_widget_set_tooltip_text (GTK_WIDGET (self), self->tooltip);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_EJECTABLE:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
self->ejectable = g_value_get_boolean (value);
if (self->ejectable)
gtk_widget_show (self->eject_button);
else
gtk_widget_hide (self->eject_button);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_ORDER_INDEX:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
self->order_index = g_value_get_int (value);
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_SECTION_TYPE:
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
self->section_type = g_value_get_enum (value);
if (self->section_type == GTK_PLACES_SECTION_COMPUTER ||
self->section_type == GTK_PLACES_SECTION_OTHER_LOCATIONS)
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
gtk_label_set_ellipsize (GTK_LABEL (self->label_widget), PANGO_ELLIPSIZE_NONE);
file chooser: Don't ellipsize "Other Locations" It just looks wrong if the file chooser comes up with "Other Locations" ellipsized. Treat it like the other fixed entries. We only want to ellipsize bookmarks, because their length is unpredictable.
2016-02-28 04:03:55 +00:00
else
gtk_label_set_ellipsize (GTK_LABEL (self->label_widget), PANGO_ELLIPSIZE_END);
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_PLACE_TYPE:
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
self->place_type = g_value_get_enum (value);
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_URI:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_free (self->uri);
self->uri = g_strdup (g_value_get_string (value));
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_DRIVE:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_set_object (&self->drive, g_value_get_object (value));
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_VOLUME:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_set_object (&self->volume, g_value_get_object (value));
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_MOUNT:
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_set_object (&self->mount, g_value_get_object (value));
break;
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
case PROP_CLOUD_PROVIDER_ACCOUNT:
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
#ifdef HAVE_CLOUDPROVIDERS
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
if (self->cloud_provider_account != NULL)
g_signal_handlers_disconnect_by_data (self->cloud_provider_account, self);
self->cloud_provider_account = g_value_dup_object (value);
if (self->cloud_provider_account != NULL)
{
g_signal_connect_swapped (self->cloud_provider_account, "notify::name",
G_CALLBACK (cloud_row_update), self);
g_signal_connect_swapped (self->cloud_provider_account, "notify::status",
G_CALLBACK (cloud_row_update), self);
g_signal_connect_swapped (self->cloud_provider_account, "notify::status-details",
G_CALLBACK (cloud_row_update), self);
}
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
#endif
SidebarRow: Unref CloudProvider on change/finalize It was never unref()d, either when replacing the existing GObject in set_property(), cleaning up in finalize(), or becoming a placeholder. Fix by using g_set_object() and g_clear_object() to unref as needed. This also drops the check that the newly set object is a valid cloud provider account, as we don’t do the equivalent for any of the other object-typed properties, and Carlos didn’t think this was important. https://bugzilla.gnome.org/show_bug.cgi?id=787600
2017-09-12 20:56:46 +00:00
break;
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
case PROP_PLACEHOLDER:
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
{
self->placeholder = g_value_get_boolean (value);
if (self->placeholder)
{
g_clear_object (&self->start_icon);
g_clear_object (&self->end_icon);
g_free (self->label);
self->label = NULL;
g_free (self->tooltip);
self->tooltip = NULL;
gtk_widget_set_tooltip_text (GTK_WIDGET (self), NULL);
self->ejectable = FALSE;
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
self->section_type = GTK_PLACES_SECTION_BOOKMARKS;
self->place_type = GTK_PLACES_BOOKMARK_PLACEHOLDER;
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
g_free (self->uri);
self->uri = NULL;
g_clear_object (&self->drive);
g_clear_object (&self->volume);
g_clear_object (&self->mount);
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
g_clear_object (&self->cloud_provider_account);
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
Don't use container api on GtkListBox
2020-05-08 06:19:18 +00:00
gtk_list_box_row_set_child (GTK_LIST_BOX_ROW (self), NULL);
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
Rename gtk_widget{get,set,has}_style_class to _css_class We want to use css instead of style everywhere now.
2020-02-06 16:32:26 +00:00
gtk_widget_add_css_class (GTK_WIDGET (self), "sidebar-placeholder-row");
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
}
break;
}
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
}
}
static void
on_child_revealed (GObject *self,
GParamSpec *pspec,
gpointer user_data)
{
/* We need to hide the actual widget because if not the GtkListBoxRow will
* still allocate the paddings, even if the revealer is not revealed, and
* therefore the row will be still somewhat visible. */
if (!gtk_revealer_get_reveal_child (GTK_REVEALER (self)))
gtk_widget_hide (GTK_WIDGET (GTK_SIDEBAR_ROW (user_data)));
}
void
gtk_sidebar_row_reveal (GtkSidebarRow *self)
{
Remove gtk_widget_show_all
2017-01-19 09:02:04 +00:00
gtk_widget_show (GTK_WIDGET (self));
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtk_revealer_set_reveal_child (GTK_REVEALER (self->revealer), TRUE);
}
void
gtk_sidebar_row_hide (GtkSidebarRow *self,
*: Fix spelling mistakes found by codespell
2020-08-21 12:41:13 +00:00
gboolean immediate)
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
{
guint transition_duration;
transition_duration = gtk_revealer_get_transition_duration (GTK_REVEALER (self->revealer));
*: Fix spelling mistakes found by codespell
2020-08-21 12:41:13 +00:00
if (immediate)
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtk_revealer_set_transition_duration (GTK_REVEALER (self->revealer), 0);
gtk_revealer_set_reveal_child (GTK_REVEALER (self->revealer), FALSE);
gtk_revealer_set_transition_duration (GTK_REVEALER (self->revealer), transition_duration);
}
gtkplacessidebar: avoid unresponsive UI while trashing We were updating the whole places sidebar when the trash changed. This effectively removes all rows and create new ones for every trash state change. Although when using GtkTreeView it was somehow ok, with the new implementation with GtkListBox this effectively locks the UI while the trash operations are being performed. When performing operations for i.e. 100 files, the UI can be locked for more than 1 minute since gvfs-trash usually takes time. To fix this just update the icon of the trash when the state of the trash change instead of the whole sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=762677
2016-02-25 13:25:40 +00:00
void
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
gtk_sidebar_row_set_start_icon (GtkSidebarRow *self,
GIcon *icon)
{
g_return_if_fail (GTK_IS_SIDEBAR_ROW (self));
if (self->start_icon != icon)
{
g_set_object (&self->start_icon, icon);
if (self->start_icon != NULL)
image: Remove icon-size argument from icon setters Instead, add a function gtk_image_set_icon_size() for the cases where overriding the icon size is necessary. Treat icon sizes the same way as pixel sizes, too. So gtk_image_clear() no longer unsets the icon size.
2017-11-15 00:43:13 +00:00
gtk_image_set_from_gicon (GTK_IMAGE (self->start_icon_widget), self->start_icon);
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
else
gtk_image_clear (GTK_IMAGE (self->start_icon_widget));
g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_START_ICON]);
}
}
void
gtk_sidebar_row_set_end_icon (GtkSidebarRow *self,
GIcon *icon)
gtkplacessidebar: avoid unresponsive UI while trashing We were updating the whole places sidebar when the trash changed. This effectively removes all rows and create new ones for every trash state change. Although when using GtkTreeView it was somehow ok, with the new implementation with GtkListBox this effectively locks the UI while the trash operations are being performed. When performing operations for i.e. 100 files, the UI can be locked for more than 1 minute since gvfs-trash usually takes time. To fix this just update the icon of the trash when the state of the trash change instead of the whole sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=762677
2016-02-25 13:25:40 +00:00
{
g_return_if_fail (GTK_IS_SIDEBAR_ROW (self));
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
if (self->end_icon != icon)
gtkplacessidebar: avoid unresponsive UI while trashing We were updating the whole places sidebar when the trash changed. This effectively removes all rows and create new ones for every trash state change. Although when using GtkTreeView it was somehow ok, with the new implementation with GtkListBox this effectively locks the UI while the trash operations are being performed. When performing operations for i.e. 100 files, the UI can be locked for more than 1 minute since gvfs-trash usually takes time. To fix this just update the icon of the trash when the state of the trash change instead of the whole sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=762677
2016-02-25 13:25:40 +00:00
{
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
g_set_object (&self->end_icon, icon);
if (self->end_icon != NULL)
image: Remove icon-size argument from icon setters Instead, add a function gtk_image_set_icon_size() for the cases where overriding the icon size is necessary. Treat icon sizes the same way as pixel sizes, too. So gtk_image_clear() no longer unsets the icon size.
2017-11-15 00:43:13 +00:00
gtk_image_set_from_gicon (GTK_IMAGE (self->end_icon_widget), self->end_icon);
gtkplacessidebar: avoid unresponsive UI while trashing We were updating the whole places sidebar when the trash changed. This effectively removes all rows and create new ones for every trash state change. Although when using GtkTreeView it was somehow ok, with the new implementation with GtkListBox this effectively locks the UI while the trash operations are being performed. When performing operations for i.e. 100 files, the UI can be locked for more than 1 minute since gvfs-trash usually takes time. To fix this just update the icon of the trash when the state of the trash change instead of the whole sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=762677
2016-02-25 13:25:40 +00:00
else
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
if (self->end_icon_widget != NULL)
gtk_image_clear (GTK_IMAGE (self->end_icon_widget));
gtkplacessidebar: avoid unresponsive UI while trashing We were updating the whole places sidebar when the trash changed. This effectively removes all rows and create new ones for every trash state change. Although when using GtkTreeView it was somehow ok, with the new implementation with GtkListBox this effectively locks the UI while the trash operations are being performed. When performing operations for i.e. 100 files, the UI can be locked for more than 1 minute since gvfs-trash usually takes time. To fix this just update the icon of the trash when the state of the trash change instead of the whole sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=762677
2016-02-25 13:25:40 +00:00
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_END_ICON]);
gtkplacessidebar: avoid unresponsive UI while trashing We were updating the whole places sidebar when the trash changed. This effectively removes all rows and create new ones for every trash state change. Although when using GtkTreeView it was somehow ok, with the new implementation with GtkListBox this effectively locks the UI while the trash operations are being performed. When performing operations for i.e. 100 files, the UI can be locked for more than 1 minute since gvfs-trash usually takes time. To fix this just update the icon of the trash when the state of the trash change instead of the whole sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=762677
2016-02-25 13:25:40 +00:00
}
}
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
static void
gtk_sidebar_row_finalize (GObject *object)
{
GtkSidebarRow *self = GTK_SIDEBAR_ROW (object);
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
g_clear_object (&self->start_icon);
g_clear_object (&self->end_icon);
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
g_free (self->label);
self->label = NULL;
g_free (self->tooltip);
self->tooltip = NULL;
g_free (self->uri);
self->uri = NULL;
g_clear_object (&self->drive);
g_clear_object (&self->volume);
g_clear_object (&self->mount);
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
#ifdef HAVE_CLOUDPROVIDERS
if (self->cloud_provider_account != NULL)
g_signal_handlers_disconnect_by_data (self->cloud_provider_account, self);
g_clear_object (&self->cloud_provider_account);
#endif
places sidebar: Always chain up in finalize The GtkSidebarRow class was forgetting to do this. The visible symptom of this in valgrind is that you notice GObject data being leaked.
2015-07-21 23:51:50 +00:00
G_OBJECT_CLASS (gtk_sidebar_row_parent_class)->finalize (object);
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
}
static void
gtk_sidebar_row_init (GtkSidebarRow *self)
{
gtk_widget_init_template (GTK_WIDGET (self));
sidebarrow: Don't focus on click This is sometimes important, e.g. when saving in the filechooser. We don't want to move the focus out of the filename entry in that case.
2019-05-17 06:42:34 +00:00
gtk_widget_set_focus_on_click (GTK_WIDGET (self), FALSE);
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
}
static void
gtk_sidebar_row_class_init (GtkSidebarRowClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
object_class->get_property = gtk_sidebar_row_get_property;
object_class->set_property = gtk_sidebar_row_set_property;
object_class->finalize = gtk_sidebar_row_finalize;
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_SIDEBAR] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_object ("sidebar", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
GTK_TYPE_PLACES_SIDEBAR,
(G_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
properties [PROP_START_ICON] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_object ("start-icon", NULL, NULL,
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
G_TYPE_ICON,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
properties [PROP_END_ICON] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_object ("end-icon", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
G_TYPE_ICON,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_LABEL] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_string ("label", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
NULL,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_TOOLTIP] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_string ("tooltip", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
NULL,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_EJECTABLE] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_boolean ("ejectable", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
FALSE,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_ORDER_INDEX] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_int ("order-index", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
0, G_MAXINT, 0,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_SECTION_TYPE] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_enum ("section-type", NULL, NULL,
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
GTK_TYPE_PLACES_SECTION_TYPE,
GTK_PLACES_SECTION_INVALID,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS |
G_PARAM_CONSTRUCT_ONLY));
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_PLACE_TYPE] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_enum ("place-type", NULL, NULL,
Remove GtkPlacesOpenFlags from public headers The GtkPlacesOpenFlags enum is only used in private API, so move it to private headers. Since we still need a GType for it, add gtkplacessidebarprivate.h to the headers we use for generating private enum types. In turn, this registers the other private enums in that header, so take the opportunity to fix their naming, and use the generated types for the corresponding sidebarrow properties. Fixes: #3337
2020-11-08 15:40:20 +00:00
GTK_TYPE_PLACES_PLACE_TYPE,
GTK_PLACES_INVALID,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS |
G_PARAM_CONSTRUCT_ONLY));
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_URI] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_string ("uri", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
NULL,
(G_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_DRIVE] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_object ("drive", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
G_TYPE_DRIVE,
(G_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_VOLUME] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_object ("volume", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
G_TYPE_VOLUME,
(G_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_MOUNT] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_object ("mount", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
G_TYPE_MOUNT,
(G_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
properties [PROP_CLOUD_PROVIDER_ACCOUNT] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_object ("cloud-provider-account", NULL, NULL,
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
G_TYPE_OBJECT,
(G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
properties [PROP_PLACEHOLDER] =
Remove all nicks and blurbs from param specs Those property features don't seem to be in use anywhere. They are redundant since the docs cover the same information and more. They also created unnecessary translation work. Closes #4904
2022-05-11 12:19:39 +00:00
g_param_spec_boolean ("placeholder", NULL, NULL,
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
FALSE,
(G_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS));
GtkPlacesSidebar: Simplify sidebar code Make this code follow GTK+ styles and conventions better.
2015-06-23 20:28:18 +00:00
g_object_class_install_properties (object_class, LAST_PROP, properties);
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtk_widget_class_set_template_from_resource (widget_class,
"/org/gtk/libgtk/ui/gtksidebarrow.ui");
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, start_icon_widget);
gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, end_icon_widget);
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, label_widget);
gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, eject_button);
gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, revealer);
gtkplacessidebar: Show busy spinner in sidebar row during mount ops
2018-07-22 11:47:46 +00:00
gtk_widget_class_bind_template_child (widget_class, GtkSidebarRow, busy_spinner);
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
gtk_widget_class_bind_template_callback (widget_class, on_child_revealed);
gtk: Intern css names This avoids a bunch of strdups at startup.
2017-11-18 03:49:57 +00:00
gtk_widget_class_set_css_name (widget_class, I_("row"));
gtkplacesidebar: use GtkListBox We were using GTkTreeView in a simple list. Also, as we know, GtkCellRenderers are not the best way to theme and manipulate widgets. So instead use a GtkListBox to modernize the GtkPlacesSidebar, and in the way clean up some parts of the code (like headings) which were not used anymore. Also we don't use a model anymore, since the data is simple enough to manage it in a subclass of the row itself.
2015-05-06 21:07:17 +00:00
}
GtkSidebarRow*
gtk_sidebar_row_clone (GtkSidebarRow *self)
{
sidebarrow: Avoid object-valued properties They tend to leak...as these do.
2015-06-23 18:42:57 +00:00
return g_object_new (GTK_TYPE_SIDEBAR_ROW,
"sidebar", self->sidebar,
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
"start-icon", self->start_icon,
"end-icon", self->end_icon,
sidebarrow: Avoid object-valued properties They tend to leak...as these do.
2015-06-23 18:42:57 +00:00
"label", self->label,
"tooltip", self->tooltip,
"ejectable", self->ejectable,
"order-index", self->order_index,
"section-type", self->section_type,
"place-type", self->place_type,
"uri", self->uri,
"drive", self->drive,
"volume", self->volume,
"mount", self->mount,
gtkplacessidebar: Adapt to libcloudproviders 0.2.x And a few improvements on the way. https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-10-30 20:38:41 +00:00
"cloud-provider-account", self->cloud_provider_account,
sidebarrow: Avoid object-valued properties They tend to leak...as these do.
2015-06-23 18:42:57 +00:00
NULL);
}
gtkplacessidebar: implement libcloudproviders support Add integration of the libcloudproviders DBus API to the GtkPlacesSidebar by showing name and sync status of the cloud providers. The exported menu is rendered as a GtkPopover. The sidebar will be updated if the list of cloudproviders changes e.g. by adding or removing an account. If any cloud provider changes detailed information like sync status only the individual sidebar row gets updated. Co-authored-by: Carlos Soriano <csoriano@gnome.org> Co-authored-by: Daniel Boles <dboles@src.gnome.org> https://bugzilla.gnome.org/show_bug.cgi?id=786123
2017-08-10 20:30:36 +00:00
GtkWidget*
sidebarrow: Avoid object-valued properties They tend to leak...as these do.
2015-06-23 18:42:57 +00:00
gtk_sidebar_row_get_eject_button (GtkSidebarRow *self)
{
return self->eject_button;
}
gtkplacessidebar: Show busy spinner in sidebar row during mount ops
2018-07-22 11:47:46 +00:00
void
gtk_sidebar_row_set_busy (GtkSidebarRow *row,
gboolean is_busy)
{
g_return_if_fail (GTK_IS_SIDEBAR_ROW (row));
gtk_widget_set_visible (row->busy_spinner, is_busy);
}
Reference in New Issue Copy Permalink